This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Implementation

1: PhaDiscnct_IntegrationManual
2: PhaDiscnct_MDD
3: PhaDiscnct_Review

Component Implementation

Component Documentation

1 - PhaDiscnct_IntegrationManual

Integration Manual

For

PhaDiscnct

VERSION: 2.0

DATE: 03-OCT-2017

Prepared By:

Software Group,

Nexteer Automotive,

Saginaw, MI, USA

Revision History

Sl. No.	Description	Author	Version	Date
1	Initial version	Krzysztof Byrski	1.0	24-Aug-2017
2	Updated as per Design version 1.2.0	Krzysztof Byrski	2.0	03-Oct-2017

Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

Abbreviation	Description
DFD	Design functional diagram
MDD	Module design Document
FDD	Functional Design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.	Title	Version
1	EA4 Software Naming Conventions	01.01.00
2	Software Design and Coding Standards	2.1
3	ES330A_PhaDiscnct_Design	See Synergy Sub Project Version

Dependencies

SWCs

Module	Required Feature
ES999A_ElecGlbPrm_Impl	ElecGlbPrm.h, #define ELECGLBPRM_STRTUPSTPHADISCNCTWRMININSTRT_CNT_U08

Note : Referencing the external components should be avoided in most cases. Only in unavoidable circumstance external components should be referred. Developer should track the references.

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

Modules	Notes
None

Configuration Files to be provided by Integration Project

None

Da Vinci Parameter Configuration Changes

Parameter	Notes	SWC
None

DaVinci Interrupt Configuration Changes

ISR Name	VIM #	Priority Dependency	Notes
None

Manual Configuration Changes

Constant	Notes	SWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer FDD

Required Global Data Outputs

Refer FDD

Specific Include Path present

Runnable Scheduling

This section specifies the required runnable scheduling.

Init	Scheduling Requirements	Trigger
PhaDiscnctInit1	None	RTE (Init)

Runnable	Scheduling Requirements	Trigger
PhaDiscnctPer1	None	RTE(2ms)
PhaDiscnctPer2	None	RTE(2ms)

Memory Map REQUIREMENTS

Mapping

Memory Section	Contents	Notes
PhaDiscnct_START_SEC_CODE	Code

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

Feature	RAM	ROM

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

*See DataDict.m

Compiler Settings

Preprocessor MACRO

None

Optimization Settings

None

Appendix

2 - PhaDiscnct_MDD

Module Design Document

For

PhaDiscnct

February 16, 2018

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

Software Group,

Nexteer Automotive,

Saginaw, MI, USA
Change History

Description	Author	Version	Date
Initial Version	Krzysztof Byrski	1	24-Aug-2017
Updated as per Design version 1.2.0	Krzysztof Byrski	2	03-Oct-2017
Updated as per Design version 1.3.0	Krzysztof Byrski	3	16-Feb-2018

Table of Contents

1 Introduction 4

1.1 Purpose 4

1.2 Scope 4

2 PhaDiscnct & High-Level Description 5

3 Design details of software module 6

3.1 Graphical representation of PhaDiscnct 6

3.2 Data Flow Diagram 6

3.2.1 Component level DFD 6

3.2.2 Function level DFD 6

4 Constant Data Dictionary 7

4.1 Program (fixed) Constants 7

4.1.1 Embedded Constants 7

5 Software Component Implementation 8

5.1 Sub-Module Functions 8

5.1.1 Init: PhaDiscnctInit1 8

5.1.2 Per: PhaDiscnctPer1 8

5.1.3 Per: PhaDiscnctPer2 8

5.2 Server Runables 8

5.3 Interrupt Functions 9

5.4 Module Internal (Local) Functions 9

5.4.1 Local Function PerformDiag 9

5.4.2 Local Function ClosingStateBody 9

5.4.3 Local Function ClosedStateBody 10

5.4.4 Local Function OpeningStateBody 10

5.4.5 Local Function OpenedStateBody 10

5.4.6 Local Function SetHwPhaDiscnctIO 11

5.5 GLOBAL Function/Macro Definitions 12

6 Known Limitations with Design 13

7 UNIT TEST CONSIDERATION 14

Appendix A Abbreviations and Acronyms 15

Appendix B Glossary 16

Appendix C References 17

Introduction

Purpose

MDD for ES330A_PhaDiscnct_Impl

Scope

The following definitions are used throughout this document:

Shall: indicates a mandatory requirement without exception in compliance.
Should: indicates a mandatory requirement; exceptions allowed only with documented justification.
May: indicates an optional action.

PhaDiscnct & High-Level Description

Phase Disconnect provides mechanism of disconnecting Motor Phases from system in order to prevent generation of unintended negative or positive motor torque. Phase Disconnect is controlled by System State and Motor Control Gate Driver FET fault signals. Phase Disconnect functionality provides support for loss of assist mitigation.

Design details of software module

Graphical representation of PhaDiscnct

Data Flow Diagram

Refer FDD

Component level DFD

Refer FDD

Function level DFD

Refer FDD

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Local Constants

Constant Name	Resolution	Units	Value
DIAGFLTPRMFAILTODIAGFLG_CNT_U08	1	Cnt	8
DIAGMOTCURRCORRDABITPOSN_CNT_U08	1	Cnt	1
DIAGMOTCURRCORRDBBITPOSN_CNT_U08	1	Cnt	2
DIAGMOTCURRCORRDCBITPOSN_CNT_U08	1	Cnt	4
DIAGSTCMPL_CNT_U08	1	Cnt	2
DIAGSTINI_CNT_U08	1	Cnt	0
DIAGSTPROC_CNT_U08	1	Cnt	1
DIAGSTSFAILTODIAG_CNT_U08	1	Cnt	2
DIAGSTSFAILTOOPEN_CNT_U08	1	Cnt	1
DIAGSTSPASS_CNT_U08	1	Cnt	0
DIAGTSTITRNPHAA_CNT_U08	1	Cnt	2
DIAGTSTITRNPHAB_CNT_U08	1	Cnt	1
DIAGTSTITRNPHAC_CNT_U08	1	Cnt	0
DISCNCTCURRCOMPIDX_CNT_U08	1	Cnt	0
OPERSTCLSPROGSN_CNT_U08	1	Cnt	0
OPERSTCLS_CNT_U08	1	Cnt	1
OPERSTOPENPROGSN_CNT_U08	1	Cnt	2
OPERSTOPEN_CNT_U08	1	Cnt	3
PHADISCNCTCMDALLOFF_CNT_U08	1	Cnt	0
PHADISCNCTCMDALLON_CNT_U08	1	Cnt	7
PHADISCNCTCMDAON_CNT_U08	1	Cnt	1
PHADISCNCTCMDBON_CNT_U08	1	Cnt	2
PHADISCNCTCMDCON_CNT_U08	1	Cnt	4

Software Component Implementation

Sub-Module Functions

Init: Init1

Design Rationale

Refer FDD

Module Outputs

Refer FDD

Per: Per1

Design Rationale

Refer FDD

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Per: PhaDiscnctPer2

Design Rationale

Refer FDD

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Server Runables

None

Interrupt Functions

None

Module Internal (Local) Functions

Local Function PerformDiag

Function Name	PerformDiag	Type	Min	Max
Arguments Passed	MotCurrCorrdA_Ampr_T_f32	float32	-200.0	200.0
	MotCurrCorrdB_Ampr_T_f32	float32	-200.0	200.0
	MotCurrCorrdC_Ampr_T_f32	float32	-200.0	200.0
Return Value	PhaDiscnctDiagcPwmVect_Cnt_T_enum	enum	1	4

Design Rationale

Refer FDD

Processing

Refer FDD

Local Function ClosingStateBody

Function Name	ClosingStateBody	Type	Min	Max
Arguments Passed	StrtUpSt_Cnt_T_u08	uint8	0	160
	SysSt_Cnt_T_enum	enum	0	3
Return Value	PhaDiscnctInactvTemp_Cnt_T_logl	boolean	FALSE	TRUE

Design Rationale

Refer FDD

Processing

Refer FDD

Local Function ClosedStateBody

Function Name	ClosedStateBody	Type	Min	Max
Arguments Passed	IvtrFetFltPha_Cnt_T_enum	enum	0	4
	IvtrFetFltTyp_Cnt_T_enum	enum	0	4
	SysSt_Cnt_T_enum	enum	0	3
Return Value	PhaDiscnctCmdTemp_Cnt_T_u08	Uint8	0	7

Design Rationale

Refer FDD

Processing

Refer FDD

Local Function OpeningStateBody

Function Name	OpeningStateBody	Type	Min	Max
Arguments Passed	IvtrFetFltTyp_Cnt_T_enum	enum	0	4
	SysSt_Cnt_T_enum	enum	0	3
Return Value	PhaDiscnctCmdTemp_Cnt_T_u08	uint8	0	7

Design Rationale

Refer FDD

Processing

Refer FDD

Local Function OpenedStateBody

Function Name	OpenedStateBody	Type	Min	Max
Arguments Passed	IvtrFetFltPha_Cnt_T_enum	enum	0	4
	IvtrFetFltTyp_Cnt_T_enum	enum	0	4
	SysSt_Cnt_T_enum	enum	0	3
Return Value	PhaDiscnctInactvTemp_Cnt_T_logl	boolean	FALSE	TRUE
	PhaDiscnctCmdTemp_Cnt_T_u08	uint8	0	7

Design Rationale

Refer FDD

Processing

Refer FDD

Local Function SetHwPhaDiscnctIO

Function Name	SetHwPhaDiscnctIO	Type	Min	Max
Arguments Passed	PhaDiscnt_Cnt_T_u08	uint8	0	7
Return Value	N/A

Design Rationale

Refer FDD

Processing

Refer FDD

GLOBAL Function/Macro Definitions

None

Known Limitations with Design

None

UNIT TEST CONSIDERATION

None

Abbreviations and Acronyms

Abbreviation or Acronym	Description

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

ISO 9000
ISO/IEC 12207
ISO/IEC 15504
Automotive SPICE® Process Reference Model (PRM)
Automotive SPICE® Process Assessment Model (PAM)
ISO/IEC 15288
ISO 26262
IEEE Standards
SWEBOK
PMBOK
Existing Nexteer Automotive documentation

Term	Definition	Source
MDD	Module Design Document
DFD	Data Flow Diagram

References

Ref. #	Title	Version
1	AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)	v1.4.0 R4.0 Rev 3
2	MDD Guideline EA4	1.02
3	EA4 Software Naming Conventions	1.01
4	Software Design and Coding Standards	2.01
5	ES330A_PhaDiscnct_Design	See Synergy Sub Project Version

3 - PhaDiscnct_Review

Overview

Summary Sheet
Synergy Project
Source Code
MDD
PolySpace

Sheet 1: Summary Sheet

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Summary Sheet

Component Short Name:

Windows User: Intended Use: Identify which component is being reviewed. This should match the component short name from the DataDict.m fileand the middle part of the Synergy project name, e.g. Assi for the SF001A_Assi_Impl Synergy project

ES330A_PhaDiscnct_Impl

Revision / Baseline:

Windows User: Intended Use: Identify the implementation baseline name intended to be used for the changed component when changes are approved E.g. SF001A_Assi_Impl_1.2.0

ES330A_PhaDiscnct_Impl_1.3.0

Change Owner:

Windows User: Intended Use: Identify the developer who made the change(s) being reviewed

Krzysztof Byrski

Work CR ID:

Windows User: Intended Use: Identify the Implementation Work CR whose work is being reviewed (may be more than one)

EA4#20593

kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:

Check the file types that needed modification for the Work CR(s); macros for the check boxes will populate the appropriate checklist tabs for the review.

kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:

Reviewed:

At start of review, all items below should be marked "No". At the end of the review, all items should be marked "Yes" or "N/A" where N/A indicates the reviewers have reviewed the existing (unchanged) item and confirmed no updates were needed for the Work CR(s).

Yes

MDD

Yes

Source Code

Yes

PolySpace

N/A

Integration Manual

N/A

Davinci Files

Comments:

General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include SWC Owner and/or SWC Design author and Integrator and/or SW Lead as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.

Each peer review shall start with a clean copy of the latest peer review checklist template. Before the peer review, the change owner shall:
o Review the previous component peer review and copy any relevant comments to the new review sheet.
o Review all checklist items and make all corrections needed, so that the component is ready for peer review. The expectation is that peer review should find very few issues,
because the change owner has already used the checklist to ensure the component changes are complete and correct.
o Fill in all file name and version information as needed on peer review checklist tabs (file names may be copied from the previous peer review where appropriate)
o Fill in checklist answers (Yes/No/NA pulldowns) ONLY on those items which are NA for the current change. All other checklist items should be blank going into the review
meeting.

During the peer review meeting:
o For each page of the review, first review the items already marked as N/A for this change, to confirm that reviewers agree with this assessment; change the checklist box to
blank if it is found that the item does apply.
o Then review the items with the checklist box blank. After reviewing each of these items, the checklist box will be marked as "Yes", or the checklist box will be marked as
"No" with needed rework indicated or with rationale indicated.
o If any items are marked "No" with rationale indicated, this must be approved by a software supervisor or the software manager; there is a line in the "Review Board" section
of each tab to indicate who approved the "No" items on that tab.

Sheet 2: Synergy Project

Rev 2.00

29-Nov-17

Peer Review Meeting Log (Component Synergy Project Review)

Quality Check Items:

Rationale is required for all answers of No

New baseline version name from Summary Sheet follows

Yes

Comments:

naming convention

Project contains necessary subprojects

Yes

Comments:

Project contains the correct version of subprojects

Yes

Comments:

Design subproject is correct version

Yes

Comments:

.gpj file in tools folder matches .gpj generated by TL109 script

Yes

Comments:

File/folder structure is correct per documentation in

Yes

Comments:

TL109A_SwcSuprt

General Notes / Comments:

Review Board:

Change Owner:

Krzysztof Byrski

Review Date :

02/16/2018

Lead Peer Reviewer:

Mateusz Bartocha

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Sheet 3: Source Code

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Meeting Log (Source Code Review)

Source File Name:

PhaDiscnct.c

Source File Revision:

Windows User: Intended Use: Synergy version number of the file being reviewed. (Version number that Synergy displays on the checked out or unmodified file in the working project) 2

Header File Name:

Header File Revision:

Windows User: Intended Use: Synergy version number of the file being reviewed. (Version number that Synergy displays on the checked out or unmodified file in the working project) -

MDD Name:

PhaDiscnct_MDD.docx

Revision:

Windows User: Intended Use: Synergy version number of the file being reviewed. (Version number that Synergy displays on the checked out or unmodified file in the working project) 3

SWC Design Name:

ES330A_PhaDiscnct_Design

Revision:

Windows User: Intended Use: For FDDs, list the Synergy baseline number (just the number part of the Synergy baseline name) of the FDD baseline being implemented. E.g., for SF001A_Assi_Design_1.3.1, this field would say "1.3.1" 1.3.0

Quality Check Items:

Rationale is required for all answers of No

EA4 Common Naming Convention followed:

Version: 01.01.00

EA4 Software Naming Convention followed:

Version: 1.02

for variable names

N/A

Comments:

N/A for changes

for constant names

Yes

Comments:

for function names

N/A

Comments:

N/A for changes

for other names (component, memory

N/A

Comments:

mapping handles, typedefs, etc.)

N/A for changes

Verified no possibility of uninitialized variables being

Yes

Comments:

written to component outputs or IRVs

Any requirements traceability tags have been removed

N/A

Comments:

from at least the changed areas of code

All variables are declared at the function level.

Yes

Comments:

Synergy version matches change history

kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.

Yes

Comments:

and Version Control version in file comment block

Change log contains detailed description of changes

Yes

Comments:

(including any anomaly number(s) being fixed) and

Work CR number

Code accurately implements SWC Design (Document or Model)

Yes

Comments:

in all areas where code was changed and/or Simulink

model was color-coded as changed and/or mentioned

in SWC Design change log. (This item includes looking at all

layers of Simulink model for possible color coding not

reflected at a higher level, and includes looking at any

intermediate SWC Design versions between the version being

implemented and the version that was included as a

subproject in the previous implementation.)

Code comparison against previous version matches

Yes

Comments:

changes needed as described by the work CR(s), all

parent CRs and parent anomalies, and the SWC

Design change log.

Verified no Compiler Errors or Warnings

KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used.

Yes

Comments:

(and verified for all possible combinations

of any conditionally compiled code)

Component.h is included

N/A

Comments:

All other includes are actually needed. (System includes

Yes

Comments:

only allowed in Nexteer library components)

Software Design and Coding Standards followed:

Windows User: Intended Use: list version/revision of latest released Software Design and Coding Standards document. Version: 2.1

Code comments are clear, correct, and adequate

N/A

Comments:

and have been updated for the change: [N40] and

N/A for changes

all other rules in the same section as rule [N40],

plus [N75], [N12], [N23], [N33], [N37], [N38],

[N48], [N54], [N77], [N79], [N72]

Source file (.c and .h) comment blocks are per

Yes

Comments:

standards and contain correct information: [N41], [N42]

Function comment blocks are per standards and

N/A

Comments:

contain correct information: [N43]

N/A for changes

Code formatting (indentation, placement of

Yes

Comments:

braces, etc.) is per standards: [N5], [N55], [N56],

[N57], [N58], [N59]

Embedded constants used per standards; no

Yes

Comments:

"magic numbers": [N12]

Memory mapping for non-RTE code

N/A

Comments:

is per standard

All access of motor control loop data uses macros

N/A

Comments:

generated by the motor control manager

All loops have termination conditions that ensure

N/A

Comments:

finite loop iterations: [N63]

All divides protect against divide by zero

N/A

Comments:

if needed: [N65]

All integer division and modulus operations

N/A

Comments:

handle negative numbers correctly: [N76]

All typecasting and fixed point arithmetic,

N/A

Comments:

including all use of fixed point macros and

timer functions, is correct and has no possibility

of unintended overflow or underflow: [N66]

All float-to-unsigned conversions ensure the.

N/A

Comments:

float value is non-negative: [N67]

N/A for changes

All conversions between signed and unsigned

Yes

Comments:

types handle msb==1 as intended: [N78]

All pointer dereferencing protects against

Yes

Comments:

null pointer if needed: [N70]

Component outputs are limited to the legal range

N/A

Comments:

defined in the SWC Design DataDict.m file : [N53]

N/A for changes

All code is mapped with SWC Design (all SWC

Yes

Comments:

Design subfunctions and/or model blocks identified

with code comments; all code corresponds to

some SWC Design subfunction and/or model block):

[N40]

Any other violations of design and coding

N/A

Comments:

standards noticed during the review are noted in the

comments section for rework.

Anomaly or Design Work CR created

N/A

Comments: List Anomaly or CR numbers

for any SWC Design corrections needed

General Notes / Comments:

Review Board:

Change Owner:

Krzysztof Byrski

Review Date :

02/16/2018

Lead Peer Reviewer:

Mateusz Bartocha

Approved by Reviewer(s):

Yes

SWC owner and/or
SWC Design author:

Dominik Wybrańczyk

Comments:

Integrator and or
SW lead:

Comments:

Not required

Unit test co-ordinator:

Comments:

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Sheet 4: MDD

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Meeting Log (MDD Review)

MDD Name:

PhaDiscnct_MDD.docx

MDD Revision:

Source File Name:

PhaDiscnct.c

Source File Revision:

Source File Name:

Source File Revision:

Source File Name:

Source File Revision:

Quality Check Items:

Rationale is required for all answers of No

Synergy version matches document

Yes

Comments:

Change log contains detailed description of changes

Yes

Comments:

Changes Highlighted (for Unit Tester)

Yes

Comments:

Diagrams have been included per MDD Guideline

N/A

Comments:

and reviewed

N/A for changes

All Design Exceptions and Limitations are listed

N/A

Comments:

N/A for changes

Design rationale given for all global

N/A

Comments:

data not communicated through RTE ports, per

N/A for changes

Design and Coding Standards rules [N9] and [N10].

All implementation details that differ from the SWC

N/A

Comments:

Design are noted and explained in Design Rationale

N/A for changes

All Unit Test Considerations have been described

N/A

Comments:

N/A for changes

General Notes / Comments:

Review Board:

Change Owner:

Krzysztof Byrski

Review Date :

02/16/2018

Lead Peer Reviewer:

Mateusz Bartocha

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Sheet 5: PolySpace

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Meeting Log (PolySpace Review)

Source File Name:

PhaDiscnct.c

Source File Revision:

Source File Name:

Source File Revision:

Source File Name:

Source File Revision:

EA4 Static Analysis Compliance Guideline version:

1.04

Poly Space version:

Windows User: eg. 2013b

2013b

TL109A sub project version:

2.2.0

Quality Check Items:

Rationale is required for all answers of No

tools/local folders' header files are appropriate and

Yes

Comments:

function prototypes match the latest component version

100% Compliance to the EA4 Static Analysis

Yes

Comments:

Compliance Guideline

Are previously added justification and deviation

Yes

Comments:

comments still appropriate

Do all MISRA deviation comments use approved

Yes

Comments:

deviation tags

For any component source files (.c, .h, generated Cfg.c and Cfg.h)

Yes

Comments:

with conditional compilation, has Polyspace been run with all

combinations of build constants that can be used together in a build?

(Note which conditional compilation results have been archived)

Cyclomatic complexity and Static path count OK

Yes

Comments:

for all functions in the component per Design

and Coding Standards rule [N47]

General Notes / Comments:

Review Board:

Change Owner:

Krzysztof Byrski

Review Date :

02/16/2018

Lead Peer Reviewer:

Mateusz Bartocha

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Rationale/justification for items marked "No" approved by: