Sr. No.	Title	Version
<1>	<MDD Guidelines>	Process 4.00.00
<2>	<Software Naming Conventions>	Process 4.00.00
<3>	<Coding standards>	Process 4.00.00
<4>	FDD – SF103A_MotRefMdl_Design	See Synergy Subproject version
	<Add if more available>

Dependencies

SWCs

Module	Required Feature
None	N/A

Note : Referencing the external components should be avoided in most cases. Only in unavoidable circumstance external components should be referred. Developer should track the references.

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

Constants	Notes
None

Configuration Files to be provided by Integration Project

Da Vinci Parameter Configuration Changes

Parameter	Notes	SWC
N/A

DaVinci Interrupt Configuration Changes

ISR Name	VIM #	Priority Dependency	Notes
N/A

Manual Configuration Changes

Constant	Notes	SWC
N/A

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file

Required Global Data Outputs

Refer DataDict.m file

Specific Include Path present

Yes

Runnable Scheduling

This section specifies the required runnable scheduling.

Init	Scheduling Requirements	Trigger
MotRefMdlInit1	None	RTE

Runnable	Scheduling Requirements	Trigger
MotRefMdlPer1	None	RTE(2ms)

Memory Map REQUIREMENTS

Mapping

Memory Section	Contents	Notes
None

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

Feature	RAM	ROM
None

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

None

Compiler Settings

Preprocessor MACRO

None

Optimization Settings

None

Appendix

None

2 - MotRefMdl_MDD

Module Design Document

For

MotRefMdl

VERSION: 6.0

DATE: 15-Nov-2017

Prepared By:

Krishna Anne,

Software Component Group

Location: The official version of this document is stored in the Nexteer Configuration Management System.

Revision History

Sl. No.	Description	Author	Version	Date
1	Initial Version	Selva	1.0	12-JUN-2015
2	Updated per design rev. 1.2.0	Rijvi	2.0	13-Mar-2016
3	Updated as per v1.3.0 of FDD	Krishna	3.0	29-Apr-16
4.	Updated as per v2.3.0 of FDD	Krishna	4.0	15-Nov-2016
5.	Updated as per v4.0.0 of FDD	TATA	5.0	25-Sep-2017
6.	Fixed Design vs Implementation Mismatch	Krishna	6.0	15-Nov-2017

Table of Contents

1 Abbrevations And Acronyms 5

2 References 6

3 MotRefMdl & High-Level Description 7

4 Design details of software module 8

4.1 Graphical representation of MotRefMdl 8

4.2 Data Flow Diagram 8

4.2.1 Module level DFD 8

4.2.2 Sub-Module level DFD 8

4.3 COMPONENT FLOW DIAGRAM 8

5 Variable Data Dictionary 9

5.1 User defined typedef definition/declaration 9

5.2 Variable definition for enumerated types 9

6 Constant Data Dictionary 10

6.1 Program(fixed) Constants 10

6.1.1 Embedded Constants 10

6.1.1.1 Local 10

6.1.1.2 Global 10

6.1.2 Module specific Lookup Tables Constants 10

7 Software Module Implementation 11

7.1 Sub-Module Functions 11

7.2 Initialization Functions 11

7.2.1 Per: MotRefMdlINIT1 11

7.2.1.1 Design Rationale 11

7.2.1.2 Store Module Inputs to Local copies 11

7.2.1.3 (Processing of function)……… 11

7.2.1.4 Store Local copy of outputs into Module Outputs 11

7.3 PERIODIC FUNCTIONS 11

7.3.1 Per: MotRefMdlper1 11

7.3.1.1 Design Rationale 11

7.3.1.2 Store Module Inputs to Local copies 11

7.3.1.3 (Processing of function)……… 11

7.3.1.4 Store Local copy of outputs into Module Outputs 11

7.4 Non PERIODIC FUNCTIONS 11

7.5 Interrupt Functions 11

7.6 Serial Communication Functions 12

7.7 Local Function/Macro Definitions 12

7.7.1 Local Function #1 CalcCurrMagSqRef 12

7.7.1.1 Description 12

7.7.2 Local Function #2 CalcIq 12

7.7.2.1 Description 12

7.7.3 Local Function #3 CurrtoVoltTest 12

7.7.3.1 Description 12

7.7.4 Local Function #4 CalcMinMotCurr 12

7.7.4.1 Description 13

7.7.5 Local Function #5 CalcTq 13

7.7.5.1 Description 13

7.7.6 Local Function #6 CalcMaxTqPt 13

7.7.6.1 Description 13

7.7.7 Local Function #7 PrbcIntrpn 13

7.7.7.1 Description 13

7.7.8 Local Function #7 PrbcIntrpn 13

7.7.8.1 Description 14

7.8 GLObAL Function/Macro Definitions 14

7.9 TRANSIENT FUNCTIONS 14

8 Unit Test Considerations 15

9 Known Limitations With Design 16

10 Appendix 17

Abbrevations And Acronyms

Abbreviation	Description
DFD	Design functional diagram
MDD	Module design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.	Title	Version
<1>	<MDD Guidelines>	Process 04.02.01
<2>	<Software Naming Conventions>	Process 04.02.01
<3>	<Coding standards>	Process 04.02.01
<4>	FDD - SF103A_MotRefMdl_Design	See Synergy Subproject version
	<Add if more available>

MotRefMdl & High-Level Description

Design details of software module

Graphical representation of MotRefMdl

Data Flow Diagram

Module level DFD

Sub-Module level DFD

COMPONENT FLOW DIAGRAM

Variable Data Dictionary

User defined typedef definition/declaration

Typedef Name	Element Name	User Defined Type	Legal Range (min)	Legal Range (max)
MotInterCalcnsRec	RelncTqCoeff_Henry_f32	Single Precision float	3e-05	0.00041
	MotREstimd_Ohm_f32	Single Precision float	0.005	0.12565
	ReacncDaxOverR_Uls_f32	Single Precision float	-14.4436	+14.4436
	ReacncQaxOverR_Uls_f32	Single Precision float	-14.4436	+14.4436
	EgOverR_Ampr_f32	Single Precision float	-200	200
	VltgOverR_Ampr_f32	Single Precision float	-200	200
	VovrRAllSqd_AmprSqd_f32	Single Precision float	0	40000
	EgOverROverZ_Ampr_f32	Single Precision float	-200	200
	VovrRovrZ_Ampr_f32	Single Precision float	-200	200
	MotKeEstimd_VoltPerMotRadPerSec_f32	Single Precision float	.025	.075

Variable definition for enumerated types

Enum Name	Element Name	Value
N/A	<(Variable name qualified Refer[2])>	<Define the value >

Constant Data Dictionary

Program(fixed) Constants

Embedded Constants

Local

Constant Name	Resolution	Units	Value
MOTVLTGDAXEFLOLIM_VOLT_F32	Single precision float	Volt	-26.5F
MOTVLTGDAXEFHILIM_VOLT_F32	Single precision float	Volt	26.5F
MOTVLTGQAXEFLOLIM_VOLT_F32	Single precision float	Volt	-26.5F
MOTVLTGQAXEFHILIM_VOLT_F32	Single precision float	Volt	26.5F
BITMASK1_CNT_U08	1	Cnt	1U
BITMASK2_CNT_U08	1	Cnt	2U
BITMASK4_CNT_U08	1	Cnt	4U
Refer constants from .m file

Global

Constant Name

Refer constants from .m file

Module specific Lookup Tables Constants

Constant Name	Resolution	Value	Software Segment
Refer .m file

Software Module Implementation

Sub-Module Functions

NONE

Initialization Functions

Per: MotRefMdlINIT1

Design Rationale

Refer to FDD

Store Module Inputs to Local copies

Refer to FDD

(Processing of function)………

Refer to FDD

Store Local copy of outputs into Module Outputs

Refer to FDD

PERIODIC FUNCTIONS

Per: MotRefMdlper1

Design Rationale

Store Module Inputs to Local copies

Refer to FDD

(Processing of function)………

Refer to FDD

Store Local copy of outputs into Module Outputs

Refer to FDD

Non PERIODIC FUNCTIONS

None

Interrupt Functions

None

Serial Communication Functions

None

Local Function/Macro Definitions

Local Function #1 CalcCurrMagSqRef

Function Name	CalcCurrMagSqRef	Type	Min	Max
Arguments Passed	CurrDaxRef_Ampr_T_f32	float32	-200	200
	CurrQaxRef_Ampr_T_f32	float32	-200	200
Return Value	CurrMagSqRef_AmprSq_T_f32	float32	0	40000

Description

Refer FDD (F_CalcIqCommand)

Local Function #2 CalcIq

Function Name	CalcIq	Type	Min	Max
Arguments Passed	Tqcmd_MotNwtMtr_T_f32	float32	-8.8	8.8
	CurrDaxRef_Ampr_T_f32	float32	-200	200
	MotRefMdlInterCalcns_T_str	struct	Refer Struct Definition in Sec5.1	Refer Struct Definition in Sec5.1
Return Value	CurrQaxRefTmp_Ampr_T_f32	float32	-200	200

Description

Refer FDD (F_CalcIqCommand)

Local Function #3 CurrtoVoltTest

Function Name	CalcIq	Type	Min	Max
Arguments Passed	CurrQaxRef_Ampr_T_f32	float32	-8.8	8.8
	CurrDaxRef_Ampr_T_f32	float32	-200	200
	MotRefMdlInterCalcns_T_str	struct	Refer Struct Definition in Sec5.1	Refer Struct Definition in Sec5.1
Return Value	VdR_Ampr_T_f32	float32	-200	200
	VqR_Ampr_T_f32	float32	-200	200
	CurrQaxRefTmp_Ampr_T_f32	float32	-200	200

Description

Refer FDD ( F_ItoV)

Local Function #4 CalcMinMotCurr

Function Name	CalcMinMotCurr	Type	Min	Max
Arguments Passed	MotTqCmd_MotNwtMtr_T_f32	float32	-8.8	8.8
	MotRefMdlInterCalcns_T_str	struct	Refer Struct Definition in Sec5.1	Refer Struct Definition in Sec5.1
Return Value	CurrQaxMin_Ampr_T_f32	float32	-200	200
	CurrDaxMin_Ampr_T_f32	float32	-200	200
	ImSqrMin_AmprSq_T_f32	float32	0	40000

Description

Refer FDD (Locate Reference)

Local Function #5 CalcTq

Function Name	CalcTq	Type	Min	Max
Arguments Passed	CosDelta_Cnt_T_f32	float32	-1	1
	SinDelta_Cnt_T_f32	float32	-1	1
	MotRefMdlInterCalcns_T_str	struct	Refer Struct Definition in Sec5.1	Refer Struct Definition in Sec5.1
Return Value	TqCalc_MotNwtMtr_T_f32	float32	-8.8	8.8
	CurrDaxMax_Ampr_T_f32	float32	-200	200

Description

Refer FDD (CalculateTorque)

Local Function #6 CalcMaxTqPt

Function Name	CalcMaxTqPt	Type	Min	Max
Arguments Passed	MotTqCmd_MotNwtMtr_T_f32	float32	-8.8	8.8
	MotRefMdlInterCalcns_T_str	struct	Refer Struct Definition in Sec5.1	Refer Struct Definition in Sec5.1
Return Value	MotTqCmdLimd_MotNwtMtr_T_f32	float32	-8.8	8.8
	CurrDaxMax_Ampr_T_f32	float32	-200	200

Description

Refer FDD (LocateTorqueExtremes)

Local Function #7 PrbcIntrpn

Function Name	PrbcIntrpn	Type	Min	Max
Arguments Passed	IntrpnPts_T_f32	float32	Full range	Full range
Return Value	ParaIntpol_Uls_T_f32	float32	Full range	Full range

Description

Refer FDD ( Parabolic Interpolations)

Local Function #8 Decoder

Function Name	Decoder	Type	Min	Max
Arguments Passed	MotAndThermProtnLoaMod_Cnt_T_u08	Uin8	0	255
Return Value	CurrMeasLoaMtgtnEna_Cnt_T_logl	Boolean	FALSE	TRUE
	IvtrLoaMtgtnEna_Cnt_T_logl	Boolean	FALSE	TRUE
	FetLoaMtgtnEna_Cnt_T_logl	Boolean	FALSE	TRUE

Description

Refer FDD ( Decoder)

Local Function #9 VltgSdlCalc

Function Name	VltgSdlCalc	Type	Min	Max
Arguments Passed	MotQuad_Cnt_T_enum	MotQuad1	1U	4U
	AbsltMotVelFiltLp_MotRadPerSec_T_u11p5	uint16	0U	1350U
Return Value	VltgSdl_Volt_T_f32	Boolean	0.0F	40.0F

Description

This function is split from Per1 to reduce the path count to less than 300.

GLObAL Function/Macro Definitions

None

TRANSIENT FUNCTIONS

None

Unit Test Considerations

None

Known Limitations With Design

None

Appendix

None

3 - MotRefMdl_Peer_Review

Overview

Summary Sheet
Davinci Files
Source Code
PolySpace
Synergy Project

Sheet 1: Summary Sheet

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Summary Sheet

Component Short Name:

Windows User: Intended Use: Identify which component is being reviewed. This should match the component short name from the DataDict.m fileand the middle part of the Synergy project name, e.g. Assi for the SF001A_Assi_Impl Synergy project

SF103A_MotRefMdl_Impl

Revision / Baseline:

Windows User: Intended Use: Identify the implementation baseline name intended to be used for the changed component when changes are approved E.g. SF001A_Assi_Impl_1.2.0

SF103A_MotRefMdl_Impl_4.0.0

Change Owner:

Windows User: Intended Use: Identify the developer who made the change(s) being reviewed

Shawn Penning

Work CR ID:

Windows User: Intended Use: Identify the Implementation Work CR whose work is being reviewed (may be more than one)

EA4#17534

kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:

Check the file types that needed modification for the Work CR(s); macros for the check boxes will populate the appropriate checklist tabs for the review.

kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:

Reviewed:

At start of review, all items below should be marked "No". At the end of the review, all items should be marked "Yes" or "N/A" where N/A indicates the reviewers have reviewed the existing (unchanged) item and confirmed no updates were needed for the Work CR(s).

N/A

MDD

Yes

Source Code

Yes

PolySpace

N/A

Integration Manual

Yes

Davinci Files

Comments:

Version rolled to 4.0 to match major revision number for design; previous implementations were not correct.

General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include SWC Owner and/or SWC Design author and Integrator and/or SW Lead as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.

Each peer review shall start with a clean copy of the latest peer review checklist template. Before the peer review, the change owner shall:
o Review the previous component peer review and copy any relevant comments to the new review sheet.
o Review all checklist items and make all corrections needed, so that the component is ready for peer review. The expectation is that peer review should find very few issues,
because the change owner has already used the checklist to ensure the component changes are complete and correct.
o Fill in all file name and version information as needed on peer review checklist tabs (file names may be copied from the previous peer review where appropriate)
o Fill in checklist answers (Yes/No/NA pulldowns) ONLY on those items which are NA for the current change. All other checklist items should be blank going into the review
meeting.

During the peer review meeting:
o For each page of the review, first review the items already marked as N/A for this change, to confirm that reviewers agree with this assessment; change the checklist box to
blank if it is found that the item does apply.
o Then review the items with the checklist box blank. After reviewing each of these items, the checklist box will be marked as "Yes", or the checklist box will be marked as
"No" with needed rework indicated or with rationale indicated.
o If any items are marked "No" with rationale indicated, this must be approved by a software supervisor or the software manager; there is a line in the "Review Board" section
of each tab to indicate who approved the "No" items on that tab.

Sheet 2: Davinci Files

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Meeting Log (Davinci Review)

Quality Check Items:

Rationale is required for all answers of No

Only StdDef Port interfaces and datatypes are used

Yes

Comments:

(compare against TL107B to ensure only implementation

data types are used)

OBSOLETE/OBSELETE doesn’t appear in any arxml file

Yes

Comments:

Do all port interface names end in PortIf and a sequence

Yes

Comments:

number

Non-program-specific components saved

Yes

Comments:

in Autosar 4.0.3 format

For components with generated configurable content:

N/A

Comments:

*Cfg.arxml.TT: Verfied Davinci Configurator imported the

change correctly

*Cfg.h.TT: Verfied Davinci Configurator generates

N/A

Comments:

the configuration header file(s) correctly

All changed files have been compared against previous

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.

Yes

Comments:

versions (If available) and changes match changes

needed as described by the work CR(s), all parent CRs

and parent anomalies, and the SWC Design change log.

Davinci files accurately implement SWC Design (DataDict.m

N/A

Comments:

file) in all areas where arxml was changed and/or the

DataDict.m file was changed as shown by

comparing the DataDict.m from the current SWC Design

with the DataDict.m used in the previous implementation.

(This is NOT always the predecessor.)

Automated validation check is performed with no issues found

Yes

Comments:

Naming conventions followed. All names should

N/A

Comments:

match DataDict.m

Sender/Receiver port properties match DataDict.m file

Yes

Comments:

(name, data type, direction)

Calibration port properties match DataDict.m file

Yes

Comments:

(name, data type)

Sender/Receiver port initialization values match

Yes

Comments:

DataDict.m file and have been converted to counts

for fixed point types

Calibration port initialization values match

Yes

Comments:

DataDict.m file and have been converted to counts

for fixed point types

Mapping set and all unused items have been

Yes

Comments:

removed

All sender/receiver port read/writes using "Write (explicit)"

Yes

Comments:

and "Read (explicit by argument)"(List justification if not)

Runnable calling frequencies match DataDict.m file

Yes

Comments:

Runnable port access matches the DataDict.m file

Yes

Comments:

DataDict.m display variables: created as

Yes

Comments:

PerInstanceMemory. Name and data type match DataDict.m file.

Per Instance Memory names and data types

Yes

Comments:

match DataDict.m file

NVM blocks match DataDict.m file

N/A

Comments:

(Named per naming convention. Default block

used if specified in DataDict.m file. Data type

matches DatatDict.m file)

Component is correct component type

Yes

Comments:

General Notes / Comments:

Review Board:

Change Owner:

Shawn Penning

Review Date :

01/03/18

Component Type :

Application

Lead Peer Reviewer:

Brendon Binder

Approved by Reviewer(s):

Yes

Integrator and or
SW lead:

Comments:

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Sheet 3: Source Code

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Meeting Log (Source Code Review)

Source File Name:

MotRefMdl.c

Source File Revision:

Windows User: Intended Use: Synergy version number of the file being reviewed. (Version number that Synergy displays on the checked out or unmodified file in the working project) 9

Header File Name:

MotRefMdl.h

Header File Revision:

Windows User: Intended Use: Synergy version number of the file being reviewed. (Version number that Synergy displays on the checked out or unmodified file in the working project) 2 (see comment)

MDD Name:

MotRefMdl_MDD.doc

Revision:

7 (see comment)

SWC Design Name:

SF103A_MotRefMdl_Design

Revision:

Windows User: Intended Use: For FDDs, list the Synergy baseline number (just the number part of the Synergy baseline name) of the FDD baseline being implemented. E.g., for SF001A_Assi_Design_1.3.1, this field would say "1.3.1" 4.1

Quality Check Items:

Rationale is required for all answers of No

EA4 Common Naming Convention followed:

Version: 1.01

EA4 Software Naming Convention followed:

Version: 1.02

for variable names

N/A

Comments:

for constant names

N/A

Comments:

for function names

N/A

Comments:

for other names (component, memory

N/A

Comments:

mapping handles, typedefs, etc.)

Verified no possibility of uninitialized variables being

N/A

Comments:

written to component outputs or IRVs

Any requirements traceability tags have been removed

N/A

Comments:

from at least the changed areas of code

All variables are declared at the function level.

N/A

Comments:

Synergy version matches change history

kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.

Yes

Comments:

and Version Control version in file comment block

Change log contains detailed description of changes

Yes

Comments:

(including any anomaly number(s) being fixed) and

Work CR number

Code accurately implements SWC Design (Document or Model)

N/A

Comments:

in all areas where code was changed and/or Simulink

model was color-coded as changed and/or mentioned

in SWC Design change log. (This item includes looking at all

layers of Simulink model for possible color coding not

reflected at a higher level, and includes looking at any

intermediate SWC Design versions between the version being

implemented and the version that was included as a

subproject in the previous implementation.)

Code comparison against previous version matches

Yes

Comments:

changes needed as described by the work CR(s), all

parent CRs and parent anomalies, and the SWC

Design change log.

Verified no Compiler Errors or Warnings

KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used.

Yes

Comments:

(and verified for all possible combinations

of any conditionally compiled code)

Component.h is included

Yes

Comments:

All other includes are actually needed. (System includes

Yes

Comments:

only allowed in Nexteer library components)

Software Design and Coding Standards followed:

Windows User: Intended Use: list version/revision of latest released Software Design and Coding Standards document. Version: 2.01

Code comments are clear, correct, and adequate

Yes

Comments:

and have been updated for the change: [N40] and

all other rules in the same section as rule [N40],

plus [N75], [N12], [N23], [N33], [N37], [N38],

[N48], [N54], [N77], [N79], [N72]

Source file (.c and .h) comment blocks are per

Yes

Comments:

standards and contain correct information: [N41], [N42]

Function comment blocks are per standards and

Yes

Comments:

contain correct information: [N43]

Code formatting (indentation, placement of

Yes

Comments:

braces, etc.) is per standards: [N5], [N55], [N56],

[N57], [N58], [N59]

Embedded constants used per standards; no

Comments:

Beyond scope of this update; requires

"magic numbers": [N12]

designer input for naming to eliminate magic numbers.

Memory mapping for non-RTE code

N/A

Comments:

is per standard

All access of motor control loop data uses macros

N/A

Comments:

generated by the motor control manager

All loops have termination conditions that ensure

N/A

Comments:

finite loop iterations: [N63]

All divides protect against divide by zero

N/A

Comments:

Not checked; beyond scope of this change.

if needed: [N65]

All integer division and modulus operations

N/A

Comments:

handle negative numbers correctly: [N76]

All typecasting and fixed point arithmetic,

N/A

Comments:

including all use of fixed point macros and

timer functions, is correct and has no possibility

of unintended overflow or underflow: [N66]

All float-to-unsigned conversions ensure the.

N/A

Comments:

float value is non-negative: [N67]

All conversions between signed and unsigned

N/A

Comments:

types handle msb==1 as intended: [N78]

All pointer dereferencing protects against

N/A

Comments:

null pointer if needed: [N70]

Component outputs are limited to the legal range

N/A

Comments:

defined in the SWC Design DataDict.m file : [N53]

All code is mapped with SWC Design (all SWC

N/A

Comments:

Design subfunctions and/or model blocks identified

with code comments; all code corresponds to

some SWC Design subfunction and/or model block):

[N40]

Any other violations of design and coding

N/A

Comments:

standards noticed during the review are noted in the

comments section for rework.

Anomaly or Design Work CR created

N/A

Comments: List Anomaly or CR numbers

for any SWC Design corrections needed

General Notes / Comments:

MDD is actually version 6 but appears in Synergy as 7. Header file is actually version 1 but appears in synergy as version 2. Both

files versions should be corrected during the next update of each file.

Review Board:

Change Owner:

Shawn Penning

Review Date :

01/03/18

Lead Peer Reviewer:

Brendon Binder

Approved by Reviewer(s):

Yes

SWC owner and/or
SWC Design author:

Comments:

Integrator and or
SW lead:

Comments:

Unit test co-ordinator:

Comments:

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Kathleen Creager

Sheet 4: PolySpace

Rev 2.00

29-Nov-17

Nexteer SWC Implementation Peer Review Meeting Log (PolySpace Review)

Source File Name:

MotRefMdl.c

Source File Revision:

Source File Name:

Source File Revision:

Source File Name:

Source File Revision:

EA4 Static Analysis Compliance Guideline version:

1.04

Poly Space version:

Windows User: eg. 2013b

2013b

TL109A sub project version:

2.2.0

Quality Check Items:

Rationale is required for all answers of No

tools/local folders' header files are appropriate and

Yes

Comments:

function prototypes match the latest component version

100% Compliance to the EA4 Static Analysis

Yes

Comments:

Compliance Guideline

Are previously added justification and deviation

Yes

Comments:

comments still appropriate

Do all MISRA deviation comments use approved

Yes

Comments:

deviation tags

For any component source files (.c, .h, generated Cfg.c and Cfg.h)

N/A

Comments:

with conditional compilation, has Polyspace been run with all

combinations of build constants that can be used together in a build?

(Note which conditional compilation results have been archived)

Cyclomatic complexity and Static path count OK

Yes

Comments:

for all functions in the component per Design

and Coding Standards rule [N47]

General Notes / Comments:

Overflow and Divide by Zero flags were not checked as none of these variables were affected by this change. Future updates affecting these variables should verify that these

polyspace flags are not relevant.

Review Board:

Change Owner: Shawn Penning Review Date :

Lead Peer Reviewer: Test Approved by Reviewer(s):

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Change Owner:

Shawn Penning

Review Date :

01/03/18

Lead Peer Reviewer:

Brendon Binder

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Rationale/justification for items marked "No" approved by:

Sheet 5: Synergy Project

Rev 2.00

29-Nov-17

Peer Review Meeting Log (Component Synergy Project Review)

Quality Check Items:

Rationale is required for all answers of No

New baseline version name from Summary Sheet follows

Yes

Comments:

naming convention

Project contains necessary subprojects

Yes

Comments:

Project contains the correct version of subprojects

Yes

Comments:

Design subproject is correct version

Yes

Comments:

.gpj file in tools folder matches .gpj generated by TL109 script

Yes

Comments:

File/folder structure is correct per documentation in

Yes

Comments:

TL109A_SwcSuprt

General Notes / Comments:

Review Board:

Change Owner:

Shawn Penning

Review Date :

01/03/18

Lead Peer Reviewer:

Brendon Binder

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Rationale/justification for items marked "No" approved by: