Sr. No.	Title	Version
1	EA4 Software Naming Conventions	01.01.00
2	Software Design and Coding Standards	2.1
3	ES200B_CurrMeas_Design	See Synergy Sub Project Version

Dependencies

SWCs

Module	Required Feature
DF001A_FltInj	Header file: FltInj.h
ES999A_ElecGlbPrm	Header file: ElecGlbPrm.h

Note : Referencing the external components should be avoided in most cases. Only in unavoidable circumstance external components should be referred. Developer should track the references.

Global Functions(Non RTE) to be provided to Integration Project

CurrMeasPer2

Configuration REQUIREMeNTS

Build Time Config

Modules	Notes
FLTINJENA	Takes values STD_ON or STD_OFF

Configuration Files to be provided by Integration Project

None

Da Vinci Parameter Configuration Changes

Parameter	Notes	SWC
None

DaVinci Interrupt Configuration Changes

ISR Name	VIM #	Priority Dependency	Notes
None

Manual Configuration Changes

Constant	Notes	SWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

See FDD DataDict.m.

Required Global Data Outputs

See FDD DataDict.m.

Specific Include Path present

Yes

Runnable Scheduling

This section specifies the required runnable scheduling.

Init	Scheduling Requirements	Trigger
CurrMeasInit1	None	RTE(Init)

Runnable	Scheduling Requirements	Trigger
CurrMeasPer1	None	RTE(2ms)
CurrMeasPer2	None	ISR(2 * MtrCtrlISR)
CurrMeasPer3	None	RTE(2ms)
CurrMeasEolGainReq_Oper	None	RTE(Event)
CurrMeasEolGainStsReq_Oper	None	RTE(Event)
CurrMeasEolOffsReq_Oper	None	RTE(Event)
CurrMeasEolOffsStsReq_Oper	None	RTE(Event)
CurrMeasGainReadReqSngIvtr_Oper	None	RTE(Event)
CurrMeasGainWrReqSngIvtr_Oper	None	RTE(Event)
CurrMeasOffsReadReqSngIvtr_Oper	None	RTE(Event)
CurrMeasOffsWrReqSngIvtr_Oper	None	RTE(Event)

Memory Map REQUIREMENTS

Mapping

Memory Section	Contents	Notes
CDD_CurrMeas_START_SEC_CODE	Functions
CDD_CurrMeas_MotCtrl_START_SEC_CODE	Functions

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

Feature	RAM	ROM
None

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

*See DataDict.m

Compiler Settings

Preprocessor MACRO

None

Optimization Settings

None

Appendix

None

2 - CurrMeas_MDD

Module Design Document

For

CurrMeas

Oct 16, 2017

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

Software Group,

Nexteer Automotive,

Saginaw, MI, USA
Change History

Description	Author	Version	Date
Initial Version	Krzysztof Byrski	1.0	19-May-2017
Fixed anomaly EA4#13330 by using required NVM blocks as applicable	Krishna Anne	2.0	16-Oct-17

Table of Contents

1 Introduction 5

1.1 Purpose 5

1.2 Scope 5

2 CurrMeas & High-Level Description 6

3 Design details of software module 7

3.1 Graphical representation of CurrMeas 7

3.2 Data Flow Diagram 7

3.2.1 Component level DFD 7

3.2.2 Function level DFD 7

4 Constant Data Dictionary 8

4.1 Program (fixed) Constants 8

4.1.1 Embedded Constants 8

5 Software Component Implementation 9

5.1 Sub-Module Functions 9

5.1.1 Init: CurrMeasInit1 9

5.1.2 Per: CurrMeasPer1 9

5.1.3 Per: CurrMeasPer2 9

5.1.4 Per: CurrMeasPer3 10

5.2 Server Runables 11

5.2.1 CurrMeasEolGainReq_Oper 11

5.2.2 CurrMeasEolGainStsReq_Oper 11

5.2.3 CurrMeasEolOffsReq_Oper 11

5.2.4 CurrMeasEolOffsStsReq_Oper 11

5.2.5 CurrMeasGainReadReqSngIvtr_Oper 11

5.2.6 CurrMeasGainWrReqSngIvtr_Oper 11

5.2.7 CurrMeasOffsReadReqSngIvtr_Oper 12

5.2.8 CurrMeasOffsWrReqSngIvtr_Oper 12

5.3 Interrupt Functions 13

5.4 Module Internal (Local) Functions 13

5.4.1 OffsetCalibration 13

5.4.2 GainCalibration 14

5.4.3 RangeChkWIABC 14

5.4.4 ProtocolChkENABC 15

5.4.5 CalcMotCurrMotAgCorrd 15

5.4.6 CalMotCurrCorrdABC 15

5.4.7 OffsCalcABC 16

5.5 GLOBAL Function/Macro Definitions 17

6 Known Limitations with Design 18

7 UNIT TEST CONSIDERATION 19

Appendix A Abbreviations and Acronyms 20

Appendix B Glossary 21

Appendix C References 22

Introduction

Purpose

Module Design Document for ES200B_CurrMeas.

Scope

The following definitions are used throughout this document:

Shall: indicates a mandatory requirement without exception in compliance.
Should: indicates a mandatory requirement; exceptions allowed only with documented justification.
May: indicates an optional action.

CurrMeas & High-Level Description

Refer FDD.

Design details of software module

Graphical representation of CurrMeas

Data Flow Diagram

Refer FDD

Component level DFD

None

Function level DFD

None

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Local Constants

Constant Name	Resolution	Units	Value
CALPROCNOTSTRTD_CNT_U08	1	Cnt	0
CALPROCSTRTD_CNT_U08	1	Cnt	1
CALPROCPASS_CNT_U08	1	Cnt	2
CALPROCPHAABCEOLOUTOFRNG_CNT_U08	1	Cnt	4
CALPROCVEHSPDCNDNOTMET_CNT_U08	1	Cnt	16
CALPROCMOTVELMRFCNDNOTMET_CNT_U08	1	Cnt	64
VEHSPDCDNNOTMET_CNT_U08	1	Cnt	4
MOTVELMRFCDNNOTMET_CNT_U08	1	Cnt	8
DIAGCSTSINVTRINACTV_CNT_U08	1	Cnt	16
FAILDATENA_CNT_U08	1	Cnt	2
FAILDATWRMININ_CNT_U08	1	Cnt	3
INVTRINACTV_CNT_U08	1	Cnt	8
DIFOFFSRNGCHKMAX_VOLT_F32	Single precision float	Volt	1.0
DEGREES30_MOTRAD_F32	Single precision float	MotRad	0.5236
MAXCURRCORRD_AMPR_F32	Single precision float	Ampr	200.0
PHAONTIBCOK_CNT_U08	1	Cnt	0x03
PHAONTIACOK_CNT_U08	1	Cnt	0x05
PHAONTIABOK_CNT_U08	1	Cnt	0x06
PHAONTIABCOK_CNT_U08	1	Cnt	0x07
PHAONTIA_CNT_U08	1	Cnt	0x04
PHAONTIB_CNT_U08	1	Cnt	0x02
PHAONTIC_CNT_U08	1	Cnt	0x01
NANOSECTOSEC_ULS_F32	Single precision float	Uls	0.000000001

Software Component Implementation

Sub-Module Functions

Init: Init1

Design Rationale

Refer FDD

Module Outputs

Refer FDD

Per: Per1

Design Rationale

Refer FDD

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Per: Per2

Design Rationale

Refer FDD

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Per: Per3

Design Rationale

Refer FDD

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Server Runables

CurrMeasEolGainReq_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

CurrMeasEolGainStsReq_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

CurrMeasEolOffsReq_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

CurrMeasEolOffsStsReq_Oper

Design Rationale

Refer FDD

CurrMeasGainReadReqSngIvtr_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

CurrMeasGainWrReqSngIvtr_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

CurrMeasOffsReadReqSngIvtr_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

CurrMeasOffsWrReqSngIvtr_Oper

Design Rationale

Refer FDD

(Processing of function)………

Refer FDD

Interrupt Functions

None

Module Internal (Local) Functions

OffsetCalibration

Function Name	OffsetCalibration	Type	Min	Max
Arguments Passed	MotCurrAdcVlyA_Volt_T_f32	float32	0.0	5.0
	MotCurrAdcVlyB_Volt_T_f32	float32	0.0	5.0
	MotCurrAdcVlyC_Volt_T_f32	float32	0.0	5.0
	MotVelMrf_MotRadPerSec_T_f32	float32	-1350.0	1350.0
	VehSpd_Kph_T_f32	float32	0.0	511.0
	VehSpdVld_Cnt_T_logl	boolean	FALSE	TRUE
	BrdgVltg_Volt_T_f32	float32	6.0	26.5
	DiagcStsIvtr1Inactv_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	N/A	-	-	-

Design Rationale

Refer FDD

Processing

Refer FDD

GainCalibration

Function Name	GainCalibration	Type	Min	Max
Arguments Passed	MotCurrEolOffsProcFlg_Cnt_T_logl	boolean	FALSE	TRUE
	MotCurrAdcVlyA_Volt_T_f32	float32	0.0	5.0
	MotCurrAdcVlyB_Volt_T_f32	float32	0.0	5.0
	MotCurrAdcVlyC_Volt_T_f32	float32	0.0	5.0
	MotVelMrf_MotRadPerSec_T_f32	float32	-1350.0	1350.0
	MotCurrOffsZeroAvrgA_Volt_T_f32	float32	0.0	5.0
	MotCurrOffsZeroAvrgB_Volt_T_f32	float32	0.0	5.0
	MotCurrOffsZeroAvrgC_Volt_T_f32	float32	0.0	5.0
	VehSpd_Kph_T_f32	float32	0.0	511.0
	VehSpdVld_Cnt_T_logl	boolean	FALSE	TRUE
	DiagcStsIvtr1Inactv_Cnt_T_logl	boolean	FALSE	TRUE
	MotCurrEolCalStPrev_Cnt_T_enum	MotCurrEolCalSt2	0	8
Return Value	N/A	-	-	-

Design Rationale

Refer FDD

Processing

Refer FDD

RangeChkWIABC

Function Name	RangeChkWIABC	Type	Min	Max
Arguments Passed	MotCurrAdcVlyA_Volt_T_f32	float32	0.0	5.0
	MotCurrAdcVlyB_Volt_T_f32	float32	0.0	5.0
	MotCurrAdcVlyC_Volt_T_f32	float32	0.0	5.0
Return Value	InRng_Cnt_T_logl	boolean	FALSE	TRUE

Design Rationale

Refer FDD

Processing

Refer FDD

ProtocolChkENABC

Function Name	ProtocolChkENABC	Type	Min	Max
Arguments Passed	N/A	-	-	-
Return Value	ProtocolChkEn_Cnt_T_logl	boolean	FALSE	TRUE

Design Rationale

Refer FDD

Processing

Refer FDD

CalcMotCurrMotAgCorrd

Function Name	CalcMotCurrMotAgCorrd	Type	Min	Max
Arguments Passed	N/A	-	-	-
Return Value	MotCtrlCurrMeasMotAgCorrd_Rad_T_f32	float32	-0.7666	6.2832

Design Rationale

Refer FDD

Processing

Refer FDD

CalMotCurrCorrdABC

Function Name	CalMotCurrCorrdABC	Type	Min	Max
Arguments Passed	MotCurrOffsA_Volt_T_f32	float32	-1892868,5	1892873,5
	MotCurrOffsA_Volt_T_f32	float32	-1892868,5	1892873,5
	MotCurrOffsA_Volt_T_f32	float32	-1892868,5	1892873,5
Return Value	N/A

Design Rationale

Refer FDD

Processing

Refer FDD

OffsCalcABC

Function Name	OffsCalcABC	Type	Min	Max
Arguments Passed	N/A
Return Value	MotCurrOffsA_Volt_T_f32	float32	-1892868,5	1892873,5
	MotCurrOffsB_Volt_T_f32	float32	-1892868,5	1892873,5
	MotCurrOffsC_Volt_T_f32	float32	-1892868,5	1892873,5

Design Rationale

Refer FDD

Processing

Refer FDD

GLOBAL Function/Macro Definitions

None

Known Limitations with Design

None

UNIT TEST CONSIDERATION

None

Abbreviations and Acronyms

Abbreviation or Acronym	Description
-	-

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

ISO 9000
ISO/IEC 12207
ISO/IEC 15504
Automotive SPICE® Process Reference Model (PRM)
Automotive SPICE® Process Assessment Model (PAM)
ISO/IEC 15288
ISO 26262
IEEE Standards
SWEBOK
PMBOK
Existing Nexteer Automotive documentation

Term	Definition	Source
MDD	Module Design Document
DFD	Data Flow Diagram

References

Ref. #	Title	Version
1	AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)	v1.3.0 R4.0 Rev 2
2	MDD Guideline	EA4 01.00.01
3	Software Naming Conventions	01.01.00
4	Software Design and Coding Standards	2.1
5	ES200B_CurrMeas_Design	See Synergy Sub Project Version

3 - CurrMeas_Review

Overview

Summary Sheet
Synergy Project
Davinci Files
Source Code
CDD_CurrMeas_MotCtrl
MDD
PolySpace

Sheet 1: Summary Sheet

Rev 1.2

8-Jun-15

Peer Review Summary Sheet

Synergy Project Name:

kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. ES200B_CurrMeas_Impl

Revision / Baseline:

kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. ES200B_CurrMeas_Impl_2.1.0

Change Owner:

kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Krishna Anne

Work CR ID:

EA4#15188

kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:

kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:

Reviewed:

Yes

MDD

Yes

Source Code

Yes

PolySpace

N/A

Integration Manual

Yes

Davinci Files

Comments:

General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.

Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)

Quality Check Items:

Rationale is required for all answers of No

New baseline version name from Summary Sheet follows

Yes

Comments:

naming convention

Project contains necessary subprojects

Yes

Comments:

Project contains the correct version of subprojects

Yes

Comments:

Latest versions

Design subproject is correct version

Yes

Comments:

General Notes / Comments:

LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:

Change Owner:

Krishna Anne

Review Date :

10/16/17

Lead Peer Reviewer:

Shawn Penning

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 3: Davinci Files

Rev 1.2

8-Jun-15

Peer Review Meeting Log (Davinci Review)

Quality Check Items:

Rationale is required for all answers of No

Only StdDef Port types are used

Yes

Comments:

For components not using application data types, do all

Yes

Comments:

port interface names end in PortIf and a sequence number

Non-program-specific components saved

Yes

Comments:

in Autosar 4.0.3 format

*Cfg.arxml.TT: Verfied Davinci Configurator imported the

N/A

Comments:

change correctly

*Cfg.h.TT: Verfied Davinci Configurator generates

N/A

Comments:

the configuration header(s) file correctly

kzshz2: Either a generic sandbox or a baselined integration project can be used to verify

All changed files have been compared against previous

Yes

Comments:

versions (If available)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.

Automated validation check is performed

Yes

Comments:

Naming conventions followed. All names should

Yes

Comments:

match DataDict.m

Sender/Receiver port properties match DataDict.m

Yes

Comments:

file (use .m file helper tool)

Calibration port properties match DataDict.m

Yes

Comments:

file (use .m file helper tool)

Components using application data types:

Sender/Receiver port initialization values match

N/A

Comments:

DataDict.m file

Calibration port initialization values match

N/A

Comments:

DataDict.m file

Components not using application data types:

Sender/Receiver port initialization values match

Yes

Comments:

DataDict.m file and have been converted to counts

for fixed point types

Calibration port initialization values match

Yes

Comments:

DataDict.m file and have been converted to counts

for fixed point types

Mapping set and all unused items have been

Yes

Comments:

removed

All sender/receiver port read/writes using direct

Yes

Comments:

read/writes(List justification if not)

Runnable calling frequencies match FDD

N/A

Comments:

DataDict.m display variables: created as

N/A

Comments:

PerInstanceMemory. Matches the FDD

Component is correct component type

Yes

Comments:

General Notes / Comments:

Change Owner:

Krishna Anne

Review Date :

10/16/17

Component Type :

CDD

Lead Peer Reviewer:

Shawn Penning

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 4: Source Code

Rev 1.2

8-Jun-15

Peer Review Meeting Log (Source Code Review)

Source File Name:

CDD_CurrMeas.c

Source File Revision:

Header File Name:

CDD_CurrMeas.h

Header File Revision:

kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this. 1

MDD Name:

CurrMeas_MDD.docx

Revision:

FDD/SCIR/DSR/FDR/CM Name:

ES200B_CurrMeas_Design

Revision:

2.1.0

Quality Check Items:

Rationale is required for all answers of No

Working EA4 Software Naming Convention followed:

for variable names

Yes

Comments:

for constant names

N/A

Comments:

N/A for changes

for function names

N/A

Comments:

N/A for changes

for other names (component, memory

N/A

Comments:

mapping handles, typedefs, etc.)

N/A for changes

All paths assign a value to outputs, ensuring

Yes

Comments:

all outputs are initialized prior to being written

Requirements Tracability tags in code match the requirements tracability in the FDD

N/A

Comments:

requirements tracability in the FDD

N/A for EA4

All variables are declared at the function level.

Yes

Comments:

Synergy version matches change history

kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.

Yes

Comments:

and Version Control version in file comment block

Change log contains detailed description of changes

Yes

Comments:

and Work CR number

Code accurately implements FDD (Document or Model)

Yes

Comments:

Verified no Compiler Errors or Warnings

KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used; QAC can find compiler errors but not warnings.

Yes

Comments:

Component.h is included

Yes

Comments:

All other includes are actually needed. (System includes

Yes

Comments:

only allowed in Nexteer library components)

Software Design and Coding Standards followed:

Version: 2.1

Code comments are clear, correct, and adequate

Yes

Comments:

and have been updated for the change: [N40] and

all other rules in the same section as rule [N40],

plus [N75], [N12], [N23], [N33], [N37], [N38],

[N48], [N54], [N77], [N79], [N72]

Source file (.c and .h) comment blocks are per

Yes

Comments:

standards and contain correct information: [N41], [N42]

Function comment blocks are per standards and

N/A

Comments:

contain correct information: [N43]

N/A for changes

Code formatting (indentation, placement of

Yes

Comments:

braces, etc.) is per standards: [N5], [N55], [N56],

[N57], [N58], [N59]

Embedded constants used per standards; no

N/A

Comments:

"magic numbers": [N12]

N/A for changes

Memory mapping for non-RTE code

Yes

Comments:

is per standard

All execution-order-dependent code can be

Yes

Comments:

recognized by the compiler: [N80]

All loops have termination conditions that ensure

N/A

Comments:

finite loop iterations: [N63]

N/A for changes

All divides protect against divide by zero

N/A

Comments:

if needed: [N65]

N/A for changes

All integer division and modulus operations

N/A

Comments:

handle negative numbers correctly: [N76]

N/A for changes

All typecasting and fixed point arithmetic,

N/A

Comments:

including all use of fixed point macros and

N/A for changes

timer functions, is correct and has no possibility

of unintended overflow or underflow: [N66]

All float-to-unsiged conversions ensure the.

N/A

Comments:

float value is non-negative: [N67]

N/A for changes

All conversions between signed and unsigned

N/A

Comments:

types handle msb==1 as intended: [N78]

N/A for changes

All pointer dereferencing protects against

Yes

Comments:

null pointer if needed: [N70]

Component outputs are limited to the legal range

N/A

Comments:

defined in the FDD DataDict.m file : [N53]

N/A for changes

All code is mapped with FDD (all FDD

Yes

Comments:

subfunctions and/or model blocks identified

with code comments; all code corresponds to

some FDD subfunction and/or model block): [N40]

Review did not identify violations of other

Yes

Comments:

coding standard rules

Anomaly or Design Work CR created

N/A

Comments: List Anomaly or CR numbers

for any FDD corrections needed

General Notes / Comments:

Change Owner:

Krishna Anne

Review Date :

10/16/17

Lead Peer Reviewer:

Shawn Penning

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 5: CDD_CurrMeas_MotCtrl

Rev 1.2

8-Jun-15

Peer Review Meeting Log (Source Code Review)

Source File Name:

CDD_CurrMeas_MotCtrl.c

Source File Revision:

Header File Name:

Header File Revision:

kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this.

MDD Name:

CurrMeas_MDD.docx

Revision:

FDD/SCIR/DSR/FDR/CM Name:

ES200B_CurrMeas_Design

Revision:

2.1.0

Quality Check Items:

Rationale is required for all answers of No

Working EA4 Software Naming Convention followed:

for variable names

N/A

Comments:

N/A for changes

for constant names

N/A

Comments:

N/A for changes

for function names

N/A

Comments:

N/A for changes

for other names (component, memory

N/A

Comments:

mapping handles, typedefs, etc.)

N/A for changes

All paths assign a value to outputs, ensuring

Yes

Comments:

all outputs are initialized prior to being written

Requirements Tracability tags in code match the requirements tracability in the FDD

N/A

Comments:

requirements tracability in the FDD

N/A for EA4

All variables are declared at the function level.

Yes

Comments:

Synergy version matches change history

Yes

Comments:

and Version Control version in file comment block

Change log contains detailed description of changes

Yes

Comments:

and Work CR number

Code accurately implements FDD (Document or Model)

Yes

Comments:

Verified no Compiler Errors or Warnings

Yes

Comments:

Component.h is included

N/A

Comments:

All other includes are actually needed. (System includes

Yes

Comments:

only allowed in Nexteer library components)

Software Design and Coding Standards followed:

Version: 2.1

Code comments are clear, correct, and adequate

Yes

Comments:

and have been updated for the change: [N40] and

all other rules in the same section as rule [N40],

plus [N75], [N12], [N23], [N33], [N37], [N38],

[N48], [N54], [N77], [N79], [N72]

Source file (.c and .h) comment blocks are per

N/A

Comments:

standards and contain correct information: [N41], [N42]

Function comment blocks are per standards and

N/A

Comments:

contain correct information: [N43]

N/A for changes

Code formatting (indentation, placement of

Yes

Comments:

braces, etc.) is per standards: [N5], [N55], [N56],

[N57], [N58], [N59]

Embedded constants used per standards; no

N/A

Comments:

"magic numbers": [N12]

N/A for changes

Memory mapping for non-RTE code

Yes

Comments:

is per standard

All execution-order-dependent code can be

Yes

Comments:

recognized by the compiler: [N80]

All loops have termination conditions that ensure

N/A

Comments:

finite loop iterations: [N63]

N/A for changes

All divides protect against divide by zero

N/A

Comments:

if needed: [N65]

N/A for changes

All integer division and modulus operations

N/A

Comments:

handle negative numbers correctly: [N76]

N/A for changes

All typecasting and fixed point arithmetic,

N/A

Comments:

including all use of fixed point macros and

N/A for changes

timer functions, is correct and has no possibility

of unintended overflow or underflow: [N66]

All float-to-unsiged conversions ensure the.

N/A

Comments:

float value is non-negative: [N67]

N/A for changes

All conversions between signed and unsigned

N/A

Comments:

types handle msb==1 as intended: [N78]

N/A for changes

All pointer dereferencing protects against

Yes

Comments:

null pointer if needed: [N70]

Component outputs are limited to the legal range

N/A

Comments:

defined in the FDD DataDict.m file : [N53]

N/A for changes

All code is mapped with FDD (all FDD

Yes

Comments:

subfunctions and/or model blocks identified

with code comments; all code corresponds to

some FDD subfunction and/or model block): [N40]

Review did not identify violations of other

Yes

Comments:

coding standard rules

Anomaly or Design Work CR created

N/A

Comments: List Anomaly or CR numbers

for any FDD corrections needed

General Notes / Comments:

Change Owner:

Krishna Anne

Review Date :

10/16/17

Lead Peer Reviewer:

Shawn Penning

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 6: MDD

Rev 1.2

8-Jun-15

Peer Review Meeting Log (MDD Review)

MDD Name:

CurrMeas_MDD

MDD Revision:

Source File Name:

CDD_CurrMeas.c

Source File Revision:

Source File Name:

CDD_CurrMeas_MotCtrl.c

Source File Revision:

Source File Name:

Source File Revision:

Quality Check Items:

Rationale is required for all answers of No

Synergy version matches document

Yes

Comments:

Change log contains detailed description of changes

Yes

Comments:

Changes Highlighted (for Unit Tester)

Yes

Comments:

Diagrams have been included per MDD Guideline

Yes

Comments:

and reviewed

All Design Exceptions and Limitations are listed

N/A

Comments:

Design rationale given for all global

Yes

Comments:

data not communicated through RTE ports, per

Design and Coding Standards rules [N9] and [N10].

All implementation details that differ from the FDD are

N/A

Comments:

noted and explained in Design Rationale

All Unit Test Considerations have been described

N/A

Comments:

General Notes / Comments:

Change Owner:

Krishna Anne

Review Date :

10/16/17

Lead Peer Reviewer:

Shawn Penning

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 7: PolySpace

Rev 1.2

8-Jun-15

Peer Review Meeting Log (QAC/PolySpace Review)

Source File Name:

CDD_CurrMeas.c

Source File Revision:

Source File Name:

CDD_CurrMeas_MotCtrl.c

Source File Revision:

Source File Name:

Source File Revision:

EA4 Static Analysis Compliance Guideline version:

01.03.00

Poly Space version:

Windows User: eg. 2013b 2013b

Polyspace sub project version:

Windows User: eg. TL108a_PolyspaceSuprt_1.0.0 NA

Quality Check Items:

Rationale is required for all answers of No

Contract Folder's header files are appropriate and

kzshz2: Intended Use: Identify that the contract folder contains only the information required for this component. All other variables, constants, function prototypes, etc. should be removed. Rationale: This will help avoid unit testers having to considers object not used. It will also avoid having other files required for QAC.

Yes

Comments:

function prototypes match the latest component version

Not changed since previous version

100% Compliance to the EA4 Static Analysis

Yes

Comments:

Compliance Guideline

Are previously added justification and deviation

Yes

Comments:

comments still appropriate

Do all MISRA deviation comments use approved

Yes

Comments:

deviation tags

Not changed since previous version

Cyclomatic complexity and Static path count OK

Creager, Kathleen: use Browse Function Metrics, STCYC and STPTH

Comments:

for all functions in the component per Design

Not changed since previous version

and Coding Standards rule [N47]

General Notes / Comments:

10/16/2017: Krishna : Cyclomatic complexity was beyond the acceptable limits since the beginning of this Impl; This needs to be fixed in a next update.

Change Owner:

Krishna Anne

Review Date :

10/16/17

Lead Peer Reviewer:

Shawn Penning

Approved by Reviewer(s):

Yes

Other Reviewer(s):