This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Implementation

1 - HwAg1Meas_IntegrationManual

Integration Manual

For

HwAg1Meas

VERSION: 6.0

DATE: 14-Aug-2017

Prepared By:

Software Engineering,

Nexteer Automotive,

Saginaw, MI, USA

Revision History

DescriptionAuthorVersionDate
Initial versionSelva Sengottaiyan1.021-July-2015
Updated to FDD v 1.2.0Selva Sengottaiyan2.011-Sep-2015
Updated to FDD v1.4.0Selva Sengottaiyan3.022-Dec-2015
Updated to FDD v1.8.0TATA4.021-Jun-2015
Updated for v2.1.0KK5.011-Apr-2017
Updated server runnable names to match DataDict.mBrionna Spencer6.014-Aug-2017

Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 NvM Blocks 10

7.4 RTE NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

AbbreviationDescription
DFDDesign functional diagram
MDDModule design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.TitleVersion
1FDD – CM670A_HwAg1Meas_DesignSee Synergy sub project version
2Software Naming Conventions01.01.00
3Software Design and Coding Standards2.1

Dependencies

SWCs

ModuleRequired Feature
None

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

ModulesNotes
None

Configuration Files to be provided by Integration Project

HwAg1Meas_Cfg.h

Da Vinci Parameter Configuration Changes

ParameterNotesSWC
Refer the .m fileCM10 provides program specific NTC configuration

DaVinci Interrupt Configuration Changes

ISR NameVIM #Priority DependencyNotes
None

Manual Configuration Changes

ConstantNotesSWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file in the FDD

Required Global Data Outputs

Refer DataDict.m file file in the FDD

Specific Include Path present

No

Runnable Scheduling

This section specifies the required runnable scheduling.

InitScheduling RequirementsTrigger
HwAg1MeasInit1NoneRTE (Init)
RunnableScheduling RequirementsTrigger
HwAg1MeasPer1NoneRTE (2 ms)
HwAg1MeasPer2NoneRTE (2 ms)
HwAg1MeasPer3NoneRTE (2 ms)
HwAg1MeasPer4NoneRTE (2ms)
HwAg1MeasPer5NoneRTE (100ms)
HwAg1AutTrim_OperNoneServer invocation
HwAg1ClrTrim_OperNoneServer invocation
HwAg1ReadTrim_OperNoneServer invocation
HwAg1ReadTrim_OperNoneServer invocation
HwAg1TrimPrfmdSts_OperNoneServer invocation
HwAg1WrTrim_OperNoneServer invocation
HwAg1ClrLtch _OperNoneServer invocation

Memory Map REQUIREMENTS

Mapping

Memory SectionContentsNotes
None

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

FeatureRAMROM
None

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

RTE NvM Blocks

Block Name
HwAg1Offs
HwAg1IfFltLtch

Note : Size of the NVM block if configured in developer

Compiler Settings

Preprocessor MACRO

None.

Optimization Settings

None.

Appendix

SENT2SPCO port out should be configured to be high level on port configurations refer CM10 for SPCO port configuration (SENT2SPCO shall be port level high). Port configuration SENT2SPCO output:

Port (that’s needs to be configured as SENT2SPCO) should be initialized as input dio with level high. The client call Iohwab_Setfctprphlhwag1_oper will reset the pin to output alterante mode for SENT2SPCO.

Design Recommandation:

- Port Config RSENT2 IO pin shall setup default input.

- Schedule execution of tasks as per below order at the end of 2ms task

1. "HwAg1MeasPer2"

2. "HwAg1MeasPer3"

3. "HwAg1MeasPer4"

4. "HwAg1MeasPer1"

- Schedule "HwAg1MeasPer4" & "HwAg1MeasPer1" shall at least 110us apart.

2 - HwAg1Meas_MDD

Module Design Document

For

HwAg1Meas

14-Aug-2017

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

Software Engineering,

Nexteer Automotive,

Saginaw, MI, USA


Change History

DescriptionAuthorVersionDate
Initial VersionSelva Sengottaiyan1.021-July-2015
Updated to v1.2.0 of the FDDSelva Sengottaiyan2.011-Sep-2015
Updated to v1.4.0 of the FDDSelva Sengottaiyan3.023-Dec-2015
Updated to v1.11.0 of the FDDRamachandran4.021-Jun-2016
Updated for v2.1.0KK5.011-Apr-2017
Updated server runnable names to match DataDict.m and updated graphicBrionna Spencer6.014-Aug-2017


Table of Contents

1 Introduction 5

1.1 Purpose 5

1.2 Scope 5

2 HwAg1Meas High-Level Description 6

3 Design details of software module 7

3.1 Graphical representation of HwAg1Meas 7

3.2 Data Flow Diagram 7

3.2.1 Component level DFD 7

3.2.2 Function level DFD 7

4 Constant Data Dictionary 8

4.1 Program (fixed) Constants 8

4.1.1 Embedded Constants 8

5 Software Component Implementation 9

5.1 Sub-Module Functions 9

5.1.1 Init: HwAg1MeasInit1 9

5.1.1.1 Design Rationale 9

5.1.2 Per: HwAg1MeasPer1 9

5.1.2.1 Design Rationale 9

5.1.3 Per: HwAg1MeasPer2 9

5.1.3.1 Design Rationale 9

5.1.4 Per: HwAg1MeasPer3 9

5.1.4.1 Design Rationale 9

5.1.5 Per: HwAg1MeasPer4 9

5.1.5.1 Design Rationale 9

5.1.6 Per: HwAg1MeasPer5 9

5.1.6.1 Design Rationale 9

5.2 Server Runnables 10

5.2.1 HwAg1AutTrim 10

5.2.1.1 Design Rationale 10

5.2.2 HwAg1ClrLtch 10

5.2.2.1 Design Rationale 10

5.2.3 HwAg1ClrTrim 10

5.2.3.1 Design Rationale 10

5.2.4 HwAg1ReadTrim 10

5.2.4.1 Design Rationale 10

5.2.5 HwAg1TrimPrfmdSts 10

5.2.5.1 Design Rationale 10

5.2.6 HwAg1WrTrim 10

5.2.6.1 Design Rationale 10

5.3 Interrupt Functions 10

5.4 Module Internal (Local) Functions 11

5.4.1 Local Function #1 11

5.4.1.1 Design Rationale 11

5.4.2 Local Function #2 11

5.4.2.1 Design Rationale 11

5.4.3 Local Function #3 11

5.4.3.1 Design Rationale 11

6 Known Limitations with Design 12

7 UNIT TEST CONSIDERATION 13

Appendix A Abbreviations and Acronyms 14

Appendix B Glossary 15

Appendix C References 16

Introduction

Purpose

Refer to FDD.

Scope

HwAg1Meas High-Level Description

Refer to FDD

Design details of software module

Graphical representation of HwAg1Meas

Data Flow Diagram

Component level DFD

Refer to FDD

Function level DFD

Refer to FDD

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Local Constants

Constant NameResolutionUnitsValue
MAXWAITININ_MICROSEC_U321MicroSec2U
DATAAVLMAXWAIT_MICROSEC_U321MicroSec300U
COMSTSMAXWAIT_MICROSEC_U321MicroSec5U
PRTCLFLTMASK_CNT_U321Cnt0xFEU
SNSRIDMASK_CNT_U081Cnt0x00FU
MSGSTSMASK_CNT_U081Cnt0x01U
COMSTSMASK_CNT_U321Cnt0x30000000UL
DATAMASK_CNT_U161Cnt0xFFF0U

* Refer to FDD for other constant definitions

Software Component Implementation

Sub-Module Functions

Init: HwAg1MeasInit1

Design Rationale

None

Per: HwAg1MeasPer1

Design Rationale

None

Per: HwAg1MeasPer2

Design Rationale

None

Per: HwAg1MeasPer3

Design Rationale

None

Per: HwAg1MeasPer4

Design Rationale

None

Per: HwAg1MeasPer5

Design Rationale

The implementation brings in the block “HwAg1Final” inside the True Condition of the “finalAbsAg” as the other error condition will just retain the previous value and rolling counter will not change. It saves extra instructions in the implementation to the match the FDD. Final Functionality is still the same.

Server Runnables

HwAg1AutTrim

Design Rationale

None

HwAg1ClrLtch

Design Rationale

None

HwAg1ClrTrim

Design Rationale

None

HwAg1ReadTrim

Design Rationale

None

HwAg1TrimPrfmdSts

Design Rationale

None

HwAg1WrTrim

Design Rationale

None

Interrupt Functions

None

Module Internal (Local) Functions

Local Function #1

Function NameCalcHwAgIdxTypeMinMax
Arguments PassedHwAgStep_HwDeg_T_f32float32-900900
Return ValueIndex_Cnt_T_u08uint16022

Design Rationale

The implementation deviates from the FDD block “Intpn” block. The implementation finds the minimum of absolute values of the difference between HwAg1Step with all the values from the Calibration table and find the index associated with minimum value of the difference in the calibration table.

Local Function #2

Function NameReadRegisterTypeMinMax
Arguments PassedRegisterDummyRead_Cnt_T_u32N/AN/AN/A
Return ValueRegisterDummyRead_Cnt_T_u32N/AN/AN/A

Design Rationale

This function can be used both for read-and-use and for read-and-discard.

Local Function #3

Function NameUpdtLthOnValChngTypeMinMax
Arguments PassedSigQlfrIfNtc_T_enumSigQlfr1SIGQLFR_NORESSIGQLFR_FAILD
Return ValueNAN/AN/AN/A

Design Rationale

This function is split from Per4 to reduce path count and cyclomatic complexity.

Path in Model: CM670A_HwAg1Meas/HwAg1Meas/HwAg1MeasPer4/HwAgRead/Update Latch on value change

Known Limitations with Design

None

UNIT TEST CONSIDERATION

  • Roll Over is intentional for

    • *Rte_Pim_HwAg1Snsr0ComStsErrCntr()

    • *Rte_Pim_HwAg1Snsr0IdErrCntr()

    • *Rte_Pim_HwAg1Snsr0IntSnsrErrCntr()

    • *Rte_Pim_HwAg1Snsr0NoMsgErrCntr()

    • *Rte_Pim_HwAg1Snsr1ComStsErrCntr()

    • *Rte_Pim_HwAg1Snsr1IdErrCntr()

    • *Rte_Pim_HwAg1Snsr1IntSnsrErrCntr()

    • *Rte_Pim_HwAg1Snsr1NoMsgErrCntr()

    • (*Rte_Pim_HwAg1PrevRollCnt).

  • Thus, counter acts in circular

Abbreviations and Acronyms

Abbreviation or AcronymDescription
MDDModule Design Document
DFDData Flow Diagram

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

  • ISO 9000

  • ISO/IEC 12207

  • ISO/IEC 15504

  • Automotive SPICE® Process Reference Model (PRM)

  • Automotive SPICE® Process Assessment Model (PAM)

  • ISO/IEC 15288

  • ISO 26262

  • IEEE Standards

  • SWEBOK

  • PMBOK

  • Existing Nexteer Automotive documentation

References

Ref. #TitleVersion
1AUTOSAR Specification of Memory Mappingv1.3.0 R4.0 Rev 2
2MDD GuidelineEA4 01.00.01
3EA4 Software Naming Conventions01.01.00
4Software Design and Coding Standards2.1
5FDD - CM670A_HwAg1Meas_DesignSee Synergy sub project version

3 - HwAg1Meas_PeerReview


Overview

Summary Sheet
Synergy Project
Davinci Files
Source Code
Polyspace
MDD
Integration Manual


Sheet 1: Summary Sheet
























Rev 1.28-Jun-15

Peer Review Summary Sheet


























Synergy Project Name:


kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attached to the wrong change request. CM670A_HwAg1Meas_Impl
Revision / Baseline:


kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attached to the wrong change request. CM670A_HwAg1Meas_Impl_3.1.0

























Change Owner:


kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by industry standards. Brionna Spencer
Work CR ID:


EA4#12552





























kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:















































































































































































kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a high-level, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:






















































Reviewed:































YesMDD


YesSource Code


YesPolyspace









































YesIntegration Manual


YesDaVinci Files








































































Comments:






























































































General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and DaVinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.





















Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)



















































Quality Check Items:




































Rationale is required for all answers of No










New baseline version name from Summary Sheet follows








Yes
Comments:



naming convention





































Project contains necessary subprojects








Yes
Comments:










































Project contains the correct version of subprojects








Yes
Comments:










































Design subproject is correct version








Yes
Comments:











































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Brionna Spencer


Review Date :

09/13/17
































Lead Peer Reviewer:


Shawn Penning


Approved by Reviewer(s):



Yes































Other Reviewer(s):


Brendon Binder






































































Sheet 3: Davinci Files






















Rev 1.28-Jun-15
Peer Review Meeting Log (Davinci Review)


























Quality Check Items:




































Rationale is required for all answers of No










Only StdDef Port types are used








Yes
Comments:










































For components not using application data types, do all








Yes
Comments:



port interface names end in PortIf and a sequence number





























































Non-program-specific components saved








Yes
Comments:




in Autosar 4.0.3 format




































*Cfg.arxml.TT: Verfied Davinci Configurator imported the








N/A
Comments:




change correctly










Local ConfigParams are #defined in either













HwAg1Meas.c or HwAg1Meas_Cfg.h
























*Cfg.h.TT: Verfied Davinci Configurator generates








N/A
Comments:










the configuration header(s) file correctly




kzshz2: Either a generic sandbox or a baselined integration project can be used to verify








































All changed files have been compared against previous








Yes
Comments:




versions (If available)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.


































Automated validation check is performed








Yes
Comments:

























































Naming conventions followed. All names should








Yes
Comments:










match DataDict.m










Numbers removed from server runnable port interface













names for reusability (eg HwAg1WrTrim -> HwAgWrTrim).













The server runnable names, however, match DataDic.m.
























Sender/Receiver port properties match DataDict.m








Yes
Comments:










file (use .m file helper tool)













































Calibration port properties match DataDict.m








Yes
Comments:










file (use .m file helper tool)













































Components using application data types:























Sender/Receiver port initialization values match







N/A
Comments:










DataDict.m file














































Calibration port initialization values match







N/A
Comments:










DataDict.m file













































Components not using application data types:























Sender/Receiver port initialization values match







Yes
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Calibration port initialization values match







Yes
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Mapping set and all unused items have been







Yes
Comments:










removed













































All sender/receiver port read/writes using direct








Yes
Comments:










read/writes(List justification if not)













































Runnable calling frequencies match FDD








Yes
Comments:

































DataDict.m display variables: created as








Yes
Comments:









PerInstanceMemory. Matches the FDD





































Component is correct component type








Yes
Comments:











































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Brionna Spencer
Review Date :

09/13/17
Component Type :


SA


























Lead Peer Reviewer:


Shawn Penning
Approved by Reviewer(s):



Yes

































Other Reviewer(s):


Brendon Binder






































































Sheet 4: Source Code






















Rev 1.28-Jun-15
Peer Review Meeting Log (Source Code Review)

























Source File Name:


HwAg1Meas.c

Source File Revision:


15
Header File Name:


N/A

Header File Revision:


kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this. N/A

























MDD Name:

HwAg1Meas_MDD.docx

Revision:
6

























FDD/SCIR/DSR/FDR/CM Name:




CM670A_HwAg1Meas_Design

Revision:
3.1.0


























Quality Check Items:



































Rationale is required for all answers of No









Working EA4 Software Naming Convention followed:















































for variable names







N/A
Comments:

















































for constant names







N/A
Comments:

















































for function names







N/A
Comments:

















































for other names (component, memory







N/A
Comments:










mapping handles, typedefs, etc.)




































All paths assign a value to outputs, ensuring








N/A
Comments:









all outputs are initialized prior to being written





































Requirements Traceability tags in code match the requirements traceability in the FDD








N/A
Comments:









requirements traceability in the FDD











Traceability tags were removed.
























All variables are declared at the function level.








N/A
Comments:
























Synergy version matches change history





kzshz2: Intended Use: Indicate that the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occasions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.


Yes
Comments:



and Version Control version in file comment block





































Change log contains detailed description of changes








Yes
Comments:



and Work CR number





































Code accurately implements FDD (Document or Model)








N/A
Comments:










































Verified no Compiler Errors or Warnings




KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandbox project should be used; QAC can find compiler errors but not warnings.



Yes
Comments:
















































Component.h is included








N/A
Comments:






















No Component.h to include.
























All other includes are actually needed. (System includes








Yes
Comments:









only allowed in Nexteer library components)











v800_ghs.h is a necessary system include for compiler













intrinsics (e.g. SYNCM and SYNCP instructions).
























Software Design and Coding Standards followed:











Version: 2.1

























Code comments are clear, correct, and adequate







Yes
Comments:










and have been updated for the change: [N40] and













all other rules in the same section as rule [N40],






















plus [N75], [N12], [N23], [N33], [N37], [N38],






















[N48], [N54], [N77], [N79], [N72]














































Source file (.c and .h) comment blocks are per







Yes
Comments:










standards and contain correct information: [N41], [N42]





































Function comment blocks are per standards and







N/A
Comments:










contain correct information: [N43]





































Code formatting (indentation, placement of







Yes
Comments:










braces, etc.) is per standards: [N5], [N55], [N56],













[N57], [N58], [N59]














































Embedded constants used per standards; no







N/A
Comments:










"magic numbers": [N12]





































Memory mapping for non-RTE code







N/A
Comments:










is per standard





































All execution-order-dependent code can be







N/A
Comments:










recognized by the compiler: [N80]





































All loops have termination conditions that ensure







N/A
Comments:










finite loop iterations: [N63]





































All divides protect against divide by zero







N/A
Comments:










if needed: [N65]





































All integer division and modulus operations







N/A
Comments:










handle negative numbers correctly: [N76]





































All typecasting and fixed point arithmetic,







N/A
Comments:










including all use of fixed point macros and













timer functions, is correct and has no possibility






















of unintended overflow or underflow: [N66]














































All float-to-unsigned conversions ensure the.







N/A
Comments:










float value is non-negative: [N67]





































All conversions between signed and unsigned







N/A
Comments:










types handle msb==1 as intended: [N78]





































All pointer dereferencing protects against







N/A
Comments:










null pointer if needed: [N70]





































Component outputs are limited to the legal range







N/A
Comments:










defined in the FDD DataDict.m file : [N53]





































All code is mapped with FDD (all FDD







N/A
Comments:










subfunctions and/or model blocks identified













with code comments; all code corresponds to






















some FDD subfunction and/or model block): [N40]













































Review did not identify violations of other








Yes
Comments:









coding standard rules





































Anomaly or Design Work CR created








N/A
Comments: List Anomaly or CR numbers









for any FDD corrections needed































































General Notes / Comments:

















































































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Brionna Spencer


Review Date :

08/23/17
































Lead Peer Reviewer:


Shawn Penning
Approved by Reviewer(s):



Yes

































Other Reviewer(s):










































































Sheet 5: Polyspace






















Rev 1.28-Jun-15
Peer Review Meeting Log (QAC/Polyspace Review)


























Source File Name:


HwAg1Meas.cSource File Revision:


15

Source File Name:















Source File Revision:





Source File Name:















Source File Revision:






























EA4 Static Analysis Compliance Guideline version:







01.03.00







Poly Space version:


Windows User: e.g. 2013b 2013b
Polyspace sub project version:




Windows User: e.g. TL108a_PolyspaceSuprt_1.0.0 N/A


























Quality Check Items:




































Rationale is required for all answers of No



































Contract Folder's header files are appropriate and





kzshz2: Intended Use: Identify that the contract folder contains only the information required for this component. All other variables, constants, function prototypes, etc. should be removed. Rationale: This will help avoid unit testers having to considers object not used. It will also avoid having other files required for QAC.


Yes
Comments:




function prototypes match the latest component version







































100% Compliance to the EA4 Static AnalysisYes
Comments:





Compliance Guideline





























Are previously added justification and deviation








Yes
Comments:





comments still appropriate






































Do all MISRA deviation comments use approved








Yes
Comments:





deviation tags






































Cyclomatic complexity and Static path count OK






Creager, Kathleen: use Browse Function Metrics, STCYC and STPTH

Yes
Comments:





for all functions in the component per Design














and Coding Standards rule [N47]

































































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Brionna Spencer


Review Date :

08/23/17
































Lead Peer Reviewer:


Shawn Penning
Approved by Reviewer(s):



Yes

































Other Reviewer(s):










































































Sheet 6: MDD






















Rev 1.28-Jun-15
Peer Review Meeting Log (MDD Review)


























MDD Name:

HwAg1Meas_MDD.docx
MDD Revision:

6


























Source File Name:


HwAg1Meas.cSource File Revision:


15

Source File Name:















Source File Revision:





Source File Name:















Source File Revision:






























Quality Check Items:




































Rationale is required for all answers of No










Synergy version matches document








Yes
Comments:













































Change log contains detailed description of changes








Yes
Comments:













































Changes Highlighted (for Unit Tester)








Yes
Comments:













































Diagrams have been included per MDD Guideline








Yes
Comments:











and reviewed






































All Design Exceptions and Limitations are listed








N/A
Comments:



















































Design rationale given for all global








N/A
Comments:











data not communicated through RTE ports, per














Design and Coding Standards rules [N9] and [N10].















































All implementation details that differ from the FDD are








N/A
Comments:











noted and explained in Design Rationale






































All Unit Test Considerations have been described








N/A
Comments:



















































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Brionna Spencer


Review Date :

08/23/17
































Lead Peer Reviewer:


Shawn Penning
Approved by Reviewer(s):



Yes

































Other Reviewer(s):










































































Sheet 7: Integration Manual






















Rev 1.28-Jun-15
Peer Review Meeting Log (Integration Manual Review)


























Integration Manual Name:



kzshz2: Intended Use: Identify which file is being reviewed Rationale: Required for traceability. It will help to ensure this sheet is not attached to the wrong design review form. HwAg1Meas_IntegrationManual.doc

Integration Manual Revision:



kzshz2: Intended Use: Identify which version of the integration manual has been reviewed. Rationale: Required for traceability between the MDD and review. Auditors will likely require this. 6





























Quality Check Items:




































Rationale is required for all answers of No










Synergy version matches header








Yes
Comments:










































Latest template used








Yes
Comments:










































Change log contains detailed description of changes








Yes
Comments:










































Changes Highlighted (for Integrator)








Yes
Comments:











































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Brionna Spencer


Review Date :

08/23/17
































Lead Peer Reviewer:


Shawn Penning
Approved by Reviewer(s):



Yes

































Other Reviewer(s):