This is the multi-page printable view of this section. Click here to print.
Component Implementation
1 - 1. Overview
Standards
Nexteer Manufacturing Services adhere to the ISO-14229 standard for Automotive Diagnostic Services as well as ISO-15765 (Transport Layer) standard for sending data packets over a CAN-Bus.
Connection Details
Request ID (to ECU): 0x712
Response ID (from ECU): 0x710
Byte Ordering
All data is transfered in Motorola format (most significant byte first - also known as big-endian).
NvM Values
For EA4, an ignition cycle or ECU reset is required to commit any and all stored values from Volatile Memory (RAM) to Non-Volatile Memory (NvM). When an auto trim, clear trim, write trim, or similar service is used to modify any value stored in NvM a flag is set within the controller indicating that the value is to be written to NvM on the next shutdown. The power cycle can be provided by means of a cycling of physical ignition (EPS ENA) or by issuing an ECU reset (11 60) service. The reception of a positive response from the ECU reset service indicates completion of NvM writes at which time it is safe to remove battery.
2 - 2. General Negative Responses
This is a comprehensive list of all negative response codes as defined by the ISO-14229 specification. A value of “Yes” in the columns below indicates that the NRC is applicable to ALL services of the corresponding type regardless of whether or not it is expressly listed in the “Unique Negative Responses” section of a specific service.
| NRC | Description | 0x22 | 0x2E | 0x2F | 0x31 |
|---|---|---|---|---|---|
| 0x11 | General service not supported | Yes | Yes | Yes | Yes |
| 0x12 | Sub-function nut supported | No | No | Yes | Yes |
| 0x13 | Invalid length | Yes | Yes | Yes | Yes |
| 0x22 | Conditions not correct | No | No | No | No |
| 0x24 | Request sequence error | No | No | No | No |
| 0x31 | Request out of range | No | No | No | No |
| 0x33 | Security access denied | No | No | No | No |
| 0x35 | Invalid Key | No | No | No | No |
| 0x36 | Exceeded number of attempts | No | No | No | No |
| 0x37 | Time delay not expired | No | No | No | No |
| 0x78 | Request received, response pending | No | No | No | No |
| 0x7E | Sub-function not supported in current session | No | No | No | No |
| 0x7F | Service not supported in current session | Yes | Yes | Yes | Yes |
| 0x81 | Engine RPM too high | No | No | No | No |
| 0x82 | Engine RPM too low | No | No | No | No |
| 0x83 | Engine running | No | No | No | No |
| 0x84 | Engine not running | No | No | No | No |
| 0x85 | Engine run time too low | No | No | No | No |
| 0x86 | Temperature too high | No | No | No | No |
| 0x87 | Temperature too low | No | No | No | No |
| 0x88 | Vehicle speed too high | No | No | No | No |
| 0x89 | Vehicle speed too low | No | No | No | No |
| 0x8A | Throttle too high | No | No | No | No |
| 0x8B | Throttle too low | No | No | No | No |
| 0x8C | Transmission not in neutral | No | No | No | No |
| 0x8D | Transmission not in gear | No | No | No | No |
| 0x8F | Brake not applied | No | No | No | No |
| 0x90 | Transmission not in park | No | No | No | No |
| 0x92 | Voltage too high | No | No | No | No |
| 0x93 | Voltage too low | No | No | No | No |
3 - 3. Document Conventions
Terms
- NvM
- Non-Volatile Memory
Hexadecimal Values
Hexadecimal values in this document will always be prefixed with “0x”. Hexadecimal format values in transaction snippets will be represented by a pair of x’s, for example:
xx
ASCII Values
ASCII text strings in transaction snippets will be represented by a pair of a’s, for example:
aa
Bitfields (Binary Values)
Binary values in this document will always be prefixed with “0b”. Binary (or bitfield) values in transaction snippets will be represented by single ‘b’ characters, for example:
b
Binary values will always be in groups that are multiples of 8 bits. In cases where some bits are unused, the unused bits will be marked as “Reserved”, for example.
bbbb b b b b
| | | | |
| | | | '-- Bit 0
| | | '-- Bit 1
| | '-- Bit 2
| '-- Bit 3
'-- Reserved
Reserved bits should be passed as zeros on writes and reads.
Grouped Bytes
If bytes are grouped (for example, 4 bytes used to represent a single 32-bit value) the transaction snippet will show the bytes as being connected using the ‘o’ character, for example:
xx xx xx xx
| | | |
'--o--o--o-- Represents a 32-bit value
Grouped values are always in Motorola format (i.e. most-significant byte first).
Floating Point Numbers
Floating point values are represented in transaction snippets as four ‘f’ character pairs, for example:
ff ff ff ff
| | | |
'--o--o--o-- Single-precision floating point value
The four pairs represent the four bytes of data transmitted over CAN that make up the single precision float value. The four pairs will always be grouped using the conventions outlined in section 2.3 above.
Grouped values are always in Motorola format (i.e. most-significant byte first).
Units
Units in transaction snippets will be called out inside a pair of square braces, for example:
[MotNwtMtr]
If no units are specified, then the signal’s units are assumed to be Counts.
Ranges
Ranges for signals in transaction snippets will be called out inside a pair of parentheses, for example:
(minimum, maximum)
If no range is specified, then the range for the signal’s value is assumed to be bounded by the signals type.
| Type | Minimum | Maximum |
|---|---|---|
| uint8 | 0 | 255 |
| uint16 | 0 | 65535 |
| uint32 | 0 | 4294967295 |
| sint8 | -128 | 127 |
| sint16 | -32768 | 32767 |
| sint32 | -2147483648 | 2147483647 |
| float32 | error* | error* |
- *The float32 type does not have a specific minimum nor maximum value and thus each signal is required to provide a valid range specific to each.
Scale/Offset
Scale values for signals in transaction snippets will be called out inside a pair of curly braces, for example:
{*1/(2^16)}
The above scale would imply multiplying the raw value from the CAN bus by 1/65536 to achieve the scaled representation. An example including an offset would look like this:
{*1/(2^4) +11.0125}
In this second example, the raw value from the bus shall have a scale of 1/16 applied and then an offset of +11.0125 added. Offsets may be positive or negative as indicated by the preceding sign.
4 - CmnMfgSrv_PeerReviewChecklist
Overview
Summary SheetSynergy Project
Davinci Files
Source Code
PolySpace
Sheet 1: Summary Sheet
Sheet 2: Synergy Project
Sheet 3: Davinci Files
Sheet 4: Source Code
| Rev 1.2 | 8-Jun-15 | |||||||||||||||||||||||
| Peer Review Meeting Log (Source Code Review) | ||||||||||||||||||||||||
| Source File Name: | CmnMfgSrv.c | Source File Revision: | 27 | |||||||||||||||||||||
| SrvFD62.c | 1 | |||||||||||||||||||||||
| SrvFD63.c | 1 | |||||||||||||||||||||||
| SrvFD73.c | 1 | |||||||||||||||||||||||
| SrvFDC1.c | 1 | |||||||||||||||||||||||
| SrvFDC2.c | 1 | |||||||||||||||||||||||
| SrvFDC9.c | 1 | |||||||||||||||||||||||
| SrvFDCA.c | 1 | |||||||||||||||||||||||
| SrvFDF4.c | 4 | |||||||||||||||||||||||
| SrvFDF5.c | 4 | |||||||||||||||||||||||
| SrvFDF6.c | 1 | |||||||||||||||||||||||
| SrvFDF7.c | 1 | |||||||||||||||||||||||
| Header File Name: | Header File Revision: | |||||||||||||||||||||||
| MDD Name: | N/A | Revision: | N/A | |||||||||||||||||||||
| FDD/SCIR/DSR/FDR/CM Name: | N/A | Revision: | N/A | |||||||||||||||||||||
| Quality Check Items: | ||||||||||||||||||||||||
| Rationale is required for all answers of No | ||||||||||||||||||||||||
| Working EA4 Software Naming Convention followed: | ||||||||||||||||||||||||
| for variable names | Yes | Comments: | ||||||||||||||||||||||
| for constant names | Yes | Comments: | ||||||||||||||||||||||
| for function names | Yes | Comments: | ||||||||||||||||||||||
| for other names (component, memory | Yes | Comments: | ||||||||||||||||||||||
| mapping handles, typedefs, etc.) | ||||||||||||||||||||||||
| All paths assign a value to outputs, ensuring | Yes | Comments: | ||||||||||||||||||||||
| all outputs are initialized prior to being written | ||||||||||||||||||||||||
| Requirements Tracability tags in code match the requirements tracability in the FDD | N/A | Comments: | Not applicable for EA4 | |||||||||||||||||||||
| requirements tracability in the FDD | ||||||||||||||||||||||||
| All variables are declared at the function level. | Yes | Comments: | ||||||||||||||||||||||
| Synergy version matches change history | Yes | Comments: | ||||||||||||||||||||||
| and Version Control version in file comment block | ||||||||||||||||||||||||
| Change log contains detailed description of changes | Yes | Comments: | ||||||||||||||||||||||
| and Work CR number | ||||||||||||||||||||||||
| Code accurately implements FDD (Document or Model) | N/A | Comments: | No design at this time | |||||||||||||||||||||
| Verified no Compiler Errors or Warnings | Yes | Comments: | CmnMfgSrv.c does not compile due to errors with definitions in contract headers but does compile without warnings in T1xx project | |||||||||||||||||||||
| Component.h is included | Yes | Comments: | ||||||||||||||||||||||
| All other includes are actually needed. (System includes | Yes | Comments: | ||||||||||||||||||||||
| only allowed in Nexteer library components) | ||||||||||||||||||||||||
| Software Design and Coding Standards followed: | Version: 2.1 | |||||||||||||||||||||||
| Code comments are clear, correct, and adequate | Yes | Comments: | ||||||||||||||||||||||
| and have been updated for the change: [N40] and | ||||||||||||||||||||||||
| all other rules in the same section as rule [N40], | ||||||||||||||||||||||||
| plus [N75], [N12], [N23], [N33], [N37], [N38], | ||||||||||||||||||||||||
| [N48], [N54], [N77], [N79], [N72] | ||||||||||||||||||||||||
| Source file (.c and .h) comment blocks are per | Yes | Comments: | ||||||||||||||||||||||
| standards and contain correct information: [N41], [N42] | ||||||||||||||||||||||||
| Function comment blocks are per standards and | Yes | Comments: | Services intentionally deviate from standard | |||||||||||||||||||||
| contain correct information: [N43] | to provide additional information relevant to each service. | |||||||||||||||||||||||
| Code formatting (indentation, placement of | Yes | Comments: | ||||||||||||||||||||||
| braces, etc.) is per standards: [N5], [N55], [N56], | ||||||||||||||||||||||||
| [N57], [N58], [N59] | ||||||||||||||||||||||||
| Embedded constants used per standards; no | Yes | Comments: | ||||||||||||||||||||||
| "magic numbers": [N12] | ||||||||||||||||||||||||
| Memory mapping for non-RTE code | No | Comments: | To be added as part of EA4#12632 | |||||||||||||||||||||
| is per standard | ||||||||||||||||||||||||
| All execution-order-dependent code can be | Yes | Comments: | ||||||||||||||||||||||
| recognized by the compiler: [N80] | ||||||||||||||||||||||||
| All loops have termination conditions that ensure | Yes | Comments: | ||||||||||||||||||||||
| finite loop iterations: [N63] | ||||||||||||||||||||||||
| All divides protect against divide by zero | N/A | Comments: | No division | |||||||||||||||||||||
| if needed: [N65] | ||||||||||||||||||||||||
| All integer division and modulus operations | N/A | Comments: | No division | |||||||||||||||||||||
| handle negative numbers correctly: [N76] | ||||||||||||||||||||||||
| All typecasting and fixed point arithmetic, | Yes | Comments: | ||||||||||||||||||||||
| including all use of fixed point macros and | ||||||||||||||||||||||||
| timer functions, is correct and has no possibility | ||||||||||||||||||||||||
| of unintended overflow or underflow: [N66] | ||||||||||||||||||||||||
| All float-to-unsiged conversions ensure the. | N/A | Comments: | ||||||||||||||||||||||
| float value is non-negative: [N67] | ||||||||||||||||||||||||
| All conversions between signed and unsigned | Yes | Comments: | ||||||||||||||||||||||
| types handle msb==1 as intended: [N78] | ||||||||||||||||||||||||
| All pointer dereferencing protects against | N/A | Comments: | ||||||||||||||||||||||
| null pointer if needed: [N70] | ||||||||||||||||||||||||
| Component outputs are limited to the legal range | Yes | Comments: | M-file is not official, but outputs are limited | |||||||||||||||||||||
| defined in the FDD DataDict.m file : [N53] | ||||||||||||||||||||||||
| All code is mapped with FDD (all FDD | N/A | Comments: | No FDD at this time | |||||||||||||||||||||
| subfunctions and/or model blocks identified | ||||||||||||||||||||||||
| with code comments; all code corresponds to | ||||||||||||||||||||||||
| some FDD subfunction and/or model block): [N40] | ||||||||||||||||||||||||
| Review did not identify violations of other | Yes | Comments: | ||||||||||||||||||||||
| coding standard rules | ||||||||||||||||||||||||
| Anomaly or Design Work CR created | N/A | Comments: | ||||||||||||||||||||||
| for any FDD corrections needed | ||||||||||||||||||||||||
| General Notes / Comments: | ||||||||||||||||||||||||
| Change Owner: | Jared Julien | Review Date : | 11/21/17 | |||||||||||||||||||||
| Lead Peer Reviewer: | Brendon Binder | Approved by Reviewer(s): | Yes | |||||||||||||||||||||
| Other Reviewer(s): | ||||||||||||||||||||||||