1 - CurrMeasCorrln_ Review


Overview

Summary Sheet
Synergy Project
Davinci Files
MDD


Sheet 1: Summary Sheet
























Rev 1.28-Jun-15

Peer Review Summary Sheet


























Synergy Project Name:


kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. ES209A_CurrMeasCorrln_Impl
Revision / Baseline:


kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. 2.5.0

























Change Owner:


kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Nick Saxton
Work CR ID:


EA4#7137





























kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:















































































































































































kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:






















































Reviewed:































YesMDD



Source Code



PolySpace









































Integration Manual


YesDavinci Files








































































Comments:

Added FltInj port to Davinci



























































































General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.





















Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)



















































Quality Check Items:




































Rationale is required for all answers of No










New baseline version name from Summary Sheet follows








Yes
Comments:



naming convention





































Project contains necessary subprojects








Yes
Comments:










































Project contains the correct version of subprojects








Yes
Comments:










































Design subproject is correct version








Yes
Comments:











































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Nick Saxton


Review Date :

09/06/16
































Lead Peer Reviewer:


Krishna Anne


Approved by Reviewer(s):



Yes































Other Reviewer(s):










































































Sheet 3: Davinci Files






















Rev 1.28-Jun-15
Peer Review Meeting Log (Davinci Review)


























Quality Check Items:




































Rationale is required for all answers of No










Only StdDef Port types are used








Yes
Comments:










































For components not using application data types, do all








Yes
Comments:



port interface names end in PortIf and a sequence number





























































Non-program-specific components saved








Yes
Comments:




in Autosar 4.0.3 format




































*Cfg.arxml.TT: Verfied Davinci Configurator imported the








N/A
Comments:




change correctly




































*Cfg.h.TT: Verfied Davinci Configurator generates








N/A
Comments:










the configuration header(s) file correctly
kzshz2: Either a generic sandbox or a baselined integration project can be used to verify



























kzshz2: Either a generic sandbox or a baselined integration project can be used to verify
















All changed files have been compared against previous








Yes
Comments:




versions (If available)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.


































Automated validation check is performed








Yes
Comments:

























































Naming conventions followed. All names should








Yes
Comments:










match DataDict.m













































Sender/Receiver port properties match DataDict.m








N/A
Comments:










file (use .m file helper tool)













































Calibration port properties match DataDict.m








N/A
Comments:










file (use .m file helper tool)













































Components using application data types:























Sender/Receiver port initialization values match







N/A
Comments:










DataDict.m file














































Calibration port initialization values match







N/A
Comments:










DataDict.m file













































Components not using application data types:























Sender/Receiver port initialization values match







N/A
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Calibration port initialization values match







N/A
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Mapping set and all unused items have been







Yes
Comments:










removed













































All sender/receiver port read/writes using direct








N/A
Comments:










read/writes(List justification if not)













































Runnable calling frequencies match FDD








Yes
Comments:

































DataDict.m display variables: created as








N/A
Comments:









PerInstanceMemory. Matches the FDD





































Component is correct component type








Yes
Comments:











































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Nick Saxton
Review Date :

09/06/16
Component Type :


Application



























Lead Peer Reviewer:


Krishna Anne
Approved by Reviewer(s):



Yes

































Other Reviewer(s):










































































Sheet 4: MDD






















Rev 1.28-Jun-15
Peer Review Meeting Log (MDD Review)


























MDD Name:

CurrMeasCorrln_MDD.doc
MDD Revision:

4


























Source File Name:


CurrMeasCorrln.cSource File Revision:


7

Source File Name:















Source File Revision:





Source File Name:















Source File Revision:






























Quality Check Items:




































Rationale is required for all answers of No










Synergy version matches document








Yes
Comments:













































Change log contains detailed description of changes








Yes
Comments:













































Changes Highlighted (for Unit Tester)








Yes
Comments:













































Diagrams have been included per MDD Guideline








Yes
Comments:











and reviewed






































All Design Exceptions and Limitations are listed








N/A
Comments:



















































Design rationale given for all global








N/A
Comments:











data not communicated through RTE ports, per














Design and Coding Standards rules [N9] and [N10].















































All implementation details that differ from the FDD are








N/A
Comments:











noted and explained in Design Rationale






































All Unit Test Considerations have been described








N/A
Comments:



















































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Nick Saxton


Review Date :

09/06/16
































Lead Peer Reviewer:


Krishna Anne


Approved by Reviewer(s):



Yes































Other Reviewer(s):









































































2 - CurrMeasCorrln_IntegrationManual

Integration Manual

For

CURRENT MEASUREMENT CORRELATION

VERSION: 2.0

DATE: 27-Jun-2016

Prepared By:

Software Group,

Nexteer Automotive,

Saginaw, MI, USA


Location:
The official version of this document is stored in the Nexteer Configuration Management System.

Revision History

Sl. No.DescriptionAuthorVersionDate
1Initial versionSelva Sengottaiyan1.009-Apr-2015
2Added FltInj point for an outputKrishna Anne2.027-Jun-16


Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 Non RTE NvM Blocks 10

7.4 RTE NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

AbbreviationDescription
DFDDesign functional diagram
MDDModule design Document
<ADD more to the table if applicable>

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.TitleVersion
<1>FDD - ES209A Current Measurement Correlation<.2.7.0>

Dependencies

SWCs

ModuleRequired Feature
NoneN/A

Note : Referencing the external components should be avoided in most cases. Only in unavoidable circumstance external components should be referred. Developer should track the references.

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

ModulesNotes
CurrMeasCorrlnFLTINJENA should be set to STD_ON as required

Configuration Files to be provided by Integration Project

None

Da Vinci Parameter Configuration Changes

ParameterNotesSWC
N/A

DaVinci Interrupt Configuration Changes

ISR NameVIM #Priority DependencyNotes
N/A

Manual Configuration Changes

ConstantNotesSWC
N/A

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file

Required Global Data Outputs

Refer DataDict.m file

Specific Include Path present

No

Runnable Scheduling

This section specifies the required runnable scheduling.

InitScheduling RequirementsTrigger
None
RunnableScheduling RequirementsTrigger
CurrMeasCorrlnPer1NoneRTE 2ms Task

.

Memory Map REQUIREMENTS

Mapping

Memory SectionContentsNotes
None

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

FeatureRAMROM
None

Table 1: ARM Cortex R4 Memory Usage

Non RTE NvM Blocks

Block Name
None

Note : Size of the NVM block if configured in developer

RTE NvM Blocks

Block Name
None

Note : Size of the NVM block if configured in developer

Compiler Settings

Preprocessor MACRO

None

Optimization Settings

None

Appendix

None

3 - CurrMeasCorrln_MDD

Module Design Document

For

Current Measurement Correlation

September 6, 2016

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

Nick Saxton,

Nexteer Automotive,

Saginaw, MI, USAChange History

DescriptionAuthorVersionDate
Initial VersionSelva1.009- Apr-2015
Updated for v2.1.0 of DesignSelva2.021 –Sep 2015
Updated graphical representationNick S.3.013-Apr-2016
Updated graphical representation with added fault injection portNick S.4.006-Sep-2016

Table of Contents

1 Introduction 4

1.1 Purpose 4

1.2 Scope 4

2 Current Measurement Correlation & High-Level Description 5

3 Design details of software module 6

3.1 Graphical representation of Current Measurement Correlation 6

3.2 Data Flow Diagram 6

3.2.1 Component level DFD 6

3.2.2 Function level DFD 6

4 Constant Data Dictionary 7

4.1 Program (fixed) Constants 7

4.1.1 Embedded Constants 7

4.1.1.1 Local 7

5 Software Component Implementation 8

5.1 Sub-Module Functions 8

5.1.1 Initialization Functions 8

5.1.1.1 INIT 8

5.1.1.2 Design Rationale 8

5.1.1.3 Store Module Inputs to Local copies 8

5.1.1.4 (Processing of function)……… 8

5.1.1.5 Store Local copy of outputs into Module Outputs 8

5.1.2 PERIODIC FUNCTIONS 8

5.1.2.1 Per: CurrMeasCorrlnPer1 8

5.1.2.2 Design Rationale 8

5.1.2.3 Store Module Inputs to Local copies 8

5.1.2.4 (Processing of function)……… 8

5.1.2.5 Store Local copy of outputs into Module Outputs 8

5.2 Server Runables 8

5.3 Interrupt Functions 8

5.4 Module Internal (Local) Functions 9

5.5 Local Function/Macro Definitions 9

5.5.1 Local Function #1 SigAvlCheck 9

5.5.1.1 Description 9

5.5.2 Local Function #1 CurrMeasCorrlnChk 9

5.5.2.1 Description 9

5.6 GLOBAL Function/Macro Definitions 9

6 Known Limitations with Design 11

7 UNIT TEST CONSIDERATION 12

Appendix A Abbreviations and Acronyms 13

Appendix B Glossary 14

Appendix C References 16

Introduction

Purpose

None

Scope

  • None

Current Measurement Correlation & High-Level Description

Current Measurement Correlation determines number of independent current measurement channels available and also correlation status of those channels.

Refer the Design for high level Description

Design details of software module

None

Graphical representation of Current Measurement Correlation

Data Flow Diagram

Component level DFD

None

Function level DFD

None

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Local

Constant NameUnitsValue
CORRLNSTSABC_CNT_U08Cnt0x07
CORRLNSTSDEF_CNT_U08Cnt0x38
MAXVALSIGSTALL_CNT_U08Cnt255
CURRMOTSUMLOLIM_AMP_F32Amp0.0
CURRMOTSUMHILIM_AMP_F32Amp600.0

Software Component Implementation

Sub-Module Functions

Initialization Functions

INIT

None

Design Rationale

None

Store Module Inputs to Local copies

None

(Processing of function)………

None

Store Local copy of outputs into Module Outputs

None

PERIODIC FUNCTIONS

(Note: For multiple periodic functions, insert new headers at the “Header 2” level – subset of “ Periodic Functions” and follow the same sub-section design shown below). If none required, place the text “None”)>

Per: CurrMeasCorrlnPer1

Design Rationale

Refer to FDD

Store Module Inputs to Local copies

Refer to FDD

(Processing of function)………

Refer to FDD

Store Local copy of outputs into Module Outputs

Refer to FDD

Server Runables

None

Interrupt Functions

None

Module Internal (Local) Functions

Local Function/Macro Definitions

Local Function #1 SigAvlCheck

Function NameSigAvlCheckTypeMinMax
Arguments PassedCurrMeasSigQlfr_T_enumSigQlfr1SIGQLFR_NORESSIGQLFR_FAILD
CurrMeasSigRollgCntr_Cnt_T_u08uint80255
PrevCurrMeasSigRollgCntr_Cnt_T_u08uint80255
CurrMeasSigStall_Cnt_T_u08uint80255
Return ValueSignalAvailable_Cnt_T_loglbooleanFALSETRUE

Description

Refer FDD.

Local Function #1 CurrMeasCorrlnChk

Function NameCurrMeasCorrlnChkTypeMinMax
Arguments PassedMotCurrCorrdSig1_Amp_T_f32float32-200200
MotCurrCorrdSig2_Amp_T_f32float32-200200
MotCurrCorrdSig3_Amp_T_f32float32-200200
CurrMeasCorrlnNtcFailStepuint16065535
CurrMeasCorrlnNtcPassStepuint16065535
NtcNr_T_enumNtcNr10x4D0x4E
*CurrMeasLongTermCorrlnStsVldSig1_Cnt_T_loglbooleanFALSETRUE
*CurrMotSum_Amp_T_f32float320.0600.0
Return ValueCurrMeasImdtCorrlnStsVldSig1_Cnt_T_loglbooleanFALSETRUE

Description

Refer FDD.

In FDD, there are two sub functions CorrlnChkABC and CorrlnChkDEF but the both functions are functionally same other than the NTCs. Hence the software merges these functions in single function with NTC as parameter.

*CurrMeasLongTermCorrlnStsVldSig1_Cnt_T_logl and *CurrMotSum_Amp_T_f32 are outputs of this function.

GLOBAL Function/Macro Definitions

None

Known Limitations with Design

None

UNIT TEST CONSIDERATION

None

Abbreviations and Acronyms

Abbreviation or AcronymDescription

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

  • ISO 9000

  • ISO/IEC 12207

  • ISO/IEC 15504

  • Automotive SPICE® Process Reference Model (PRM)

  • Automotive SPICE® Process Assessment Model (PAM)

  • ISO/IEC 15288

  • ISO 26262

  • IEEE Standards

  • SWEBOK

  • PMBOK

  • Existing Nexteer Automotive documentation

TermDefinitionSource
MDDModule Design Document
DFDData Flow Diagram

References

Ref. #TitleVersion
1AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)v1.3.0 R4.0 Rev 2
2MDD GuidelineEA4 01.00.00
3Software Naming Conventions.doc1.0
4Software Design and Coding Standards.doc2.1
5FDD - ES209A Current Measurement CorrelationSee synergy subversion

4 - requirements

FDDIDSourceFunctionLine(s)StatusComment
.SwFileName.SwFuncName.SwLines.SwStatus.SwComment
ES209A216CurrMeasCorrln.cCurrMeasCorrlnPer1919I
ES209A217CurrMeasCorrln.cCurrMeasCorrlnPer1890-903I
ES209A214CurrMeasCorrln.cCurrMeasCorrlnPer1812I
ES209A215CurrMeasCorrln.cCurrMeasCorrlnPer1811I
ES209A212CurrMeasCorrln.cCurrMeasCorrlnPer1814I
ES209A213CurrMeasCorrln.cCurrMeasCorrlnPer1813I
ES209A211CurrMeasCorrln.cCurrMeasCorrlnPer1873-878I
ES209A228CurrMeasCorrln.cCurrMeasCorrlnPer1889-902I
ES209A219CurrMeasCorrln.cCurrMeasCorrlnPer1830-834I
ES209A259CurrMeasCorrln.cCurrMeasCorrlnChk1017I
ES209A135CurrMeasCorrln.cCurrMeasCorrlnPer1825-829I
ES209A277CurrMeasCorrln.cCurrMeasCorrlnPer1921I
ES209A252CurrMeasCorrln.cCurrMeasCorrlnChk1018,1023I
ES209A236CurrMeasCorrln.cCurrMeasCorrlnChk1018,1023I
ES209A230CurrMeasCorrln.cCurrMeasCorrlnPer1888-904I
ES209A257CurrMeasCorrln.cCurrMeasCorrlnPer1849-858I
ES209A276CurrMeasCorrln.cCurrMeasCorrlnPer1920I
ES209A181CurrMeasCorrln.cCurrMeasCorrlnChk1022I
ES209A280CurrMeasCorrln.cCurrMeasCorrlnPer1907-911I
ES209A205CurrMeasCorrln.cCurrMeasCorrlnPer1918I
ES209A263CurrMeasCorrln.cCurrMeasCorrlnPer1837-846I
ES209A244CurrMeasCorrln.cCurrMeasCorrlnPer1837-846I
ES209A261CurrMeasCorrln.cCurrMeasCorrlnChk1022I
ES209A229CurrMeasCorrln.cCurrMeasCorrlnPer1887-905I
ES209A265CurrMeasCorrln.cCurrMeasCorrlnPer1837-846,849-858I
ES209A264CurrMeasCorrln.cCurrMeasCorrlnPer1849-858I
ES209A102CurrMeasCorrln.cCurrMeasCorrlnPer1807I
ES209A103CurrMeasCorrln.cCurrMeasCorrlnPer1806I
ES209A100CurrMeasCorrln.cCurrMeasCorrlnPer1809I
ES209A101CurrMeasCorrln.cCurrMeasCorrlnPer1808I
ES209A249CurrMeasCorrln.cCurrMeasCorrlnChk1017I
ES209A222CurrMeasCorrln.cCurrMeasCorrlnPer1879-884I
ES209A104CurrMeasCorrln.cCurrMeasCorrlnPer1805I
ES209A99CurrMeasCorrln.cCurrMeasCorrlnPer1810I
ES209A262CurrMeasCorrln.cCurrMeasCorrlnPer1804-923I