This is the multi-page printable view of this section. Click here to print.
Component Implementation
1 - PwrDiscnct Review
Overview
Summary SheetDavinci Files
Source Code
MDD
QAC
Integration Manual
Sheet 1: Summary Sheet
Sheet 2: Davinci Files
Sheet 3: Source Code
Rev 6.0 | 28-Oct-14 | |||||||||||||||||||||||
Peer Review Meeting Log (Source Code Review) | ||||||||||||||||||||||||
Source File Name: | Source File Revision: | |||||||||||||||||||||||
Module Design Document Name: | MDD Revision: | |||||||||||||||||||||||
Data Dictionary Revision: | FDD/SER/CMS | |||||||||||||||||||||||
and Revision: | ||||||||||||||||||||||||
Quality Check Items: | ||||||||||||||||||||||||
Yes | No | Rationale is required for all answers of No | ||||||||||||||||||||||
Pre-review checklist for change owners | Software Naming Convention V1.2 followed: | |||||||||||||||||||||||
for variable names | X | Comments: | ||||||||||||||||||||||
Referred working EA4 naming conventions document | ||||||||||||||||||||||||
for constant names | X | Comments: | ||||||||||||||||||||||
Referred working EA4 naming conventions document | ||||||||||||||||||||||||
for function names | X | Comments: | ||||||||||||||||||||||
Referred working EA4 naming conventions document | ||||||||||||||||||||||||
for other names (component, memory | X | Comments: | ||||||||||||||||||||||
mapping handles, typedefs, etc.) | Referred working EA4 naming conventions document | |||||||||||||||||||||||
All buffered outputs written in every path, i.e. no | X | Comments: | ||||||||||||||||||||||
possibility of an uninitialized value being written | ||||||||||||||||||||||||
Group-review Checklist (review board) | Synergy version matches change history | X | Comments: | |||||||||||||||||||||
and Version Control version in file comment block | ||||||||||||||||||||||||
Change log contains detailed description of changes | X | Comments: | ||||||||||||||||||||||
and CR number | ||||||||||||||||||||||||
Code accurately implements FDD (Document or Model) | X | Comments: | ||||||||||||||||||||||
No Compiler Errors or Warnings verified | X | Comments: | ||||||||||||||||||||||
FDD test points exist as display variables: declared | X | Comments: | ||||||||||||||||||||||
static volatile, written once and never used, names | NA | |||||||||||||||||||||||
match the FDD | ||||||||||||||||||||||||
Software Design and Coding Standards V2.0 followed: | ||||||||||||||||||||||||
Code comments are clear, correct, and adequate | X | Comments: | ||||||||||||||||||||||
and have been updated for the change: [N40] and | ||||||||||||||||||||||||
all other rules in the same section as rule [N40], | ||||||||||||||||||||||||
plus [N75], [N12], [N23], [N33], [N37], [N38], | ||||||||||||||||||||||||
[N48], [N54], [N77], [N79], [N72] | ||||||||||||||||||||||||
Source file (.c and .h) comment blocks are per | X | Comments: | ||||||||||||||||||||||
standards and contain correct information: [N41], [N42] | ||||||||||||||||||||||||
Function comment blocks are per standards and | X | Comments: | ||||||||||||||||||||||
contain correct information: [N43] | ||||||||||||||||||||||||
Code formatting (indentation, placement of | X | Comments: | ||||||||||||||||||||||
braces, etc.) is per standards: [N5], [N55], [N56], | ||||||||||||||||||||||||
[N57], [N58], [N59] | ||||||||||||||||||||||||
Embedded constants used per standards; no | X | Comments: | ||||||||||||||||||||||
"magic numbers": [N12] | ||||||||||||||||||||||||
All variables and constants defined at module | X | Comments: | ||||||||||||||||||||||
level are included in appropriate MemMap | NA | |||||||||||||||||||||||
section: [N25] and Naming Conventions | ||||||||||||||||||||||||
All execution-order-dependent code can be | X | Comments: | ||||||||||||||||||||||
recognized by the compiler: [N80] | ||||||||||||||||||||||||
No possibility of a non-terminating loop: [N63] | X | Comments: | ||||||||||||||||||||||
No possibility of divide by zero: [N65] | X | Comments: | ||||||||||||||||||||||
All integer division and modulus operations | X | Comments: | ||||||||||||||||||||||
handle negative numbers correctly: [N76] | ||||||||||||||||||||||||
All typecasting and fixed point arithmetic, | X | Comments: | ||||||||||||||||||||||
including all use of fixed point macros and | ||||||||||||||||||||||||
timer functions, is correct and has no possibility | ||||||||||||||||||||||||
of unintended overflow or underflow: [N66] | ||||||||||||||||||||||||
No possibility of converting a negative floating | X | Comments: | ||||||||||||||||||||||
point value to an unsigned type: [N67] | ||||||||||||||||||||||||
All conversions between signed and unsigned | X | Comments: | ||||||||||||||||||||||
types handle msb==1 as intended: [N78] | ||||||||||||||||||||||||
No possibility of dereferencing a null | X | Comments: | ||||||||||||||||||||||
pointer: [N70] | ||||||||||||||||||||||||
Global outputs (RTE and Non-RTE) Initialized: | X | Comments: | ||||||||||||||||||||||
[N24] | ||||||||||||||||||||||||
Module outputs are limited to the legal range | X | Comments: | ||||||||||||||||||||||
defined in the FDD Data dictionary: [N53] | ||||||||||||||||||||||||
All code is mapped with FDD (all FDD | X | Comments: | ||||||||||||||||||||||
subfunctions and/or model blocks identified | ||||||||||||||||||||||||
with code comments; all code corresponds to | ||||||||||||||||||||||||
some FDD subfunction and/or model block): [N40] | ||||||||||||||||||||||||
Struct types used for NvM have | X | Comments: | ||||||||||||||||||||||
elements declared in decreasing order by size | ||||||||||||||||||||||||
and are not nested or used in arrays: [N84], [N85] | ||||||||||||||||||||||||
No violations of other coding standard rules | X | Comments: | ||||||||||||||||||||||
identified during review | ||||||||||||||||||||||||
General Notes / Comments: | ||||||||||||||||||||||||
1. Rename 'PwrDiscnct.h' to"'ElecGlbPrm.h". Remove the change log in this header file(to be consistent with others) - fixed | ||||||||||||||||||||||||
2. Rename 'StrtUpSt_Cnt_T_u8' to 'StrtUpSt_Cnt_T_u08' - fixed | ||||||||||||||||||||||||
3. Replace 0/1 with 'FALSE/TRUE' - fixed | ||||||||||||||||||||||||
4. Treat 'ELECGLBPRM_IVTRCNT_CNT_U08' as extern variable in the header file placed in contract folder - fixed | ||||||||||||||||||||||||
Change Owner: | Sankardu Varadapureddi | Review Date : | 04/20/15 | |||||||||||||||||||||
Lead Peer Reviewer: | Lucas Wendling | Approved by Reviewer(s): | Yes | |||||||||||||||||||||
Other Reviewer(s): | Kathleen Creager | Spandana Balani | Rijvi Ahmed | |||||||||||||||||||||
Sheet 4: MDD
Sheet 5: QAC
Rev 6.0 | 28-Oct-14 | |||||||||||||||||||||||
Peer Review Meeting Log (QAC Review) | ||||||||||||||||||||||||
Module Name: | Source File Revision: | 1 | Module | 1 | of | 1 | ||||||||||||||||||
Compliance Guidelines Version: | ||||||||||||||||||||||||
Quality Check Items: | ||||||||||||||||||||||||
Yes | No | Rationale is required for all answers of No | ||||||||||||||||||||||
Pre-review checklist for change owners | QAC version is correct and did not change (List version) | X | Comments: | ver 1.1.0 | ||||||||||||||||||||
Contract Folder's header files are appropriate | X | Comments: | ||||||||||||||||||||||
Group-review Checklist (review board) | 100% Compliance to the MISRA Compliance Guidelines | X | Comments: | |||||||||||||||||||||
Cyclomatic complexity and Static path count ok per | X | Comments: | ||||||||||||||||||||||
Design and Coding Standards rule [N47] | ||||||||||||||||||||||||
General Notes / Comments: | ||||||||||||||||||||||||
1. Add MISRA deviation statement at file level for 'void' return type statements… - fixed | ||||||||||||||||||||||||
2.Polyspace results are reviewed. | ||||||||||||||||||||||||
Change Owner: | Sankardu Varadapureddi | Review Date : | 04/20/15 | |||||||||||||||||||||
Lead Peer Reviewer: | Lucas Wendling | Approved by Reviewer(s): | Yes | |||||||||||||||||||||
Other Reviewer(s): | Kathleen Creager | Spandana Balani | Rijvi Ahmed | |||||||||||||||||||||
Sheet 6: Integration Manual
2 - PwrDiscnct_Integration Manual
Integration Manual
For
‘PwrDiscnct’
VERSION: 1.0
DATE: 09-Apr-2015
Prepared By:
Sankardu Varadapureddi,
Nexteer Automotive,
Saginaw, MI, USA
Revision History
Sl. No. | Description | Author | Version | Date |
1 | Initial version | Sankardu Varadapureddi | 1.0 | 09-Apr-2015 |
Table of Contents
3.2 Global Functions(Non RTE) to be provided to Integration Project 6
4 Configuration REQUIREMeNTS 7
4.2 Configuration Files to be provided by Integration Project 7
4.3 Da Vinci Parameter Configuration Changes 7
4.4 DaVinci Interrupt Configuration Changes 7
4.5 Manual Configuration Changes 7
5 Integration DATAFLOW REQUIREMENTS 8
5.1 Required Global Data Inputs 8
5.2 Required Global Data Outputs 8
5.3 Specific Include Path present 8
Abbrevations And Acronyms
Abbreviation | Description |
---|---|
DFD | Design functional diagram |
MDD | Module design Document |
References
This section lists the title & version of all the documents that are referred for development of this document
Sr. No. | Title | Version |
---|---|---|
1 | FDD - ES003A_PwrDiscnct_Design | See Synergy sub project version |
2 | Software Naming Conventions | Process 3.06.00 |
3 | Software Design and Coding Standards | Process 3.06.00 |
Dependencies
SWCs
Module | Required Feature |
---|---|
None |
Global Functions(Non RTE) to be provided to Integration Project
None
Configuration REQUIREMeNTS
Build Time Config
Modules | Notes | |
---|---|---|
None |
Configuration Files to be provided by Integration Project
None
Da Vinci Parameter Configuration Changes
Parameter | Notes | SWC |
---|---|---|
None |
DaVinci Interrupt Configuration Changes
ISR Name | VIM # | Priority Dependency | Notes |
---|---|---|---|
None |
Manual Configuration Changes
Constant | Notes | SWC |
---|---|---|
None |
Integration DATAFLOW REQUIREMENTS
Required Global Data Inputs
Refer DataDict.m file in the FDD
Required Global Data Outputs
Refer DataDict.m file file in the FDD
Specific Include Path present
No
Runnable Scheduling
This section specifies the required runnable scheduling.
Init | Scheduling Requirements | Trigger |
---|---|---|
None |
Runnable | Scheduling Requirements | Trigger |
---|---|---|
PwrDiscnctPer1 | None | RTE (2ms) |
.
Memory Map REQUIREMENTS
Mapping
Memory Section | Contents | Notes |
---|---|---|
PwrDiscnct_START_SEC_CODE | ||
* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.
Usage
Feature | RAM | ROM |
---|---|---|
<Memmap usuage info> |
Table 1: ARM Cortex R4 Memory Usage
Non RTE NvM Blocks
Block Name |
---|
None |
RTE NvM Blocks
Block Name |
---|
None |
Compiler Settings
Preprocessor MACRO
None.
Optimization Settings
None
Appendix
None
3 - PwrDiscnct_MDD
Module Design Document
For
‘PwrDiscnct’
VERSION: 1.0
DATE: 09-Apr-2015
Prepared By:
Sankardu Varadapureddi,
Nexteer Automotive,
Saginaw, MI, USA
Location: The official version of this document is stored in the Nexteer Configuration Management System.
Revision History
Sl. No. | Description | Author | Version | Date |
1 | Initial Version | Sankardu Varadapureddi | 1.0 | 09-Apr-2015 |
Table of Contents
3 Power Disconnect High-Level Description 6
4 Design details of software module 7
4.1 Graphical representation of POWER DISCONNECT 7
5.1 User defined typedef definition/declaration 8
5.2 Variable definition for enumerated types 8
6.1 Program(fixed) Constants 9
6.1.2 Module specific Lookup Tables Constants 9
7 Software Module Implementation 10
7.1.1 Initialization Functions 10
7.1.2.1 Per: PwrDiscnct_Per1 10
7.1.2.1.2 Store Module Inputs to Local copies 10
7.1.2.1.3 (Processing of function)……… 10
7.1.2.1.4 Store Local copy of outputs into Module Outputs 10
7.1.4 Serial Communication Functions 11
7.1.5 Local Function/Macro Definitions 11
7.1.6 GLObAL Function/Macro Definitions 11
7.1.7 Tranisition FUNCTIONS 11
8 Known Limitations With Design 12
Abbrevations And Acronyms
Abbreviation | Description |
---|---|
DFD | Design functional diagram |
MDD | Module design Document |
FDD | Functional Design Document |
References
This section lists the title & version of all the documents that are referred for development of this document
Sr. No. | Title | Version |
---|---|---|
1 | MDD Guidelines | Process 3.06.00 |
2 | Software Naming Conventions | Process 3.06.00 |
3 | Software Design and Coding standards | Process 3.06.00 |
4 | FDD - ES003A_PwrDiscnct_Design | See Synergy sub project version |
Power Disconnect High-Level Description
This function will verify that the PowerDisconnect is not stuck closed at init once per Ignition Cycle.
Design details of software module
Graphical representation of POWER DISCONNECT
Data Flow Diagram
Refer FDD
Module level DFD
Refer FDD
Sub-Module level DFD
Refer FDD
COMPONENT FLOW DIAGRAM
Refer FDD
Variable Data Dictionary
User defined typedef definition/declaration
<This section documents any user types uniquely used for the module.>
Typedef Name | Element Name | User Defined Type | Legal Range (min) | Legal Range (max) |
---|---|---|---|---|
None | ||||
Variable definition for enumerated types
Enum Name | Element Name | Value |
---|---|---|
None |
Constant Data Dictionary
Program(fixed) Constants
Embedded Constants
Local
Constant Name | Resolution | Units | Value |
---|---|---|---|
None |
Global
Constant Name |
---|
Module specific Lookup Tables Constants
Constant Name | Resolution | Value | Software Segment |
---|---|---|---|
None |
Software Module Implementation
Sub-Module Functions
Initialization Functions
None
PERIODIC FUNCTIONS
Per: PwrDiscnctPer1
Design Rationale
Design follows implemenetation in FDD.
Store Module Inputs to Local copies
Refer to FDD
(Processing of function)………
Refer to FDD (Block ‘PwrDiscnct’)
Store Local copy of outputs into Module Outputs
Refer to FDD
Interrupt Functions
None
Serial Communication Functions
None
Local Function/Macro Definitions
None
GLObAL Function/Macro Definitions
None
Tranisition FUNCTIONS
None
Known Limitations With Design
None
UNIT TEST CONSIDERATION
Appendix
None
4 - requirements
FDD | ID | Source | Function | Line(s) | Status | Comment |
---|---|---|---|---|---|---|
.SwFileName | .SwFuncName | .SwLines | .SwStatus | .SwComment | ||
ES003A | 88 | PwrDiscnct.c | PwrDiscnctPer1 | 885 | I | |
ES003A | 89 | PwrDiscnct.c | PwrDiscnctPer1 | 823-840 | I | |
ES003A | 82 | PwrDiscnct.c | PwrDiscnctPer1 | 884 | I | |
ES003A | 86 | PwrDiscnct.c | PwrDiscnctPer1 | 808-815 | I | |
ES003A | 87 | PwrDiscnct.c | PwrDiscnctPer1 | 848-856,864-869 | I | |
ES003A | 21 | PwrDiscnct.c | PwrDiscnctPer1 | 799-805 | I | |
ES003A | 22 | PwrDiscnct.c | PwrDiscnctPer1 | 810,835 | I | |
ES003A | 23 | PwrDiscnct.c | PwrDiscnctPer1 | 824-830 | I | |
ES003A | 47 | PwrDiscnct.c | PwrDiscnctPer1 | 796-882 | I | |
ES003A | 42 | PwrDiscnct.c | PwrDiscnctPer1 | 812,818 | I | |
ES003A | 43 | PwrDiscnct.c | PwrDiscnctPer1 | 837,844 | I | |
ES003A | 76 | PwrDiscnct.c | PwrDiscnctPer1 | 825-831 | I | |
ES003A | 106 | PwrDiscnct.c | PwrDiscnctPer1 | 792 | I | |
ES003A | 91 | PwrDiscnct.c | PwrDiscnctPer1 | 819 | I | |
ES003A | 93 | PwrDiscnct.c | PwrDiscnctPer1 | 843 | I | |
ES003A | 92 | PwrDiscnct.c | PwrDiscnctPer1 | 807-814 | I | |
ES003A | 95 | PwrDiscnct.c | PwrDiscnctPer1 | 833-839 | I | |
ES003A | 11 | PwrDiscnct.c | PwrDiscnctPer1 | 790 | I | |
ES003A | 10 | PwrDiscnct.c | PwrDiscnctPer1 | 789 | I | |
ES003A | 13 | PwrDiscnct.c | PwrDiscnctPer1 | 826 | I | |
ES003A | 12 | PwrDiscnct.c | PwrDiscnctPer1 | 791 | I | |
ES003A | 15 | PwrDiscnct.c | PwrDiscnctPer1 | 892 | I | |
ES003A | 14 | PwrDiscnct.c | PwrDiscnctPer1 | 891 | I | |
ES003A | 98 | PwrDiscnct.c | PwrDiscnctPer1 | 795-889 | I | |
ES003A | 18 | PwrDiscnct.c | PwrDiscnctPer1 | 803,829 | I | |
ES003A | 50 | PwrDiscnct.c | PwrDiscnctPer1 | 798-804 | I |