1 - HwAg1Meas_DesignReview


Overview

Summary Sheet
Synergy Project
Davinci Files


Sheet 1: Summary Sheet
























Rev 1.28-Jun-15

Peer Review Summary Sheet


























Synergy Project Name:


kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. CM670A_HwAg1Meas_Impl
Revision / Baseline:


kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. 1.8.1

























Change Owner:


kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Krishna Anne
Work CR ID:


EA4#6437





























kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:















































































































































































kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:






















































Reviewed:































YesMDD


YesSource Code


YesPolySpace









































YesIntegration Manual


YesDavinci Files








































































Comments:

Reviewed changes only, made port interface correction for a client, no functional changes



























































































General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.





















Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)



















































Quality Check Items:




































Rationale is required for all answers of No










New baseline version name from Summary Sheet follows








Yes
Comments:



naming convention





































Project contains necessary subprojects








Yes
Comments:










































Project contains the correct version of subprojects








Yes
Comments:










































Design subproject is correct version








Yes
Comments:











































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Krishna Anne


Review Date :

06/27/16
































Lead Peer Reviewer:


Nick Saxton


Approved by Reviewer(s):



Yes































Other Reviewer(s):










































































Sheet 3: Davinci Files






















Rev 1.28-Jun-15
Peer Review Meeting Log (Davinci Review)


























Quality Check Items:




































Rationale is required for all answers of No










Only StdDef Port types are used








Yes
Comments:










































For components not using application data types, do all








Yes
Comments:



port interface names end in PortIf and a sequence number





























































Non-program-specific components saved








Yes
Comments:




in Autosar 4.0.3 format




































*Cfg.arxml.TT: Verfied Davinci Configurator imported the








N/A
Comments:




change correctly




































*Cfg.h.TT: Verfied Davinci Configurator generates








N/A
Comments:










the configuration header(s) file correctly
kzshz2: Either a generic sandbox or a baselined integration project can be used to verify



























kzshz2: Either a generic sandbox or a baselined integration project can be used to verify
















All changed files have been compared against previous








Yes
Comments:




versions (If available)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.


































Automated validation check is performed








Yes
Comments:

























































Naming conventions followed. All names should








Yes
Comments:










match DataDict.m













































Sender/Receiver port properties match DataDict.m








Yes
Comments:










file (use .m file helper tool)













































Calibration port properties match DataDict.m








Yes
Comments:










file (use .m file helper tool)













































Components using application data types:























Sender/Receiver port initialization values match







N/A
Comments:










DataDict.m file














































Calibration port initialization values match







N/A
Comments:










DataDict.m file













































Components not using application data types:























Sender/Receiver port initialization values match







Yes
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Calibration port initialization values match







Yes
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Mapping set and all unused items have been







Yes
Comments:










removed













































All sender/receiver port read/writes using direct








Yes
Comments:










read/writes(List justification if not)













































Runnable calling frequencies match FDD








Yes
Comments:

































DataDict.m display variables: created as








Yes
Comments:









PerInstanceMemory. Matches the FDD





































Component is correct component type








Yes
Comments:











































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Krishna Anne
Review Date :

06/27/16
Component Type :


SA



























Lead Peer Reviewer:


Nick Saxton
Approved by Reviewer(s):



Yes

































Other Reviewer(s):









































































2 - HwAg1Meas_IntegrationManual

Integration Manual

For

HwAg1Meas

VERSION: 4.0

DATE: 21-Jun-2015

Prepared By:

TATA ELXSI

CHENNAI

Location: The official version of this document is stored in the Nexteer Configuration Management System.

Revision History

Sl. No.DescriptionAuthorVersionDate
1Initial versionSelva Sengottaiyan1.021-July-2015
2Updated to FDD v 1.2.0Selva Sengottaiyan2.011-Sep-2015
3Updated to FDD v1.4.0Selva Sengottaiyan3.022-Dec-2015
4Updated to FDD v1.8.0TATA4.021-Jun-2015

Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 NvM Blocks 10

7.4 RTE NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

AbbreviationDescription
DFDDesign functional diagram
MDDModule design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.TitleVersion
vFDD – CM670A_HwAg1Meas_DesignSee Synergy sub project version
2Software Naming ConventionsProcess 4.01.00
3Software Design and Coding StandardsProcess 4.01.00

Dependencies

SWCs

ModuleRequired Feature
None

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

ModulesNotes
None

Configuration Files to be provided by Integration Project

HwAg1Meas_Cfg.h

Da Vinci Parameter Configuration Changes

ParameterNotesSWC
Refer the . mfileCM10 provides program specific NTC configuration

DaVinci Interrupt Configuration Changes

ISR NameVIM #Priority DependencyNotes
None

Manual Configuration Changes

ConstantNotesSWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file in the FDD

Required Global Data Outputs

Refer DataDict.m file file in the FDD

Specific Include Path present

No

Runnable Scheduling

This section specifies the required runnable scheduling.

InitScheduling RequirementsTrigger
HwAg1MeasInit1NoneRTE (Init)
RunnableScheduling RequirementsTrigger
HwAg1MeasPer1NoneRTE (2 ms)
HwAg1MeasPer2NoneRTE (2 ms)
HwAg1MeasPer3NoneRTE (2 ms)
HwAg1MeasPer4NoneRTE (2ms)
HwAg1MeasPer5NoneRTE (100ms)
HwAg1MeasHwAg1AutTrim_OperNoneServer invocation
HwAg1MeasHwAg1ClrTrim_OperNoneServer invocation
HwAg1MeasHwAg1ReadTrim_OperNoneServer invocation
HwAg1MeasHwAg1ReadTrim_OperNoneServer invocation
HwAg1MeasHwAg1TrimPrfmdSts_OperNoneServer invocation
HwAg1MeasHwAg1WrTrim_OperNoneServer invocation

.

Memory Map REQUIREMENTS

Mapping

Memory SectionContentsNotes
None

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

FeatureRAMROM
None

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

RTE NvM Blocks

Block Name
HwAg1Offs

Note : Size of the NVM block if configured in developer

Compiler Settings

Preprocessor MACRO

None.

Optimization Settings

None.

Appendix

SENT2SPCO port out should be configured to be high level on port configurations refer CM10 for SPCO port configuration (SENT2SPCO shall be port level high). port configuration SENT2SPCO output:port (that’s needs to be configured as SENT2SPCO) should be initialized as input dio with level high.the client call Iohwab_Setfctprphlhwag1_oper will reset the pin to output alterante mode for SENT2SPCO

Design Recommandation :

- Port Config RSENT2 IO pin shall setup default input.

- Schedule execution of tasks as per below order at the end of 2ms task

1. "HwAg1MeasPer2"

2. "HwAg1MeasPer3"

3. "HwAg1MeasPer4"

4. "HwAg1MeasPer1"

- Schedule "HwAg1MeasPer4" & "HwAg1MeasPer1" shall at least 110us apart.

3 - HwAg1Meas_MDD

Module Design Document

For

HwAg1Meas

Jun 21,2016

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

TATA ELXSI

CHENNAI


Change History

DescriptionAuthorVersionDate
Initial VersionSelva Sengottaiyan1.021-July-2015
Updated to v1.2.0 of the FDDSelva Sengottaiyan2.011-Sep-15
Updated to v1.4.0 of the FDDSelva Sengottaiyan3.023-Dec-15
Updated to v1.11.0 of the FDDRamachandran4.021-Jun-2016


Table of Contents

1 Introduction 4

1.1 Purpose 4

1.2 Scope 4

2 HwAg1Meas High-Level Description 5

3 Design details of software module 6

3.1 Graphical representation of HwAg1Meas 6

3.2 Data Flow Diagram 6

3.2.1 Component level DFD 6

3.2.2 Function level DFD 6

4 Constant Data Dictionary 7

4.1 Program (fixed) Constants 7

4.1.1 Embedded Constants 7

5 Software Component Implementation 8

5.1.1 Sub-Module Functions 8

5.1.2 Interrupt Service Routines 8

5.1.3 Server Runnable Functions 9

5.1.4 Module Internal (Local) Functions 9

5.1.4.1 Local Function #1 9

5.1.4.2 Description 9

5.1.5 Transition Functions 10

6 Known Limitations with Design 11

7 UNIT TEST CONSIDERATION 12

Appendix A Abbreviations and Acronyms 13

Appendix B Glossary 14

Appendix C References 15

Introduction

Purpose

MDD for HwAg1.

Scope

HwAg1Meas High-Level Description

Refer to FDD

Design details of software module

Graphical representation of HwAg1Meas

C:\Users\vignesh.l\Desktop\CM670.JPG

Data Flow Diagram

Component level DFD

Refer FDD

Function level DFD

Refer FDD

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Local Constants

Constant NameValue
MAXWAITININ_MICROSEC_U32((uint32)2U)
DATAAVLMAXWAIT_MICROSEC_U32((uint32)300U)
COMSTSMAXWAIT_MICROSEC_U32((uint32)5U)
PRTCLFLTMASK_CNT_U320xFEU
SNSRIDMASK_CNT_U080x00FU
MSGSTSMASK_CNT_U080x01U
COMSTSMASK_CNT_U320x30000000UL
DATAMASK_CNT_U160xFFF0U

Software Component Implementation

Sub-Module Functions

Initialization sub-module {_Init()}

HwAg1MeasInit1 (Refer FDD for details)

Periodic sub-module {_Per()}

HwAg1MeasPer1 (Refer FDD for details)

Periodic sub-module {_Per()}

HwAg1MeasPer2 (Refer FDD for details)

Periodic sub-module {_Per()}

HwAg1MeasPer3 (Refer FDD for details)

Periodic sub-module {_Per()}

HwAg1MeasPer4 (Refer FDD for details)

Periodic sub-module {_Per()}

HwAg1MeasPer5 (Refer FDD for details)

Design Rationale:

The implementation brings in the block “HwAg1Final” inside the True Condition of the “finalAbsAg” as the other error condition will just retain the previous value and rolling counter will not change. It saves extra instructions in the implementation to the match the FDD. Final Functionality is still the same.

Interrupt Service Routines

None

Server Runnable Functions

Server Runnable: HwAg1MeasHwAg1AutTrim

Refer FDD for details

Server Runnable: HwAg1MeasHwAg1ClrTrim

Refer FDD for details

Server Runnable: HwAg1MeasHwAg1ReadTrim

Refer FDD for details

Server Runnable: HwAg1MeasHwAg1TrimPrfmdSts

Refer FDD for details

Server Runnable: HwAg1MeasHwAg1WrTrim

Refer FDD for details

Module Internal (Local) Functions

Local Function #1

Function NameCalcHwAgIdxTypeMinMax
Arguments PassedHwAgStep_HwDeg_T_f32float32-900900
Return ValueIndex_Cnt_T_u08uint16022

Description

The implementation deviates from the FDD block “Intpn” block. The implementation finds the minimum of absolute values of the difference between HwAg1Step with all the values from the Calibration table and find the index associated with minimum value of the difference in the calibration table.

Local Function #2

Function NameReadRegisterTypeMinMax
Arguments PassedRegisterDummyRead_Cnt_T_u32N/AN/AN/A
Return ValueRegisterDummyRead_Cnt_T_u32N/AN/AN/A

Design Rationale

This function can be used both for read-and-use and for read-and-discard

Transition Functions

None

Known Limitations with Design

None

UNIT TEST CONSIDERATION

  • Roll Over is intentional for

    • *Rte_Pim_HwAg1Snsr0ComStsErrCntr()

    • *Rte_Pim_HwAg1Snsr0IdErrCntr()

    • *Rte_Pim_HwAg1Snsr0IntSnsrErrCntr()

    • *Rte_Pim_HwAg1Snsr0NoMsgErrCntr()

    • *Rte_Pim_HwAg1Snsr1ComStsErrCntr()

    • *Rte_Pim_HwAg1Snsr1IdErrCntr()

    • *Rte_Pim_HwAg1Snsr1IntSnsrErrCntr()

    • *Rte_Pim_HwAg1Snsr1NoMsgErrCntr()

    • (*Rte_Pim_HwAg1PrevRollCnt).

  • Thus counter acts in circular

Abbreviations and Acronyms

Abbreviation or AcronymDescription

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

  • ISO 9000

  • ISO/IEC 12207

  • ISO/IEC 15504

  • Automotive SPICE® Process Reference Model (PRM)

  • Automotive SPICE® Process Assessment Model (PAM)

  • ISO/IEC 15288

  • ISO 26262

  • IEEE Standards

  • SWEBOK

  • PMBOK

  • Existing Nexteer Automotive documentation

TermDefinitionSource
MDDModule Design Document
DFDData Flow Diagram

References

Ref. #TitleVersion
1AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)v1.3.0 R4.0 Rev 2
2MDD GuidelineEA4 01.00.00
3Software Naming Conventions.doc1.0
4Software Design and Coding Standards.doc2.0
5FDD - CM670A_HwAg1Meas_DesignSee Synergy sub project version

4 - requirements

FDDIDSourceFunctionLine(s)StatusComment
.SwFileName.SwFuncName.SwLines.SwStatus.SwComment
CM670A93HwAg1Meas.cHwAg1MeasPer41518I
CM670A28HwAg1Meas.cHwAg1MeasPer2,HwAg1MeasPer31160,1312I
CM670A29HwAg1Meas.cHwAg1MeasPer41543I
CM670A60HwAg1Meas.cHwAg1MeasPer31266-1377I
CM670A88HwAg1Meas.cHwAg1MeasHwAg1ClrTrim_Oper810-814I
CM670A89HwAg1Meas.cHwAg1MeasHwAg1WrTrim_Oper913-917I
CM670A64HwAg1Meas.cHwAg1MeasPer31323I
CM670A65HwAg1Meas.cHwAg1MeasPer31323I
CM670A66HwAg1Meas.cHwAg1MeasPer31323I
CM670A67HwAg1Meas.cHwAg1MeasPer31323I
CM670A68HwAg1Meas.cHwAg1MeasPer31323I
CM670A69HwAg1Meas.cHwAg1MeasPer31323I
CM670A80HwAg1Meas.cHwAg1MeasPer51609-1618I
CM670A86HwAg1Meas.cHwAg1MeasHwAg1AutTrim_Oper,HwAg1MeasHwAg1ClrTrim_Oper,HwAg1MeasHwAg1ReadTrim_Oper,HwAg1MeasHwAg1WrTrim_Oper767,769,811,813,843,914,916I
CM670A87HwAg1Meas.cHwAg1MeasHwAg1TrimPrfmdSts_Oper873I
CM670A85HwAg1Meas.cHwAg1MeasHwAg1AutTrim_Oper,HwAg1MeasHwAg1ClrTrim_Oper,HwAg1MeasHwAg1WrTrim_Oper768,769,812,813,915,916I
CM670A27HwAg1Meas.cHwAg1MeasPer2,HwAg1MeasPer31134-1189,1279-1368I
CM670A48HwAg1Meas.cHwAg1MeasPer21160I
CM670A49HwAg1Meas.cHwAg1MeasPer21145I
CM670A46HwAg1Meas.cHwAg1MeasPer21170I
CM670A47HwAg1Meas.cHwAg1MeasPer21179I
CM670A44HwAg1Meas.cHwAg1MeasPer21170I
CM670A45HwAg1Meas.cHwAg1MeasPer21170I
CM670A42HwAg1Meas.cHwAg1MeasPer21170I
CM670A43HwAg1Meas.cHwAg1MeasPer21170I
CM670A40HwAg1Meas.cHwAg1MeasPer21170I
CM670A41HwAg1Meas.cHwAg1MeasPer21170I
CM670A104HwAg1Meas.cHwAg1MeasPer51616I
CM670A75HwAg1Meas.cHwAg1MeasPer31299I
CM670A74HwAg1Meas.cHwAg1MeasPer21151I
CM670A73HwAg1Meas.cHwAg1MeasPer31291I
CM670A71HwAg1Meas.cHwAg1MeasPer31312I
CM670A70HwAg1Meas.cHwAg1MeasPer31331I
CM670A91HwAg1Meas.cHwAg1MeasPer41473,1476I
CM670A90HwAg1Meas.cHwAg1MeasHwAg1AutTrim_Oper765-770I
CM670A100HwAg1Meas.cHwAg1MeasPer4,HwAg1MeasPer51503-1515,1612,1616I
CM670A95HwAg1Meas.cHwAg1MeasPer41461,1572I
CM670A97HwAg1Meas.cHwAg1MeasPer41524I
CM670A39HwAg1Meas.cHwAg1MeasPer21122-1207I
CM670A58HwAg1Meas.cHwAg1MeasPer31310I
CM670A55HwAg1Meas.cHwAg1MeasPer21170I
CM670A54HwAg1Meas.cHwAg1MeasPer2,HwAg1MeasPer31121-1206,1265-1376I
CM670A31HwAg1Meas.cHwAg1MeasPer41569I
CM670A30HwAg1Meas.cHwAg1MeasPer41570I
CM670A62HwAg1Meas.cHwAg1MeasPer31323I
CM670A53HwAg1Meas.cHwAg1MeasPer11044-1069I
CM670A33HwAg1Meas.cHwAg1MeasPer41543I
CM670A63HwAg1Meas.cHwAg1MeasPer31323I
CM670A32HwAg1Meas.cHwAg1MeasPer41543I