This is the multi-page printable view of this section. Click here to print.
Nexteer Manufacturing Components(Applicative Software)
- 1: Component Design
- 2: Component Implementation
- 2.1: 1. Overview
- 2.2: 2. General Negative Responses
- 2.3: 3. Document Conventions
- 2.4: CmnMfgSrv_PeerReviewChecklist
- 3: Component Implementation
- 4: Component Implementation
- 4.1: MotVelCtrl_IntegrationManual
- 4.2: MotVelCtrl_MDD
- 4.3: MotVelCtrl_Review
- 5: Component Implementation
- 6: Component Implementation
- 7: Component Implementation
1.1 - NM100A_MotVelCtrl_PeerReview_Design
Overview
Peer Review InstructionsTechnical Review Checklist
Template Change Log
Sheet 1: Peer Review Instructions
Instructions for Functional Design Package Peer Review | ||
PRE-MEETING | ||
Function Owner | Confirm that requirements are reviewed and approved PRIOR to the FDP peer review | |
Function Owner | Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews | |
Function Owner | Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review | |
Function Owner | Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting | |
Function Owner | Identify necessary attendance and invite to meeting | |
Function Owner | Complete the "Author" column information for sections 1 through 3 prior to the review | |
Function Owner | Complete the attendance invitation list in section 5 | |
Function Owner | For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews. | |
DURING MEETING | ||
Function Owner | Present document changes to the review team | |
Peer Reviewer | Capture attendance of the review | |
Peer Reviewer | Capture actions and issues in section 4. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN" | |
POST MEETING | ||
Function Owner | Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided. | |
Function Owner | Schedule follow up review OR review open items with peer reviewer and obtain agreement to close | |
Peer Reviewer | Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates |
Sheet 2: Technical Review Checklist
Sheet 3: Template Change Log
Rev | Change | Author |
01.00.05 | Added lesson learned #3.5 | MDK |
01.00.06 | Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models. | MDK |
02.00.00 | Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD. | K. Derry |
02.01.00 | Added: Does FDD.DesignASIL match requirements? Added: Was webview model created without requirements highlighted? Removed: Redundant row in Data Dictionary section. Formatting: Column C now consistently center-justified. | K. Derry |
2.1 - 1. Overview
Standards
Nexteer Manufacturing Services adhere to the ISO-14229 standard for Automotive Diagnostic Services as well as ISO-15765 (Transport Layer) standard for sending data packets over a CAN-Bus.
Connection Details
Request ID (to ECU): 0x712
Response ID (from ECU): 0x710
Byte Ordering
All data is transfered in Motorola format (most significant byte first - also known as big-endian).
NvM Values
For EA4, an ignition cycle or ECU reset is required to commit any and all stored values from Volatile Memory (RAM) to Non-Volatile Memory (NvM). When an auto trim, clear trim, write trim, or similar service is used to modify any value stored in NvM a flag is set within the controller indicating that the value is to be written to NvM on the next shutdown. The power cycle can be provided by means of a cycling of physical ignition (EPS ENA) or by issuing an ECU reset (11 60) service. The reception of a positive response from the ECU reset service indicates completion of NvM writes at which time it is safe to remove battery.
2.2 - 2. General Negative Responses
This is a comprehensive list of all negative response codes as defined by the ISO-14229 specification. A value of “Yes” in the columns below indicates that the NRC is applicable to ALL services of the corresponding type regardless of whether or not it is expressly listed in the “Unique Negative Responses” section of a specific service.
NRC | Description | 0x22 | 0x2E | 0x2F | 0x31 |
---|---|---|---|---|---|
0x11 | General service not supported | Yes | Yes | Yes | Yes |
0x12 | Sub-function nut supported | No | No | Yes | Yes |
0x13 | Invalid length | Yes | Yes | Yes | Yes |
0x22 | Conditions not correct | No | No | No | No |
0x24 | Request sequence error | No | No | No | No |
0x31 | Request out of range | No | No | No | No |
0x33 | Security access denied | No | No | No | No |
0x35 | Invalid Key | No | No | No | No |
0x36 | Exceeded number of attempts | No | No | No | No |
0x37 | Time delay not expired | No | No | No | No |
0x78 | Request received, response pending | No | No | No | No |
0x7E | Sub-function not supported in current session | No | No | No | No |
0x7F | Service not supported in current session | Yes | Yes | Yes | Yes |
0x81 | Engine RPM too high | No | No | No | No |
0x82 | Engine RPM too low | No | No | No | No |
0x83 | Engine running | No | No | No | No |
0x84 | Engine not running | No | No | No | No |
0x85 | Engine run time too low | No | No | No | No |
0x86 | Temperature too high | No | No | No | No |
0x87 | Temperature too low | No | No | No | No |
0x88 | Vehicle speed too high | No | No | No | No |
0x89 | Vehicle speed too low | No | No | No | No |
0x8A | Throttle too high | No | No | No | No |
0x8B | Throttle too low | No | No | No | No |
0x8C | Transmission not in neutral | No | No | No | No |
0x8D | Transmission not in gear | No | No | No | No |
0x8F | Brake not applied | No | No | No | No |
0x90 | Transmission not in park | No | No | No | No |
0x92 | Voltage too high | No | No | No | No |
0x93 | Voltage too low | No | No | No | No |
2.3 - 3. Document Conventions
Terms
- NvM
- Non-Volatile Memory
Hexadecimal Values
Hexadecimal values in this document will always be prefixed with “0x”. Hexadecimal format values in transaction snippets will be represented by a pair of x’s, for example:
xx
ASCII Values
ASCII text strings in transaction snippets will be represented by a pair of a’s, for example:
aa
Bitfields (Binary Values)
Binary values in this document will always be prefixed with “0b”. Binary (or bitfield) values in transaction snippets will be represented by single ‘b’ characters, for example:
b
Binary values will always be in groups that are multiples of 8 bits. In cases where some bits are unused, the unused bits will be marked as “Reserved”, for example.
bbbb b b b b
| | | | |
| | | | '-- Bit 0
| | | '-- Bit 1
| | '-- Bit 2
| '-- Bit 3
'-- Reserved
Reserved bits should be passed as zeros on writes and reads.
Grouped Bytes
If bytes are grouped (for example, 4 bytes used to represent a single 32-bit value) the transaction snippet will show the bytes as being connected using the ‘o’ character, for example:
xx xx xx xx
| | | |
'--o--o--o-- Represents a 32-bit value
Grouped values are always in Motorola format (i.e. most-significant byte first).
Floating Point Numbers
Floating point values are represented in transaction snippets as four ‘f’ character pairs, for example:
ff ff ff ff
| | | |
'--o--o--o-- Single-precision floating point value
The four pairs represent the four bytes of data transmitted over CAN that make up the single precision float value. The four pairs will always be grouped using the conventions outlined in section 2.3 above.
Grouped values are always in Motorola format (i.e. most-significant byte first).
Units
Units in transaction snippets will be called out inside a pair of square braces, for example:
[MotNwtMtr]
If no units are specified, then the signal’s units are assumed to be Counts.
Ranges
Ranges for signals in transaction snippets will be called out inside a pair of parentheses, for example:
(minimum, maximum)
If no range is specified, then the range for the signal’s value is assumed to be bounded by the signals type.
Type | Minimum | Maximum |
---|---|---|
uint8 | 0 | 255 |
uint16 | 0 | 65535 |
uint32 | 0 | 4294967295 |
sint8 | -128 | 127 |
sint16 | -32768 | 32767 |
sint32 | -2147483648 | 2147483647 |
float32 | error* | error* |
- *The float32 type does not have a specific minimum nor maximum value and thus each signal is required to provide a valid range specific to each.
Scale/Offset
Scale values for signals in transaction snippets will be called out inside a pair of curly braces, for example:
{*1/(2^16)}
The above scale would imply multiplying the raw value from the CAN bus by 1/65536 to achieve the scaled representation. An example including an offset would look like this:
{*1/(2^4) +11.0125}
In this second example, the raw value from the bus shall have a scale of 1/16 applied and then an offset of +11.0125 added. Offsets may be positive or negative as indicated by the preceding sign.
2.4 - CmnMfgSrv_PeerReviewChecklist
Overview
Summary SheetDavinci Files
Source Code
QAC
Sheet 1: Summary Sheet
Sheet 2: Davinci Files
Sheet 3: Source Code
Rev 6.0 | 28-Oct-14 | |||||||||||||||||||||||||
Peer Review Meeting Log (Source Code Review) | ||||||||||||||||||||||||||
Source File Name: | Source File Revision: | |||||||||||||||||||||||||
Module Design Document Name: | MDD Revision: | |||||||||||||||||||||||||
Data Dictionary Revision: | FDD/SER/CMS | |||||||||||||||||||||||||
and Revision: | ||||||||||||||||||||||||||
Quality Check Items: | ||||||||||||||||||||||||||
Yes | No | Rationale is required for all answers of No | ||||||||||||||||||||||||
Pre-review checklist for change owners | Software Naming Convention V1.2 followed: | |||||||||||||||||||||||||
for variable names | X | Comments: | ||||||||||||||||||||||||
for constant names | X | Comments: | N/A | |||||||||||||||||||||||
for function names | X | Comments: | ||||||||||||||||||||||||
for other names (component, memory | X | Comments: | ||||||||||||||||||||||||
mapping handles, typedefs, etc.) | ||||||||||||||||||||||||||
All buffered outputs written in every path, i.e. no | X | Comments: | ||||||||||||||||||||||||
possibility of an uninitialized value being written | ||||||||||||||||||||||||||
Group-review Checklist (review board) | Synergy version matches change history | X | Comments: | |||||||||||||||||||||||
and Version Control version in file comment block | ||||||||||||||||||||||||||
Change log contains detailed description of changes | X | Comments: | ||||||||||||||||||||||||
and CR number | ||||||||||||||||||||||||||
Code accurately implements FDD (Document or Model) | X | Comments: | N/A | |||||||||||||||||||||||
No Compiler Errors or Warnings verified | X | Comments: | ||||||||||||||||||||||||
FDD test points exist as display variables: declared | X | Comments: | N/A | |||||||||||||||||||||||
static volatile, written once and never used, names | ||||||||||||||||||||||||||
match the FDD | ||||||||||||||||||||||||||
Software Design and Coding Standards V2.0 followed: | ||||||||||||||||||||||||||
Code comments are clear, correct, and adequate | X | Comments: | ||||||||||||||||||||||||
and have been updated for the change: [N40] and | ||||||||||||||||||||||||||
all other rules in the same section as rule [N40], | ||||||||||||||||||||||||||
plus [N75], [N12], [N23], [N33], [N37], [N38], | ||||||||||||||||||||||||||
[N48], [N54], [N77], [N79], [N72] | ||||||||||||||||||||||||||
Source file (.c and .h) comment blocks are per | X | Comments: | ||||||||||||||||||||||||
standards and contain correct information: [N41], [N42] | ||||||||||||||||||||||||||
Function comment blocks are per standards and | X | Comments: | ||||||||||||||||||||||||
contain correct information: [N43] | ||||||||||||||||||||||||||
Code formatting (indentation, placement of | X | Comments: | ||||||||||||||||||||||||
braces, etc.) is per standards: [N5], [N55], [N56], | ||||||||||||||||||||||||||
[N57], [N58], [N59] | ||||||||||||||||||||||||||
Embedded constants used per standards; no | X | Comments: | ||||||||||||||||||||||||
"magic numbers": [N12] | ||||||||||||||||||||||||||
All variables and constants defined at module | X | Comments: | ||||||||||||||||||||||||
level are included in appropriate MemMap | ||||||||||||||||||||||||||
section: [N25] and Naming Conventions | ||||||||||||||||||||||||||
All execution-order-dependent code can be | X | Comments: | ||||||||||||||||||||||||
recognized by the compiler: [N80] | ||||||||||||||||||||||||||
No possibility of a non-terminating loop: [N63] | X | Comments: | ||||||||||||||||||||||||
No possibility of divide by zero: [N65] | X | Comments: | ||||||||||||||||||||||||
All integer division and modulus operations | X | Comments: | N/A | |||||||||||||||||||||||
handle negative numbers correctly: [N76] | ||||||||||||||||||||||||||
All typecasting and fixed point arithmetic, | X | Comments: | N/A | |||||||||||||||||||||||
including all use of fixed point macros and | ||||||||||||||||||||||||||
timer functions, is correct and has no possibility | ||||||||||||||||||||||||||
of unintended overflow or underflow: [N66] | ||||||||||||||||||||||||||
No possibility of converting a negative floating | X | Comments: | N/A | |||||||||||||||||||||||
point value to an unsigned type: [N67] | ||||||||||||||||||||||||||
All conversions between signed and unsigned | X | Comments: | N/A | |||||||||||||||||||||||
types handle msb==1 as intended: [N78] | ||||||||||||||||||||||||||
No possibility of dereferencing a null | X | Comments: | ||||||||||||||||||||||||
pointer: [N70] | ||||||||||||||||||||||||||
Global outputs (RTE and Non-RTE) Initialized: | X | Comments: | ||||||||||||||||||||||||
[N24] | ||||||||||||||||||||||||||
Module outputs are limited to the legal range | X | Comments: | ||||||||||||||||||||||||
defined in the FDD Data dictionary: [N53] | ||||||||||||||||||||||||||
All code is mapped with FDD (all FDD | X | Comments: | ||||||||||||||||||||||||
subfunctions and/or model blocks identified | ||||||||||||||||||||||||||
with code comments; all code corresponds to | ||||||||||||||||||||||||||
some FDD subfunction and/or model block): [N40] | ||||||||||||||||||||||||||
Struct types used for NvM have | X | Comments: | N/A | |||||||||||||||||||||||
elements declared in decreasing order by size | ||||||||||||||||||||||||||
and are not nested or used in arrays: [N84], [N85] | ||||||||||||||||||||||||||
No violations of other coding standard rules | X | Comments: | ||||||||||||||||||||||||
identified during review | ||||||||||||||||||||||||||
General Notes / Comments: | ||||||||||||||||||||||||||
Updates made to SrvFD70 (3), SrvFDF4 (3), SrvFDF5 (3), SrvFE88 (1), SrvFE89 (1), SrvFE8A (1), SrvFE8B (1), SrvFEA2 (2) | ||||||||||||||||||||||||||
Change Owner: | Jared Julien | Review Date : | 05/06/16 | |||||||||||||||||||||||
Lead Peer Reviewer: | Kevin Smith | Approved by Reviewer(s): | Yes | |||||||||||||||||||||||
Other Reviewer(s): | ||||||||||||||||||||||||||
Sheet 4: QAC
Rev 6.0 | 28-Oct-14 | |||||||||||||||||||||||
Peer Review Meeting Log (QAC Review) | ||||||||||||||||||||||||
Module Name: | Source File Revision: | N/A | Module | 1 | of | 1 | ||||||||||||||||||
Compliance Guidelines Version: | Working EA4 guideline | |||||||||||||||||||||||
Quality Check Items: | ||||||||||||||||||||||||
Yes | No | Rationale is required for all answers of No | ||||||||||||||||||||||
Pre-review checklist for change owners | QAC version is correct and did not change (List version) | X | Comments: | TL100A_QACSuprt_1.2.0 | ||||||||||||||||||||
Contract Folder's header files are appropriate | X | Comments: | ||||||||||||||||||||||
Group-review Checklist (review board) | 100% Compliance to the MISRA Compliance Guidelines | X | Comments: | |||||||||||||||||||||
Cyclomatic complexity and Static path count ok per | X | Comments: | ||||||||||||||||||||||
Design and Coding Standards rule [N47] | ||||||||||||||||||||||||
General Notes / Comments: | ||||||||||||||||||||||||
QAC Run against ALL source files - one tab used to document all files. | ||||||||||||||||||||||||
Change Owner: | Jared Julien | Review Date : | 03/24/16 | |||||||||||||||||||||
Lead Peer Reviewer: | Sankardu Varadapureddi | Approved by Reviewer(s): | Yes | |||||||||||||||||||||
Other Reviewer(s): | ||||||||||||||||||||||||
4.1 - MotVelCtrl_IntegrationManual
Integration Manual
For
MotVelCtrl
VERSION: 1.0
DATE: 16-Feb-2016
Prepared By:
Sankardu Varadapureddi,
Nexteer Automotive,
Saginaw, MI, USA
Location: The official version of this document is stored in the Nexteer Configuration Management System.
Revision History
Sl. No. | Description | Author | Version | Date |
1 | Initial version | Sankardu Varadapureddi | 1.0 | 16-Feb-2016 |
Table of Contents
3.2 Global Functions(Non RTE) to be provided to Integration Project 6
4 Configuration REQUIREMeNTS 7
4.2 Configuration Files to be provided by Integration Project 7
4.3 Da Vinci Parameter Configuration Changes 7
4.4 DaVinci Interrupt Configuration Changes 7
4.5 Manual Configuration Changes 7
5 Integration DATAFLOW REQUIREMENTS 8
5.1 Required Global Data Inputs 8
5.2 Required Global Data Outputs 8
5.3 Specific Include Path present 8
Abbrevations And Acronyms
Abbreviation | Description |
DFD | Design functional diagram |
MDD | Module design Document |
References
This section lists the title & version of all the documents that are referred for development of this document
Sr. No. | Title | Version |
1 | FDD : NM100A_ MotVelCtrl_Design | See Synergy sub project version |
2 | Software Naming Conventions | 2.0 |
3 | Software Design and Coding Standards | 2.1 |
4 | Integration Manual Template | 1.3 |
Dependencies
SWCs
Module | Required Feature |
None |
Global Functions(Non RTE) to be provided to Integration Project
None
Configuration REQUIREMeNTS
Build Time Config
Modules | Notes | |
None |
Configuration Files to be provided by Integration Project
None
Da Vinci Parameter Configuration Changes
Parameter | Notes | SWC |
None |
DaVinci Interrupt Configuration Changes
ISR Name | VIM # | Priority Dependency | Notes |
None |
Manual Configuration Changes
Constant | Notes | SWC |
None |
Integration DATAFLOW REQUIREMENTS
Required Global Data Inputs
Refer DataDict.m file
Required Global Data Outputs
Refer DataDict.m file
Specific Include Path present
No
Runnable Scheduling
This section specifies the required runnable scheduling.
Init | Scheduling Requirements | Trigger |
MotVelCtrlInit1 | None | RTE (Init) |
Runnable | Scheduling Requirements | Trigger |
MotVelCtrlPer1 | None | RTE (2ms) |
Server Runnable | Scheduling Requirements | Trigger |
GetCtrlPrm_Oper | None | On event |
SetCtrlPrm_Oper | None | On event |
StopCtrl_Oper | None | On event |
StrtCtrl_Oper | None | On event |
Memory Map REQUIREMENTS
Mapping
Memory Section | Contents | Notes |
None | ||
* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.
Usage
Feature | RAM | ROM |
None |
Table 1: ARM Cortex R4 Memory Usage
NvM Blocks
None
Compiler Settings
Preprocessor MACRO
None.
Optimization Settings
None.
Appendix
None
4.2 - MotVelCtrl_MDD
Module Design Document
For
MotVelCtrl
May 4, 2016
Prepared For:
Software Engineering
Nexteer Automotive,
Saginaw, MI, USA
Prepared By:
Nick Saxton,
Nexteer Automotive,
Saginaw, MI, USA
Change History
Description | Author | Version | Date |
Initial Version | Sankardu Varadapureddi | 1 | 17-Feb-2016 |
Input name change | Nick Saxton | 2 | 04-May-2016 |
Table of Contents
2 MotVelCtrl High-Level Description 6
3 Design details of software module 7
3.1 Graphical representation of MotVelCtrl 7
4.1 Program (fixed) Constants 8
5 Software Component Implementation 9
5.1.2.2 Store Module Inputs to Local copies 9
5.1.2.3 (Processing of function)……… 9
5.1.2.4 Store Local copy of outputs into Module Outputs 9
5.2.1.2 (Processing of function)……… 9
5.2.2.2 (Processing of function)……… 9
5.2.3.2 (Processing of function)……… 10
5.2.4.2 (Processing of function)……… 10
5.4 Module Internal (Local) Functions 10
5.5 GLOBAL Function/Macro Definitions 11
6 Known Limitations with Design 12
Appendix A Abbreviations and Acronyms 14
Introduction
Purpose
Scope
MotVelCtrl High-Level Description
Refer to FDD
Design details of software module
Graphical representation of MotVelCtrl
Data Flow Diagram
Refer FDD
Component level DFD
Function level DFD
Constant Data Dictionary
Program (fixed) Constants
Embedded Constants
Constant Name | Resolution | Units | Value |
---|---|---|---|
ONEOVERTWOMPLR_ULS_F32 | 1 | Cnt | 0.5 |
For other constants, refer .m file.
Local Constants
Software Component Implementation
Sub-Module Functions
Init: MotVelCtrlInit1
Design Rationale
Refer FDD
Module Outputs
Refer FDD
Per: MotVelCtrlPer1
Design Rationale
Refer FDD
Store Module Inputs to Local copies
Refer FDD
(Processing of function)………
Refer FDD
Store Local copy of outputs into Module Outputs
Refer FDD
Server Runables
GetCtrlPrm_Oper
Design Rationale
Refer FDD
(Processing of function)………
Refer FDD
SetCtrlPrm_Oper
Design Rationale
Refer FDD
(Processing of function)………
Refer FDD
StopCtrl_Oper
Design Rationale
Refer FDD
(Processing of function)………
Refer FDD
StrtCtrl_Oper
Design Rationale
Refer FDD
(Processing of function)………
Refer FDD
Interrupt Functions
None
Module Internal (Local) Functions
Local Function #1
Function Name | FPIDControl | Type | Min | Max | |
Arguments Passed | MotVelTarSlewed_MotRadPerSec_T_f32 | float32 | - 183500 | 183500 | |
MotVelCrf_MotRadPerSec_T_f32 | float32 | -1350 | 1350 | ||
Return Value | PIDCmdLimid_MotNwtMtr_T_f32 | float32 | -8.8 | 8.8 |
Description
Blocks "F_PID Control_1" , "F_PID Control_2" and "F_PID Control_3" are of same functionality in the FDD. This sub function corresponds to those blocks implementation.
GLOBAL Function/Macro Definitions
None
Known Limitations with Design
None.
UNIT TEST CONSIDERATION
None
Abbreviations and Acronyms
Abbreviation or Acronym | Description |
---|---|
Glossary
Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:
ISO 9000
ISO/IEC 12207
ISO/IEC 15504
Automotive SPICE® Process Reference Model (PRM)
Automotive SPICE® Process Assessment Model (PAM)
ISO/IEC 15288
ISO 26262
IEEE Standards
SWEBOK
PMBOK
Existing Nexteer Automotive documentation
Term | Definition | Source |
---|---|---|
MDD | Module Design Document | |
DFD | Data Flow Diagram |
References
Ref. # | Title | Version |
---|---|---|
1 | AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf) | v1.3.0 R4.0 Rev 2 |
2 | MDD Guideline | EA4 01.00.01 |
3 | Software Naming Conventions.doc | 2.0 |
4 | Software Design and Coding Standards.doc | 2.1 |
5 | FDD : NM100A_ MotVelCtrl_Design | See Synergy sub project version |
4.3 - MotVelCtrl_Review
Overview
Summary SheetSynergy Project
Source Code
PolySpace
Sheet 1: Summary Sheet

Sheet 2: Synergy Project
Sheet 3: Source Code
Rev 1.2 | 8-Jun-15 | |||||||||||||||||||||||
Peer Review Meeting Log (Source Code Review) | ||||||||||||||||||||||||
Source File Name: | MotVelCtrl.c | Source File Revision: | 3 | |||||||||||||||||||||
Header File Name: | Header File Revision: | |||||||||||||||||||||||
MDD Name: | MotVelCtrl_MDD.docx | Revision: | 2 | |||||||||||||||||||||
FDD/SCIR/DSR/FDR/CM Name: | NM100A_MotVelCtrl_Design | Revision: | 1.4.0 | |||||||||||||||||||||
Quality Check Items: | ||||||||||||||||||||||||
Rationale is required for all answers of No | ||||||||||||||||||||||||
Working EA4 Software Naming Convention followed: | ||||||||||||||||||||||||
for variable names | Yes | Comments: | ||||||||||||||||||||||
for constant names | Yes | Comments: | ||||||||||||||||||||||
for function names | N/A | Comments: | ||||||||||||||||||||||
for other names (component, memory | N/A | Comments: | ||||||||||||||||||||||
mapping handles, typedefs, etc.) | ||||||||||||||||||||||||
All paths assign a value to outputs, ensuring | Yes | Comments: | ||||||||||||||||||||||
all outputs are initialized prior to being written | ||||||||||||||||||||||||
Requirements Tracability tags in code match the requirements tracability in the FDD | N/A | Comments: | ||||||||||||||||||||||
requirements tracability in the FDD | ||||||||||||||||||||||||
All variables are declared at the function level. | Yes | Comments: | ||||||||||||||||||||||
Synergy version matches change history | Yes | Comments: | ||||||||||||||||||||||
and Version Control version in file comment block | ||||||||||||||||||||||||
Change log contains detailed description of changes | Yes | Comments: | ||||||||||||||||||||||
and Work CR number | ||||||||||||||||||||||||
Code accurately implements FDD (Document or Model) | Yes | Comments: | ||||||||||||||||||||||
Verified no Compiler Errors or Warnings | Yes | Comments: | ||||||||||||||||||||||
Component.h is included | N/A | Comments: | ||||||||||||||||||||||
All other includes are actually needed. (System includes | N/A | Comments: | ||||||||||||||||||||||
only allowed in Nexteer library components) | ||||||||||||||||||||||||
Software Design and Coding Standards followed: | Version: 2.1 | |||||||||||||||||||||||
Code comments are clear, correct, and adequate | Yes | Comments: | ||||||||||||||||||||||
and have been updated for the change: [N40] and | ||||||||||||||||||||||||
all other rules in the same section as rule [N40], | ||||||||||||||||||||||||
plus [N75], [N12], [N23], [N33], [N37], [N38], | ||||||||||||||||||||||||
[N48], [N54], [N77], [N79], [N72] | ||||||||||||||||||||||||
Source file (.c and .h) comment blocks are per | Yes | Comments: | ||||||||||||||||||||||
standards and contain correct information: [N41], [N42] | ||||||||||||||||||||||||
Function comment blocks are per standards and | N/A | Comments: | ||||||||||||||||||||||
contain correct information: [N43] | ||||||||||||||||||||||||
Code formatting (indentation, placement of | Yes | Comments: | ||||||||||||||||||||||
braces, etc.) is per standards: [N5], [N55], [N56], | ||||||||||||||||||||||||
[N57], [N58], [N59] | ||||||||||||||||||||||||
Embedded constants used per standards; no | Yes | Comments: | ||||||||||||||||||||||
"magic numbers": [N12] | ||||||||||||||||||||||||
Memory mapping for non-RTE code | N/A | Comments: | ||||||||||||||||||||||
is per standard | ||||||||||||||||||||||||
All execution-order-dependent code can be | Yes | Comments: | ||||||||||||||||||||||
recognized by the compiler: [N80] | ||||||||||||||||||||||||
All loops have termination conditions that ensure | N/A | Comments: | ||||||||||||||||||||||
finite loop iterations: [N63] | ||||||||||||||||||||||||
All divides protect against divide by zero | N/A | Comments: | ||||||||||||||||||||||
if needed: [N65] | ||||||||||||||||||||||||
All integer division and modulus operations | N/A | Comments: | ||||||||||||||||||||||
handle negative numbers correctly: [N76] | ||||||||||||||||||||||||
All typecasting and fixed point arithmetic, | N/A | Comments: | ||||||||||||||||||||||
including all use of fixed point macros and | ||||||||||||||||||||||||
timer functions, is correct and has no possibility | ||||||||||||||||||||||||
of unintended overflow or underflow: [N66] | ||||||||||||||||||||||||
All float-to-unsiged conversions ensure the. | N/A | Comments: | ||||||||||||||||||||||
float value is non-negative: [N67] | ||||||||||||||||||||||||
All conversions between signed and unsigned | N/A | Comments: | ||||||||||||||||||||||
types handle msb==1 as intended: [N78] | ||||||||||||||||||||||||
All pointer dereferencing protects against | N/A | Comments: | ||||||||||||||||||||||
null pointer if needed: [N70] | ||||||||||||||||||||||||
Component outputs are limited to the legal range | Yes | Comments: | ||||||||||||||||||||||
defined in the FDD DataDict.m file : [N53] | ||||||||||||||||||||||||
All code is mapped with FDD (all FDD | Yes | Comments: | ||||||||||||||||||||||
subfunctions and/or model blocks identified | ||||||||||||||||||||||||
with code comments; all code corresponds to | ||||||||||||||||||||||||
some FDD subfunction and/or model block): [N40] | ||||||||||||||||||||||||
Review did not identify violations of other | Yes | Comments: | ||||||||||||||||||||||
coding standard rules | ||||||||||||||||||||||||
Anomaly or Design Work CR created | N/A | Comments: List Anomaly or CR numbers | ||||||||||||||||||||||
for any FDD corrections needed | ||||||||||||||||||||||||
General Notes / Comments: | ||||||||||||||||||||||||
Change Owner: | Nick Saxton | Review Date : | 07/11/16 | |||||||||||||||||||||
Lead Peer Reviewer: | Krishna Anne | Approved by Reviewer(s): | Yes | |||||||||||||||||||||
Other Reviewer(s): | ||||||||||||||||||||||||