This is the multi-page printable view of this section. Click here to print.
Component Design
1 - SF001A_Assi_Design_PeerReviewChkList
Overview
Peer Review InstructionsTechnical Review Checklist
Template Change Log
Sheet 1: Peer Review Instructions
Instructions for Functional Design Package Peer Review | ||
PRE-MEETING | ||
Function Owner | Confirm that requirements are reviewed and approved PRIOR to the FDP peer review | |
Function Owner | Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews | |
Function Owner | Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review | |
Function Owner | Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting | |
Function Owner | Identify necessary attendance and invite to meeting | |
Function Owner | Complete the "Author" column information for sections 1 through 5 prior to the review | |
Function Owner | Complete the attendance invitation list in section 7 | |
Function Owner | For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews. | |
DURING MEETING | ||
Function Owner | Present document changes to the review team | |
Peer Reviewer | Capture attendance of the review | |
Peer Reviewer | Capture actions and issues in section 6. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN" | |
POST MEETING | ||
Function Owner | Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided. | |
Function Owner | Schedule follow up review OR review open items with peer reviewer and obtain agreement to close | |
Peer Reviewer | Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates |
Sheet 2: Technical Review Checklist
Sheet 3: Template Change Log
Rev | Change | Author |
01.00.05 | Added lesson learned #3.5 | MDK |
01.00.06 | Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models. | MDK |
02.00.00 | Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD. | K. Derry |
02.01.00 | Added: Does FDD.DesignASIL match requirements? Added: Was webview model created without requirements highlighted? Removed: Redundant row in Data Dictionary section. Formatting: Column C now consistently center-justified. | K. Derry |
02.02.00 | Added: Are all data types represented by released Data_Management classes? Removed: Are all runnables defined? Rationale: Automated tools checking. Removed: Does the Component shortname match data dictionary FDD metadata? Removed: "Data store name must resolve to Simulink signal object" Edited: Model Advisor report should now be left unzipped. | K. Derry |
2 - SF001A_Assi_ModelAdvisor
Model Advisor Report - SF001A_Assi.slx | |
Simulink version: 8.2 | Model version: 1.240 |
System: SF001A_Assi | Current run: 08-Aug-2016 11:26:07 |
Model Advisor configuration: ...NxtrModelAdvisorConfig.mat |
Run Summary
Pass | Fail | Warning | Not Run | Total |
| | | | 200 |
You should turn on the following optimization(s):
none . | |
Identify Inport blocks in the top-level of the model with missing or inherited sample times, data types, or port dimensions
Warning
The following Inport blocks have undefined or inherited sample times, data types or port dimensions
Inport | Link | Conditions |
1 | SF001A_Assi/In2 | Missing port dimension Missing signal data type Missing port sample time |
2 | SF001A_Assi/In3 | Missing port dimension Missing signal data type Missing port sample time |
3 | SF001A_Assi/In4 | Missing port dimension Missing signal data type Missing port sample time |
4 | SF001A_Assi/In5 | Missing port dimension Missing signal data type Missing port sample time |
5 | SF001A_Assi/In6 | Missing port dimension Missing signal data type Missing port sample time |
6 | SF001A_Assi/In7 | Missing port dimension Missing signal data type Missing port sample time |
7 | SF001A_Assi/In8 | Missing port dimension Missing signal data type Missing port sample time |
8 | SF001A_Assi/In9 | Missing port dimension Missing signal data type Missing port sample time |
9 | SF001A_Assi/In10 | Missing port dimension Missing signal data type Missing port sample time |
Recommended Action
Explicitly define all missing Inport block properties identified in the results
- Missing port dimension: Model contains Inport blocks with inherited port dimension (-1). Specify port dimension for the listed Inport blocks.
- Missing signal data type: Model contains Inport blocks with inherited data type. Specify a data type for the listed Inport blocks.
- Missing port sample time: Model contains Inport blocks with inherited sample time (-1). Specify sample time information for the listed Inport blocks. Note: The sample time of root Inports with bus type must match the sample times specified at the leaf elements of the bus object.
Check Simulink blocks and Stateflow objects that do not link to a requirements document
Warning
The following blocks do not link to a requirement document:
- SF001A_Assi/In2
- SF001A_Assi/In3
- SF001A_Assi/In4
- SF001A_Assi/In5
- SF001A_Assi/In6
- SF001A_Assi/In7
- SF001A_Assi/In8
- SF001A_Assi/In9
- SF001A_Assi/In10
- SF001A_Assi/Assi
- SF001A_Assi/Assi/call_AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1/VehSpd
- SF001A_Assi/Assi/AssiPer1/WhlImbRejctnAmp
- SF001A_Assi/Assi/AssiPer1/AssiLnrGainEna
- SF001A_Assi/Assi/AssiPer1/AssiLnrGain
- SF001A_Assi/Assi/AssiPer1/ThermLimSlowFilMax
- SF001A_Assi/Assi/AssiPer1/function
- SF001A_Assi/Assi/AssiPer1/Constant
- SF001A_Assi/Assi/AssiPer1/CopyRight2
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/ModHwTrq
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/AssiLnrGain
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/Action Port
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/CopyRight2
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/Product
- SF001A_Assi/Assi/AssiPer1/End If
- SF001A_Assi/Assi/AssiPer1/FltInj_Sim
- SF001A_Assi/Assi/AssiPer1/From1
- SF001A_Assi/Assi/AssiPer1/From2
- SF001A_Assi/Assi/AssiPer1/From3
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/VehSpd
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/ModHwTq
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/WhlImbRejctnAmp
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Action Port
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/CopyRight2
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_s1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_s16
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_u1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_u16
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f2
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f3
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f32
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From2
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From3
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From4
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From5
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Goto
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Goto1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/LnrIntrpn_u16_u16VariXu16VariY
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Product
- SF001A_Assi/Assi/AssiPer1/Sign_s08_f32
- SF001A_Assi/Assi/AssiPer1/AssiCmdBas
- SF001A_Assi/Assi/CopyRight2
- SF001A_Assi/Assi/Display1
- SF001A_Assi/Assi/Display2
- SF001A_Assi/CopyRight2
- SF001A_Assi/Function_Call_Generator
- SF001A_Assi/Out1
Recommended Action
For each object in the list, in the Model Editor, right-click the block, select Requirements, and specify a requirement.
Identify names of Inport or Outport blocks that use characters that are not correct in C code.
See Also
The following Inport and Outport block names contain incorrect characters:
Error | Incorrect port block |
Name contains incorrect characters. | SF001A_Assi/Assi/call_AssiPer1 |
Recommended Action
Rename the Inport or Outport blocks to use correct characters.
Identify levels in the model that include basic blocks and subsystems. Each level of a model must be designed with blocks of the same level (for example, only subsystems or only basic blocks).
See Also
The following level(s) in the model include basic blocks and subsystems:
∧ Less
Recommended Action
If possible, replace blocks at the identified level of the model hierarchy with basic blocks. Move nonvirtual blocks into the identified subsystem.
Identify nonstandard display attributes in Simulink diagrams.
See Also
Check format settings
Identify incorrect model-level format options.
Warning
The following format display options are incorrect.
Display Attribute | Recommended Value | Actual Value |
Display > Signals & Ports > Wide Nonscalar Lines | on | off |
View > Model Browser Options > Model Browser | off | on |
Recommended Action
Set the format options to the recommended value.
_________________________________________________________________________________________
Check block colors
Identify blocks using nonstandard colors.
Warning
The following blocks use nonstandard colors:
- SF001A_Assi/Assi/AssiCmdBas
- SF001A_Assi/Assi/AssiCmdBasSca
- SF001A_Assi/Assi/AssiLnrGain
- SF001A_Assi/Assi/AssiLnrGainEna
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1/AssiCmdBas
- SF001A_Assi/Assi/AssiPer1/AssiCmdBasSca
- SF001A_Assi/Assi/AssiPer1/AssiLnrGain
- SF001A_Assi/Assi/AssiPer1/AssiLnrGainEna
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/AssiLnrGain
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/ModHwTrq
- SF001A_Assi/Assi/AssiPer1/From1
- SF001A_Assi/Assi/AssiPer1/From2
- SF001A_Assi/Assi/AssiPer1/From3
- SF001A_Assi/Assi/AssiPer1/Goto
- SF001A_Assi/Assi/AssiPer1/Goto1
- SF001A_Assi/Assi/AssiPer1/HwTq
- SF001A_Assi/Assi/AssiPer1/HwTqHysOvrl
- SF001A_Assi/Assi/AssiPer1/HwTqOvrl
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/AssistTrq
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From2
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From3
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From4
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/From5
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Goto
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Goto1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/ModHwTq
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/ThermLimSlowFilMax
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/VehSpd
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/WhlImbRejctnAmp
- SF001A_Assi/Assi/AssiPer1/ThermLimSlowFilMax
- SF001A_Assi/Assi/AssiPer1/VehSpd
- SF001A_Assi/Assi/AssiPer1/WhlImbRejctnAmp
- SF001A_Assi/Assi/HwTq
- SF001A_Assi/Assi/HwTqHysOvrl
- SF001A_Assi/Assi/HwTqOvrl
- SF001A_Assi/Assi/ThermLimSlowFilMax
- SF001A_Assi/Assi/VehSpd
- SF001A_Assi/Assi/WhlImbRejctnAmp
- SF001A_Assi/Assi/call_AssiPer1
Recommended Action
Set the block foreground color to black and the background color to white.
_________________________________________________________________________________________
Check canvas colors
Identify canvases that are not white.
Passed
All diagrams use a white canvas.
_________________________________________________________________________________________
Check diagram zoom
Identify diagrams that do not have zoom factor set to 100 %.
Warning
The following diagrams do not have zoom factor set to 100 percent:
For each listed diagram, select View > Zoom > Normal View (100%).
Identify Trigger and Enable blocks that are not centered in the upper third of the model diagram.
See Also
The following Trigger and Enable blocks are not centered in the upper third of the model diagram:
- SF001A_Assi/Assi/AssiPer1/function
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/Action Port
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Action Port
Move the above Trigger or Enable blocks such that it is centered in the upper third of the model diagram.
Identify blocks that require labeled signals. A subset of source and destination blocks require labeled signals.
See Also
Check source block labels
The following source blocks require labeled signals; Inport, From, Data Store Read, Constant, Bus Selector, Demux, Selector. If the signal name is visible on the block, this rule is considered met.
Warning
The following signals have no label:
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi
- SF001A_Assi/Assi
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
- SF001A_Assi/Assi/AssiPer1/Normal_Operation
Recommended Action
Add a new or propagated label to the signal line.
_________________________________________________________________________________________
Check destination block labels
The following destination blocks require labeled signals; Outport, Goto, Data Store Write, Bus Creator, Mux, Subsystem, Chart. If the signal name is visible on the source block, this rule is considered met.
Warning
The following signals have no label:
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/AssiTq/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/AssistTrq/
- SF001A_Assi/Assi/AssiPer1/AssiCmdBas/
- SF001A_Assi/Assi/AssiCmdBas/
- SF001A_Assi/Out1/
- SF001A_Assi/Assi/AssiPer1/Goto/
- SF001A_Assi/Assi/AssiPer1/Goto1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Goto/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Goto1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/AsstThermScalar/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/Asst_WIRBlend/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/
- SF001A_Assi/Assi/AssiPer1/Defeat_Tables/
- SF001A_Assi/Assi/AssiPer1/FltInj_Sim/
- SF001A_Assi/Assi/AssiPer1/FltInj_Sim/
- SF001A_Assi/Assi/AssiPer1/LimStat_f1/
- SF001A_Assi/Assi/AssiPer1/LimStat_f32/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/BilnrIntrpnWithRound_s16_u16MplXs16MplY1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/BilnrIntrpnWithRound_s16_u16MplXs16MplY1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/BilnrIntrpnWithRound_s16_u16MplXs16MplY2/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/BilnrIntrpnWithRound_s16_u16MplXs16MplY2/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/BilnrIntrpnWithRound_u16_u16MplXu16MplY/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/BilnrIntrpnWithRound_u16_u16MplXu16MplY/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_s1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_s16/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_u1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FixdToFloat_f32_u16/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f1/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f2/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f3/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/FloatToFixd_u16_f32/
- SF001A_Assi/Assi/AssiPer1/Normal_Operation/LnrIntrpn_u16_u16VariXu16VariY/
Recommended Action
Add a new or propagated label to the signal line.
Identify blocks that are not allowed in discrete controllers. Prohibited blocks include all continuous blocks and some source and sink blocks.
See Also
- MathWorks Automotive Advisory Board Guideline: jm_0001
- Check for blocks not recommended for C/C++ production code deployment
All blocks in the model are allowed in discrete controllers.
Inconsistencies:
The following requirements link to invalid locations within their documents. The specified location (e.g., bookmark, line number, anchor) within the requirements document could not be found. To resolve this issue, edit each requirement and specify a valid location within its requirements document. Block Requirements REQ: SF001A_54 SF001A_Assi/Assi/AssiPer1/Normal_Operation/ThermLimSlowFilMax
REQ: SF001A_53 REQ: SF001A_53 REQ: SF001A_52
This model contains the following C-MEX S-functions:
ID | S-Function | Block |
1 | C:\Users\hzq8v7\Documents\MATLAB\FDD_lib\Nexteer_Utilities v4.7.0\EA4_Library\Math\Abslt_f32_f32.mexw64 | SF001A_Assi/Assi/AssiPer1/Abslt_f32_f32 |
2 | C:\Users\hzq8v7\Documents\MATLAB\FDD_lib\Nexteer_Utilities v4.7.0\EA4_Library\Math\Blnd_f32.mexw64 | SF001A_Assi/Assi/AssiPer1/Normal_Operation/Blnd_f32 |
3 | C:\Users\hzq8v7\Documents\MATLAB\FDD_lib\Nexteer_Utilities v4.7.0\EA4_Library\Math\Sign_s08_f32.mexw64 | SF001A_Assi/Assi/AssiPer1/Sign_s08_f32 |
Consider setting Solver data inconsistency [?] to either error
or warning
(currently set to none
) to validate whether S-functions adhere to the ODE solver consistency rules that Simulink applies to its built-in blocks.
Consider setting ArrayBounds exceeded [?]to either error
or warning
(currently set to none
) to check if S-functions are writing outside array boundaries.
Note: These runtime diagnostics may slow down simulation considerably. You should set them back to none
once you have verified that they do not cause any warnings or errors during simulation.