This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Implementation

1 - AssiPahFwl_IntegrationManual

Integration Manual

For

SF034A_AssiPahFwl

VERSION: 1.0

DATE: 05-Feb-2016

Prepared By:

Sarika Natu,

KPIT Technologies,

India

Location: The official version of this document is stored in the Nexteer Configuration Management System.

Revision History

DescriptionAuthorVersionDate
Initial versionSarika Natu1.005-Feb-2016

Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

AbbreviationDescription
DFDDesign functional diagram
MDDModule design Document
<ADD more to the table if applicable>

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.TitleVersion
1MDD GuidelineEA4 01.00.01
2Software Naming Conventions.doc2.0
3Software Design and Coding Standards.doc2.1
4AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)v1.3.0 R4.0 Rev 2
5SF044A_HowDetn_DesignPlease refer synergy subproject version

Dependencies

SWCs

ModuleRequired Feature
None

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

ModulesNotes
None

Configuration Files to be provided by Integration Project

None

Da Vinci Parameter Configuration Changes

ParameterNotesSWC
None

DaVinci Interrupt Configuration Changes

ISR NameVIM #Priority DependencyNotes
None

Manual Configuration Changes

ConstantNotesSWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file

Required Global Data Outputs

Refer DataDict.m file

Specific Include Path present

No

Runnable Scheduling

This section specifies the required runnable scheduling.

InitScheduling RequirementsTrigger
AssiPahFwlInit1NoneRTE (Init)
RunnableScheduling RequirementsTrigger
AssiPahFwlPer1NoneRTE(2ms)

.

Memory Map REQUIREMENTS

Mapping

Memory SectionContentsNotes
AssiPahFwl_START_SEC_CODE
AssiPahFwl_STOP_SEC_CODE

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

FeatureRAMROM
<Memmap usuage info>

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

None

Compiler Settings

Preprocessor MACRO

None

Optimization Settings

None

Appendix

None

2 - AssiPahFwl_MDD

Module Design Document

For

AssiPahFwl

Feb 05, 2016

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

Sarika Natu,

KPIT Technologies,

India


Change History

DescriptionAuthorVersionDate
Initial VersionSarika Natu(KPIT Technologies)1.005-Feb-2016


Table of Contents

1 AssiPahFwl & High-Level Description 5

2 Design details of software module 6

2.1 Graphical representation of AssiPahFwl 6

2.2 Data Flow Diagram 6

2.2.1 Component level DFD 6

2.2.2 Function level DFD 6

3 Constant Data Dictionary 7

3.1 Program (fixed) Constants 7

3.1.1 Embedded Constants 7

4 Software Component Implementation 8

4.1 Sub-Module Functions 8

4.1.1 Init: AssiPahFwl_Init1 8

4.1.1.1 Design Rationale 8

4.1.1.2 Module Outputs 8

4.1.2 Per: AssiPahFwl_Per1 8

4.1.2.1 Design Rationale 8

4.1.2.2 Store Module Inputs to Local copies 8

4.1.2.3 (Processing of function)……… 8

4.1.2.4 Store Local copy of outputs into Module Outputs 8

4.2 Server Runables 8

4.3 Interrupt Functions 8

4.4 Module Internal (Local) Functions 8

4.4.1 Local Function #1 8

4.4.1.1 Design Rationale 9

4.4.1.2 Processing 9

4.4.2 Local Function #2 9

4.4.2.1 Design Rationale 9

4.4.2.2 Processing 9

4.4.3 Local Function #3 9

4.4.3.1 Design Rationale 9

4.4.3.2 Processing 10

4.4.4 Local Function #4 10

4.4.4.1 Design Rationale 10

4.4.4.2 Processing 10

4.4.5 Local Function #5 10

4.4.5.1 Design Rationale 10

4.4.5.2 Processing 10

4.5 GLOBAL Function/Macro Definitions 11

5 Known Limitations with Design 12

6 UNIT TEST CONSIDERATION 13

Appendix A Abbreviations and Acronyms 14

Appendix B Glossary 15

Appendix C References 16

AssiPahFwl & High-Level Description

Refer FDD

Design details of software module

Graphical representation of AssiPahFwl

Data Flow Diagram

Refer FDD

Component level DFD

Refer FDD

Function level DFD

Refer FDD

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Local Constants

Constant NameResolutionUnitsValue
NODEBSTEP_CNT_U16NANA65535U

Software Component Implementation

Sub-Module Functions

Init: AssiPahFwl_Init1

Design Rationale

Refer FDD

Module Outputs

Refer FDD

Per: AssiPahFwl_Per1

Design Rationale

Refer FDD

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Server Runnables

None

Interrupt Functions

None

Module Internal (Local) Functions

Local Function #1

Function NameDynamic_Assi_BoundaryTypeMinMax
Arguments PassedVehSpd_Kph_T_u9p7Uint160511
HwTq_HwNwtMtr_T_f32Float32-10.010.0
LoFrqInp_MotNwtMtr_T_f32Float32-1616
*LowrBndLpFil_MotNwtMtr_T_f32Float32*-1616
*UpprBndLpFil_MotNwtMtr_T_f32Float32*-1616
Return ValueHiFrqAssiLimd_MotNwtMtr_T_f32Float32-1616

Design Rationale

LowrBndLpFil_MotNwtMtr_T_f32 and UpprBndLpFil_MotNwtMtr_T_f32 will be updated in this function.

Processing

Refer to the subsystems 'Determine HiFreqAsst Boundaries' and 'Low pass filter boundaries' in FDD.

Local Function #2

Function NameBase_Assi_BoundaryTypeMinMax
Arguments PassedHwTrq_HwNwtMtr_T_f32Float32-20.020.0
VehSpd_Kph_T_u9p7Uint160511
AssiCmdBas_MotNwtMtr_T_f32Float32-8.88.8
BasAssiLowrBnd_MotNwtMtr_T_f32float32*-1616
BasAssiUpprBnd_MotNwtMtr_T_f32float32*-1616
Return ValueBasAssiLimd_MotNwtMtr_T_f32Float32-1616

Design Rationale

BasAssiLowrBnd_MotNwtMtr_T_f32 and BasAssiUpprBnd_MotNwtMtr_T_f32 will be updated in this function

Processing

Refer the subsystem ‘Determine_BaseAsst_Boundaries’ implementation in FDD.

Local Function #3

Function NameDet_Boundary_LimTypeMinMax
Arguments PassedAssiCmdBas_MotNwtMtr_T_f32Float32-8.88.8
BasAssiUpprBnd_MotNwtMtr_T_f32Float32-1616
BasAssiLowrBnd_MotNwtMtr_T_f32Float32-1616
LowrBndLpFil_MotNwtMtr_T_f32Float32-1616
UpprBndLpFil_MotNwtMtr_T_f32Float32-1616
LoFrqInp_MotNwtMtr_T_f32Float32-1616
HiFrqOverBnd_MotNwtMtr_T_LoglBoolean*FALSETRUE
BasAssiOverBnd_MotNwtMtr_T_LoglBoolean*FALSETRUE
Return ValueAssiFwlFailSts_Cnt_T_LoglBooleanFALSETRUE

Design Rationale

HiFrqOverBnd_MotNwtMtr_T_Logl and BasAssiOverBnd_MotNwtMtr_T_Logl will be updated in this function.

Processing

Refer to the section ‘Check both command paths for reaching boundary limits, if so begin de bounce counters’ in FDD.

Local Function #4

Function NameAssist_Recovery_CondTypeMinMax
Arguments PassedAssiCmdBas_MotNwtMtr_T_f32Float32-8.88.8
DftAssi_MotNwtMtr_T_f32Float32-8.88.8
AssiFwlFailSts_Cnt_T_LoglBooleanFASLETRUE
SumInp_MotNwtMtr_T_f32Float32-17.617.6
BasAssiLimd_MotNwtMtr_T_f32Float32-1616
HiFrqInp_MotNwtMtr_T_f32Float32-1616
HiFrqAssiLimd_MotNwtMtr_T_f32Float32-1616
BasAssiOverBnd_MotNwtMtr_T_LoglBooleanFALSETRUE
HiFrqOverBnd_MotNwtMtr_T_LoglBooleanFALSETRUE
*AssiPahLimrActv_Uls_T_f32Float32FASLETRUE
Return ValueCombdAssiDft_MotNwtMtr_T_f32Float32-8.88.8

Design Rationale

AssiPahLimrActv_Uls_T_f32 will be updated in this function

Processing

Refer to the section ‘Check Input commands vs. Fwl Output command for Assist Recovery Conditions’ in FDD.

Local Function #5

Function NameSet_FaultsTypeMinMax
Arguments PassedHiFrqOverBnd_MotNwtMtr_T_LoglBooleanFASLETRUE
BasAssiOverBnd_MotNwtMtr_T_LoglBooleanFASLETRUE
Return ValueNone

Design Rationale

None

Processing

Refer ‘Set_Faults’ subsystem in FDD.

GLOBAL Function/Macro Definitions

None

Known Limitations with Design

UNIT TEST CONSIDERATION

None

Abbreviations and Acronyms

Abbreviation or AcronymDescription

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

  • ISO 9000

  • ISO/IEC 12207

  • ISO/IEC 15504

  • Automotive SPICE® Process Reference Model (PRM)

  • Automotive SPICE® Process Assessment Model (PAM)

  • ISO/IEC 15288

  • ISO 26262

  • IEEE Standards

  • SWEBOK

  • PMBOK

  • Existing Nexteer Automotive documentation

TermDefinitionSource
MDDModule Design Document
DFDData Flow Diagram

References

Ref. #TitleVersion
1AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)v1.3.0 R4.0 Rev 2
2MDD GuidelineEA4 01.00.00
3Software Naming Conventions.doc2.0
4Software Design and Coding Standards.doc2.1

3 - AssiPahFwl_PeerReview


Overview

Summary Sheet
Synergy Project
Davinci Files
Source Code
MDD
Integration Manual
PolySpace


Sheet 1: Summary Sheet
























Rev 1.28-Jun-15

Peer Review Summary Sheet


























Synergy Project Name:


kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. SF034A_AssiPahFwl_Impl
Revision / Baseline:


kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. SF034A_AssiPahFwl_Impl_1.1.0

























Change Owner:


kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Sarika Natu (KPIT)
Work CR ID:


EA4#3608





























kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:















































































































































































kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:






















































Reviewed:































YesMDD


YesSource Code


YesPolySpace









































YesIntegration Manual


YesDavinci Files








































































Comments:

Created a revision 1.1.0 of the component to correct the issues in the review checklist and used
NODEBSTEP_CNT_U16 in the Set_NTC function




























































































General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.





















Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)



















































Quality Check Items:




































Rationale is required for all answers of No










New baseline version name from Summary Sheet follows








Yes
Comments:



naming convention





































Project contains necessary subprojects








Yes
Comments:










































Project contains the correct version of subprojects








Yes
Comments:










































Design subproject is correct version








Yes
Comments:











































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Basavaraja Ganeshappa
Review Date :

02/15/16


































Lead Peer Reviewer:


Chaitanya
Approved by Reviewer(s):



Yes

































Other Reviewer(s):


















































































Sheet 3: Davinci Files






















Rev 1.28-Jun-15
Peer Review Meeting Log (Davinci Review)


























Quality Check Items:




































Rationale is required for all answers of No










Only StdDef Port types are used








Yes
Comments:










































For components not using application data types, do all








Yes
Comments:



port interface names end in PortIf and a sequence number





























































Non-program-specific components saved








Yes
Comments:




in Autosar 4.0.3 format




































*Cfg.arxml.TT: Verfied Davinci Configurator imported the








N/A
Comments:




change correctly




































*Cfg.h.TT: Verfied Davinci Configurator generates








N/A
Comments:










the configuration header(s) file correctly
kzshz2: Either a generic sandbox or a baselined integration project can be used to verify



























kzshz2: Either a generic sandbox or a baselined integration project can be used to verify
















All changed files have been compared against previous








N/A
Comments:




versions (If available)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.








Initial version
























Automated validation check is performed








Yes
Comments:

























































Naming conventions followed. All names should








Yes
Comments:










match DataDict.m













































Sender/Receiver port properties match DataDict.m








Yes
Comments:










file (use .m file helper tool)













































Calibration port properties match DataDict.m








Yes
Comments:










file (use .m file helper tool)













































Components using application data types:























Sender/Receiver port initialization values match







N/A
Comments:










DataDict.m file














































Calibration port initialization values match







Yes
Comments:










DataDict.m file













































Components not using application data types:























Sender/Receiver port initialization values match







Yes
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Calibration port initialization values match







Yes
Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Mapping set and all unused items have been







Yes
Comments:










removed













































All sender/receiver port read/writes using direct








Yes
Comments:










read/writes(List justification if not)













































Runnable calling frequencies match FDD








Yes
Comments:

































DataDict.m display variables: created as








Yes
Comments:









PerInstanceMemory. Matches the FDD





































Component is correct component type








Yes
Comments:











































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Basavaraja Ganeshappa
Review Date :

02/11/16
Component Type :


Application



























Lead Peer Reviewer:


Nick
Approved by Reviewer(s):



Yes

































Other Reviewer(s):










































































Sheet 4: Source Code






















Rev 1.28-Jun-15
Peer Review Meeting Log (Source Code Review)

























Source File Name:


AssiPahFwl.c

Source File Revision:


2
Header File Name:


N/A

Header File Revision:


kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this. N/A

























MDD Name:

AssiPahFwl_MDD

Revision:
1

























FDD/SCIR/DSR/FDR/CM Name:




SF034A_AssiPahFwl_Design

Revision:
1.1.0


























Quality Check Items:



































Rationale is required for all answers of No









Working EA4 Software Naming Convention followed:















































for variable names







Yes
Comments:

















































for constant names







Yes
Comments:

















































for function names







Yes
Comments:

















































for other names (component, memory







N/A
Comments:










mapping handles, typedefs, etc.)




































All paths assign a value to outputs, ensuring








Yes
Comments:









all outputs are initialized prior to being written





































Requirements Tracability tags in code match the requirements tracability in the FDD








N/A
Comments:









requirements tracability in the FDD











Requirements Tracability is not established in FDD
























All variables are declared at the function level.








Yes
Comments:
























Synergy version matches change history





kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.


Yes
Comments:



and Version Control version in file comment block





































Change log contains detailed description of changes








Yes
Comments:



and Work CR number





































Code accurately implements FDD (Document or Model)








Yes
Comments:










































Verified no Compiler Errors or Warnings


KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used; QAC can find compiler errors but not warnings.





Yes
Comments:
















































Component.h is included








N/A
Comments:
























All other includes are actually needed. (System includes








Yes
Comments:









only allowed in Nexteer library components)





































Software Design and Coding Standards followed:











Version:2.1

























Code comments are clear, correct, and adequate







Yes
Comments:










and have been updated for the change: [N40] and













all other rules in the same section as rule [N40],






















plus [N75], [N12], [N23], [N33], [N37], [N38],






















[N48], [N54], [N77], [N79], [N72]














































Source file (.c and .h) comment blocks are per







Yes
Comments:










standards and contain correct information: [N41], [N42]





































Function comment blocks are per standards and







Yes
Comments:










contain correct information: [N43]





































Code formatting (indentation, placement of







Yes
Comments:










braces, etc.) is per standards: [N5], [N55], [N56],













[N57], [N58], [N59]














































Embedded constants used per standards; no







Yes
Comments:










"magic numbers": [N12]





































Memory mapping for non-RTE code







N/A
Comments:










is per standard





































All execution-order-dependent code can be







Yes
Comments:










recognized by the compiler: [N80]





































All loops have termination conditions that ensure







N/A
Comments:










finite loop iterations: [N63]





































All divides protect against divide by zero







N/A
Comments:










if needed: [N65]





































All integer division and modulus operations







N/A
Comments:










handle negative numbers correctly: [N76]





































All typecasting and fixed point arithmetic,







Yes
Comments:










including all use of fixed point macros and













timer functions, is correct and has no possibility






















of unintended overflow or underflow: [N66]














































All float-to-unsiged conversions ensure the.







Yes
Comments:










float value is non-negative: [N67]





































All conversions between signed and unsigned







N/A
Comments:










types handle msb==1 as intended: [N78]





































All pointer dereferencing protects against







Yes
Comments:










null pointer if needed: [N70]





































Component outputs are limited to the legal range







Yes
Comments:










defined in the FDD DataDict.m file : [N53]





































All code is mapped with FDD (all FDD







Yes
Comments:










subfunctions and/or model blocks identified













with code comments; all code corresponds to






















some FDD subfunction and/or model block): [N40]













































Review did not identify violations of other








Yes
Comments:









coding standard rules





































Anomaly or Design Work CR created








Yes
Comments:









for any FDD corrections needed































































General Notes / Comments:























Use NODEBSTEP_CNT_U16 (= 65535) as the last argument in set ntc. Also put it in mdd too : Fixed on 2/11/2016

Check the naming conventions for static functions and verify that usage of '_' is allowed in the function name : Doesn’t require any fix

NXTRFIXDPT_P8TOFLOAT_ULS_F32 in line nr 941 should be changed : Fixed on 2/11/2016

line nr 942 - check for the consistency in the way array's are passed as arguments to interpolation function : Fixed on 2/11/2016

Check if setting the NTC to passed in init is required as prepassing is done in periodic : Review comment rejected after discussing with function team

Comment on 1.0.0

Add Misra violation comment 16.10 and use NODEBSTEP_CNT_U16 in Set NTC function intialization - Fixed on 2/15/2016


















































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Sarika Natu, Basavaraja Ganeshappa
Review Date :

02/15/16


































Lead Peer Reviewer:


Nick
Approved by Reviewer(s):



Yes

































Other Reviewer(s):


Chaitanya(Reviewed the delta change)














































































Sheet 5: MDD






















Rev 1.28-Jun-15
Peer Review Meeting Log (MDD Review)


























MDD Name:


AssiPahFwl_MDD.doc












MDD Revision:

1


























Source File Name:


AssiPahFwl.c



Source File Revision:


1

Source File Name:



NA










Source File Revision:





Source File Name:



NA










Source File Revision:






























Quality Check Items:




































Rationale is required for all answers of No










Synergy version matches document








Yes
Comments:













































Change log contains detailed description of changes








Yes
Comments:













































Changes Highlighted (for Unit Tester)








N/A
Comments:

















Initial Version


























Diagrams have been included per MDD Guideline








Yes
Comments:











and reviewed






































All Design Exceptions and Limitations are listed








N/A
Comments:



















































Design rationale given for all global








N/A
Comments:











data not communicated through RTE ports, per














Design and Coding Standards rules [N9] and [N10].















































All implementation details that differ from the FDD are








Yes
Comments:











noted and explained in Design Rationale






































All Unit Test Considerations have been described








N/A
Comments:



















































General Notes / Comments:
















































Provide reference to local constant under the section 'Embedded Constants'































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Sarika Natu
Review Date :

02/11/16


































Lead Peer Reviewer:


Nick
Approved by Reviewer(s):



Yes

































Other Reviewer(s):


Sankar






































































Sheet 6: Integration Manual






















Rev 1.28-Jun-15
Peer Review Meeting Log (Integration Manual Review)


























Integration Manual Name:



kzshz2: Intended Use: Identify which file is being reviewed Rationale: Required for traceability. It will help to ensure this sheet is not attached to the wrong design review form. AssiPahFwl_IntegrationManual

Integration Manual Revision:



kzshz2: Intended Use: Identify which version of the integration manual has been reviewed. Rationale: Required for traceability between the MDD and review. Auditors will likely require this. 1





























Quality Check Items:




































Rationale is required for all answers of No










Synergy version matches header








Yes
Comments:










































Latest template used








Yes
Comments:










































Change log contains detailed description of changes








Yes
Comments:
















Initial version



























Changes Highlighted (for Integrator)








N/A
Comments:

















































General Notes / Comments:























Add FDD name in the reference tabel: Fixed on 2/11/2016





































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Basavaraja Ganeshappa


Review Date :

02/11/16
































Lead Peer Reviewer:


Nick


Approved by Reviewer(s):



Yes































Other Reviewer(s):


Sankar






































































Sheet 7: PolySpace






















Rev 1.28-Jun-15
Peer Review Meeting Log (QAC/PolySpace Review)


























Source File Name:



AssiPahFwl.c










Source File Revision:


2

Source File Name:



NA










Source File Revision:


NA

Source File Name:



NA










Source File Revision:


NA


























EA4 Static Analysis Compliance Guideline version:








01.01.00













Poly Space version:


Windows User: eg. 2013b R2013B
Polyspace sub project version:




Windows User: eg. TL108a_PolyspaceSuprt_1.0.0 TL108A_PolySpaceSuprt_1.0.0

QAC version:


Windows User: eg 8.1.1-R 8.1.1-R
QAC sub project version:




Windows User: eg. TL_100A_1.1.0 TL100A_QACSuprt_1.2.0


























Quality Check Items:




































Rationale is required for all answers of No



































Contract Folder's header files are appropriate and





kzshz2: Intended Use: Identify that the contract folder contains only the information required for this component. All other variables, constants, function prototypes, etc. should be removed. Rationale: This will help avoid unit testers having to considers object not used. It will also avoid having other files required for QAC.


Yes
Comments:




function prototypes match the latest component version







































100% Compliance to the EA4 Static AnalysisYes
Comments:





Compliance Guideline





























Are previously added justification and deviation








N/A
Comments:





comments still appropriate










Initial Version


























Do all MISRA deviation comments use approved








Yes
Comments:





deviation tags






































Cyclomatic complexity and Static path count OK






Creager, Kathleen: use Browse Function Metrics, STCYC and STPTH

Yes
Comments:





for all functions in the component per Design














and Coding Standards rule [N47]

































































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Basavaraja Ganeshappa
Review Date :

02/15/16


































Lead Peer Reviewer:


Nick
Approved by Reviewer(s):



Yes

































Other Reviewer(s):


Chaitanya