| Technical Review Checklist - Template Version 02.00.00 |
|
|
|
|
|
|
|
|
| Product Name | Electric Power Steering | Electrical Arch. | 4 | Review Scope | Defect Type | Numbers |
|
|
|
|
| Yes | Closed | FR |
| Function ID | SF03A_Dampg |
|
| Initial Baseline in EA4 | Requirement | 0 |
|
|
|
|
| No | Rejected | FDD |
| Long Name | Damping |
|
| Interface | 4 |
|
|
|
|
| NA | Open | Model |
| Version that you started from.
NOT the version you hope to release.
If this will be v1.0.0, enter NA.
Starting Baseline | NA | Effort | Design | 0 |
|
|
|
|
|
|
| FMEA |
| Author | Sudeep Shankar | Review Effort(Hrs.) | 2.00 | Standards | 2 |
|
|
|
|
|
|
| *.m File |
|
| Corr+Verf effort(Hrs.) | 3.00 | Documentation | 10 |
|
|
|
|
|
|
| Cal Process |
|
| Total Effort (Hrs.) | 5.00 | Others | 0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Total | 16 |
|
|
|
|
|
|
|
|
| Checklist No. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 | Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Filename of Data Dictionary in correct format? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the FDD.Version property correctly updated? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Data Dictionary Verification report error free? | No |
| Error due to update needed in VerifyDD tool |
|
| Closed |
|
|
|
|
|
|
|
|
| Does FDD Long Name, Short Name, and Description match requirements? | NA |
| No Baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
| Are all runnables defined? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do runnables have the correct time step? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do server runnables correctly define arguments? | NA |
| No Server runnables |
|
|
|
|
|
|
|
|
|
|
|
| Are all clients defined? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do client definitions match the corresponding server runnable? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does name and metadata of every signal match its corresponding interface signal? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do output signal ranges match requirements (check DOOR min/max attributes too)? | NA |
| No Baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do all calibrations have correct values for all metadata? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM defined in the appropriate number of blocks? | NA |
| No NVM defined |
|
|
|
|
|
|
|
|
|
|
|
| Are constants defined with proper scope (local vs global)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all dependent constants and calibrations included in one file? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 | Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Is filename of model in correct format? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Requirements Baseline? | NA |
| No Baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
| Is the Top level of the model annotated with Tool Dependencies? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Change Log or History? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Component shortname match data dictionary FDD metadata? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from subsystems that are not Function-Call Subsystems? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from arithmetic and logic operations? | Yes |
| |
|
|
|
|
|
|
|
|
|
|
|
| Are the Runnable trigger signals named as "call_<Runnable>"? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all data flow layers free of Function-Call Subsystems and Memory Store blocks? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Model have the confidentiality and copyright information inside all its Subsystems? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do all Memory Store blocks for PIM and Display Variables have the "Data store name must resolve to Simulink signal object" setting checked to true? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is each diagnostic (NTC) capable of being set to "PASS"? | NA |
| No NTCs |
|
|
|
|
|
|
|
|
|
|
|
| Does non-zero intialization of PIM occur in the function's Init runnable? | NA |
| No non-zero intialization of PIMs in the model |
|
|
|
|
|
|
|
|
|
|
|
| Does design properly include Set Ram Block Status when NVM RAM values change? | NA |
| No NVM defined |
|
|
|
|
|
|
|
|
|
|
|
| Does model include appropriate logic for dealing with missing or corrupted NVM data? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does model execute without errors/warnings after loading NxtrMBDConfig configuration set? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 | Section 3: Requirements Linking | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Are all requirements links of the format <FDDNumber>_<ObjectID>? | NA |
| No baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
| Does requirements HTML report reference only the DOORS module of this component for all links in the design? | NA |
| No baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
| Are linked blocks linked to the correct requirements(s)? (watch for problems due to copy/pasted blocks) | NA |
| No baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
| Is the list of unlinked blocks acceptable? | NA |
| No baseline requirements available |
|
| Closed |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 | Section 4: Model Advisor | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Was Model Advisor run with the correct configuration settings? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Model Advisor rerport free from "Fails". | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are Model Advisor report "Warnings" acceptable? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 5 | Section 5: Delivery Package | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does Doc folder contain a zipped HTML webview model? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does Reports folder contain only the data dictionary verification report, zipped Model Advisor report, and zipped requirements traceability report? | No |
| Requirement traceability report does not exists as requirement linking is not created due to non availability of baseline requirements |
|
| Closed |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6 | Section 6: Other Issus/Actions Identified | Document | Reference | Summary of resolution | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 6.1 | Update the change log with the information "Initial release based on EA3 version #' | Model | Change log | Updated the change log to refer EA3 version | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.2 | Instead of QuadDampgCmd use QuadDampgSca | Model | Enhd_Quad_Dampg block | Changed QuadDampgCmd to QuadDampgSca. Updated the Memory block and signal names as well | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.3 | Provide annotation about using Global Vehicle Speed Bilinear selection table used in linear intrepolation | Model | HydPwrSteerDampgCmd | Added annotation regarding use of Global Vehicle speed Bilinear Selection in linear interpolation | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.4 | Suggestion : DampgFilMotVelCrfLpFrq can be changed to DampgMotVelLpFilFrq. Similar to other Filter calibration as well. | *.m File | SF003A_Dampg_DataDict | Changed in DD and model | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.5 | Gain block '-1' to be changed to unary minus | Model | HydPwrSteerDampgCmd\AssiLimScale | Changed Gain block ' -1' with Unary minus | Standards | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.6 | Instead of 'Dampg Force' use 'Dampg Command' | Model | HydPwrSteerDampgCmd | Output port name is renamed as 'HydDampg' | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.7 | In the Long name of Calibration, remove 'Damping' | *.m File | SF003A_Dampg_DataDict | Removed 'Damping' from long name of Calibrations | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.8 | MotVelCrf can be changed to 'MotVel' wherever applicable | *.m File | SF003A_Dampg_DataDict | Changed from MotVelCrf to MotVel wherever applicable | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.9 | Following changes are to be done on the calibration attributes
1. DampgHwTqX: Cardinality = 'R', CustomerVisible = 'True' , Online = 'True'
2. DampgHwTqY: Cardinality = 'R', CustomerVisible = 'True' , Online = 'True'
3. DampgHydAssiLim : Cardinality = 'I', CustomerVisible = 'false' , Online = 'True'
4. DampgHydCoeff1ScaY : Cardinality ='R', CustomerVisible = 'true', Online = 'true'
5. DampgHydCoeff2ScaY : Cardinality ='R', CustomerVisible = 'true', Online = 'true'
6. DampgHydCoeff3ScaY : Cardinality ='R', CustomerVisible = 'true', Online = 'true'
7. DampgHydCoeff4ScaY : Cardinality ='R', CustomerVisible = 'true', Online = 'true'
8. DampgMotVelCrfX : Cardinality ='R', CustomerVisible = 'true', Online = 'true'
9. DampgMotVelCrfY : Cardinality ='R', CustomerVisible = 'true', Online = 'true'
10. DampgQuadHwTqBacklsh: Cardinality = 'N'
11. DampgQuadMotVelCrfBacklsh : Cardinality = 'N'
12. DampgTScaX = Cardinality ='I', CustomerVisible = 'true', Online = 'true'
13. DampgTScaY = Cardinality ='I', CustomerVisible = 'true', Online = 'true' | *.m File | SF003A_Dampg_DataDict | Changed the attributes of the calibrations as given in the comment | Interface | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.10 | DampgHydCoeff1ScaY EngVal to be changed to 1 | *.m File | SF003A_Dampg_DataDict | Updated the Coefficient values of DampgHydCoeff1ScaY to 1 | Interface | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.11 | Change 'DampgHydOutLim' to DampgHydOutpLim | *.m File | SF003A_Dampg_DataDict | updated to 'DampgHydOutpLim' both in model and DD | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.12 | Simplify the DampgMotVelX and DampgMotVelY table values. | *.m File | SF003A_Dampg_DataDict | Simplied the table values to nearest 3 digit precision | Standards | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.13 | Add annotation to backlash logic in the model | *.m File | SF003A_Dampg_DataDict | Added annotation of the backlash logic | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.14 | dDampgQuadHwTqBacklsh.Description = to be updated to say that the lashed output is captured in the display variable. | *.m File | SF003A_Dampg_DataDict | Description updated | Documentation | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.15 | For the filter logic, instead of removing the datastore check box, change the initialization in the model. | *.m File | SF003A_Dampg_DataDict | Updated in the model | Interface | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.16 | Following PIM are to be verified for the Min, max and units
1. MotVelCrfLpFil : Doc units to be ' '
2. PrevHwTqBacklshOutp : Min , Max values to be corrected
3. PrevHydOutLim : Min, Max values to be corrected
4. PrevMotVelCrfBacklshOutp : Min, Max values to be corrected
5. QuadDampgCmdLpFil : Doc units to be ' '
6. QuadDampgHwTqLpFil : Doc Units to be ' '
7. QuadDampgMotVelCrfLpFil : Doc units to be ' ' | *.m File | SF003A_Dampg_DataDict | Updated the Doc units , Min and Max values for the display variables given in the comment | Interface | updated as per finding | Closed |
|
|
|
|
|
|
|
|
| 6.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 7 | Section 7: APPROVALS |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | First Review | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Klein | 6/24/2015 | No |
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Kevin Derry, Chris Wheatly, Fei Yuan | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | Scott Weiss | No |
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | Matthew Tompkins | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Second Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Klein | 6/26/2015 | No |
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Fei Yuan | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | Matthew Tompkins | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Third Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Klein | 7/7/2015 | No |
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Fei Yuan | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | Sankardu Varadapureddi | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Fourth Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | <Owner Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | <Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Add more if necessary | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| P.S.: | Yes indicates adherence |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| NA indicates not applicable |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
