| Technical Review Checklist - Template Version 02.00.00 |
|
|
|
|
|
|
|
|
| Product Name | Electric Power Steering | Electrical Arch. | 4 | Review Scope | Defect Type | Numbers |
|
|
|
|
| Yes | Closed | FR |
| Function ID | SF027A_EotProtnFwl |
|
| Work CR EA4#7338
- Correction to EotProtnFwlEotDampgActvBndX calibration to define as a 1D array (1 row instead of 1 column) to be compatible with downstreamd software data dictionary tool(s). Design impact to only the data dictionary m-file.
- Additionally added a NTC 1 pager to Synergy project to be up to date with latest process requirements. | Requirement | 0 |
|
|
|
|
| No | Rejected | FDD |
| Long Name | Eot Protection Firewall |
|
| Interface | 0 |
|
|
|
|
| NA | Open | Model |
| Version that you started from.
NOT the version you hope to release.
If this will be v1.0.0, enter NA.
Starting Baseline | 1.1.0 | Effort | Design | 1 |
|
|
|
|
|
|
| FMEA |
| Author | Scott Millsap | Review Effort(Hrs.) | 2.00 | Standards | 0 |
|
|
|
|
|
|
| *.m File |
| EA4#7338 | Corr+Verf effort(Hrs.) |
| Documentation | 0 |
|
|
|
|
|
|
| Cal Process |
|
| Total Effort (Hrs.) | 2.00 | Others | 0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Total | 1 |
|
|
|
|
|
|
|
|
| Checklist No. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 | Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Filename of Data Dictionary in correct format? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is the FDD.Version property correctly updated? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Data Dictionary Verification report error free? | No | No |
|
|
|
|
|
|
|
|
|
|
|
|
| Does FDD Long Name, Short Name, and Description match requirements? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all runnables defined? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do runnables have the correct time step? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do server runnables correctly define arguments? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all clients defined? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do client definitions match the corresponding server runnable? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does name and metadata of every signal match its corresponding interface signal? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do output signal ranges match requirements (check DOOR min/max attributes too)? | Yes | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do all calibrations have correct values for all metadata? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM defined in the appropriate number of blocks? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are constants defined with proper scope (local vs global)? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all dependent constants and calibrations included in one file? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 | Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Is filename of model in correct format? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Requirements Baseline? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Top level of the model annotated with Tool Dependencies? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Change Log or History? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Component shortname match data dictionary FDD metadata? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from subsystems that are not Function-Call Subsystems? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from arithmetic and logic operations? | Yes | Yes | |
|
|
|
|
|
|
|
|
|
|
|
| Are the Runnable trigger signals named as "call_<Runnable>"? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all data flow layers free of Function-Call Subsystems and Memory Store blocks? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Model have the confidentiality and copyright information inside all its Subsystems? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model? | NA | Yes | Checked each display variable block |
| Not inspected |
|
|
|
|
|
|
|
|
|
| Do all Memory Store blocks for PIM and Display Variables have the "Data store name must resolve to Simulink signal object" setting checked to true? | NA | Yes |
|
| Not inspected |
|
|
|
|
|
|
|
|
|
| Is each diagnostic (NTC) capable of being set to "PASS"? | NA | Yes | Happens in the Init1 runnable |
| Not inspected |
|
|
|
|
|
|
|
|
|
| Does non-zero intialization of PIM occur in the function's Init runnable? | NA | NA |
|
| Not inspected |
|
|
|
|
|
|
|
|
|
| Does design properly include Set Ram Block Status when NVM RAM values change? | NA | NA |
|
| Not inspected |
|
|
|
|
|
|
|
|
|
| Does model include appropriate logic for dealing with missing or corrupted NVM data? | NA | NA |
|
| Not inspected |
|
|
|
|
|
|
|
|
|
| Does model execute without errors/warnings after loading NxtrMBDConfig configuration set? | NA | Yes |
|
| Not inspected |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 | Section 3: Requirements Linking | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Are all requirements links of the format <FDDNumber>_<ObjectID>? | NA | NA | No baseline requirements available |
|
|
|
|
|
|
|
|
|
|
|
| Does requirements HTML report reference only the DOORS module of this component for all links in the design? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are linked blocks linked to the correct requirements(s)? (watch for problems due to copy/pasted blocks) | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Is the list of unlinked blocks acceptable? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 | Section 4: Model Advisor | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Was Model Advisor run with the correct configuration settings? | No | No | Dictionary changes only, so ok. |
| content changes to m-file only |
|
|
|
|
|
|
|
|
|
| Is the Model Advisor rerport free from "Fails". | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are Model Advisor report "Warnings" acceptable? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 5 | Section 5: Delivery Package | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does Doc folder contain a zipped HTML webview model? | No | No |
|
| Need support from MB team to generate |
|
|
|
|
|
|
|
|
|
| Does Reports folder contain only the data dictionary verification report, zipped Model Advisor report, and zipped requirements traceability report? | No | No | No traceability documents available. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 6 | Section 6: Other Issus/Actions Identified | Document | Reference | Summary of resolution | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Blocks in model have red foreground from previous release. Every block in this model should have black foreground because only the dictionary in changing. | Model |
|
| Design | Model is updated to remove red foreground from prior model version. | Closed |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 7 | Section 7: APPROVALS |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | First Review | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Scott Millsap | 9/7/2016 |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Kevin Derry | Yes | No |
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | Basavaraja, Krishna |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Second Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Scott Millsap | 9/8/2016 |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Kevin Derry | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Third Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | <Owner Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Fourth Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Add more if necessary | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| P.S.: | Yes indicates adherence |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| NA indicates not applicable |
|
|
|
|
|
|
|
|
|
|
|
|
|
|