This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Design

1: EA4 NTC 0x0A1 Kinematic Integrity Fault
2: EA4 NTC 0x0A6 Handwheel Angle to Motor Angle Correlation
3: SF045A_HwAgSysArbn_Peer Review Checklist Design

Component Design

Component Documentation

1 - EA4 NTC 0x0A1 Kinematic Integrity Fault

Slide 1

Nexteer Confidential

NTC Overview
NTC 0x0A1 Kinematic Integrity Fault

Description:

This diagnostic is responsible for detecting a condition of failed mechanical integrity between the input shaft and output shaft, where the motor coupling may have broken free from the assist mechanism and the motor starts spinning freely.

Diagnostic Overview:

•This diagnostic monitors cumulative motor position (scaled to hw deg) and if this hw position exceeds a calibratable threshold ~ (maximum rack travel + tolerance), the NTC is set.
•This is not a recoverable fault.

Typical Fault Response: F3 fault type.

•Since motor is free spinning, the hand wheel position is not known for those systems that use motor position to help with Handwheel angle calculations. In such cases Handwheel angle dependent functions need to be disabled.

Probable Sources
(Most to Least Probable):

- •Motor Rotations not constrained mechanically

- - •Not connected to a R & P gear
  - •Mechanical failure

Initialization
Periodic	X
Event

Nexteer Confidential

Date	Revision	Initials
06-13-16	Initial Release	SS

Description of Unusual Event setting NTC	Root Cause / Explanation

Date	FDD & Rev	Modifications to Diagnostic Function
06-13-16	SF045A, V2.0.0	Initial release

Algorithm Changes / Lessons Learned / Revision Log

2 - EA4 NTC 0x0A6 Handwheel Angle to Motor Angle Correlation

Slide 1

Nexteer Confidential

NTC Overview
NTC 0x0A6 Hw Angle to Motor Angle Correlation

Description:

•This diagnostic is in place primarily to detect a correlation error between motor position and Handwheel position derived from a Handwheel angle sensor.

Diagnostic Overview:

•The diagnostic compares the Handwheel angle with the cumulative motor position scaled to Handwheel degrees.
•If the difference exceeds a calibratable threshold for a duration of time, then the NTC is set. An error accumulator strategy is used to set the NTC.
•The diagnostic as designed will apply only for those systems that have an absolute position sensor.
•This diagnostic is executed only if the motor position and Handwheel angle sensor signals are valid, and the Handwheel position sensor has been trimmed.

Typical Fault Response: F3 Notification Only

•The fault response will stop providing Handwheel position to dependent functions for the duration of the fault.

Probable Sources
(Most to Least Probable):

•System without travel stops and non-contacting sensor roll-over
•Sensor – Electrical connection – open/short
•Control module – Signal Open / Short - Failed external component or solder connection (resistor or capacitor)
•Broken motor coupling/belt

Initialization
Periodic	X
Event

Nexteer Confidential

Date	Revision	Initials
06-13-16	Initial Release	SS

Description of Unusual Event setting NTC	Root Cause / Explanation

Date	FDD & Rev	Modifications to Diagnostic Function
06-13-16	SF045A, V2.0.0	Initial release

Algorithm Changes / Lessons Learned / Revision Log

3 - SF045A_HwAgSysArbn_Peer Review Checklist Design

Nexteer_Template_V1.0

Overview

Peer Review Instructions
Technical Review Checklist
Template Change Log

Sheet 1: Peer Review Instructions

Instructions for Functional Design Package Peer Review

PRE-MEETING
	Function Owner	Confirm that requirements are reviewed and approved PRIOR to the FDP peer review
	Function Owner	Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews
	Function Owner	Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review
	Function Owner	Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting
	Function Owner	Identify necessary attendance and invite to meeting
	Function Owner	Complete the "Author" column information for sections 1 through 3 prior to the review
	Function Owner	Complete the attendance invitation list in section 5
	Function Owner	For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews.

DURING MEETING
	Function Owner	Present document changes to the review team
	Peer Reviewer	Capture attendance of the review
	Peer Reviewer	Capture actions and issues in section 4. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN"

POST MEETING
	Function Owner	Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided.
	Function Owner	Schedule follow up review OR review open items with peer reviewer and obtain agreement to close
	Peer Reviewer	Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates

Sheet 2: Technical Review Checklist

Technical Review Checklist - Template Version 02.00.00

Product Name

Electric Power Steering

Electrical Arch.

Review Scope

Defect Type

Numbers

Yes

Closed

Function ID

SF045A_HwAgSysArbn

Generic design is now simplfied considering only Pinion coordinates to arbitrate the HwAg signals instead of flexibility to choose between Handwheel, Pinion and MotorAg coordinates. This resulted in removing the cals used to apply compilance error compensation and priority selection.
- Kinematic Integrity diagonstic added
- HwAg to MotAg Correlation diagonstic added
- Logic added to arbitrate HwAg signal going to EOT when HwAg sensor signals not available.

Requirement

Rejected

FDD

Long Name

Loa Manager

Interface

Open

Model

Version that you started from. NOT the version you hope to release. If this will be v1.0.0, enter NA. Starting Baseline

1.1.0

Effort

Design

FMEA

Author

Sudeep Shankar

Review Effort(Hrs.)

Standards

*.m File

Corr+Verf effort(Hrs.)

Documentation

Cal Process

Total Effort (Hrs.)

0.00

Others

Total

Checklist No.

Description of Check

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Section 1: Data Dictionary

Is Filename of Data Dictionary in correct format?

Yes

Is the FDD.Version property correctly updated?

Yes

Is the Data Dictionary Verification report error free?

Special cases are shown as error

Others

Tools issue

Closed

Does FDD Long Name, Short Name, and Description match requirements?

Yes

Are all runnables defined?

Yes

Do runnables have the correct time step?

Yes

Do server runnables correctly define arguments?

No Server runnables

Are all clients defined?

Yes

Do client definitions match the corresponding server runnable?

Yes

Does name and metadata of every signal match its corresponding interface signal?

Yes

Do output signal ranges match requirements (check DOOR min/max attributes too)?

Yes

Are calibration tables named correctly (e.g. AssiX and AssiY)?

No cal tables

Do all calibrations have correct values for all metadata?

Yes

Are calibration tables named correctly (e.g. AssiX and AssiY)?

No cal tables

Is NVM defined in the appropriate number of blocks?

No NVM defined

Are constants defined with proper scope (local vs global)?

Yes

Are all dependent constants and calibrations included in one file?

Yes

Section 2: Model

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Is filename of model in correct format?

Yes

Is Top level of model annotated with Requirements Baseline?

Yes

Is the Top level of the model annotated with Tool Dependencies?

Yes

Is Top level of model annotated with Change Log or History?

Yes

Does the Component shortname match data dictionary FDD metadata?

Yes

Is the 2nd level of model free from subsystems that are not Function-Call Subsystems?

Yes

Is the 2nd level of model free from arithmetic and logic operations?

Yes

Are the Runnable trigger signals named as "call_<Runnable>"?

Yes

Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number?

Yes

Are all data flow layers free of Function-Call Subsystems and Memory Store blocks?

Yes

Does the Model have the confidentiality and copyright information inside all its Subsystems?

Yes

Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model?

Yes

Do all Memory Store blocks for PIM and Display Variables have the "Data store name must resolve to Simulink signal object" setting checked to true?

Yes

Is each diagnostic (NTC) capable of being set to "PASS"?

Yes

Does non-zero intialization of PIM occur in the function's Init runnable?

Yes

Does design properly include Set Ram Block Status when NVM RAM values change?

No NVM defined

Does model include appropriate logic for dealing with missing or corrupted NVM data?

Does model execute without errors/warnings after loading NxtrMBDConfig configuration set?

Yes

Section 3: Requirements Linking

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Are all requirements links of the format <FDDNumber>_<ObjectID>?

No baseline requirements

Does requirements HTML report reference only the DOORS module of this component for all links in the design?

Are linked blocks linked to the correct requirements(s)? (watch for problems due to copy/pasted blocks)

Is the list of unlinked blocks acceptable?

Section 4: Model Advisor

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Was Model Advisor run with the correct configuration settings?

Yes

Is the Model Advisor rerport free from "Fails".

Yes

Are Model Advisor report "Warnings" acceptable?

Yes

Section 5: Delivery Package

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script?

Yes

Does Doc folder contain a zipped HTML webview model?

Yes

Does Reports folder contain only the data dictionary verification report, zipped Model Advisor report, and zipped requirements traceability report?

No requirement traceability report

Section 6: Other Issus/Actions Identified

Document

Reference

Summary of resolution

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

6.1

Change the order of inputs fed to Periodic

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1

Changed the input order

Documentation

Implemented

Closed

6.2

HwAgSnsrls can be removed from If and Else block as in both blocks it is just a pass through

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/VldtSnsrlsData

Updated as per comment

Design

Implemented

Closed

6.3

Change the name of the HwAgSysArbnHwAgSnsrlsThd to a meaningful name representing Kinematic in the name.

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/VldtSnsrlsData

Name changed

Documentation

Implemented

Closed

6.4

Latch the confidence to 0 when Kinematic integrity fault is set to TRUE.

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/VldtSnsrlsData

Fault latched

Design

Implemented

Closed

6.5

Change the design to compare sensor and sensorless confidence signals against correlation confidence thershold cals to determine whether to perform correlation check. And also simplify the design to select between sensor and sensorless signal

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/HwAgSrcSeln

Design in simplified

Design

Implemented

Closed

6.6

Simplify the correlation logic. Substract one signal from another and take the absolute value of it.

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/HwAgSrcSeln/VrfyHwAgCorrln

Updated as per comment

Design

Implemented

Closed

6.7

Store the flag to a PIM to indicate whether correlation is true or not

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/HwAgSrcSeln/VrfyHwAgCorrln/SetNtcPass

PIM updated

Design

Implemented

Closed

6.8

Set the NTC to "Prepass" instead of "Pass" when Correlation is true with debounce step

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/HwAgSrcSeln/VrfyHwAgCorrln/SetNtcPass

NTC state updated

Design

Implemented

Closed

6.9

NtcNr1.NTCNR_0X0A6 NTC definition in data dictionary must indicate that the NTC uses debounce step

*.m File

Changed in DD

Standards

Implemented

Closed

6.10

Change the block name "DftCal" to a meaningful name

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/TestHwAgSrcChg

change the name to be more meaningful

Documentation

Implemented

Closed

6.11

Move Reference timer and calibrations inside block. ( If, else and other) block

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/TestHwAgSrcChg

Moved the calibrations inside the blocks

Standards

Implemented

Closed

6.12

Port name "Tmr" to the "ApplyRateLim" block to be updated to more meaningful name so that design is readable.

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/TestHwAgSrcChg

change the name to be more meaningful

Documentation

Implemented

Closed

6.13

Add Correlation Status flag to else and elseif logic

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/HwAgSrcSeln

Added correlation flag after simplifying the design

Design

Implemented

Closed

6.14

Add a cal to to restrict the duration of sensorless HwAg signal to be transmitted on Serial Com sincel last correlated also set the calibration to duration equivalent to one day

Model

SF045A_HwAgSysArbn/HwAgSysArbn/HwAgSysArbnPer1/HwAgArbn/HwAgSrcSeln/SnsrlsDataToSerlCom

updated design to add timer logic

Design

Implemented

Closed

6.15

6.16

6.17

6.18

6.19

6.20

6.21

6.22

6.23

6.24

6.25

Section 7: APPROVALS

Role

First Review

Date

Attendance

Approval?

Function Owner*

Sudeep Shankar

6/13/2016

Yes

Peer Reviewer*

Kevin Derry

Yes

Safety

Carl Tarum

Software

Spandana Balani

Yes

ESG / Systems

EPDT / CSE

Matthew Tompkins

Yes

Hardware

Test

Role

Second Review (if required)

Date

Attendance

Approval?

Function Owner*

6/15/2016

Peer Reviewer*

Kevin Derry

Yes

Safety

Software

ESG / Systems

EPDT / CSE

Matthew Tompkins

Yes

Hardware

Test

Role

Third Review (if required)

Date

Attendance

Approval?

Function Owner*

Peer Reviewer*

Safety

Software

ESG / Systems

EPDT / CSE

Hardware

Test

Role

Fourth Review (if required)

Date

Attendance

Approval?

Function Owner*

Peer Reviewer*

<Name>

Safety

Software

ESG / Systems

EPDT / CSE

Hardware

Test

Role

Add more if necessary

Date

Attendance

Approval?

P.S.:

Yes indicates adherence

No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point.

NA indicates not applicable

Sheet 3: Template Change Log

Rev	Change	Author
01.00.05	Added lesson learned #3.5	MDK
01.00.06	Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models.	MDK
02.00.00	Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD.	K. Derry