Component Design
Component Documentation
- EA4 NTC Handwheel Angle Vehicle Center Trim Fault.html
- SF053A_HwAgVehCentrTrim_Design_PeerReviewChkList.html
This is the multi-page printable view of this section. Click here to print.
NTC Overview
NTC HwAgVehCentrTrimVld
Description:
Handwheel Angle Vehicle Center Trim provides a service to update an NVM value that is the Vehicle Center Trim. When there isn’t a valid value for Vehicle Center Trim, a non-debounced diagnostic is set.
Diagnostic Overview:
The NTC HwAgVehCentrTrimVld will be set when any one of the following conditions occur:
1..When HwAgTrimData.TrimPrfmd is False, the Ntc Status will be set to Failed.
2..When HwAgTrimData.TrimPrfmd is True, the Ntc Status will be set to Passed.
Typical Fault Response:
- Response for this diagnostic is F3
Probable Sources
(Most to Least Probable):
The service to update the Vehicle Center Trim hasn’t been performed.
The Vehicle Center Trim value has been cleared.
Initialization | X |
Periodic | X |
Event | X |
Date | Revision | Initials |
19may2016 | Initial Release | PTL |
Description of Unusual Event setting NTC | Root Cause / Explanation |
Date | FDD & Rev | Modifications to Diagnostic Function |
19May2016 | SF053A 1.3.0 | Initial version with the diagnostic |
Algorithm Changes / Lessons Learned / Revision Log
Instructions for Functional Design Package Peer Review | ||
PRE-MEETING | ||
Function Owner | Confirm that requirements are reviewed and approved PRIOR to the FDP peer review | |
Function Owner | Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews | |
Function Owner | Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review | |
Function Owner | Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting | |
Function Owner | Identify necessary attendance and invite to meeting | |
Function Owner | Complete the "Author" column information for sections 1 through 5 prior to the review | |
Function Owner | Complete the attendance invitation list in section 7 | |
Function Owner | For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews. | |
DURING MEETING | ||
Function Owner | Present document changes to the review team | |
Peer Reviewer | Capture attendance of the review | |
Peer Reviewer | Capture actions and issues in section 6. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN" | |
POST MEETING | ||
Function Owner | Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided. | |
Function Owner | Schedule follow up review OR review open items with peer reviewer and obtain agreement to close | |
Peer Reviewer | Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates |
Rev | Change | Author |
01.00.05 | Added lesson learned #3.5 | MDK |
01.00.06 | Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models. | MDK |
02.00.00 | Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD. | K. Derry |
02.01.00 | Added: Does FDD.DesignASIL match requirements? Added: Was webview model created without requirements highlighted? Removed: Redundant row in Data Dictionary section. Formatting: Column C now consistently center-justified. | K. Derry |
02.02.00 | Added: Are all data types represented by released Data_Management classes? Removed: Are all runnables defined? Rationale: Automated tools checking. Removed: Does the Component shortname match data dictionary FDD metadata? Removed: "Data store name must resolve to Simulink signal object" Edited: Model Advisor report should now be left unzipped. | K. Derry |
Model Advisor Report - SF053A_HwAgVehCentrTrim.slx | |
Simulink version: 8.2 | Model version: 1.209 |
System: SF053A_HwAgVehCentrTrim | Current run: 10-Jun-2016 14:59:30 |
Model Advisor configuration: ...NxtrModelAdvisorConfig.mat |
Pass | Fail | Warning | Not Run | Total |
| | | | 359 |
You should turn on the following optimization(s):
none . | |
Compares the state machine type of all Stateflow charts to the desired type.
Check for Classic state machines
Identify Stateflow charts using the Classic state machine type.
Warning
The following charts using Classic state machines were found in the model:
Check for Mealy state machines
Identify Stateflow charts using the Mealy state machine type.
Passed
No charts using Mealy state machines were found in the model.
_________________________________________________________________________________________
Check for Moore state machines
Identify Stateflow charts using the Moore state machine type.
Passed
No charts using Moore state machines were found in the model.
Name | Value |
State Machine Type | Common |
Check Simulink blocks and Stateflow objects that do not link to a requirements document
Warning
The following blocks do not link to a requirement document:
Identify block names that use characters that are not correct in C code.
See Also
Error type | Block |
Name contains incorrect characters. | ..../Function-Call Generator |
Identify levels in the model that include basic blocks and subsystems. Each level of a model must be designed with blocks of the same level (for example, only subsystems or only basic blocks).
See Also
Identify nonstandard display attributes in Simulink diagrams.
See Also
Check format settings
Identify incorrect model-level format options.
Warning
The following format display options are incorrect.
Display Attribute | Recommended Value | Actual Value |
Display > Signals & Ports > Wide Nonscalar Lines | on | off |
View > Model Browser Options > Model Browser | off | on |
Display > Library Links > All | none | disabled |
Check block colors
Identify blocks using nonstandard colors.
Warning
The following blocks use nonstandard colors:
Check canvas colors
Identify canvases that are not white.
Passed
All diagrams use a white canvas.
_________________________________________________________________________________________
Check diagram zoom
Identify diagrams that do not have zoom factor set to 100 %.
Warning
The following diagrams do not have zoom factor set to 100 percent:
Identify whether to display block names.
See Also
Check for blocks with hidden names and obvious function
Identify block names that are displayed but can be hidden due to obvious behavior.
Warning
The following block names can be hidden:
Check for non-descriptive displayed block names
Identify block names that are displayed but should be hidden due to a lack of a descriptive name.
Warning
The following blocks have a name displayed, however, the name is not descriptive:
Check for missing block names
Identify block names that are hidden but should be displayed to show a descriptive name.
Warning
The following blocks have descriptive names, however, the names are hidden:
Identify blocks that require labeled signals. A subset of source and destination blocks require labeled signals.
See Also
Check source block labels
The following source blocks require labeled signals; Inport, From, Data Store Read, Constant, Bus Selector, Demux, Selector. If the signal name is visible on the block, this rule is considered met.
Warning
The following signals have no label:
Check destination block labels
The following destination blocks require labeled signals; Outport, Goto, Data Store Write, Bus Creator, Mux, Subsystem, Chart. If the signal name is visible on the source block, this rule is considered met.
Warning
The following signals have no label:
Identify blocks that are not allowed in discrete controllers. Prohibited blocks include all continuous blocks and some source and sink blocks.
See Also
Identify transitions in Stateflow flowcharts that are drawn incorrectly.
See Also
Check for conditions drawn vertically
Condition expressions should be drawn on the horizontal segments of flowcharts.
Warning
The following transitions have condition expressions that are not horizontal:
Check for action transitions drawn vertically
Transition actions should be drawn on the vertical segments of flowcharts.
Warning
The following transitions have action expressions that are not vertical:
Check for junctions for default transitions
All Junctions in a flow chart should have a default exit transition.
Warning
The following Junctions do not have a default exit transition:
Check for transitions that combine condition and action
Flowcharts should not combine condition evaluations and action expressions in a single transition.
Warning
The following transition have a mixture of condition and assignment actions:
SF053A_HwAgVehCentrTrim/Data Store Memory1
SF053A_HwAgVehCentrTrim/Data Store Memory15
SF053A_HwAgVehCentrTrim/Data Store Memory18
SF053A_HwAgVehCentrTrim/Data Store Memory3
SF053A_HwAgVehCentrTrim/Data Store Memory1
SF053A_HwAgVehCentrTrim/Data Store Memory15
SF053A_HwAgVehCentrTrim/Data Store Memory18
SF053A_HwAgVehCentrTrim/Data Store Memory3
SF053A_HwAgVehCentrTrim/Data Store Memory1
SF053A_HwAgVehCentrTrim/Data Store Memory15
SF053A_HwAgVehCentrTrim/Data Store Memory18
SF053A_HwAgVehCentrTrim/Data Store Memory3
Note: These runtime diagnostics may slow down simulation considerably. You should set them back to Disable all
once you have verified that they do not cause any warnings or errors during simulation.