1 - SF104A_MotCurrRegCfg_Design_PeerReviewChkList

Nexteer_Template_V1.0

Overview

Project Info
Process
Safety
Software
Apps
SME
Master
Template Change Log


Sheet 1: Project Info

Peer Review Checklist - Component DesignTemplate Version: 3.0.0
Product NameElectric Power SteeringReview Scope
Component IDSF104A_MotCurrRegCfgChange an input signal name: Changed input name DualEcuFltMtgtnEna to DualEcuMotCtrlMtgtnEna
Component Long NameMotor Current Regulator Configuration
Component OwnerPrerit Pramod
Version that you started from. NOT the version you hope to release. If this will be v1.0.0, enter NA. Starting Baseline2.1.0
The number that will be used when package is baselined in Synergy. For example, the first one will be 1.0.0. Intended Baseline2.2.0
Electrical ArchitectureEA4
CR Number8294
Author: The person who edited the design. Usually the Resolver of a CR. AuthorVarsha Govindu
Review TypeWalk-through



Author's Quality Statement:Author must provide an explanation of any deviation from an ideal Instpection process. This field may be used for analysis of anomalies. This change involved an input signal name change. No functionality change.




Meeting DateAttendeesExamples: Initial Mtg, Follow-up. Reason for Meeting
11/10/2016Venkata Sivanand, Varsha Govindu










Sheet 2: Process

Peer Review Checklist - Component Design
Template Version:3.0.0






















YesClosedFR











NoRejectedFDD

Process Reviewer:Siva






NAOpenModel

(optional) Reviewer #2:









FMEA












*.m File















Cal Process
































Item No.Cross Ref.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1
Section 1: Data Dictionary














Are the following values correct for Runnables: .ContextYesYes












Are the following values correct for Runnables: .TimeStepYesYes












Are the following values correct for SrvRunnables: .ReturnNANA












Are the following values correct for SrvRunnables: .ArgumentsNANA












Are the following values correct for all Ip/Op/IrvSignals: .EngDTYesYes












Are the following values correct for all Ip/Op/IrvSignals: .DocUnitYesYes












Are the following values correct for all Ip/Op/IrvSignals: .EngInitYesYes












Are the following values correct for all Ip/Op/IrvSignals: .EngMinYesYes












Are the following values correct for all Ip/Op/IrvSignals: .EngMaxYesYes












Are the following values correct for all Ip/Op/IrvSignals: .ReadIn/WrittenInYesYes












Are the following values correct for all Ip/Op/IrvSignals: .ReadType/WriteTypeYesYes












Are the following values correct for all Calibrations: .DocUnitYesYes












Are the following values correct for all Calibrations: .PortNameYesYes












Are the following values correct for all NVM: .DocUnitNANA












Are the following values correct for all PIM: .DocUnitYesYes












Are the following values correct for all Constants: .DocUnitYesYes












Does FDD Long Name, Short Name, and Description match requirements?YesYes












Do output signal ranges match requirements?YesYes












Are all clients from model defined in dictionary?NANA












Do client definitions match their corresponding server runnable?NANA












Is NVM defined in the appropriate number of blocks (separate for EOL vs saved at power-off)?NANA












Is NVM with multiple values defined as a structure?NANA












Are NVM structure members arranged largest-to-smallest datatype?NANA












Are local Constants unique from global constants available in xx999A dictionaries?YesYes












Are calibration tables named correctly (e.g. AssiX and AssiY)?YesYes












Are Constant names abbreviated properly (ALLCAPS are not checkable by tools)?YesYes












Is the Data Dictionary Verification report error free?YesYes












Are all data types represented by released Data_Management classes?YesYes


























































































































































































2
Section 2: ModelAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model?YesYes












Is each diagnostic (NTC) capable of being set to "PASS"?NANA












Does non-zero intialization of PIM occur in the function's Init runnable?NANA












Does design properly include Set Ram Block Status when NVM RAM values change?NANA












Are NTCs set only outside an IRQ (not related to the typical periodic OS)?NANA












Are NTCs set and read only at periodic steps no less than 2 ms?NANA












Does model execute without errors/warnings after loading NxtrMBDConfig configuration set?YesYes












Is filename of model in correct format?YesYes












Is Top level of model annotated with Requirements Baseline?YesYes












Is the Top level of the model annotated with Tool Dependencies?YesYes












Is Top level of model annotated with Change Log or History?YesYes












Is the 2nd level of model free from subsystems that are not Function-Call Subsystems?YesYes












Is the 2nd level of model free from arithmetic and logic operations?YesYes












Are the Runnable trigger signals named as "call_<Runnable>"?YesYes












Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number?YesYes












Are all data flow layers free of Function-Call Subsystems and Memory Store blocks?YesYes












Does the Model have the confidentiality and copyright information inside all its Subsystems?YesYes












Are all requirements links of the format <FDDNumber>_<ObjectID>?YesYes












Does requirements HTML report reference only the DOORS module of this component for all links in the design?YesYes












Was Model Advisor run with the correct configuration settings?YesYes












Is the Model Advisor rerport free from "Fails".YesYes












Does the model execute?YesYes












If model has ADC input, is failure boolean input and appropriate fault response been included?NANA












Do cal ranges & logic ensure no incompatible values for their datatype?YesYes












Are "magic numbers" acceptable?YesYes












Do IF..ELSEIF blocks also contain an ELSE condition?YesYes












Do SWITCH CASE blocks also contain a DEFAULT condtion?NANA










3
Are ELSE and DEFAULT branching conditions reachable when dependent on internal variables?Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Does review meet 'inspection' criteria?YesYes












Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script?YesYes












Does Doc folder contain a zipped HTML webview model?YesYes












Was webview model created without requirements highlighted?YesYes












Does Doc folder contain appropriate number of NTC Summary sheets?NANA












Does Reports folder contain only the data dictionary verification report, Model Advisor report, and zipped requirements traceability report?YesYes


























































4
Section 4: Other Issus/Actions IdentifiedDocumentReferenceSummary of resolutionCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1














4.2














4.3














4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25































Sheet 3: Safety

Peer Review Checklist - Component Design
Template Version:3.0.0






















YesClosedFR











NoRejectedFDD

Safety Reviewer:







NAOpenModel

(optional) Reviewer #2:









FMEA












*.m File















Cal Process
































Item No.Cross Ref.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1
Section 1: Data Dictionary














Are the following values correct for all Calibrations: .Impact














Are the following values correct for all Calibrations: .TuningOwner














Are the following values correct for all Calibrations: .Online














Does the FDD .DesignASIL property match requirements?














Are lookup tables using compatible table dimensions?












































































































































































































































































































































































































































































































































































2
Section 2: ModelAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Are Model Advisor report ISO26262 warnings acceptable?














Is model free from dynamic array size allocation?














Is model free from data type conversion blocks that do not explicitly state desired data type?














Does model refrain from using Display Variable values in downstream operations?














Are all GOTO/FROM blocks restricted in scope to their own subystem level?














If model has ADC input, is failure boolean input and appropriate fault response been included?














Does design include output limiting blocks?














Do cal ranges & logic ensure freedom from divide-by-zero?














Are the following values correct for all NTC: .NtcTyp














Does model include appropriate logic for dealing with missing or corrupted NVM data?




























































































































































































































































































3
Section 3: Delivery PackageAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Does review meet 'inspection' criteria?












































































































































4
Section 4: Other Issus/Actions IdentifiedDocumentReferenceSummary of resolutionCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1














4.2














4.3














4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25































Sheet 4: Software

Peer Review Checklist - Component Design
Template Version:3.0.0






















YesClosedFR











NoRejectedFDD

Software Reviewer:







NAOpenModel

(optional) Reviewer #2:









FMEA












*.m File















Cal Process
































Item No.Cross Ref.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1
Section 1: Data Dictionary














Are the following values correct for Runnables: .Context














Are the following values correct for SrvRunnables: .Return














Are the following values correct for SrvRunnables: .Arguments














Are the following values correct for all Calibrations: .PortName














Are the following values correct for all NVM: .EngInit














Are the following values correct for all NVM: .Alias














Are the following values correct for all NVM: .InitRowCol














Are the following values correct for all Display Variables: .EngMin














Are the following values correct for all Display Variables: .EngMax














Are the following values correct for all Display Variables: .InitRowCol














Are the following values correct for all PIM: .EngMin














Are the following values correct for all PIM: .EngMax














Are the following values correct for all PIM: .InitRowCol














Are lookup tables using compatible table dimensions?














Are all clients from model defined in dictionary?














Do client definitions match their corresponding server runnable?














Is NVM defined in the appropriate number of blocks (separate for EOL vs saved at power-off)?














Is NVM with multiple values defined as a structure?














Are NVM structure members arranged largest-to-smallest datatype?














Are local Constants unique from global constants available in xx999A dictionaries?






























































































































































































































































































































Section 2: ModelAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Author: Detailed Description of the finding shall be provided by the reviewer.
Corrective Action: What action is taken to fix the issue?
Author: Data in this column shall be filled by reviewer after checking whether the rework is completed.










Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model?














Is each diagnostic (NTC) capable of being set to "PASS"?














Does non-zero intialization of PIM occur in the function's Init runnable?














Does design properly include Set Ram Block Status when NVM RAM values change?














Are NTCs set only outside an IRQ (not related to the typical periodic OS)?














Are NTCs set and read only at periodic steps no less than 2 ms?














Is model free from dynamic array size allocation?














Is model free from data type conversion blocks that do not explicitly state desired data type?














Does model refrain from using Display Variable values in downstream operations?














Are all GOTO/FROM blocks restricted in scope to their own subystem level?














Does design calculate PIM values only within their defined range?














Does design include output limiting blocks?














Do cal ranges & logic ensure freedom from divide-by-zero?














Do cal ranges & logic ensure no incompatible values for their datatype?














Are Model Advisor report MISRA warnings acceptable?














Is design free of unreachable logic?














Do state machines provide exits of all non-latch states?














Is design free from recursive logic that could cause indefinate waits?














Does design maintain data size consistency?














Are "magic numbers" acceptable?














Is design of a managable size and easy to understand?














Is Stateflow used only for state machines not easily represented in Simulink?














Is model free from over-nested IF logic or redundant IF..ELSEIF..ELSEIF.. Conditions?














Is model free from arithmetic operations on Boolean values?




























































3
Section 3: Delivery PackageAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status























































































































































4

DocumentReferenceSummary of resolutionCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1














4.2














4.3














4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25































Sheet 5: Apps

Peer Review Checklist - Component Design
Template Version:3.0.0






















YesClosedFR











NoRejectedFDD

Applications Reviewer:







NAOpenModel

(optional) Reviewer #2:









FMEA












*.m File















Cal Process
































Item No.Cross Ref.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1
Section 1: Data Dictionary














Are the following values correct for Runnables: .TimeStep














Are the following values correct for all Calibrations: .DocUnit














Are the following values correct for all Calibrations: .EngMax














Are the following values correct for all Calibrations: .Cardinality














Are the following values correct for all Calibrations: .CustomerVisible














Are the following values correct for all Calibrations: .Impact














Are the following values correct for all Calibrations: .GraphLink














Are the following values correct for all Calibrations: .Monotony














Are the following values correct for all NVM: .DocUnit














Are the following values correct for all Display Variables: .DocUnit














Are the following values correct for all Calibrations: .EngVal














Are the following values correct for all Calibrations: .EngMin














Are the following values correct for all Calibrations: .TuningOwner














Are the following values correct for all Calibrations: .Online














Does FDD Long Name, Short Name, and Description match requirements?














Do output signal ranges match requirements?














Do signal and parameter names accurately describe their purpose?














Do all .Description properties provide useful information?














Are calibration tables named correctly (e.g. AssiX and AssiY)?












































































































































































































































































































































2
Section 2: ModelAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Does model execute without errors/warnings after loading NxtrMBDConfig configuration set?














Does model include adequate annotation throughout?














Are the following values correct for all NTC: .NtcTyp














Are display variables appropriately placed?














Does design provide appropriate tuning flexibility?














Are blocks linked to the correct requirements? (watch for problems due to copy/pasted blocks)














Is the list of unlinked blocks acceptable?














Does design account for all requirements?














Is design of a managable size and easy to understand?














Is design easily disabled via calibration?














Does design either work with global signal units or contain necessary unit-conversion logic?












































































































































































































































































3
Section 3: Delivery PackageAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Does NTC Summary sheet adequately describe NTC usage?












































































































































4
Section 4: Other Issus/Actions IdentifiedDocumentReferenceSummary of resolutionCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1














4.2














4.3














4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25































Sheet 6: SME

Peer Review Checklist - Component Design
Template Version:3.0.0






















YesClosedFR











NoRejectedFDD

SME Reviewer:







NAOpenModel

(optional) Reviewer #2:









FMEA












*.m File















Cal Process
































Item No.Cross Ref.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1
Section 1: Data Dictionary














Are the following values correct for all Calibrations: .EngDT














Are the following values correct for all NVM: .EngDT














Are the following values correct for all Display Variables: .EngDT














Are the following values correct for all PIM: .EngDT














Are the following values correct for all Constants: .EngDT














Has Static Register evaluation has been completed and updated for any register data that is written to?




























































































































































































































































































































































































































































































































































2
Section 2: ModelAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Does model include appropriate logic for dealing with missing or corrupted NVM data?














Does design either work with global signal units or contain necessary unit-conversion logic?














Does the design prevent Integrator drifting?














Does design make proper use of limiters to prevent integrator windup and runaway values?














Are all IIR filters free of potential instability over their defined calibration ranges?












































































































































































































































































































































































3

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status









Has author performed basic simulations to screen for problems?












































































































































4

DocumentReferenceSummary of resolutionCorrective Action: What action is taken to fix the issue? Corrective ActionAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1














4.2














4.3














4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25































Sheet 7: Master

This is the master list of questions.


ADVANCED FILTER CRITERIA

A macro is used to filter and populate separate spreadsheets for each engineering discipline.

ArtifactDomain1Domain2















NumberArtifactChecklist ItemDomain1Domain2



1dictIs Filename of Data Dictionary in correct format?Processnone



2dictIs the FDD.Version property correctly updated?Processnone



3dictAre the following values correct for Runnables: .ContextProcessSoftwareShould be Architect


4dictAre the following values correct for Runnables: .TimeStepProcessAppsShould be Architect


5dictAre the following values correct for SrvRunnables: .ReturnProcessSoftwareShould be Architect


6dictAre the following values correct for SrvRunnables: .ArgumentsProcessSoftwareShould be Architect


7dictAre the following values correct for all Ip/Op/IrvSignals: .EngDTProcessnoneShould be Architect


8dictAre the following values correct for all Ip/Op/IrvSignals: .DocUnitProcessnoneShould be Architect


9dictAre the following values correct for all Ip/Op/IrvSignals: .EngInitProcessnoneShould be Architect


10dictAre the following values correct for all Ip/Op/IrvSignals: .EngMinProcessnoneShould be Architect


11dictAre the following values correct for all Ip/Op/IrvSignals: .EngMaxProcessnoneShould be Architect


12dictAre the following values correct for all Ip/Op/IrvSignals: .ReadIn/WrittenInProcessnone



13dictAre the following values correct for all Ip/Op/IrvSignals: .ReadType/WriteTypeProcessnone



14dictAre the following values correct for all Calibrations: .EngDTSMEnone



15dictAre the following values correct for all Calibrations: .DocUnitAppsProcess



16dictAre the following values correct for all Calibrations: .EngMaxAppsnone



17dictAre the following values correct for all Calibrations: .CardinalityAppsnone



18dictAre the following values correct for all Calibrations: .CustomerVisibleAppsnone



19dictAre the following values correct for all Calibrations: .ImpactAppsSafety



20dictAre the following values correct for all Calibrations: .GraphLinkAppsnone



21dictAre the following values correct for all Calibrations: .MonotonyAppsnone



22dictAre the following values correct for all Calibrations: .PortNameSoftwareProcess



23dictAre the following values correct for all NVM: .EngDTSMEnone



24dictAre the following values correct for all NVM: .DocUnitProcessApps



25dictAre the following values correct for all NVM: .EngInitSoftwarenone



26dictAre the following values correct for all NVM: .AliasSoftwarenone



27dictAre the following values correct for all NVM: .InitRowColSoftwarenone



28dictAre the following values correct for all Display Variables: .EngDTSMEnone



29dictAre the following values correct for all Display Variables: .DocUnitAppsnone



30dictAre the following values correct for all Display Variables: .EngMinSoftwarenone



31dictAre the following values correct for all Display Variables: .EngMaxSoftwarenone



32dictAre the following values correct for all Display Variables: .InitRowColSoftwarenone



33dictAre the following values correct for all PIM: .EngDTSMEnone



34dictAre the following values correct for all PIM: .DocUnitProcessnone



35dictAre the following values correct for all PIM: .EngMinSoftwarenone



36dictAre the following values correct for all PIM: .EngMaxSoftwarenone



37dictAre the following values correct for all PIM: .InitRowColSoftwarenone



38dictAre the following values correct for all Constants: .EngDTSMEnone



39dictAre the following values correct for all Constants: .DocUnitProcessnone



40dictAre the following values correct for all Calibrations: .EngValAppsnone



41dictAre the following values correct for all Calibrations: .EngMinAppsnone



43dictAre the following values correct for all Calibrations: .TuningOwnerSafetyApps



47dictAre the following values correct for all Calibrations: .OnlineSafetyApps



44dictDoes the FDD .DesignASIL property match requirements?Safetynone



45dictDoes FDD Long Name, Short Name, and Description match requirements?AppsProcess



46dictDo output signal ranges match requirements?AppsProcess



42dictAre lookup tables using compatible table dimensions?SafetySoftware



48dictDo signal and parameter names accurately describe their purpose?Appsnone



49dictDo all .Description properties provide useful information?Appsnone



50dictHas Static Register evaluation has been completed and updated for any register data that is written to?SMEnone



51dictAre all clients from model defined in dictionary?ProcessSoftware



52dictDo client definitions match their corresponding server runnable?ProcessSoftware



53dictIs NVM defined in the appropriate number of blocks (separate for EOL vs saved at power-off)?ProcessSoftware



54dictIs NVM with multiple values defined as a structure?ProcessSoftware



55dictAre NVM structure members arranged largest-to-smallest datatype?ProcessSoftware



56dictAre local Constants unique from global constants available in xx999A dictionaries?ProcessSoftware



57dictAre calibration tables named correctly (e.g. AssiX and AssiY)?ProcessApps



58dictAre Constant names abbreviated properly (ALLCAPS are not checkable by tools)?Processnone



59dictIs the Data Dictionary Verification report error free?Processnone



60dictAre all data types represented by released Data_Management classes?Processnone



61modelAre all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model?ProcessSoftware



62modelIs each diagnostic (NTC) capable of being set to "PASS"?ProcessSoftware



63modelDoes non-zero intialization of PIM occur in the function's Init runnable?ProcessSoftware



64modelDoes design properly include Set Ram Block Status when NVM RAM values change?ProcessSoftware



65modelAre NTCs set only outside an IRQ (not related to the typical periodic OS)?ProcessSoftware



66modelAre NTCs set and read only at periodic steps no less than 2 ms?ProcessSoftware



67modelDoes model execute without errors/warnings after loading NxtrMBDConfig configuration set?ProcessApps



68modelIs filename of model in correct format?Processnone



69modelIs Top level of model annotated with Requirements Baseline?Processnone



70modelIs the Top level of the model annotated with Tool Dependencies?Processnone



71modelIs Top level of model annotated with Change Log or History?Processnone



72modelIs the 2nd level of model free from subsystems that are not Function-Call Subsystems?Processnone



73modelIs the 2nd level of model free from arithmetic and logic operations?Processnone



74modelAre the Runnable trigger signals named as "call_<Runnable>"?Processnone



75modelDoes 2nd level of model have a properly updated annotation with name, description, and intended baseline number?Processnone



76modelAre all data flow layers free of Function-Call Subsystems and Memory Store blocks?Processnone



77modelDoes the Model have the confidentiality and copyright information inside all its Subsystems?Processnone



78modelAre all requirements links of the format <FDDNumber>_<ObjectID>?Processnone



79modelDoes requirements HTML report reference only the DOORS module of this component for all links in the design?Processnone



80modelWas Model Advisor run with the correct configuration settings?Processnone



81modelIs the Model Advisor rerport free from "Fails".Processnone



82modelDoes the model execute?Processnone



83modelAre Model Advisor report ISO26262 warnings acceptable?Safetynone



84modelIs model free from dynamic array size allocation?SafetySoftware



85modelDoes model include adequate annotation throughout?Appsnone



86modelIs model free from data type conversion blocks that do not explicitly state desired data type?SafetySoftware



87modelDoes model refrain from using Display Variable values in downstream operations?SafetySoftware



88modelAre all GOTO/FROM blocks restricted in scope to their own subystem level?SafetySoftware



89modelIf model has ADC input, is failure boolean input and appropriate fault response been included?SafetyProcess



90modelDoes design calculate PIM values only within their defined range?Softwarenone



91modelDoes design include output limiting blocks?SoftwareSafety



92modelDo cal ranges & logic ensure freedom from divide-by-zero?SoftwareSafety



93modelDo cal ranges & logic ensure no incompatible values for their datatype?SoftwareProcess



94modelAre Model Advisor report MISRA warnings acceptable?Softwarenone



95modelIs design free of unreachable logic?Softwarenone



96modelDo state machines provide exits of all non-latch states?Softwarenone



97modelIs design free from recursive logic that could cause indefinate waits?Softwarenone



98modelDoes design maintain data size consistency?Softwarenone



99modelAre "magic numbers" acceptable?ProcessSoftware



100modelAre the following values correct for all NTC: .NtcTypAppsSafety



101modelAre display variables appropriately placed?Appsnone



102modelDoes design provide appropriate tuning flexibility?Appsnone



103modelAre blocks linked to the correct requirements? (watch for problems due to copy/pasted blocks)Appsnone



104modelIs the list of unlinked blocks acceptable?Appsnone



105modelDoes design account for all requirements?Appsnone



106modelIs design of a managable size and easy to understand?AppsSoftware



107modelIs design easily disabled via calibration?Appsnone



108modelDoes model include appropriate logic for dealing with missing or corrupted NVM data?SMESafety



109modelDoes design either work with global signal units or contain necessary unit-conversion logic?SMEApps



110modelDoes the design prevent Integrator drifting?SMEnone



111modelDoes design make proper use of limiters to prevent integrator windup and runaway values?SMEnone



112modelAre all IIR filters free of potential instability over their defined calibration ranges?SMEnone



113modelIs Stateflow used only for state machines not easily represented in Simulink?Softwarenone



114modelDo IF..ELSEIF blocks also contain an ELSE condition?Processnone



115modelDo SWITCH CASE blocks also contain a DEFAULT condtion?Processnone



116modelAre ELSE and DEFAULT branching conditions reachable when dependent on internal variables?Processnone



117modelIs model free from over-nested IF logic or redundant IF..ELSEIF..ELSEIF.. Conditions?Softwarenone



118modelIs model free from arithmetic operations on Boolean values?Softwarenone



119modelIs model optimized to minimize redundant calculations?Processnone



120packageDoes NTC Summary sheet adequately describe NTC usage?Appsnone



121packageDoes review meet 'inspection' criteria?SafetyProcess



122packageDoes Design folder contain only the model, data dictionary, and (optionally) a simulation setup script?Processnone



123packageDoes Doc folder contain a zipped HTML webview model?Processnone



124packageWas webview model created without requirements highlighted?Processnone



125packageDoes Doc folder contain appropriate number of NTC Summary sheets?Processnone



126packageDoes Reports folder contain only the data dictionary verification report, Model Advisor report, and zipped requirements traceability report?Processnone



127packageHas author performed basic simulations to screen for problems?SMEnone




Sheet 8: Template Change Log

RevChangeAuthor
01.00.05Added lesson learned #3.5MDK
01.00.06Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models.MDK
02.00.00Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD.K. Derry
02.01.00Added: Does FDD.DesignASIL match requirements?
Added: Was webview model created without requirements highlighted?
Removed: Redundant row in Data Dictionary section.
Formatting: Column C now consistently center-justified.
K. Derry
02.02.00Added: Are all data types represented by released Data_Management classes?
Removed: Are all runnables defined? Rationale: Automated tools checking.
Removed: Does the Component shortname match data dictionary FDD metadata?
Removed: "Data store name must resolve to Simulink signal object"
Edited: Model Advisor report should now be left unzipped.
K. Derry
3.0.0New concept of discipline-specific checklists.
New sheets for Project Info, Safety, Software, Apps, SME, and Master.
New VBA code to distribute master list onto appropriate discipline sheets.
Major reformatting, many line item checks added/deleted/modified.
K. Derry








































































2 - SF104A_MotCurrRegCfg_ModelAdvisor_Report

Model Advisor Report for 'SF104A_MotCurrRegCfg'
Model Advisor Report - SF104A_MotCurrRegCfg.slx
Simulink version: 8.2Model version: 1.181
System: SF104A_MotCurrRegCfgCurrent run: 11-Nov-2016 11:38:41
 Model Advisor configuration: ...NxtrModelAdvisorConfig.mat

Run Summary
PassFailWarningNot RunTotal
   52   0   15   292359


Model Advisor

    By Product

        Simulink

        Simulink Coder


        Embedded Coder


        Simscape


        Simulink Verification and Validation

            Modeling Standards

                DO-178C/DO-331 Checks


                IEC 61508, ISO 26262, and EN 50128 Checks


                MathWorks Automotive Advisory Board Checks


            Requirements Consistency


        Simulink Control Design


    By Task

        Code Generation Efficiency


 Check optimization settings

You should turn on the following optimization(s):

  • Block reduction
  • Remove code from floating-point to integer conversions that wraps out-of-range values
  • Inline invariant signals
  • The Simulation range checking diagnostic is enabled. Because this diagnostic can increase the time it takes to simulate your model, you should consider turning it off, by setting its value to none.
  • Ignore testpoints when generating code
  • Pass reusable subsystem outputs as individual arguments


  •  Identify blocks using one-based indexing

    Check the model for blocks configured for one-based indexing

    Warning
    The following blocks use one-based indexing:

    Recommended Action
    Set the index to use zero-based indexing and update the supporting blocks as required.
    _________________________________________________________________________________________

    Check for blocks requiring one-based indexing

    Passed
    No blocks requiring one-based indexing were found



            Frequency Response Estimation


            Managing Data Store Memory Blocks


            Managing Library Links And Variants


            Model Referencing


            Modeling Guidelines for MISRA-C:2004

            Modeling Physical Systems


            Modeling Signals and Parameters using Buses


            Modeling Single-Precision Systems


            Modeling Standards for DO-178C/DO-331


            Modeling Standards for EN 50128


            Modeling Standards for IEC 61508


            Modeling Standards for ISO 26262


     Display model metrics and complexity report

    Display number of elements and name, level, and depth of subsystems for the model or subsystem

    Model metrics information
    Display number of elements for Simulink blocks and Stateflow constructs


    Summary

    Element TypeCount
    Inport93
    Outport86
    SubSystem53


    Simulink

    Block TypeCount
    Inport93
    Outport86
    Constant81
    SubSystem53
    S-Function22
    Product20
    Merge14
    From10
    Math8
    Width8
    Sum7
    ActionPort6
    SignalConversion6
    Goto5
    DataTypeConversion5
    DataStoreWrite4
    Selector4
    UnaryMinus4
    If3
    EnablePort2
    DataStoreMemory2
    TriggerPort2
    Step2
    DataStoreRead1
    Abs1
    Logic1
    RelationalOperator1
    ∧ Less

    Model complexity information
    Display name, level, and depth of subsystems


    Maximum Subsystem Depth: 8

    Subsystem Depth

    Subsystem NameLevelDepth
    CopyRight211
    Enabled Subsystem11
    Enabled Subsystem111
    MotCurrRegCfg17
    MotCurrRegCfg/CopyRight221
    MotCurrRegCfg/MotCurrRegCfgInit122
    MotCurrRegCfg/MotCurrRegCfgInit1/CopyRight231
    MotCurrRegCfg/MotCurrRegCfgInit1/FilLpInit31
    MotCurrRegCfg/MotCurrRegCfgPer126
    MotCurrRegCfg/MotCurrRegCfgPer1/2nd_Order_Damping_Terms32
    MotCurrRegCfg/MotCurrRegCfgPer1/2nd_Order_Damping_Terms/CopyRight241
    MotCurrRegCfg/MotCurrRegCfgPer1/2nd_Order_Damping_Terms/LimStat_f141
    MotCurrRegCfg/MotCurrRegCfgPer1/2nd_Order_Damping_Terms/LimStat_f3241
    MotCurrRegCfg/MotCurrRegCfgPer1/Calc MotAgElecDly32
    MotCurrRegCfg/MotCurrRegCfgPer1/Calc MotAgElecDly/CopyRight241
    MotCurrRegCfg/MotCurrRegCfgPer1/Calc MotAgElecDly/LimStat_f3241
    MotCurrRegCfg/MotCurrRegCfgPer1/CopyRight231
    MotCurrRegCfg/MotCurrRegCfgPer1/FilLpUpdOutp31
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling35
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/CopyRight241
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Enumerated Constant41
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled44
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Calculate_Gains53
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Calculate_Gains/2nd Order Disabled62
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Calculate_Gains/2nd Order Disabled/CopyRight271
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Calculate_Gains/2nd Order Enabled62
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Calculate_Gains/2nd Order Enabled/CopyRight271
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Calculate_Gains/CopyRight261
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/CopyRight251
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/FixdToFloat_f32_u151
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/FixdToFloat_f32_u1651
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/FixdToFloat_f32_u251
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/FixdToFloat_f32_u351
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/LimStat_f151
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/LimStat_f251
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/LimStat_f351
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/LimStat_f3251
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table52
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table/CopyRight261
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table/FloatToFixd_u16_f3261
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table/LnrIntrpn_u16_u16VariXu16VariY61
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table/LnrIntrpn_u16_u16VariXu16VariY161
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table/LnrIntrpn_u16_u16VariXu16VariY261
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Lookup_Table/LnrIntrpn_u16_u16VariXu16VariY361
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Max52
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_ Enabled/Use_Max/CopyRight261
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_Disabled42
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/Feedback_Control_Disabled/CopyRight251
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/LimStat_f141
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/LimStat_f241
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/LimStat_f341
    MotCurrRegCfg/MotCurrRegCfgPer1/PI_Gain_Scheduling/LimStat_f3241
    ∧ Less



     Check for root Inports with missing properties

    Identify Inport blocks in the top-level of the model with missing or inherited sample times, data types, or port dimensions

    Warning
    The following Inport blocks have undefined or inherited sample times, data types or port dimensions

    InportLinkConditions
    1SF104A_MotCurrRegCfg/MotInduDaxEstimdMissing port dimension
    Missing signal data type
    Missing port sample time
    2SF104A_MotCurrRegCfg/MotInduQaxEstimdMissing port dimension
    Missing signal data type
    Missing port sample time
    3SF104A_MotCurrRegCfg/MotREstimdMissing port dimension
    Missing signal data type
    Missing port sample time
    4SF104A_MotCurrRegCfg/MotVelMrfMissing port dimension
    Missing signal data type
    Missing port sample time
    5SF104A_MotCurrRegCfg/VehSpdMissing port dimension
    Missing signal data type
    Missing port sample time
    6SF104A_MotCurrRegCfg/IvtrLoaMtgtnEnaMissing port dimension
    Missing signal data type
    Missing port sample time
    7SF104A_MotCurrRegCfg/CurrMeasLoaMtgtnEnaMissing port dimension
    Missing signal data type
    Missing port sample time
    8SF104A_MotCurrRegCfg/MotCurrEolCalStMissing port dimension
    Missing signal data type
    Missing port sample time
    9..../DualEcuMotCtrlMtgtnEnaMissing port dimension
    Missing signal data type
    Missing port sample time


    Recommended Action
    Explicitly define all missing Inport block properties identified in the results
    • Missing port dimension: Model contains Inport blocks with inherited port dimension (-1). Specify port dimension for the listed Inport blocks.
    • Missing signal data type: Model contains Inport blocks with inherited data type. Specify a data type for the listed Inport blocks.
    • Missing port sample time: Model contains Inport blocks with inherited sample time (-1). Specify sample time information for the listed Inport blocks. Note: The sample time of root Inports with bus type must match the sample times specified at the leaf elements of the bus object.


     Check for model objects that do not link to requirements

    Check Simulink blocks and Stateflow objects that do not link to a requirements document

    Warning
    The following blocks do not link to a requirement document:

    ∧ Less
    Recommended Action
    For each object in the list, in the Model Editor, right-click the block, select Requirements, and specify a requirement.



            Modeling Standards for MAAB

                Naming Conventions


     Check subsystem names

    Identify subsystem names that use characters that are not correct in C code.

    See Also

    Warning
    The following subsystem names contain incorrect characters:

    ErrorSubsystem block
    Name contains incorrect characters.SF104A_MotCurrRegCfg/Enabled Subsystem
    Name contains incorrect characters.SF104A_MotCurrRegCfg/Enabled Subsystem1
    Name contains incorrect characters...../Feedback_Control_ Enabled
    Name starts with a number [0123456789]...../Calculate_Gains/2nd Order Disabled
    Name starts with a number [0123456789]...../Calculate_Gains/2nd Order Enabled


    Recommended Action
    Rename the subsystem blocks using correct characters.


     Check character usage in block names

    Identify block names that use characters that are not correct in C code.

    See Also

    Warning
    The following block names use characters that are not correct for C code:

    Error typeBlock
    Name contains incorrect characters...../Function-Call Generator
    Name contains incorrect characters...../Function-Call Generator


    Recommended Action
    Rename the block using correct characters.



                Model Architecture


     Check for mixing basic blocks and subsystems

    Identify levels in the model that include basic blocks and subsystems. Each level of a model must be designed with blocks of the same level (for example, only subsystems or only basic blocks).

    See Also

    Warning
    The following level(s) in the model include basic blocks and subsystems:

    SystemBlock path
    SF104A_MotCurrRegCfgSF104A_MotCurrRegCfg/CopyRight2
    SF104A_MotCurrRegCfgSF104A_MotCurrRegCfg/Step
    SF104A_MotCurrRegCfgSF104A_MotCurrRegCfg/Step1
    SF104A_MotCurrRegCfg/MotCurrRegCfg..../MotCurrRegCfg/CopyRight2
    ..../MotCurrRegCfg/MotCurrRegCfgPer1..../MotCurrRegCfgPer1/CopyRight2
    ..../MotCurrRegCfg/MotCurrRegCfgPer1..../MotCurrRegCfgPer1/Data Store Write
    ..../MotCurrRegCfg/MotCurrRegCfgPer1..../MotCurrRegCfgPer1/FilLpUpdOutp
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/Constant
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/Constant1
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/CopyRight2
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/Enumerated Constant
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/LimStat_f1
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/LimStat_f2
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/LimStat_f3
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/LimStat_f32
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/Logical Operator
    ..../MotCurrRegCfgPer1/PI_Gain_Scheduling..../PI_Gain_Scheduling/Relational Operator
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant2
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant3
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant4
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant5
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant6
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Constant7
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/CopyRight2
    ..../Feedback_Control_ Enabled..../FixdToFloat_f32_u1
    ..../Feedback_Control_ Enabled..../FixdToFloat_f32_u16
    ..../Feedback_Control_ Enabled..../FixdToFloat_f32_u2
    ..../Feedback_Control_ Enabled..../FixdToFloat_f32_u3
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/LimStat_f1
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/LimStat_f2
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/LimStat_f3
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/LimStat_f32
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Product
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/Product1
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/SizeOf_1
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/SizeOf_2
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/SizeOf_3
    ..../Feedback_Control_ Enabled..../Feedback_Control_ Enabled/SizeOf_4
    ..../Calculate_Gains..../Calculate_Gains/Constant
    ..../Calculate_Gains..../Calculate_Gains/CopyRight2
    ∧ Less


    Recommended Action
    If possible, replace blocks at the identified level of the model hierarchy with basic blocks. Move nonvirtual blocks into the identified subsystem.



                Model Configuration Options

                Simulink


     Check for Simulink diagrams using nonstandard display attributes

    Identify nonstandard display attributes in Simulink diagrams.

    See Also

    _________________________________________________________________________________________

    Check format settings
    Identify incorrect model-level format options.

    Warning
    The following format display options are incorrect.

    Display AttributeRecommended ValueActual Value
    Display > Signals & Ports > Wide Nonscalar Linesonoff
    View > Model Browser Options > Model Browseroffon
    Display > Library Links > Allnonedisabled


    Recommended Action
    Set the format options to the recommended value.
    _________________________________________________________________________________________

    Check block colors
    Identify blocks using nonstandard colors.

    Warning
    The following blocks use nonstandard colors:

    Recommended Action
    Set the block foreground color to black and the background color to white.
    _________________________________________________________________________________________

    Check canvas colors
    Identify canvases that are not white.

    Passed
    All diagrams use a white canvas.
    _________________________________________________________________________________________

    Check diagram zoom
    Identify diagrams that do not have zoom factor set to 100 %.

    Warning
    The following diagrams do not have zoom factor set to 100 percent:

    ∧ Less
    Recommended Action
    For each listed diagram, select View > Zoom > Normal View (100%).


     Check font formatting

    Identify inconsistent formatting of text.

    See Also

    Warning
    Font formatting is not consistent.

    The following font characteristics are used in the model/subsystem. Font characteristics are sorted by number of occurrences. The most common characteristics are bold.
    Font NameFont SizeFont Style

    Helvetica
    Arial

    10
    14
    9

    normal



    Recommended Action
    To have consistent font formatting, click Modify All Fonts to apply the font formatting selected in the input parameters above to all objects.

    Input Parameters Selection
    NameValue
    Font NameCommon
    Font SizeCommon
    Font StyleCommon


     Check positioning and configuration of ports

    Identify input and output ports with incorrect positioning and configurations.

    See Also

    _________________________________________________________________________________________

    Check Inport blocks position
    Identify Inport blocks that result in left-flowing signals.

    Passed
    There are no Inport blocks in the model that result in left-flowing signals.
    _________________________________________________________________________________________

    Check Outport block position
    Identify Outport blocks that result in left-flowing signals.

    Passed
    There are no Outport blocks in the model that result in left-flowing signals.
    _________________________________________________________________________________________

    Check port orientation
    Identify port blocks with nondefault orientation.

    Passed
    All ports use the default orientation.
    _________________________________________________________________________________________

    Check for duplicate Inports blocks
    Identify duplicate Inport blocks.

    Passed
    All Inport blocks in the model are used once.


     Check visibility of block port names

    Identify port block names that are not uniformly displayed. The block names must all be displayed or none displayed. Library blocks are an exception to this rule. This check ignores masked and subsystem blocks.

    See Also

    _________________________________________________________________________________________

    Check for incorrect port name display
    Identify ports that are incorrectly displaying names.

    Passed
    Subsystem blocks are correctly displayed.
    _________________________________________________________________________________________

    Check for incorrect subsystem port name display
    Identify subsystems that are incorrectly displaying names.

    Passed
    Subsystem blocks are correctly displayed.

    Input Parameters Selection
    NameValue
    Display all port names (Diagram > Format > Show Block Name).true


     Check the display attributes of block names

    Identify whether to display block names.

    See Also

    _________________________________________________________________________________________

    Check for blocks with hidden names and obvious function
    Identify block names that are displayed but can be hidden due to obvious behavior.

    Passed
    All blocks with obvious behavior have hidden names.
    _________________________________________________________________________________________

    Check for non-descriptive displayed block names
    Identify block names that are displayed but should be hidden due to a lack of a descriptive name.

    Warning
    The following blocks have a name displayed, however, the name is not descriptive:

    Recommended Action
    Modify the block name to provide descriptive information, or hide the block name by deselecting (Diagram > Format > Show Block Name).
    _________________________________________________________________________________________

    Check for missing block names
    Identify block names that are hidden but should be displayed to show a descriptive name.

    Warning
    The following blocks have descriptive names, however, the names are hidden:

    ∧ Less
    Recommended Action
    Modify the blocks to show the block name (Diagram > Format > Show Block Name).


     Check signal line labels

    Identify blocks that require labeled signals. A subset of source and destination blocks require labeled signals.

    See Also

    _________________________________________________________________________________________

    Check source block labels
    The following source blocks require labeled signals; Inport, From, Data Store Read, Constant, Bus Selector, Demux, Selector. If the signal name is visible on the block, this rule is considered met.

    Warning
    The following signals have no label:

    ∧ Less
    Recommended Action
    Add a new or propagated label to the signal line.
    _________________________________________________________________________________________

    Check destination block labels
    The following destination blocks require labeled signals; Outport, Goto, Data Store Write, Bus Creator, Mux, Subsystem, Chart. If the signal name is visible on the source block, this rule is considered met.

    Warning
    The following signals have no label:

    ∧ Less
    Recommended Action
    Add a new or propagated label to the signal line.


     Check for propagated signal labels

    Identify propagated labels on signal lines.

    See Also

    _________________________________________________________________________________________

    Check subsystem input labels
    Identify subsystem inputs that are labeled and display propagated signals.

    Passed
    All inputs to the subsystem have labels and display propagated signals.
    _________________________________________________________________________________________

    Check subsystem output labels
    Identify outputs from subsystems that are labeled and display signal propagation.

    Passed
    All outputs from the subsystem have labels and display propagated signals.
    _________________________________________________________________________________________

    Signal propagation for nonsubsystem blocks
    Identify the signal propagation status for both transformative and nontransformative blocks.

    Passed
    All outputs from non subsystem blocks correctly use labels and display propagated signals.



                Stateflow


     Check usage of exclusive and default states in state machines

    Identify Stateflow charts and substates that incorrectly use or define exclusive and default states.
    Note: This check does not support charts that use MATLAB as the action language.

    See Also

    _________________________________________________________________________________________

    Check Stateflow charts for exclusive states
    Identify Stateflow charts that have singular exclusive (OR) states.

    Passed
    The Stateflow charts do not have singular exclusive (OR) states.
    _________________________________________________________________________________________

    Check Stateflow charts for undefined default states
    Identify Stateflow charts that do not define default states.

    Passed
    Each Stateflow chart defines a default state.
    _________________________________________________________________________________________

    Check for multiple states assigned as the default state
    At the root level in the Stateflow hierarchy only one state should be assigned as the default.

    Passed
    The root level of the chart has only one default state assigned.
    _________________________________________________________________________________________

    Check for substates with singular OR states
    States configured as OR should always be part of a group of states.

    Passed
    No singular OR states were detected.
    _________________________________________________________________________________________

    Check for substates without default states defined
    At every level in the Stateflow hierarchy a default state should be assigned.

    Passed
    All substates have default states assigned.
    _________________________________________________________________________________________

    Check for substates with multiple default states defined
    At every level in the Stateflow hierarchy only one state should be assigned as the default.

    Passed
    All levels of the chart have only one default state assigned.


     Check transition orientations in flowcharts

    Identify transitions in Stateflow flowcharts that are drawn incorrectly.

    See Also

    _________________________________________________________________________________________

    Check for conditions drawn vertically
    Condition expressions should be drawn on the horizontal segments of flowcharts.

    Passed
    All conditions expressions were drawn horizontally.
    _________________________________________________________________________________________

    Check for action transitions drawn vertically
    Transition actions should be drawn on the vertical segments of flowcharts.

    Passed
    All transitions actions where drawn vertically.
    _________________________________________________________________________________________

    Check for junctions for default transitions
    All Junctions in a flow chart should have a default exit transition.

    Passed
    All Junctions have a default exit transition.
    _________________________________________________________________________________________

    Check for transitions that combine condition and action
    Flowcharts should not combine condition evaluations and action expressions in a single transition.

    Passed
    No combined expressions where found in the chart.



                MATLAB Functions


            Requirements Consistency Checking


            Simulation Accuracy


            Simulation Runtime Accuracy Diagnostics


     Check if Read/Write diagnostics are enabled for Data Store blocks

    Note: These runtime diagnostics may slow down simulation considerably. You should set them back to Disable all once you have verified that they do not cause any warnings or errors during simulation.



            Simulink Model File Integrity

            Upgrading to the Current Simulink Version