This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Implementation

Component Implementation

Component Documentation

1 - MotCurrRegVltgLimr_Integration Manual

Integration Manual

For

‘MotCurrRegVltgLimr’

VERSION: 1.0

DATE: 26-May-2015

Prepared By:

Selva Sengottaiyan

Nexteer Automotive,

Saginaw, MI, USA


Revision History

: ARM Cortex R4 Memory Usage

Sl. No.DescriptionAuthorVersionDate
1Initial versionSelva Sengottaiyan1.04-June-2015


Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 Non RTE NvM Blocks 10

7.4 RTE NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

AbbreviationDescription
DFDDesign functional diagram
MDDModule design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.TitleVersion
1FDD – SF105A_MotCurrRegVltgLimr_DesignSee Synergy sub project version
2Software Naming ConventionsProcess 4.00.00
3Software Design and Coding StandardsProcess 4.00.00

Dependencies

SWCs

ModuleRequired Feature
None

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

ModulesNotes
None

Configuration Files to be provided by Integration Project

None

Da Vinci Parameter Configuration Changes

ParameterNotesSWC
None

DaVinci Interrupt Configuration Changes

ISR NameVIM #Priority DependencyNotes
None

Manual Configuration Changes

ConstantNotesSWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file in the FDD

Required Global Data Outputs

Refer DataDict.m file file in the FDD

Specific Include Path present

Yes

Runnable Scheduling

This section specifies the required runnable scheduling.

InitScheduling RequirementsTrigger
MotCurrRegVltgLimrInit1NoneInit
RunnableScheduling RequirementsTrigger
MotCurrRegVltgLimrPer1Motor Control ISR*2

Memory Map REQUIREMENTS

Mapping

Memory SectionContentsNotes
MotCtrl_START_SEC_CODECode section for Motor Control scheduled functions

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

FeatureRAMROM
<Memmap usuage info>

Non RTE NvM Blocks

Block Name
None

RTE NvM Blocks

Block Name
none

Compiler Settings

Preprocessor MACRO

None.

Optimization Settings

None

Appendix

None

2 - MotCurrRegVltgLimr_MDD

Module Design Document

For

‘MotCurrRegVltgLimr’

VERSION: 3.0

DATE: 7-Nov-2016

Prepared By:

Matthew Leser,

Nexteer Automotive,

Saginaw, MI, USA


Location: The official version of this document is stored in the Nexteer Configuration Management System.

Revision History

Sl. No.DescriptionAuthorVersionDate
1Initial VersionSelva Sengottaiyan1.026-May-2015
2Updated graphical representation and added local function informationNick Saxton2.013-Apr-2016
3Updated for FDD v2.1.0Matthew Leser3.07-Nov-2016


Table of Contents

1 Abbrevations And Acronyms 5

2 References 6

3 High-Level Description 7

4 Design details of software module 8

4.1 Graphical representation 8

4.2 Data Flow Diagram 8

4.2.1 Module level DFD 8

4.2.2 Sub-Module level DFD 8

4.3 COMPONENT FLOW DIAGRAM 8

5 Variable Data Dictionary 9

5.1 User defined typedef definition/declaration 9

5.2 Variable definition for enumerated types 9

6 Constant Data Dictionary 10

6.1 Program(fixed) Constants 10

6.1.1 Embedded Constants 10

6.1.1.1 Local 10

6.1.1.2 Global 10

6.1.2 Module specific Lookup Tables Constants 10

7 Software Module Implementation 11

7.1 Sub-Module Functions 11

7.1.1 Initialization Functions 11

7.1.1.1 INIT: MotCurrRegVltgLimrInit1 11

7.1.1.1.1 Design Rationale 11

7.1.1.1.2 Module Outputs 11

7.1.1.1.3 Module Internal 11

7.1.2 PERIODIC FUNCTIONS 11

7.1.2.1 INIT: MotCurrRegVltgLimrPER1 11

7.1.2.1.1 Design Rationale 11

7.1.2.1.2 Module Outputs 11

7.1.3 Interrupt Functions 11

7.1.4 Server runnables 12

7.1.4.1.1 Store Local copy of outputs into Module Outputs 12

7.1.5 Local Function/Macro Definitions 12

7.1.5.1.1 Local function #1 12

7.1.5.1.2 Local function #2 12

7.1.5.1.3 Local function #3 12

7.1.6 GLObAL Function/Macro Definitions 12

7.1.7 Tranisition FUNCTIONS 13

8 Known Limitations With Design 14

9 UNIT TEST CONSIDERATION 15

10 Appendix 16

Abbrevations And Acronyms

AbbreviationDescription
DFDDesign functional diagram
MDDModule design Document
FDDFunctional Design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.TitleVersion
1MDD GuidelinesProcess 4.02.01
2Software Naming ConventionsProcess 4.02.01
3Software Design and Coding standardsProcess 4.02.01
4FDD – SF105A_MotCurrRegVltgLimr_DesignSee Synergy sub project version

High-Level Description

None

Design details of software module

Graphical representation

Data Flow Diagram

Refer FDD

Module level DFD

Refer FDD

Sub-Module level DFD

Refer FDD

COMPONENT FLOW DIAGRAM

Refer FDD

Variable Data Dictionary

User defined typedef definition/declaration

<This section documents any user types uniquely used for the module.>

Typedef NameElement NameUser Defined Type

Legal Range

(min)

Legal Range

(max)

None

Variable definition for enumerated types

Enum NameElement NameValue
None

Constant Data Dictionary

Program(fixed) Constants

Embedded Constants

Local

Constant NameResolutionUnitsValue
MODIDXHILIM_VOLT_F32Single precision floatVolt1
MODIDXLOLIM_VOLT_F32Single precision floatVolt0

Global

Constant Name

Module specific Lookup Tables Constants

None

Software Module Implementation

Sub-Module Functions

Initialization Functions

MotCurrRegVltgLimrInit1

INIT: MotCurrRegVltgLimrInit1

Design Rationale

Design follows implemenetation in FDD.

Module Outputs

Refer ‘MotCurrRegVltgLimrInit’ block in FDD

Module Internal

None

PERIODIC FUNCTIONS

INIT: MotCurrRegVltgLimrPER1

Design Rationale

Design follows implemenetation in FDD.

Module Outputs

Design follows implemenetation in FDD.

Interrupt Functions

None


Server runnables

None

Store Local copy of outputs into Module Outputs

None

Local Function/Macro Definitions

Local function #1

Function NameKpKiCtrlTypeMinMax
Arguments PassedMotPropGain_Ohm_T_f32Float3202.25
MotIntglGain_Ohm_T_f32Float3203.6
SysSt_Cnt_T_enumEnumSYSST_DISYSST_WRMININ
CmdErr_Ampr_T_f32Float32-200400
*MotVltgIntglCmdPrev_Volt_T_f32Float32-10001000
*MotCurrRegVltgLimrMotVltgPropCmd_Volt_T_f32Float32-26.526.5
*MotCurrRegVltgLimrMotVltgIntglPreLim_Volt_T_f32Float32-26.526.5
MotVltgIntglLoLim_Volt_T_f32Float32-310
MotVltgIntglHiLim_Volt_T_f32Float32031
*MotVltgPropCmd_Volt_T_f32Float32-26.526.5
*MotVltgIntglCmd_Volt_T_f32Float32626.5

* MotVltgPropCmd_Volt_T_f32 and * MotVltgIntglCmd_Volt_T_f32 are outputs of this function.

Local function #2

Function NameErrorCalcQaxTypeMinMax
Arguments PassedQaxCurrCmd_Ampr_T_f32Float32-200200
QaxRplCmd_Ampr_T_f32Float32-2929
QaxCoggCmd_Ampr_T_f32Float32-66
QaxCurrModif_Ampr_T_f32Float32-200200
* QaxCmdFinal_Ampr_T_f32Float32-200200
ReturnsCmdErrQax_Ampr_T_f32Float32-200400

*QaxCmdFinal_Ampr_T_f32 is also an output of this function.

Local function #3

Function NameLoaScaFacTypeMinMax
Arguments PassedCurrLoaMtgtnEn_Cnt_T_loglBooleanFALSETRUE
IvtrLoaMtgtnEn_Cnt_T_loglBooleanFALSETRUE
MotCtrlDualEcuMotCtrlMtgtnEna_Cnt_T_loglBooleanFALSETRUE
*CurrLoaScaFac_Uls_T_f32Float3201
*IvtrLoaScaFac_Uls_T_f32Float3201
*DualEcuScaFac_Uls_T_f32Float3201

*CurrLoaScaFac_Uls_T_f32, *IvtrLoaScaFac_Uls_T_f32, and *DualEcuScaFac_Uls_T_f32 are outputs of this function.

Local function #4

Function NameMotCurr_PredTypeMinMax
Arguments PassedMotInduQaxEstimdIvs_IvsHenry_T_f32Float32224033334
MotREstimd_Ohm_T_f32Float320.0050.12565
CurrQax_Ampr_T_f32Float32-200200
MotVltgQaxPrev_Volt_T_f32Float32-26.526.5
CurrDax_Ampr_T_f32Float32-200200
MotVltgDaxPrev_Volt_T_f32Float32-26.526.5
MotBackEmfVltg_Volt_T_f32Float32-101.25101.25
ReacncQax_Ohm_T_f32Float32-0.50.5
ReacncDax_Ohm_T_f32Float32-0.50.5
MotInduDaxEstimdIvs_IvsHenry_T_f32Float32224033334
MotCurrRegVltgLimrMotCurrPredEna_Cnt_T_f32BooleanFALSETRUE
MotCtrlCurrPredTi_NanoSec_T_f32Float320125000
*MotCurrQaxPred_Ampr_T_f32Float32-200200
*MotCurrDaxPred_Ampr_T_f32Float32-200200

*MotCurrQaxPred_Ampr_T_f32 and *MotCurrDaxPred_Ampr_T_f32 are outputs of this function.

GLObAL Function/Macro Definitions

None

Tranisition FUNCTIONS

None

Known Limitations With Design

None

UNIT TEST CONSIDERATION

None

Appendix

None

3 - MotCurrRegVltgLimr_Peer Review Checklists

Overview

Summary Sheet
Synergy Project
Davinci Files
Source Code
Source Code1
MDD
PolySpace

Sheet 1: Summary Sheet
























Rev 1.28-Jun-15

Peer Review Summary Sheet


























Synergy Project Name:


kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. SF105A_MotCurrRegVltgLimr_Impl
Revision / Baseline:


kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. 2.0.0

























Change Owner:


kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Matthew Leser
Work CR ID:


EA4#7548





























kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:















































































































































































kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:






















































Reviewed:































YesMDD


YesSource Code


YesPolySpace









































Integration Manual


YesDavinci Files








































































Comments:

Review Changes Only






Updated Checklist with correct revision/baseline number



















































































General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.




















Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)



















































Quality Check Items:




































Rationale is required for all answers of No










New baseline version name from Summary Sheet follows








Yes
Comments:



naming convention





































Project contains necessary subprojects








Yes
Comments:










































Project contains the correct version of subprojects








Yes
Comments:










































Design subproject is correct version








Yes
Comments:











































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Matthew Leser


Review Date :

11/14/16
































Lead Peer Reviewer:


Shruthi R


Approved by Reviewer(s):



Yes































Other Reviewer(s):









































































Sheet 3: Davinci Files






















Rev 1.28-Jun-15
Peer Review Meeting Log (Davinci Review)


























Quality Check Items:




































Rationale is required for all answers of No










Only StdDef Port types are used









Comments:










































For components not using application data types, do all









Comments:



port interface names end in PortIf and a sequence number





























































Non-program-specific components saved









Comments:




in Autosar 4.0.3 format




































*Cfg.arxml.TT: Verfied Davinci Configurator imported the









Comments:




change correctly




































*Cfg.h.TT: Verfied Davinci Configurator generates









Comments:










the configuration header(s) file correctly
kzshz2: Either a generic sandbox or a baselined integration project can be used to verify



























kzshz2: Either a generic sandbox or a baselined integration project can be used to verify
















All changed files have been compared against previous









Comments:




versions (If available)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. This is for text files only, not binary or GUIs Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.


































Automated validation check is performed









Comments:

























































Naming conventions followed. All names should









Comments:










match DataDict.m













































Sender/Receiver port properties match DataDict.m









Comments:










file (use .m file helper tool)













































Calibration port properties match DataDict.m









Comments:










file (use .m file helper tool)













































Components using application data types:























Sender/Receiver port initialization values match








Comments:










DataDict.m file














































Calibration port initialization values match








Comments:










DataDict.m file













































Components not using application data types:























Sender/Receiver port initialization values match








Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Calibration port initialization values match








Comments:










DataDict.m file and have been converted to counts






















for fixed point types














































Mapping set and all unused items have been








Comments:










removed













































All sender/receiver port read/writes using direct









Comments:










read/writes(List justification if not)













































Runnable calling frequencies match FDD









Comments:

































DataDict.m display variables: created as









Comments:









PerInstanceMemory. Matches the FDD





































Component is correct component type









Comments:











































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:



Review Date :



Component Type :































Lead Peer Reviewer:




Approved by Reviewer(s):






































Other Reviewer(s):









































































Sheet 4: Source Code






















Rev 1.28-Jun-15
Peer Review Meeting Log (Source Code Review)

























Source File Name:


CDD_MotCurrRegVltgLimr.c

Source File Revision:


4
Header File Name:


N/A

Header File Revision:


kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this. N/A

























MDD Name:

MotCurrRegVltgLimr_MDD.docx
Revision:
3

























FDD/SCIR/DSR/FDR/CM Name:




SF105A_MotCurrRegVltgLimr_Design
Revision:
2.1.0


























Quality Check Items:



































Rationale is required for all answers of No









Working EA4 Software Naming Convention followed:















































for variable names







N/A
Comments:

















































for constant names







N/A
Comments:

















































for function names







N/A
Comments:

















































for other names (component, memory







N/A
Comments:










mapping handles, typedefs, etc.)




































All paths assign a value to outputs, ensuring








Yes
Comments:









all outputs are initialized prior to being written





































Requirements Tracability tags in code match the requirements tracability in the FDD








N/A
Comments:









requirements tracability in the FDD





































All variables are declared at the function level.








N/A
Comments:
























Synergy version matches change history





kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.


Yes
Comments:



and Version Control version in file comment block





































Change log contains detailed description of changes








Yes
Comments:



and Work CR number





































Code accurately implements FDD (Document or Model)








Yes
Comments:










































Verified no Compiler Errors or Warnings


KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used; QAC can find compiler errors but not warnings.





Yes
Comments:
















































Component.h is included








N/A
Comments:
























All other includes are actually needed. (System includes








Yes
Comments:









only allowed in Nexteer library components)





































Software Design and Coding Standards followed:











Version:

























Code comments are clear, correct, and adequate







Yes
Comments:










and have been updated for the change: [N40] and













all other rules in the same section as rule [N40],






















plus [N75], [N12], [N23], [N33], [N37], [N38],






















[N48], [N54], [N77], [N79], [N72]














































Source file (.c and .h) comment blocks are per







Yes
Comments:










standards and contain correct information: [N41], [N42]





































Function comment blocks are per standards and







Yes
Comments:










contain correct information: [N43]





































Code formatting (indentation, placement of







Yes
Comments:










braces, etc.) is per standards: [N5], [N55], [N56],













[N57], [N58], [N59]














































Embedded constants used per standards; no







N/A
Comments:










"magic numbers": [N12]





































Memory mapping for non-RTE code







N/A
Comments:










is per standard





































All execution-order-dependent code can be







N/A
Comments:










recognized by the compiler: [N80]





































All loops have termination conditions that ensure







N/A
Comments:










finite loop iterations: [N63]





































All divides protect against divide by zero







N/A
Comments:










if needed: [N65]





































All integer division and modulus operations







N/A
Comments:










handle negative numbers correctly: [N76]





































All typecasting and fixed point arithmetic,







N/A
Comments:










including all use of fixed point macros and













timer functions, is correct and has no possibility






















of unintended overflow or underflow: [N66]














































All float-to-unsiged conversions ensure the.







N/A
Comments:










float value is non-negative: [N67]





































All conversions between signed and unsigned







N/A
Comments:










types handle msb==1 as intended: [N78]





































All pointer dereferencing protects against







N/A
Comments:










null pointer if needed: [N70]





































Component outputs are limited to the legal range







N/A
Comments:










defined in the FDD DataDict.m file : [N53]





































All code is mapped with FDD (all FDD







Yes
Comments:










subfunctions and/or model blocks identified













with code comments; all code corresponds to






















some FDD subfunction and/or model block): [N40]













































Review did not identify violations of other








Yes
Comments:









coding standard rules





































Anomaly or Design Work CR created








N/A
Comments: List Anomaly or CR numbers









for any FDD corrections needed































































General Notes / Comments:

















































































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Matthew Leser


Review Date :

11/14/16
































Lead Peer Reviewer:


Shruthi R


Approved by Reviewer(s):



Yes































Other Reviewer(s):









































































Sheet 5: Source Code1






















Rev 1.28-Jun-15
Peer Review Meeting Log (Source Code Review)

























Source File Name:


CDD_MotCurrRegVltgLimr_MotCtrl.c

Source File Revision:


8
Header File Name:


N/A

Header File Revision:


kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this. N/A

























MDD Name:

MotCurrRegVltgLimr_MDD.docx
Revision:
3

























FDD/SCIR/DSR/FDR/CM Name:




SF105A_MotCurrRegVltgLimr_Design
Revision:
2.1.0


























Quality Check Items:



































Rationale is required for all answers of No









Working EA4 Software Naming Convention followed:















































for variable names







Yes
Comments:

















































for constant names







Yes
Comments:

















































for function names







Yes
Comments:

















































for other names (component, memory







N/A
Comments:










mapping handles, typedefs, etc.)




































All paths assign a value to outputs, ensuring








Yes
Comments:









all outputs are initialized prior to being written





































Requirements Tracability tags in code match the requirements tracability in the FDD








N/A
Comments:









requirements tracability in the FDD





































All variables are declared at the function level.








Yes
Comments:
























Synergy version matches change history





kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.


Yes
Comments:



and Version Control version in file comment block





































Change log contains detailed description of changes








Yes
Comments:



and Work CR number





































Code accurately implements FDD (Document or Model)








Yes
Comments:










































Verified no Compiler Errors or Warnings


KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used; QAC can find compiler errors but not warnings.





Yes
Comments:
















































Component.h is included








N/A
Comments:
























All other includes are actually needed. (System includes








Yes
Comments:









only allowed in Nexteer library components)





































Software Design and Coding Standards followed:











Version:

























Code comments are clear, correct, and adequate







Yes
Comments:










and have been updated for the change: [N40] and













all other rules in the same section as rule [N40],






















plus [N75], [N12], [N23], [N33], [N37], [N38],






















[N48], [N54], [N77], [N79], [N72]














































Source file (.c and .h) comment blocks are per







Yes
Comments:










standards and contain correct information: [N41], [N42]





































Function comment blocks are per standards and







Yes
Comments:










contain correct information: [N43]





































Code formatting (indentation, placement of







Yes
Comments:










braces, etc.) is per standards: [N5], [N55], [N56],













[N57], [N58], [N59]














































Embedded constants used per standards; no







Yes
Comments:










"magic numbers": [N12]





































Memory mapping for non-RTE code







Yes
Comments:










is per standard





































All execution-order-dependent code can be







Yes
Comments:










recognized by the compiler: [N80]





































All loops have termination conditions that ensure







N/A
Comments:










finite loop iterations: [N63]





































All divides protect against divide by zero







N/A
Comments:










if needed: [N65]





































All integer division and modulus operations







N/A
Comments:










handle negative numbers correctly: [N76]





































All typecasting and fixed point arithmetic,







N/A
Comments:










including all use of fixed point macros and













timer functions, is correct and has no possibility






















of unintended overflow or underflow: [N66]














































All float-to-unsiged conversions ensure the.







N/A
Comments:










float value is non-negative: [N67]





































All conversions between signed and unsigned







N/A
Comments:










types handle msb==1 as intended: [N78]





































All pointer dereferencing protects against







Yes
Comments:










null pointer if needed: [N70]





































Component outputs are limited to the legal range







Yes
Comments:










defined in the FDD DataDict.m file : [N53]





































All code is mapped with FDD (all FDD







Yes
Comments:










subfunctions and/or model blocks identified













with code comments; all code corresponds to






















some FDD subfunction and/or model block): [N40]













































Review did not identify violations of other








Yes
Comments:









coding standard rules





































Anomaly or Design Work CR created








N/A
Comments: List Anomaly or CR numbers









for any FDD corrections needed































































General Notes / Comments:

















































































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Matthew Leser


Review Date :

11/14/16
































Lead Peer Reviewer:


Shruthi R


Approved by Reviewer(s):



Yes































Other Reviewer(s):









































































Sheet 6: MDD






















Rev 1.28-Jun-15
Peer Review Meeting Log (MDD Review)


























MDD Name:

MotCurrRegVltgLimr_MDD.docx
MDD Revision:

3


























Source File Name:


CDD_MotCurrRegVltgLimr.cSource File Revision:


4

Source File Name:


CDD_MotCurrRegVltgLimr_MotCtrl.cSource File Revision:


8

Source File Name:















Source File Revision:






























Quality Check Items:




































Rationale is required for all answers of No










Synergy version matches document








Yes
Comments:













































Change log contains detailed description of changes








Yes
Comments:













































Changes Highlighted (for Unit Tester)








Yes
Comments:













































Diagrams have been included per MDD Guideline








Yes
Comments:











and reviewed






































All Design Exceptions and Limitations are listed








N/A
Comments:



















































Design rationale given for all global








N/A
Comments:











data not communicated through RTE ports, per














Design and Coding Standards rules [N9] and [N10].















































All implementation details that differ from the FDD are








N/A
Comments:











noted and explained in Design Rationale






































All Unit Test Considerations have been described








N/A
Comments:



















































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Matthew Leser


Review Date :

11/14/16
































Lead Peer Reviewer:


Shruthi R


Approved by Reviewer(s):



Yes































Other Reviewer(s):









































































Sheet 7: PolySpace






















Rev 1.28-Jun-15
Peer Review Meeting Log (QAC/PolySpace Review)


























Source File Name:


CDD_MotCurrRegVltgLimr.cSource File Revision:


4

Source File Name:


CDD_MotCurrRegVltgLimr_MotCtrl.cSource File Revision:


8

Source File Name:















Source File Revision:






























EA4 Static Analysis Compliance Guideline version:







Draft 1.02.00







Poly Space version:


Windows User: eg. 2013b 2013b
Polyspace sub project version:




Windows User: eg. TL108a_PolyspaceSuprt_1.0.0 N/A

QAC version:


Windows User: eg 8.1.1-R 8.1.1-R
QAC sub project version:




Windows User: eg. TL_100A_1.1.0 TL_100A_1.2.0


























Quality Check Items:




































Rationale is required for all answers of No



































Contract Folder's header files are appropriate and





kzshz2: Intended Use: Identify that the contract folder contains only the information required for this component. All other variables, constants, function prototypes, etc. should be removed. Rationale: This will help avoid unit testers having to considers object not used. It will also avoid having other files required for QAC.


Yes
Comments:




function prototypes match the latest component version







































100% Compliance to the EA4 Static AnalysisYes
Comments:





Compliance Guideline





























Are previously added justification and deviation








Yes
Comments:





comments still appropriate






































Do all MISRA deviation comments use approved








Yes
Comments:





deviation tags






































Cyclomatic complexity and Static path count OK






Creager, Kathleen: use Browse Function Metrics, STCYC and STPTH

Yes
Comments:





for all functions in the component per Design














and Coding Standards rule [N47]

































































































General Notes / Comments:



























































LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:


























Change Owner:

Matthew Leser


Review Date :

11/14/16
































Lead Peer Reviewer:


Shruthi R


Approved by Reviewer(s):



Yes































Other Reviewer(s):









































































4 - requirements

FDDIDSourceFunctionLine(s)StatusComment
.SwFileName.SwFuncName.SwLines.SwStatus.SwComment
SF105A153CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1134I
SF105A155CDD_MotCurrRegVltgLimr.cMotCurrRegVltgLimrInit1153,154I
SF105A135CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1188-201I
SF105A156CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1281-286I
SF105A158CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1283-288I
SF105A67CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1174-182I
SF105A115CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1328,359-384I
SF105A61CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1436I
SF105A62CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1440I
SF105A89CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1224-275I
SF105A137CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1206-219I
SF105A136CDD_MotCurrRegVltgLimr.cMotCurrRegVltgLimrInit1154I
SF105A66CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1173-184I
SF105A134CDD_MotCurrRegVltgLimr.cMotCurrRegVltgLimrInit1154I
SF105A68CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1175-183I
SF105A80CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1160-170I
SF105A93CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1239-265I
SF105A84CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1207-220I
SF105A85CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1205-218I
SF105A171CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1357-373I
SF105A27CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1141I
SF105A63CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1439I
SF105A48CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1143I
SF105A49CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1151I
SF105A46CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1135I
SF105A47CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1142I
SF105A44CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1153I
SF105A45CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1152I
SF105A42CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1146I
SF105A43CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1148I
SF105A40CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1147I
SF105A41CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1149I
SF105A97CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1242-268I
SF105A28CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1437I
SF105A172CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1358-374I
SF105A122CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1388-410I
SF105A141CDD_MotCurrRegVltgLimr.cMotCurrRegVltgLimrInit1151,152I
SF105A120CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1329-385I
SF105A121CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1387-409I
SF105A108CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1297-316I
SF105A74CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1189-202I
SF105A168CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1134,139I
SF105A126CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1413-432I
SF105A102CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1280-285I
SF105A90CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1243-269I
SF105A166CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1133I
SF105A101CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1282-287I
SF105A95CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1241-267I
SF105A161CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1154I
SF105A79CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1159-169I
SF105A96CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1240-266I
SF105A118CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1377,378,379I
SF105A60CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1438I
SF105A38CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1137I
SF105A59CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1139I
SF105A58CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1133I
SF105A57CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1136I
SF105A56CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1140I
SF105A51CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1144I
SF105A50CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1150I
SF105A53CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1138I
SF105A52CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1145I
SF105A130CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1414-433I
SF105A107CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1296-315I
SF105A116CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1327,334-383I
SF105A94CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1225-276I
SF105A73CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1187-200I
SF105A111CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1319-325I
SF105A175CDD_MotCurrRegVltgLimr_MotCtrl.cMotCurrRegVltgLimrPer1389-411I