This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Design

1: EA4 NTC 0x1F1 PwrpkCmpblty
2: SF054A_PwrpkCmptbltyChk_Peer Review Checklist Design

Component Design

Component Documentation

1 - EA4 NTC 0x1F1 PwrpkCmpblty

Slide 1

Nexteer Confidential

<PwrpkCmpblty> Overview
NTC 0x1F1

FDD: <SF054A>

Description:

The NTC will be SET when the Powerpack is not compatible with the Gear.

This means when either the Gear ID’s are Invalid or they don’t correlate to each other or

don’t correlate with the Gear ID calibration value.

Diagnostic Overview:

The diagnostics will start only after 500msec. Once 500 msec is elapsed, the detection

shall be done and the respective bits of NTC shall be set.

Following is the NTC bit definition

•PwrpkCmpblty.NtcStInfo.Bit0Descr = 'Gear ID input #1 timed out or was otherwise invalid';
•PwrpkCmpblty.NtcStInfo.Bit1Descr = 'Gear ID input #2 timed out or was otherwise invalid';
•PwrpkCmpblty.NtcStInfo.Bit2Descr = 'Gear ID inputs do not correlate to each other';
•PwrpkCmpblty.NtcStInfo.Bit3Descr = 'Gear ID inputs do not

Typical Fault Response:

- –F3 Notify driver

Probable Sources (Most to Least Probable):
Gear ID in PHA does not match Gear ID on CCA

Gear ID’s do not match each other

Gear ID’s are invalid from PHA

Gear ID’s are not provided in less than 500ms

Initialization
Periodic	X
Event

Nexteer Confidential

Rev	Revision
6 April 2016	Initial Release

Revision Log

2 - SF054A_PwrpkCmptbltyChk_Peer Review Checklist Design

Nexteer_Template_V1.0

Overview

Peer Review Instructions
Technical Review Checklist
Template Change Log

Sheet 1: Peer Review Instructions

Instructions for Functional Design Package Peer Review

PRE-MEETING
	Function Owner	Confirm that requirements are reviewed and approved PRIOR to the FDP peer review
	Function Owner	Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews
	Function Owner	Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review
	Function Owner	Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting
	Function Owner	Identify necessary attendance and invite to meeting
	Function Owner	Complete the "Author" column information for sections 1 through 3 prior to the review
	Function Owner	Complete the attendance invitation list in section 5
	Function Owner	For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews.

DURING MEETING
	Function Owner	Present document changes to the review team
	Peer Reviewer	Capture attendance of the review
	Peer Reviewer	Capture actions and issues in section 4. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN"

POST MEETING
	Function Owner	Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided.
	Function Owner	Schedule follow up review OR review open items with peer reviewer and obtain agreement to close
	Peer Reviewer	Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates

Sheet 2: Technical Review Checklist

Technical Review Checklist - Template Version 02.00.00

Product Name

SF054A_PwrpkCmptbltyChk

Electrical Arch.

Review Scope

Defect Type

Numbers

Yes

Closed

Function ID

SF054A

EA4#4854 Design Implementation

Requirement

Rejected

FDD

Long Name

Interface

Open

Model

Version that you started from. NOT the version you hope to release. If this will be v1.0.0, enter NA. Starting Baseline

Effort

Design

Model and m file

Author

Nimmy Mathews

Review Effort(Hrs.)

0.20

Standards

*.m File

Corr+Verf effort(Hrs.)

3.00

Documentation

Total Effort (Hrs.)

3.20

Others

Total

Checklist No.

Description of Check

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Section 1: Data Dictionary

Is Filename of Data Dictionary in correct format?

Yes

Is the FDD.Version property correctly updated?

Yes

Is the Data Dictionary Verification report error free?

Outputs signal names and units are not found in known nexteer signals.

Does FDD Long Name, Short Name, and Description match requirements?

Yes

Are all runnables defined?

Yes

Do runnables have the correct time step?

Yes

Do server runnables correctly define arguments?

Are all clients defined?

Yes

Do client definitions match the corresponding server runnable?

Does name and metadata of every signal match its corresponding interface signal?

Yes

Do output signal ranges match requirements (check DOOR min/max attributes too)?

Are calibration tables named correctly (e.g. AssiX and AssiY)?

Do all calibrations have correct values for all metadata?

Yes

Is NVM defined in the appropriate number of blocks?

Are constants defined with proper scope (local vs global)?

Are all dependent constants and calibrations included in one file?

Yes

Does FDD.DesignASIL match requirements?

Yes

Section 2: Model

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Is filename of model in correct format?

Yes

Is Top level of model annotated with Requirements Baseline?

Yes

Is the Top level of the model annotated with Tool Dependencies?

Yes

Is Top level of model annotated with Change Log or History?

Yes

Does the Component shortname match data dictionary FDD metadata?

Yes

Is the 2nd level of model free from subsystems that are not Function-Call Subsystems?

Yes

Is the 2nd level of model free from arithmetic and logic operations?

Yes

Are the Runnable trigger signals named as "call_<Runnable>"?

Yes

Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number?

Yes

Are all data flow layers free of Function-Call Subsystems and Memory Store blocks?

Yes

Does the Model have the confidentiality and copyright information inside all its Subsystems?

Yes

Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model?

Yes

Do all Memory Store blocks for PIM and Display Variables have the "Data store name must resolve to Simulink signal object" setting checked to true?

Yes

Is each diagnostic (NTC) capable of being set to "PASS"?

Yes

Does non-zero intialization of PIM occur in the function's Init runnable?

Does design properly include Set Ram Block Status when NVM RAM values change?

Does model include appropriate logic for dealing with missing or corrupted NVM data?

Does model execute without errors/warnings after loading NxtrMBDConfig configuration set?

Section 3: Requirements Linking

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Are all requirements links of the format <FDDNumber>_<ObjectID>?

Yes

Does requirements HTML report reference only the DOORS module of this component for all links in the design?

Yes

Are linked blocks linked to the correct requirements(s)? (watch for problems due to copy/pasted blocks)

Yes

Is the list of unlinked blocks acceptable?

There are some blocks/subsystems unlinked. Need to correct this.

Standards

Section 4: Model Advisor

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Was Model Advisor run with the correct configuration settings?

Yes

Is the Model Advisor report free from "Fails".

Can incorporate the signal names

Documentation

Comments accepted and corrected in the design

Are Model Advisor report "Warnings" acceptable?

Yes

Section 5: Delivery Package

Author: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. Author

Author: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. Reviewer

Author: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewer

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script?

Yes

Does Doc folder contain a zipped HTML webview model?

Needs to create after the review

Comments accepted and corrected in the design

Was webview model created without requirements highlighted?

Does Reports folder contain only the data dictionary verification report, zipped Model Advisor report, and zipped requirements traceability report?

Yes

Section 6: Other Issus/Actions Identified

Document

Reference

Summary of resolution

Author: Defect type to be selected. Defect Type

Author: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author

Author: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status

The logic to determine the Correlation GearId is wrong and needs to be corrected

Model

Design

Comments accepted and corrected in the design

Closed

Compatibility short name should be corrected

Model and m file

Standards

Comments accepted and corrected in the design and m file

Closed

Debounce constant needs to be replaced for the NTC block and cannot be grounded

Model and m file

Standards

Comments accepted and corrected in the design and m file

Closed

Correlation Fault check subsystem needs to get aligned to right of the Gear Id validation check subsystem

Model

Design

Comments accepted and corrected in the design

Closed

The switch used to assign constant needs to be replaced by the if else subsystems.

Model

Design

Comments accepted and corrected in the design

Closed

Change the NTC Implementation to increase the throughput. Don’t call PASSED more than once if it continues to be PASSED

Model

Design

Comments accepted and corrected in the design

Closed

Change the Init function name to Init1

Model and m file

Design

Comments accepted and corrected in the design

Closed

Change 0 and 1 to false and true to have consistency in the model

Model

Design

Comments accepted and corrected in the design

Closed

Added requirement for clearing the NTC

Requirement

Comments accepted and corrected the requirement

Closed

Typo error in GearId1Vld check where validation status should be changed from false to true.

Model

Design

Comments accepted and corrected the requirement

Closed

Traceability link to a different SF existed in the Fault block needs to be removed.

FDD

Design

Comments accepted and corrected the requirement

Closed

Section 7: APPROVALS

Role

First Review

Date

Attendance

Approval?

Function Owner*

Matthew Tompkins

3/30/2016

Yes

Peer Reviewer*

Kevin Derry

Yes

Safety

Software

ESG / Systems

Price Lefler

Yes

EPDT / CSE

Hardware

Test

Role

Second Review (if required)

Date

Attendance

Approval?

Function Owner*

Peer Reviewer*

Safety

Software

ESG / Systems

EPDT / CSE

Hardware

Test

Role

Third Review (if required)

Date

Attendance

Approval?

Function Owner*

Peer Reviewer*

<Name>

Safety

Software

ESG / Systems

EPDT / CSE

Hardware

Test

Role

Fourth Review (if required)

Date

Attendance

Approval?

Function Owner*

Peer Reviewer*

<Name>

Safety

Software

ESG / Systems

EPDT / CSE

Hardware

Test

Role

Add more if necessary

Date

Attendance

Approval?

P.S.:

Yes indicates adherence

No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point.

NA indicates not applicable

Sheet 3: Template Change Log

Rev	Change	Author