1 - SF043A_TqOscn_Design_PeerReviewChkList

Nexteer_Template_V1.0

Overview

Peer Review Instructions
Technical Review Checklist
Template Change Log


Sheet 1: Peer Review Instructions

Instructions for Functional Design Package Peer Review




PRE-MEETING


Function OwnerConfirm that requirements are reviewed and approved PRIOR to the FDP peer review

Function OwnerStart with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews

Function OwnerProvide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review

Function OwnerNotify the assigned peer reviewer and make sure they are prepared to do their function in the meeting

Function OwnerIdentify necessary attendance and invite to meeting

Function OwnerComplete the "Author" column information for sections 1 through 5 prior to the review

Function OwnerComplete the attendance invitation list in section 7

Function OwnerFor Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews.



DURING MEETING


Function OwnerPresent document changes to the review team

Peer ReviewerCapture attendance of the review

Peer ReviewerCapture actions and issues in section 6. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN"



POST MEETING


Function OwnerFollow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided.

Function OwnerSchedule follow up review OR review open items with peer reviewer and obtain agreement to close

Peer ReviewerClose change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates

Sheet 2: Technical Review Checklist

Technical Review Checklist - Template Version 02.02.00







Product NameElectric Power SteeringElectrical Arch.4Review ScopeDefect TypeNumbers




YesClosedFR
Function IDSF043A_TqOscn

Initial ReleaseRequirement0




NoRejectedFDD
Long NameTorque Oscillation

Interface0




NAOpenModel
Version that you started from. NOT the version you hope to release. If this will be v1.0.0, enter NA. Starting Baselinenone, trying to baseline v1.0.0EffortDesign1






FMEA
AuthorTejas Varunjikar (this sheet filled out by Kevin Derry)Review Effort(Hrs.)6.00Standards0






*.m File


Corr+Verf effort(Hrs.)1.00Documentation0






Cal Process


Total Effort (Hrs.)7.00Others0













Total1







Checklist No.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1Section 1: Data Dictionary














Is Filename of Data Dictionary in correct format?Yes













Is the FDD.Version property correctly updated?Yes













Is the Data Dictionary Verification report error free?No


FltInj and Std_On naming are known violations of VerifyDD but are deemed acceptable deviations.Closed








Does FDD Long Name, Short Name, and Description match requirements?NA













Are all runnables defined?Yes













Do runnables have the correct time step?Yes













Do server runnables correctly define arguments?NA













Are all clients defined?Yes













Do client definitions match the corresponding server runnable?Yes













Does name and metadata of every signal match its corresponding interface signal?Yes













Do output signal ranges match requirements (check DOOR min/max attributes too)?NA













Are calibration tables named correctly (e.g. AssiX and AssiY)?Yes













Are all data types represented by released Data_Management classes?Yes













Do all calibrations have correct values for all metadata?Yes













Is NVM defined in the appropriate number of blocks?NA













Are constants defined with proper scope (local vs global)?Yes













Are all dependent constants and calibrations included in one file?Yes













Does FDD.DesignASIL match requirements?NA




























2Section 2: ModelAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status








Is filename of model in correct format?Yes













Is Top level of model annotated with Requirements Baseline?Yes













Is the Top level of the model annotated with Tool Dependencies?Yes













Is Top level of model annotated with Change Log or History?Yes













Is the 2nd level of model free from subsystems that are not Function-Call Subsystems?Yes













Is the 2nd level of model free from arithmetic and logic operations?Yes













Are the Runnable trigger signals named as "call_<Runnable>"?Yes













Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number?Yes













Are all data flow layers free of Function-Call Subsystems and Memory Store blocks?Yes













Does the Model have the confidentiality and copyright information inside all its Subsystems?Yes













Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model?Yes













Is each diagnostic (NTC) capable of being set to "PASS"?NA













Does non-zero intialization of PIM occur in the function's Init runnable?NA













Does design properly include Set Ram Block Status when NVM RAM values change?NA













Does model include appropriate logic for dealing with missing or corrupted NVM data?NA













Does model execute without errors/warnings after loading NxtrMBDConfig configuration set?Yes




























3Section 3: Requirements LinkingAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status








Are all requirements links of the format <FDDNumber>_<ObjectID>?NA













Does requirements HTML report reference only the DOORS module of this component for all links in the design?NA













Are linked blocks linked to the correct requirements(s)? (watch for problems due to copy/pasted blocks)NA













Is the list of unlinked blocks acceptable?NA




























4Section 4: Model AdvisorAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status








Was Model Advisor run with the correct configuration settings?Yes













Is the Model Advisor rerport free from "Fails".Yes













Are Model Advisor report "Warnings" acceptable?Yes




























5Section 5: Delivery PackageAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status








Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script?Yes













Does Doc folder contain a zipped HTML webview model?Yes













Was webview model created without requirements highlighted?Yes













Does Reports folder contain only the data dictionary verification report, Model Advisor report, and zipped requirements traceability report?Yes




























4Section 6: Other Issus/Actions IdentifiedDocumentReferenceSummary of resolutionAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1Internal Temp variable named wrong.Model
Renamed.Design
Closed







4.2














4.3














4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25














5Section 7: APPROVALS













RoleFirst ReviewDateAttendanceApproval?










Function Owner*Michael Hales1/19/2016
(plus several emails back and forth)
No











Peer Reviewer*Kevin DerryYesYes










Safety<Name - if invited>












SoftwareKrishna AnneYesYes










ESG / Systems<Name - if invited>












EPDT / CSE<Name - if invited>












Hardware<Name - if invited>












Test<Name - if invited>












RoleSecond Review (if required)DateAttendanceApproval?










Function Owner*<Owner Name>













Peer Reviewer*<Name>












Safety<Name - if invited>












Software<Name - if invited>












ESG / Systems<Name - if invited>












EPDT / CSE<Name - if invited>












Hardware<Name - if invited>












Test<Name - if invited>












RoleThird Review (if required)DateAttendanceApproval?










Function Owner*<Owner Name>













Peer Reviewer*<Name>












Safety<Name - if invited>












Software<Name - if invited>












ESG / Systems<Name - if invited>












EPDT / CSE<Name - if invited>












Hardware<Name - if invited>












Test<Name - if invited>












RoleFourth Review (if required)DateAttendanceApproval?










Function Owner*<Owner Name>













Peer Reviewer*<Name>












Safety<Name - if invited>












Software<Name - if invited>












ESG / Systems<Name - if invited>












EPDT / CSE<Name - if invited>












Hardware<Name - if invited>












Test<Name - if invited>












RoleAdd more if necessaryDateAttendanceApproval?










































P.S.:Yes indicates adherence














No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point.














NA indicates not applicable














Sheet 3: Template Change Log

RevChangeAuthor
01.00.05Added lesson learned #3.5MDK
01.00.06Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models.MDK
02.00.00Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD.K. Derry
02.01.00Added: Does FDD.DesignASIL match requirements?
Added: Was webview model created without requirements highlighted?
Removed: Redundant row in Data Dictionary section.
Formatting: Column C now consistently center-justified.
K. Derry
02.02.00Added: Are all data types represented by released Data_Management classes?
Removed: Are all runnables defined? Rationale: Automated tools checking.
Removed: Does the Component shortname match data dictionary FDD metadata?
Removed: "Data store name must resolve to Simulink signal object"
Edited: Model Advisor report should now be left unzipped.
K. Derry











































































2 - SF043A_TqOscn_modeladvisor

Model Advisor Report for 'SF043A_TqOscn'
Model Advisor Report - SF043A_TqOscn.slx
Simulink version: 8.2Model version: 1.426
System: SF043A_TqOscnCurrent run: 04-Feb-2016 11:26:07
 Model Advisor configuration: ...NxtrModelAdvisorConfig.mat

Run Summary
PassFailWarningNot RunTotal
   50   0   18   132200


By Task

    Code Generation Efficiency


 Check optimization settings

You should turn on the following optimization(s):

  • Block reduction
  • Remove code from floating-point to integer conversions that wraps out-of-range values
  • Inline invariant signals
  • The Simulation range checking diagnostic is enabled. Because this diagnostic can increase the time it takes to simulate your model, you should consider turning it off, by setting its value to none.
  • Ignore testpoints when generating code
  • Pass reusable subsystem outputs as individual arguments



  •     Frequency Response Estimation


        Managing Data Store Memory Blocks


        Managing Library Links And Variants


        Model Referencing


        Modeling Guidelines for MISRA-C:2004

        Modeling Physical Systems


        Modeling Signals and Parameters using Buses


        Modeling Single-Precision Systems


        Modeling Standards for DO-178C/DO-331


        Modeling Standards for EN 50128


        Modeling Standards for IEC 61508


        Modeling Standards for ISO 26262


     Display model metrics and complexity report

    Display number of elements and name, level, and depth of subsystems for the model or subsystem

    Model metrics information
    Display number of elements for Simulink blocks and Stateflow constructs


    Summary

    Element TypeCount
    Inport80
    Outport63
    SubSystem67


    Simulink

    Block TypeCount
    Inport80
    SubSystem67
    Outport63
    Constant41
    DataStoreWrite19
    S-Function15
    DataStoreMemory14
    ActionPort14
    Merge12
    DataStoreRead10
    Product7
    Sum7
    If7
    UnaryMinus5
    Math4
    From4
    TriggerPort2
    RelationalOperator2
    Goto2
    Lookup2
    EnablePort1
    Step1
    Terminator1
    Saturate1
    ∧ Less

    Model complexity information
    Display name, level, and depth of subsystems


    Maximum Subsystem Depth: 6

    Subsystem Depth

    Subsystem NameLevelDepth
    Enabled Subsystem11
    Subsystem411
    TqOscn15
    TqOscn/Subsystem421
    TqOscn/TqOscnInit122
    TqOscn/TqOscnInit1/CopyRight231
    TqOscn/TqOscnInit1/FilLpInit31
    TqOscn/TqOscnPer124
    TqOscn/TqOscnPer1/Amplitude Rate Limiter33
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/Compare To Zero41
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/CopyRight241
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/LimDyn_f3241
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/LimStat_f3241
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/RateLimDyn_f3241
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/SetToZero42
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/SetToZero/CopyRight251
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/UseCals42
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/UseCals/CopyRight251
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/UseCmd41
    TqOscn/TqOscnPer1/Amplitude Rate Limiter/UseInputs41
    TqOscn/TqOscnPer1/Angle Wrapper33
    TqOscn/TqOscnPer1/Angle Wrapper/CopyRight241
    TqOscn/TqOscnPer1/Angle Wrapper/Pass_through42
    TqOscn/TqOscnPer1/Angle Wrapper/Pass_through/CopyRight251
    TqOscn/TqOscnPer1/Angle Wrapper/Subtract_2pi42
    TqOscn/TqOscnPer1/Angle Wrapper/Subtract_2pi/CopyRight251
    TqOscn/TqOscnPer1/CheckFlag33
    TqOscn/TqOscnPer1/CheckFlag/CopyRight241
    TqOscn/TqOscnPer1/CheckFlag/SetToZero42
    TqOscn/TqOscnPer1/CheckFlag/SetToZero/CopyRight251
    TqOscn/TqOscnPer1/CheckFlag/UseInput42
    TqOscn/TqOscnPer1/CheckFlag/UseInput/CopyRight251
    TqOscn/TqOscnPer1/CopyRight231
    TqOscn/TqOscnPer1/DC Check33
    TqOscn/TqOscnPer1/DC Check/CopyRight241
    TqOscn/TqOscnPer1/DC Check/DC Trend42
    TqOscn/TqOscnPer1/DC Check/DC Trend/CopyRight251
    TqOscn/TqOscnPer1/DC Check/DC Trend/FilLpUpdOutp51
    TqOscn/TqOscnPer1/DC Check/DC_Detd42
    TqOscn/TqOscnPer1/DC Check/DC_Detd/CopyRight251
    TqOscn/TqOscnPer1/DC Check/DC_ok42
    TqOscn/TqOscnPer1/DC Check/DC_ok/CopyRight251
    TqOscn/TqOscnPer1/FltInj_f32 client33
    TqOscn/TqOscnPer1/FltInj_f32 client/Sim42
    TqOscn/TqOscnPer1/FltInj_f32 client/Sim/CopyRight151
    TqOscn/TqOscnPer1/Modified Amplitude Saturation31
    TqOscn/TqOscnPer1/Set_false32
    TqOscn/TqOscnPer1/Set_false/CopyRight241
    TqOscn/TqOscnPer1/Set_true32
    TqOscn/TqOscnPer1/Set_true/CopyRight241
    TqOscn/TqOscnPer1/Update Variables33
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM42
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM/CopyRight251
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM/FixdToFloat_f32_u16a51
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM/FixdToFloat_f32_u16b51
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM/FloatToFixd_u16_f3251
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM/LimDyn_f3251
    TqOscn/TqOscnPer1/Update Variables/CaptureInputs_UpdatePIM/LimStat_u1651
    TqOscn/TqOscnPer1/Update Variables/CopyRight241
    TqOscn/TqOscnPer1/Update Variables/UsePreviousValues42
    TqOscn/TqOscnPer1/Update Variables/UsePreviousValues/CopyRight251
    ∧ Less



     Check for model objects that do not link to requirements

    Check Simulink blocks and Stateflow objects that do not link to a requirements document

    Warning
    The following blocks do not link to a requirement document:

    ∧ Less
    Recommended Action
    For each object in the list, in the Model Editor, right-click the block, select Requirements, and specify a requirement.



        Modeling Standards for MAAB

            Naming Conventions


     Check folder names

    Identify folders using incorrect characters and formatting.

    See Also

    Warning
    The following folders have incorrect names:

    FolderIncorrect Character or Format
    T:/Tejas/Misc_EPS_FDD/FDD/EA4_FDDs/SF-43_TrqOsc EA4/Submission/Version1/SF043A_TqOscn_DesignFolder name includes incorrect characters or formatting.


    Recommended Action
    Rename the above folders to remove incorrect characters and formatting.


     Check subsystem names

    Identify subsystem names that use characters that are not correct in C code.

    See Also

    Warning
    The following subsystem names contain incorrect characters:

    ErrorSubsystem block
    Name contains incorrect characters.SF043A_TqOscn/Enabled Subsystem
    Name contains incorrect characters...../TqOscn/TqOscnPer1/Update Variables


    Recommended Action
    Rename the subsystem blocks using correct characters.


     Check port block names

    Identify names of Inport or Outport blocks that use characters that are not correct in C code.

    See Also

    Warning
    The following Inport and Outport block names contain incorrect characters:

    ErrorIncorrect port block
    Name contains incorrect characters...../TqOscnPer1/FltInj_f32 client/LocnKey


    Recommended Action
    Rename the Inport or Outport blocks to use correct characters.


     Check character usage in block names

    Identify block names that use characters that are not correct in C code.

    See Also

    Warning
    The following block names use characters that are not correct for C code:

    Error typeBlock
    Name starts with a space (" ")...../TqOscn/TqOscnPer1/Angle Wrapper/


    Recommended Action
    Rename the block using correct characters.



            Model Architecture


     Check for mixing basic blocks and subsystems

    Identify levels in the model that include basic blocks and subsystems. Each level of a model must be designed with blocks of the same level (for example, only subsystems or only basic blocks).

    See Also

    Warning
    The following level(s) in the model include basic blocks and subsystems:

    SystemBlock path
    SF043A_TqOscnSF043A_TqOscn/Step
    SF043A_TqOscnSF043A_TqOscn/Subsystem4
    SF043A_TqOscn/TqOscnSF043A_TqOscn/TqOscn/Subsystem4
    SF043A_TqOscn/TqOscn/TqOscnPer1SF043A_TqOscn/TqOscn/TqOscnPer1/Constant
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscn/TqOscnPer1/Constant1
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscn/TqOscnPer1/CopyRight2
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscn/TqOscnPer1/Data Store Write1
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscn/TqOscnPer1/Data Store Write3
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscn/TqOscnPer1/Data Store Write6
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscnPer1/Modified Amplitude Saturation
    SF043A_TqOscn/TqOscn/TqOscnPer1SF043A_TqOscn/TqOscn/TqOscnPer1/Product2
    SF043A_TqOscn/TqOscn/TqOscnPer1SF043A_TqOscn/TqOscn/TqOscnPer1/Sin_f32
    SF043A_TqOscn/TqOscn/TqOscnPer1..../TqOscn/TqOscnPer1/Unary Minus
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/Compare To Zero
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/Constant
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/CopyRight2
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/Data Store Write4
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/Data Store Write5
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/LimDyn_f32
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/LimStat_f32
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/RateLimDyn_f32
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/Unary Minus
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/Unary Minus1
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/time_step3
    ..../TqOscn/TqOscnPer1/Amplitude Rate Limiter..../Amplitude Rate Limiter/time_step4
    ..../TqOscn/TqOscnPer1/Angle Wrapper..../TqOscn/TqOscnPer1/Angle Wrapper/Add
    ..../TqOscn/TqOscnPer1/Angle Wrapper..../TqOscnPer1/Angle Wrapper/Constant1
    ..../TqOscn/TqOscnPer1/Angle Wrapper..../TqOscnPer1/Angle Wrapper/CopyRight2
    ..../TqOscn/TqOscnPer1/Angle Wrapper..../TqOscnPer1/Angle Wrapper/Data Store Read
    ..../TqOscn/TqOscnPer1/CheckFlag..../TqOscn/TqOscnPer1/CheckFlag/CopyRight2
    ..../TqOscn/TqOscnPer1/CheckFlag..../TqOscnPer1/CheckFlag/Data Store Read1
    ..../TqOscn/TqOscnPer1/CheckFlag..../TqOscnPer1/CheckFlag/Data Store Write
    SF043A_TqOscn/TqOscn/TqOscnPer1/DC Check..../TqOscn/TqOscnPer1/DC Check/CopyRight2
    SF043A_TqOscn/TqOscn/TqOscnPer1/DC Check..../TqOscnPer1/DC Check/Data Store Read1
    SF043A_TqOscn/TqOscn/TqOscnPer1/DC Check..../TqOscnPer1/DC Check/Data Store Write
    ..../TqOscn/TqOscnPer1/Update Variables..../TqOscnPer1/Update Variables/CopyRight2
    ..../TqOscn/TqOscnPer1/Update Variables..../Update Variables/Data Store Read
    ..../TqOscn/TqOscnPer1/Update Variables..../Update Variables/Data Store Write
    ∧ Less


    Recommended Action
    If possible, replace blocks at the identified level of the model hierarchy with basic blocks. Move nonvirtual blocks into the identified subsystem.



            Model Configuration Options

            Simulink


     Check for Simulink diagrams using nonstandard display attributes

    Identify nonstandard display attributes in Simulink diagrams.

    See Also

    _________________________________________________________________________________________

    Check format settings
    Identify incorrect model-level format options.

    Warning
    The following format display options are incorrect.

    Display AttributeRecommended ValueActual Value
    Display > Signals & Ports > Wide Nonscalar Linesonoff
    View > Model Browser Options > Model Browseroffon


    Recommended Action
    Set the format options to the recommended value.
    _________________________________________________________________________________________

    Check block colors
    Identify blocks using nonstandard colors.

    Warning
    The following blocks use nonstandard colors:

    ∧ Less
    Recommended Action
    Set the block foreground color to black and the background color to white.
    _________________________________________________________________________________________

    Check canvas colors
    Identify canvases that are not white.

    Passed
    All diagrams use a white canvas.
    _________________________________________________________________________________________

    Check diagram zoom
    Identify diagrams that do not have zoom factor set to 100 %.

    Warning
    The following diagrams do not have zoom factor set to 100 percent:

    ∧ Less
    Recommended Action
    For each listed diagram, select View > Zoom > Normal View (100%).


     Check font formatting

    Identify inconsistent formatting of text.

    See Also

    Warning
    Font formatting is not consistent.

    The following font characteristics are used in the model/subsystem. Font characteristics are sorted by number of occurrences. The most common characteristics are bold.
    Font NameFont SizeFont Style

    Helvetica
    Arial

    10
    9
    14

    normal



    Recommended Action
    To have consistent font formatting, click Modify All Fonts to apply the font formatting selected in the input parameters above to all objects.

    Input Parameters Selection
    NameValue
    Font NameCommon
    Font SizeCommon
    Font StyleCommon


     Check positioning and configuration of ports

    Identify input and output ports with incorrect positioning and configurations.

    See Also

    _________________________________________________________________________________________

    Check Inport blocks position
    Identify Inport blocks that result in left-flowing signals.

    Passed
    There are no Inport blocks in the model that result in left-flowing signals.
    _________________________________________________________________________________________

    Check Outport block position
    Identify Outport blocks that result in left-flowing signals.

    Passed
    There are no Outport blocks in the model that result in left-flowing signals.
    _________________________________________________________________________________________

    Check port orientation
    Identify port blocks with nondefault orientation.

    Passed
    All ports use the default orientation.
    _________________________________________________________________________________________

    Check for duplicate Inports blocks
    Identify duplicate Inport blocks.

    Passed
    All Inport blocks in the model are used once.


     Check visibility of block port names

    Identify port block names that are not uniformly displayed. The block names must all be displayed or none displayed. Library blocks are an exception to this rule. This check ignores masked and subsystem blocks.

    See Also

    _________________________________________________________________________________________

    Check for incorrect port name display
    Identify ports that are incorrectly displaying names.

    Passed
    Subsystem blocks are correctly displayed.
    _________________________________________________________________________________________

    Check for incorrect subsystem port name display
    Identify subsystems that are incorrectly displaying names.

    Passed
    Subsystem blocks are correctly displayed.

    Input Parameters Selection
    NameValue
    Display all port names (Diagram > Format > Show Block Name).true


     Check the display attributes of block names

    Identify whether to display block names.

    See Also

    _________________________________________________________________________________________

    Check for blocks with hidden names and obvious function
    Identify block names that are displayed but can be hidden due to obvious behavior.

    Warning
    The following block names can be hidden:

    Recommended Action
    Hide the block name by deselecting (Diagram > Format > Show Block Name).
    _________________________________________________________________________________________

    Check for non-descriptive displayed block names
    Identify block names that are displayed but should be hidden due to a lack of a descriptive name.

    Warning
    The following blocks have a name displayed, however, the name is not descriptive:

    ∧ Less
    Recommended Action
    Modify the block name to provide descriptive information, or hide the block name by deselecting (Diagram > Format > Show Block Name).
    _________________________________________________________________________________________

    Check for missing block names
    Identify block names that are hidden but should be displayed to show a descriptive name.

    Warning
    The following blocks have descriptive names, however, the names are hidden:

    Recommended Action
    Modify the blocks to show the block name (Diagram > Format > Show Block Name).


     Check signal line labels

    Identify blocks that require labeled signals. A subset of source and destination blocks require labeled signals.

    See Also

    _________________________________________________________________________________________

    Check source block labels
    The following source blocks require labeled signals; Inport, From, Data Store Read, Constant, Bus Selector, Demux, Selector. If the signal name is visible on the block, this rule is considered met.

    Warning
    The following signals have no label:

    ∧ Less
    Recommended Action
    Add a new or propagated label to the signal line.
    _________________________________________________________________________________________

    Check destination block labels
    The following destination blocks require labeled signals; Outport, Goto, Data Store Write, Bus Creator, Mux, Subsystem, Chart. If the signal name is visible on the source block, this rule is considered met.

    Warning
    The following signals have no label:

    ∧ Less
    Recommended Action
    Add a new or propagated label to the signal line.


     Check for propagated signal labels

    Identify propagated labels on signal lines.

    See Also

    _________________________________________________________________________________________

    Check subsystem block input labels
    Identify inputs to subsystem blocks to verify that the signals have labels.

    Warning
    The following subsystem-level Inport block signals should propagate signal labels from the parent system.

    Recommended Action
    Add labels to the input signals.
    _________________________________________________________________________________________

    Check subsystem input signals
    Identify inputs to subsystem blocks to ensure that propagated signals are displayed.

    Warning
    The following subsystem-level Inport block signals have no propagated signal labels. Signals coming from parent system should have a label.

    Recommended Action
    Display signal labels for propagated signals on the inputs signals.
    _________________________________________________________________________________________

    Check subsystem output label propagation
    Identify outputs from subsystem blocks where propagated signals are not displayed.

    Warning
    The following subsystem-level Outport block signals have no propagated signal label. Signals coming from the subsystem should have a label.

    Recommended Action
    Display signal labels for propagated signals on the output signals.
    _________________________________________________________________________________________

    Signal propagation for nonsubsystem blocks
    Identify the signal propagation status for both transformative and nontransformative blocks.

    Passed
    All outputs from non subsystem blocks correctly use labels and display propagated signals.



            Stateflow


     Check usage of exclusive and default states in state machines

    Identify Stateflow charts and substates that incorrectly use or define exclusive and default states.
    Note: This check does not support charts that use MATLAB as the action language.

    See Also

    _________________________________________________________________________________________

    Check Stateflow charts for exclusive states
    Identify Stateflow charts that have singular exclusive (OR) states.

    Passed
    The Stateflow charts do not have singular exclusive (OR) states.
    _________________________________________________________________________________________

    Check Stateflow charts for undefined default states
    Identify Stateflow charts that do not define default states.

    Passed
    Each Stateflow chart defines a default state.
    _________________________________________________________________________________________

    Check for multiple states assigned as the default state
    At the root level in the Stateflow hierarchy only one state should be assigned as the default.

    Passed
    The root level of the chart has only one default state assigned.
    _________________________________________________________________________________________

    Check for substates with singular OR states
    States configured as OR should always be part of a group of states.

    Passed
    No singular OR states were detected.
    _________________________________________________________________________________________

    Check for substates without default states defined
    At every level in the Stateflow hierarchy a default state should be assigned.

    Passed
    All substates have default states assigned.
    _________________________________________________________________________________________

    Check for substates with multiple default states defined
    At every level in the Stateflow hierarchy only one state should be assigned as the default.

    Passed
    All levels of the chart have only one default state assigned.


     Check transition orientations in flowcharts

    Identify transitions in Stateflow flowcharts that are drawn incorrectly.

    See Also

    _________________________________________________________________________________________

    Check for conditions drawn vertically
    Condition expressions should be drawn on the horizontal segments of flowcharts.

    Passed
    All conditions expressions were drawn horizontally.
    _________________________________________________________________________________________

    Check for action transitions drawn vertically
    Transition actions should be drawn on the vertical segments of flowcharts.

    Passed
    All transitions actions where drawn vertically.
    _________________________________________________________________________________________

    Check for junctions for default transitions
    All Junctions in a flow chart should have a default exit transition.

    Passed
    All Junctions have a default exit transition.
    _________________________________________________________________________________________

    Check for transitions that combine condition and action
    Flowcharts should not combine condition evaluations and action expressions in a single transition.

    Passed
    No combined expressions where found in the chart.



            MATLAB Functions


        Requirements Consistency Checking


        Simulation Accuracy


        Simulation Runtime Accuracy Diagnostics


     Check if Read/Write diagnostics are enabled for Data Store blocks

    Note: These runtime diagnostics may slow down simulation considerably. You should set them back to Disable all once you have verified that they do not cause any warnings or errors during simulation.



        Simulink Model File Integrity

        Upgrading to the Current Simulink Version