This is the multi-page printable view of this section. Click here to print.
Component Design
1 - SF023A_TunSelnAuthy_Design_PeerReviewChkList
Overview
Peer Review InstructionsTechnical Review Checklist
Template Change Log
Sheet 1: Peer Review Instructions
Instructions for Functional Design Package Peer Review | ||
PRE-MEETING | ||
Function Owner | Confirm that requirements are reviewed and approved PRIOR to the FDP peer review | |
Function Owner | Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews | |
Function Owner | Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review | |
Function Owner | Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting | |
Function Owner | Identify necessary attendance and invite to meeting | |
Function Owner | Complete the "Author" column information for sections 1 through 5 prior to the review | |
Function Owner | Complete the attendance invitation list in section 7 | |
Function Owner | For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews. | |
DURING MEETING | ||
Function Owner | Present document changes to the review team | |
Peer Reviewer | Capture attendance of the review | |
Peer Reviewer | Capture actions and issues in section 6. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN" | |
POST MEETING | ||
Function Owner | Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided. | |
Function Owner | Schedule follow up review OR review open items with peer reviewer and obtain agreement to close | |
Peer Reviewer | Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates |
Sheet 2: Technical Review Checklist
Sheet 3: Template Change Log
Rev | Change | Author |
01.00.05 | Added lesson learned #3.5 | MDK |
01.00.06 | Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models. | MDK |
02.00.00 | Combined ESG and Systems into one, compatible with Data_Management 2.13.0 of CreateDD and VerifyDD. | K. Derry |
02.01.00 | Added: Does FDD.DesignASIL match requirements? Added: Was webview model created without requirements highlighted? Removed: Redundant row in Data Dictionary section. Formatting: Column C now consistently center-justified. | K. Derry |
02.02.00 | Added: Are all data types represented by released Data_Management classes? Removed: Are all runnables defined? Rationale: Automated tools checking. Removed: Does the Component shortname match data dictionary FDD metadata? Removed: "Data store name must resolve to Simulink signal object" Edited: Model Advisor report should now be left unzipped. | K. Derry |
2 - SF023A_TunSelnAuthy_ModelAdvisor_Report
Model Advisor Report - SF023A_TunSelnAuthy.slx | |
Simulink version: 8.2 | Model version: 1.261 |
System: SF023A_TunSelnAuthy | Current run: 14-Jun-2016 16:00:39 |
Model Advisor configuration: ...NxtrModelAdvisorConfig.mat |
Run Summary
Pass | Fail | Warning | Not Run | Total |
| | | | 359 |
You should turn on the following optimization(s):
none . | |
Mux blocks used to create bus signals
Identify Mux blocks in the model that are creating bus signals. For guidelines about changes that you might need to make to models, callbacks, scripts, or tests after running the check, see Compatibility Issues.
Passed
The model uses Mux blocks properly. Model is configured to detect future changes that might result in improper Mux block usage.
_________________________________________________________________________________________
Bus signal treated as vector
Identify bus signals in the model that are treated as vectors by the Simulink software.
Passed
The model uses bus signals properly. Model is configured to detect future changes that might result in improper bus signal usage.
Identify Inport blocks in the top-level of the model with missing or inherited sample times, data types, or port dimensions
Warning
The following Inport blocks have undefined or inherited sample times, data types or port dimensions
Inport | Link | Conditions |
1 | SF023A_TunSelnAuthy/HwTq | Missing port dimension Missing signal data type Missing port sample time |
2 | SF023A_TunSelnAuthy/VehSpd | Missing port dimension Missing signal data type Missing port sample time |
3 | SF023A_TunSelnAuthy/HwVel | Missing port dimension Missing signal data type Missing port sample time |
4 | SF023A_TunSelnAuthy/TunSelnRtDi | Missing port dimension Missing signal data type Missing port sample time |
Recommended Action
Explicitly define all missing Inport block properties identified in the results
- Missing port dimension: Model contains Inport blocks with inherited port dimension (-1). Specify port dimension for the listed Inport blocks.
- Missing signal data type: Model contains Inport blocks with inherited data type. Specify a data type for the listed Inport blocks.
- Missing port sample time: Model contains Inport blocks with inherited sample time (-1). Specify sample time information for the listed Inport blocks. Note: The sample time of root Inports with bus type must match the sample times specified at the leaf elements of the bus object.
Identify blocks not supported by code generation or not recommended for C/C++ production code deployment.
Warning
The following blocks are not supported or not recommended for C/C++ production code deployment:
Block | Block Type | Code generation support | Recommendation for C/C++ production code deployment |
SF023A_TunSelnAuthy/Step | Step | Yes | No |
Recommended Action
Although Embedded Coder supports these blocks, they are not recommended for C/C++ production code deployment.
Check Simulink blocks and Stateflow objects that do not link to a requirements document
Warning
The following blocks do not link to a requirement document:
- SF023A_TunSelnAuthy/HwTq
- SF023A_TunSelnAuthy/VehSpd
- SF023A_TunSelnAuthy/HwVel
- SF023A_TunSelnAuthy/TunSelnRtDi
- SF023A_TunSelnAuthy/CopyRight2
- SF023A_TunSelnAuthy/Step
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy/call_TunSelnAuthyInit1
- SF023A_TunSelnAuthy/TunSelnAuthy/call_RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/call_XcpCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/From
- SF023A_TunSelnAuthy/TunSelnAuthy/From1
- SF023A_TunSelnAuthy/TunSelnAuthy/From4
- SF023A_TunSelnAuthy/TunSelnAuthy/Goto
- SF023A_TunSelnAuthy/TunSelnAuthy/Goto1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/HwTq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/VehSpd
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/HwVel
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/function
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Abs
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Abs1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FixdToFloat_f32_u1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FixdToFloat_f32_u16
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FloatToFixd_u16_f32
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/From
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/From1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/From4
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/From6
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Goto
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Goto1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Goto3
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/If
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Logical Operator
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Merge
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnNotOK
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnNotOK/Action Port
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnNotOK/Constant
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnNotOK/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnNotOK/ReqSts
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnOK
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnOK/Action Port
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnOK/Constant
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnOK/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnOK/ReqSts
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/ReqSts
- SF023A_TunSelnAuthy/TunSelnAuthy/TunSelnAuthyInit1
- SF023A_TunSelnAuthy/TunSelnAuthy/TunSelnAuthyInit1/function
- SF023A_TunSelnAuthy/TunSelnAuthy/TunSelnAuthyInit1/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/VehSpd
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/function
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/Add
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/Constant4
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/If
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/Merge
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnNotOK
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnNotOK/Action Port
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnNotOK/Constant
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnNotOK/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnNotOK/ReqSts
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnOK
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnOK/Action Port
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnOK/Constant
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnOK/CopyRight2
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnOK/ReqSts
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/VehSpdThd
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/ReqSts
- SF023A_TunSelnAuthy/call_RtCalChgReq
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1/Enable
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1/CopyRight2
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1/Function-Call Generator
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1/Out1
- SF023A_TunSelnAuthy/call_XcpCalChgReq
- SF023A_TunSelnAuthy/RtCalChgReq_StdRtn
- SF023A_TunSelnAuthy/XcpCalChgReq_StdRtn
Recommended Action
For each object in the list, in the Model Editor, right-click the block, select Requirements, and specify a requirement.
Identify block names that use characters that are not correct in C code.
See Also
The following block names use characters that are not correct for C code:
Error type | Block |
Name contains incorrect characters. | ..../Function-Call Generator |
Recommended Action
Rename the block using correct characters.
Identify levels in the model that include basic blocks and subsystems. Each level of a model must be designed with blocks of the same level (for example, only subsystems or only basic blocks).
See Also
The following level(s) in the model include basic blocks and subsystems:
∧ Less
Recommended Action
If possible, replace blocks at the identified level of the model hierarchy with basic blocks. Move nonvirtual blocks into the identified subsystem.
Identify nonstandard display attributes in Simulink diagrams.
See Also
Check format settings
Identify incorrect model-level format options.
Warning
The following format display options are incorrect.
Display Attribute | Recommended Value | Actual Value |
Display > Signals & Ports > Wide Nonscalar Lines | on | off |
Display > Signals & Ports > Signal Dimensions | off | on |
View > Model Browser Options > Model Browser | off | on |
Display > Library Links > All | none | disabled |
Recommended Action
Set the format options to the recommended value.
_________________________________________________________________________________________
Check block colors
Identify blocks using nonstandard colors.
Warning
The following blocks use nonstandard colors:
- SF023A_TunSelnAuthy/HwVel
- SF023A_TunSelnAuthy/TunSelnAuthy/HwVel
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Constant2
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FixdToFloat_f32_u1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FixdToFloat_f32_u16
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FloatToFixd_u16_f32
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/HwVel
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/LnrIntrpn_u16_u16VariXu16VariY
- ..../TunSelnAuthy/RtCalChgReq/LnrIntrpn_u16_u16VariXu16VariY1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Logical Operator1
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Logical Operator2
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/TunSelnRtDi
- SF023A_TunSelnAuthy/TunSelnAuthy/TunSelnRtDi
- SF023A_TunSelnAuthy/TunSelnRtDi
Recommended Action
Set the block foreground color to black and the background color to white.
_________________________________________________________________________________________
Check canvas colors
Identify canvases that are not white.
Passed
All diagrams use a white canvas.
_________________________________________________________________________________________
Check diagram zoom
Identify diagrams that do not have zoom factor set to 100 %.
Warning
The following diagrams do not have zoom factor set to 100 percent:
For each listed diagram, select View > Zoom > Normal View (100%).
Identify whether to display block names.
See Also
Check for blocks with hidden names and obvious function
Identify block names that are displayed but can be hidden due to obvious behavior.
Passed
All blocks with obvious behavior have hidden names.
_________________________________________________________________________________________
Check for non-descriptive displayed block names
Identify block names that are displayed but should be hidden due to a lack of a descriptive name.
Passed
All displayed names provide descriptive information.
_________________________________________________________________________________________
Check for missing block names
Identify block names that are hidden but should be displayed to show a descriptive name.
Warning
The following blocks have descriptive names, however, the names are hidden:
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/function
- SF023A_TunSelnAuthy/TunSelnAuthy/TunSelnAuthyInit1/function
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/Add
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/VehSpdThd
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/function
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1/Enable
Modify the blocks to show the block name (Diagram > Format > Show Block Name).
Identify blocks that require labeled signals. A subset of source and destination blocks require labeled signals.
See Also
Check source block labels
The following source blocks require labeled signals; Inport, From, Data Store Read, Constant, Bus Selector, Demux, Selector. If the signal name is visible on the block, this rule is considered met.
Warning
The following signals have no label:
- SF023A_TunSelnAuthy
- SF023A_TunSelnAuthy
- SF023A_TunSelnAuthy
- SF023A_TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy
- SF023A_TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq
- SF023A_TunSelnAuthy
Recommended Action
Add a new or propagated label to the signal line.
_________________________________________________________________________________________
Check destination block labels
The following destination blocks require labeled signals; Outport, Goto, Data Store Write, Bus Creator, Mux, Subsystem, Chart. If the signal name is visible on the source block, this rule is considered met.
Warning
The following signals have no label:
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnNotOK/ReqSts/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/RtnOK/ReqSts/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/ReqSts/
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnNotOK/ReqSts/
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/RtnOK/ReqSts/
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/ReqSts/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq_StdRtn/
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq_StdRtn/
- SF023A_TunSelnAuthy/call_TunSelnAuthyInit1/Out1/
- SF023A_TunSelnAuthy/RtCalChgReq_StdRtn/
- SF023A_TunSelnAuthy/XcpCalChgReq_StdRtn/
- SF023A_TunSelnAuthy/TunSelnAuthy/Goto/
- SF023A_TunSelnAuthy/TunSelnAuthy/Goto1/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Goto1/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/Goto3/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FixdToFloat_f32_u1/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FixdToFloat_f32_u16/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/FloatToFixd_u16_f32/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/LnrIntrpn_u16_u16VariXu16VariY/
- SF023A_TunSelnAuthy/TunSelnAuthy/RtCalChgReq/LnrIntrpn_u16_u16VariXu16VariY1/
- SF023A_TunSelnAuthy/TunSelnAuthy/XcpCalChgReq/
Recommended Action
Add a new or propagated label to the signal line.
Identify blocks that are not allowed in discrete controllers. Prohibited blocks include all continuous blocks and some source and sink blocks.
See Also
- MathWorks Automotive Advisory Board Guideline: jm_0001
- Check for blocks not recommended for C/C++ production code deployment
All blocks in the model are allowed in discrete controllers.
Identify blocks not supported by code generation or not recommended for C/C++ production code deployment.
Warning
The following blocks are not supported or not recommended for C/C++ production code deployment:
Block | Block Type | Code generation support | Recommendation for C/C++ production code deployment |
SF023A_TunSelnAuthy/Step | Step | Yes | No |
Recommended Action
Although Embedded Coder supports these blocks, they are not recommended for C/C++ production code deployment.