| Technical Review Checklist - Template Version 02.00.00 |
|
|
|
|
|
|
|
|
| Product Name | Electric Power Steering | Electrical Arch. | 4 | Review Scope | Defect Type | Numbers |
|
|
|
|
| Yes | Closed | FR |
| Function ID | SF038A_LimrCdng |
|
| Peer review of SF038A_LimrCdng Design | Requirement | 1 |
|
|
|
|
| No | Rejected | FDD |
| Long Name | Limiter Conditioning |
|
| Interface | 0 |
|
|
|
|
| NA | Open | Model |
| Version that you started from.
NOT the version you hope to release.
If this will be v1.0.0, enter NA.
Starting Baseline | 3.0 | Effort | Design | 0 |
|
|
|
|
|
|
| FMEA |
| Author | Fei Yuan | Review Effort(Hrs.) | 1.00 | Standards | 1 |
|
|
|
|
|
|
| *.m File |
|
| Corr+Verf effort(Hrs.) | 2.00 | Documentation | 6 |
|
|
|
|
|
|
| Cal Process |
|
| Total Effort (Hrs.) | 3.00 | Others | 0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Total | 8 |
|
|
|
|
|
|
|
|
| Checklist No. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 | Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Filename of Data Dictionary in correct format? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the FDD.Version property correctly updated? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Data Dictionary Verification report error free? | No |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does FDD Long Name, Short Name, and Description match requirements? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all runnables defined? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do runnables have the correct time step? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do server runnables correctly define arguments? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all clients defined? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do client definitions match the corresponding server runnable? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does name and metadata of every signal match its corresponding interface signal? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do output signal ranges match requirements (check DOOR min/max attributes too)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do all calibrations have correct values for all metadata? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM defined in the appropriate number of blocks? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are constants defined with proper scope (local vs global)? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all dependent constants and calibrations included in one file? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 | Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Is filename of model in correct format? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Requirements Baseline? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Top level of the model annotated with Tool Dependencies? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Change Log or History? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Component shortname match data dictionary FDD metadata? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from subsystems that are not Function-Call Subsystems? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from arithmetic and logic operations? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the Runnable trigger signals named as "call_<Runnable>"? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all data flow layers free of Function-Call Subsystems and Memory Store blocks? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Model have the confidentiality and copyright information inside all its Subsystems? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do all Memory Store blocks for PIM and Display Variables have the "Data store name must resolve to Simulink signal object" setting checked to true? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is each diagnostic (NTC) capable of being set to "PASS"? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does non-zero intialization of PIM occur in the function's Init runnable? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does design properly include Set Ram Block Status when NVM RAM values change? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does model include appropriate logic for dealing with missing or corrupted NVM data? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does model execute without errors/warnings after loading NxtrMBDConfig configuration set? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 | Section 3: Requirements Linking | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Are all requirements links of the format <FDDNumber>_<ObjectID>? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does requirements HTML report reference only the DOORS module of this component for all links in the design? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are linked blocks linked to the correct requirements(s)? (watch for problems due to copy/pasted blocks) | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the list of unlinked blocks acceptable? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 | Section 4: Model Advisor | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Was Model Advisor run with the correct configuration settings? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Model Advisor rerport free from "Fails". | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are Model Advisor report "Warnings" acceptable? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 5 | Section 5: Delivery Package | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does Doc folder contain a zipped HTML webview model? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does Reports folder contain only the data dictionary verification report, zipped Model Advisor report, and zipped requirements traceability report? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 | Section 6: Other Issus/Actions Identified | Document | Reference | Summary of resolution | Author:
Defect type to be selected.
Defect Type | Author:
What action is taken to fix the comment & other remarks need to be filled by author. Remarks By Author | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 4.1 | Change 'FltInj' back to 'FltInj_f32' | *.m File |
| Keep the same with the global one | Standards |
| Closed |
|
|
|
|
|
|
|
|
| 4.2 | version to 1.0.x 1.0.0 for model | FDD |
| In the first edition FDD converted from EA3 to EA4, the version of the DataDict should be 1.0.X and that of the model should be 1.0.0. | Documentation |
| Closed |
|
|
|
|
|
|
|
|
| 4.3 | Check with Scott DesignASIL | *.m File |
| Based on the document, it should be "A". | Documentation |
| Closed |
|
|
|
|
|
|
|
|
| 4.4 | Update the dependencies in the model | Model |
|
| Documentation |
| Closed |
|
|
|
|
|
|
|
|
| 4.5 | Note the ea3 base version | Model |
|
| Documentation |
| Closed |
|
|
|
|
|
|
|
|
| 4.6 | Check the PIM range | *.m File |
| The PIMs range should be the same with the inputs | Documentation |
| Closed |
|
|
|
|
|
|
|
|
| 4.7 | MOTTQCMDLOLIM_MOTNWTMTR_F32 should be changed | *.m File |
| To distinguish from the global one, just change it to MOTTQLOLIMCDNG_MOTNWTMTR_F32 | Documentation |
| Closed |
|
|
|
|
|
|
|
|
| 4.8 | The Data Dicitonary Verification report is not error free. | *.m File |
|
FltInj_f32, FLTINJ_LIMRCDNG_EOTGAIN, FLTINJ_LIMRCDNG_EOTLIM,FLTINJ_LIMRCDNG_SYSMOTTQCMDSCA should keep the same with the global one. 'Being unable to find model for comparison " is a tool bug. | Requirement |
| Closed |
|
|
|
|
|
|
|
|
| 4.9 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.10 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.11 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.12 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.13 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.14 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.15 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.16 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 5 | Section 7: APPROVALS |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | First Review | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Bill Wittig | 7/13/2015 | No |
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Sudeep Shankar | Yes | No |
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | Sankardu Varadapureddi | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Second Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | Bill Wittig | 0714/2015 |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | Sudeep Shankar | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Third Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | <Owner Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | <Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Fourth Review (if required) | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
| Function Owner* | <Owner Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Reviewer* | <Name> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Safety | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Software | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| ESG / Systems | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| EPDT / CSE | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Hardware | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Test | <Name - if invited> |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Role | Add more if necessary | Date | Attendance | Approval? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| P.S.: | Yes indicates adherence |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| NA indicates not applicable |
|
|
|
|
|
|
|
|
|
|
|
|
|
|