This is the multi-page printable view of this section. Click here to print.

Return to the regular view of this page.

Component Implementation

1: GmOvrlStMgr_IntegrationManual
2: GmOvrlStMgr_MDD
3: GmOvrlStMgr_Review

Component Implementation

Component Documentation

1 - GmOvrlStMgr_IntegrationManual

Integration Manual

For

GmOvrlStMgr

VERSION: 2.0

DATE: 11-Feb-2016

Prepared By:

Nick Saxton,

Nexteer Automotive,

Saginaw, MI, USA

Location: The official version of this document is stored in the Nexteer Configuration Management System.

Revision History

Sl. No.	Description	Author	Version	Date
1	Initial version	Sankardu Varadapureddi	1.0	6-Oct-2015
2	Updated to include IgnCntr NVM	Nick Saxton	2.0	11-Feb-2016

Table of Contents

1 Abbrevations And Acronyms 4

2 References 5

3 Dependencies 6

3.1 SWCs 6

3.2 Global Functions(Non RTE) to be provided to Integration Project 6

4 Configuration REQUIREMeNTS 7

4.1 Build Time Config 7

4.2 Configuration Files to be provided by Integration Project 7

4.3 Da Vinci Parameter Configuration Changes 7

4.4 DaVinci Interrupt Configuration Changes 7

4.5 Manual Configuration Changes 7

5 Integration DATAFLOW REQUIREMENTS 8

5.1 Required Global Data Inputs 8

5.2 Required Global Data Outputs 8

5.3 Specific Include Path present 8

6 Runnable Scheduling 9

7 Memory Map REQUIREMENTS 10

7.1 Mapping 10

7.2 Usage 10

7.3 NvM Blocks 10

8 Compiler Settings 11

8.1 Preprocessor MACRO 11

8.2 Optimization Settings 11

9 Appendix 12

Abbrevations And Acronyms

Abbreviation	Description
DFD	Design functional diagram
MDD	Module design Document

References

This section lists the title & version of all the documents that are referred for development of this document

Sr. No.	Title	Version
1	FDD : CF009A_ GmOvrlStMgr_Design	See Synergy sub project version
2	Software Naming Conventions	1.0
3	Software Design and Coding Standards	2.1

Dependencies

SWCs

Module	Required Feature
None

Global Functions(Non RTE) to be provided to Integration Project

None

Configuration REQUIREMeNTS

Build Time Config

Modules	Notes
None

Configuration Files to be provided by Integration Project

None

Da Vinci Parameter Configuration Changes

Parameter	Notes	SWC
None

DaVinci Interrupt Configuration Changes

ISR Name	VIM #	Priority Dependency	Notes
None

Manual Configuration Changes

Constant	Notes	SWC
None

Integration DATAFLOW REQUIREMENTS

Required Global Data Inputs

Refer DataDict.m file in the FDD

Required Global Data Outputs

Refer DataDict.m file file in the FDD

Specific Include Path present

Runnable Scheduling

This section specifies the required runnable scheduling.

Init	Scheduling Requirements	Trigger
GmOvrlStMgrInit1	None	RTE (Init)

Runnable	Scheduling Requirements	Trigger
GmOvrlStMgrPer1	None	RTE (2ms)

Runnable	Scheduling Requirements	Trigger
GetGmLoaIgnCntr	None	On event
SetGmLoaIgnCntr	None	On event

Memory Map REQUIREMENTS

Mapping

Memory Section	Contents	Notes
None

* Each …START_SEC… constant is terminated by a …STOP_SEC… constant as specified in the AUTOSAR Memory Mapping requirements.

Usage

Feature	RAM	ROM
None

Table 1: ARM Cortex R4 Memory Usage

NvM Blocks

Block Name

GmLoaIgnCntr

Compiler Settings

Preprocessor MACRO

None.

Optimization Settings

None.

Appendix

None

2 - GmOvrlStMgr_MDD

Module Design Document

For

GmOvrlStMgr

Feb 02, 2017

Prepared For:

Software Engineering

Nexteer Automotive,

Saginaw, MI, USA

Prepared By:

Jayakrishnan T,

Nexteer Automotive,

Saginaw, MI, USA
Change History

Description	Author	Version	Date
Initial Version	Sankardu Varadapureddi	1	6-Oct-2015
Added HwTq based intervention for LKA, handwheel buzz based on LoA key cycles	Nick Saxton	2	11-Feb-2016
Changed argument names of ESCFlt local function	Nick Saxton	3	13-Jun-2016
Updated graphical representation and edited local function section	Nick Saxton	4	24-Jun-2016
Updated for FDD v4.0.0	Nick Saxton	5	22-Aug-2016
Updated to design version 4.1.0	TATA	6	12-Dec-16
Anomaly fix EA4#8726, Removed local function LkaCheck	JK	7	02-Feb-17

Table of Contents

1 GmOvrlStMgr High-Level Description 6

2 Design details of software module 7

2.1 Graphical representation of GmOvrlStMgr 7

2.2 Data Flow Diagram 8

2.2.1 Component level DFD 8

2.2.2 Function level DFD 8

3 Constant Data Dictionary 9

3.1 Program (fixed) Constants 9

3.1.1 Embedded Constants 9

4 Software Component Implementation 10

4.1 Sub-Module Functions 10

4.1.1 Init: GmOvrlStMgrInit1 10

4.1.1.1 Design Rationale 10

4.1.1.2 Module Outputs 10

4.1.2 Per: GmOvrlStMgrPer1 10

4.1.2.1 Design Rationale 10

4.1.2.2 Store Module Inputs to Local copies 10

4.1.2.3 (Processing of function)……… 10

4.1.2.4 Store Local copy of outputs into Module Outputs 10

4.2 Server Runables 10

4.2.1 GetGmLoaIgnCntr_Oper 10

4.2.1.1 Design Rationale 10

4.2.1.2 Store Module Inputs to Local copies 10

4.2.1.3 (Processing of function)……… 10

4.2.1.4 Store Local copy of outputs into Module Outputs 10

4.2.2 SetGmLoaIgnCntr_Oper 11

4.2.2.1 Design Rationale 11

4.2.2.2 Store Module Inputs to Local copies 11

4.2.2.3 (Processing of function)……… 11

4.2.2.4 Store Local copy of outputs into Module Outputs 11

4.3 Interrupt Functions 11

4.4 Module Internal (Local) Functions 11

4.4.1 Local Function #1 11

4.4.1.1 Description 11

4.4.2 Local Function #2 11

4.4.2.1 Description 11

4.4.3 Local Function #3 11

4.4.3.1 Description 12

4.4.4 Local Function #4 12

4.4.4.1 Description 12

4.4.5 Local Function #5 12

4.4.5.1 Description 12

4.4.6 Local Function #6 12

4.4.6.1 Description 12

4.4.7 Local Function #7 13

4.4.7.1 Description 13

4.4.8 Local Function #8 13

4.4.8.1 Description 13

4.4.9 Local Function #9 13

4.4.9.1 Description 14

4.4.10 Local Function #10 14

4.4.10.1 Description 14

4.4.11 Local Function #11 14

4.4.11.1 Description 15

4.4.12 Local Function #12 15

4.4.12.1 Description 15

4.4.13 Local Function #13 16

4.4.13.1 Description 16

4.4.14 Local Function #14 16

4.4.14.1 Description 16

4.4.15 Local Function #15 16

4.4.15.1 Description 16

4.4.16 Local Function #16 16

4.4.16.1 Description 17

4.4.17 Local Function #17 17

4.4.17.1 Description 17

4.4.18 Local Function #18 17

4.4.18.1 Description 17

4.4.19 Local Function #19 17

4.4.19.1 Description 17

4.4.20 Local Function #20 17

4.4.20.1 Description 18

4.4.21 Local Function #21 18

4.4.21.1 Description 18

4.4.22 Local Function #22 18

4.4.22.1 Description 18

4.4.23 Local Function #23 18

4.4.23.1 Description 19

4.4.24 Local Function #24 19

4.4.24.1 Description 19

4.5 GLOBAL Function/Macro Definitions 19

5 Known Limitations with Design 20

6 UNIT TEST CONSIDERATION 21

Appendix A Abbreviations and Acronyms 22

Appendix B Glossary 23

Appendix C References 24

GmOvrlStMgr High-Level Description

Refer to FDD

Design details of software module

Graphical representation of GmOvrlStMgr

$C:\Component\CF009A_GmOvrlStMgr_Impl_4.1.0\MDD.JPG$

Data Flow Diagram

Refer FDD

Component level DFD

Function level DFD

Constant Data Dictionary

Program (fixed) Constants

Embedded Constants

Refer .m file

Software Component Implementation

Sub-Module Functions

Init: GmOvrlStMgrInit1

Design Rationale

Refer FDD

Module Outputs

Refer FDD

Per: GmOvrlStMgrPer1

Design Rationale

Refer FDD for the overall functionality.

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Server Runables

GetGmLoaIgnCntr_Oper

Design Rationale

Refer FDD for the overall functionality.

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

SetGmLoaIgnCntr_Oper

Design Rationale

Refer FDD for the overall functionality.

Store Module Inputs to Local copies

Refer FDD

(Processing of function)………

Refer FDD

Store Local copy of outputs into Module Outputs

Refer FDD

Interrupt Functions

None

Module Internal (Local) Functions

Local Function #1

Function Name	VehStandStillTmrElpdChk	Type	Min		Max
Arguments Passed	VehSpdSecurMax_Kph_T_f32	float32	0	511
Return Value	VehStandStillTiExcdd_Cnt_T_logl	boolean	FALSE	TRUE

Description

"Timer for VehStandStill" block implementation.

Local Function #2

Function Name	ShiftLvrRvsTmrElpdChk	Type	Min		Max
Arguments Passed	ShiftLvrRvs_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	ShiftLvrRvsTiExcdd_Cnt_T_logl	boolean	FALSE	TRUE

Description

"Timer for ShiftLvrRvs" block implementation.

Local Function #3

Function Name	ApaIntv	Type	Min		Max
Arguments Passed	HwTq_HwNwtMtr_T_f32	float32	-10	10
Return Value	ApaIntv_Cnt_T_logl	boolean	FALSE	TRUE

Description

"ApaIntv" block implementation.

Local Function #4

Function Name	HaptcEnaDurnElpdChk	Type	Min		Max
Arguments Passed	HwHaptcEna_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	HwHaptcEnaDurnExcdd_Cnt_T_logl	boolean	FALSE	TRUE

Description

"Timer for HwHaptcEna" block implementation.

Local Function #5

Function Name	LkaFltActvChk	Type	Min		Max
Arguments Passed	Msg17DBusHiSpdMiss_Cnt_T_logl	boolean	FALSE	TRUE
	Msg180BusHiSpdMiss_Cnt_T_logl	boolean	FALSE	TRUE
	Msg180BusHiSpdInvld_Cnt_T_logl	boolean	FALSE	TRUE
	Msg1E9BusHiSpdMiss_Cnt_T_logl	boolean	FALSE	TRUE
	Msg214BusHiSpdInvld_Cnt_T_logl	boolean	FALSE	TRUE
	Msg214BusHiSpdMiss_Cnt_T_logl	boolean	FALSE	TRUE
	VehSpdSecurMaxVld_Cnt_T_logl	boolean	FALSE	TRUE
	VehSpdSecurMinVld_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	LkaFlt_Cnt_T_logl	boolean	FALSE	TRUE

Description

Determination of 'LkaFlt'.

Local Function #6

Function Name	LkaInhbChk	Type	Min		Max
Arguments Passed	Msg17DBusHiSpdInvld_Cnt_T_logl	boolean	FALSE	TRUE
	VehStabyEnhmtActv_Cnt_T_logl	boolean	FALSE	TRUE
	AbsActvProtd_Cnt_T_logl	boolean	FALSE	TRUE
	Msg1E9BusHiSpdInvld_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	LkaInhb_Cnt_T_logl	boolean	FALSE	TRUE

Description

Determination of ' LkaInhb'.

Local Function #7

Function Name	ApaRcvrlFltChk	Type	Min		Max
Arguments Passed	Msg1F5BusHiSpdInvld_Cnt_T_logl	boolean	FALSE	TRUE
	VehSpdSecurMaxVld_Cnt_T_logl	boolean	FALSE	TRUE
	VehSpdSecurMinVld_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	ApaRcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE

Description

Determination of ‘ ApaRcvrlFlt’.

Local Function #8

Function Name	ApaTmpInhbExitCdnsChk	Type	Min		Max
Arguments Passed	ApaNrcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE
	LoaSt_Cnt_T_enum	LoaSt1 (enum)	LOAST_NORM	LOAST_IMDTSHTDWNREQD
	VehSpdSecurMax_Kph_T_f32	float32	0	511
	ApaEna_Cnt_T_logl	boolean	FALSE	TRUE
	HwHaptcEna_Cnt_T_logl	boolean	FALSE	TRUE
	ApaRcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE
	SysSt_Cnt_T_enum	SysSt1	SYSST_DI	SYSST_WRMIN
	*ApaSt_Cnt_T_u08	uint8	0	4
Return Value	None

Description

This function validates conditions for all state transitions from ‘ APA Temporarily Inhibited’ state.

‘*ApaSt_Cnt_T_u08’ is an output of this function.

Local Function #9

Function Name	ApaActvExitCdnsChk	Type	Min		Max
Arguments Passed	ApaNrcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE
	LoaSt_Cnt_T_enum	LoaSt1 (enum)	LOAST_NORM	LOAST_IMDTSHTDWNREQD
	VehSpdSecurMax_Kph_T_f32	float32	0	511
	ApaEna_Cnt_T_logl	boolean	FALSE	TRUE
	HwHaptcEna_Cnt_T_logl	boolean	FALSE	TRUE
	ApaRcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE
	ApaIntv_Cnt_T_logl	boolean	FALSE	TRUE
	SysSt_Cnt_T_enum	SysSt1	SYSST_DI	SYSST_WRMININ
	*ApaSt_Cnt_T_u08	uint8	0	4
Return Value	None

Description

This function validates conditions for all state transitions from ‘ APA Active’ state.

‘*ApaSt_Cnt_T_u08’ is an output of this function.

Local Function #10

Function Name	ApaCtrlAvlExitCdnsChk	Type	Min		Max
Arguments Passed	VehSpdSecurMax_Kph_T_f32	float32	0	511
	ApaRcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE
	HwHaptcEnaDurnExcdd_Cnt_T_logl	boolean	FALSE	TRUE
	VehStandStillTiExcdd_Cnt_T_logl	boolean	FALSE	TRUE
	ShiftLvrRvsTiExcdd_Cnt_T_logl	boolean	FALSE	TRUE
	ApaEna_Cnt_T_logl	boolean	FALSE	TRUE
	HwHaptcEna_Cnt_T_logl	boolean	FALSE	TRUE
	HaptcStTranActvToWaitFlg_Cnt_T_logl	boolean	FALSE	TRUE
	TranHaptcWaitToApaStActvFlg_Cnt_T_logl	boolean	FALSE	TRUE
	SysSt_Cnt_T_enum	SysSt1	SYSST_DI	SYSST_WRMININ
	*HaptcSt_Cnt_T_u08	uint8	0	2
	*ApaSt_Cnt_T_u08	uint8	0	4
Return Value	None

Description

This function validates conditions for all state transitions from and within ‘APA Availability for Control’ state.

‘*ApaSt_Cnt_T_u08 and *HaptcSt_Cnt_T_u08’ are outputs of this function.

Local Function #11

Function Name	LkaStTran	Type	Min		Max
Arguments Passed	LkaMfgEna_Cnt_T_logl	boolean	FALSE	TRUE
	LkaPrmntFlt_Cnt_T_logl	boolean	FALSE	TRUE
	LoaSt_Cnt_T_enum	boolean	LOAST_NORM	LOAST_IMDTSHTDWNREQD
	LkaFlt_Cnt_T_logl	boolean	FALSE	TRUE
	LkaInhb_Cnt_T_logl	boolean	FALSE	TRUE
	EscSt_Cnt_T_u08	uint8	0	4
	LkaEna_Cnt_T_logl	boolean	FALSE	TRUE
	VehSpdSecurMin_Kph_T_f32	float32	0	511
	VehSpdSecurMax_Kph_T_f32	float32	0	511
	LKAIntv_Cnt_T_logl	boolean	FALSE	TRUE
	MfgOvrlDi_Cnt_T_logl	boolean	FALSE	TRUE
	SysSt_Cnt_T_enum	SysSt1	SYSST_DI	SYSST_WRMININ
	* LkaSt_Cnt_T_u08	uint8	0	4
Return Value	None

Description

Implementation of all LKA state transitions.

‘*LkaSt_Cnt_T_u08’ is the output of this function.

Local Function #12

Function Name	EscStTran	Type	Min		Max
Arguments Passed	EscMfgEna_Cnt_T_logl	boolean	FALSE	TRUE
	EscFlt_Cnt_T_logl	boolean	FALSE	TRUE
	LoaSt_Cnt_T_enum	boolean	LOAST_NORM	LOAST_IMDTSHTDWNREQD
	VehSpdSecurMax_Kph_T_f32	boolean	0	511
	EscEna_Cnt_T_logl	boolean	FALSE	TRUE
	EscLimdActv_Cnt_T_logl	boolean	FALSE	TRUE
	MfgOvrlDi_Cnt_T_logl	boolean	FALSE	TRUE
	SysSt_Cnt_T_enum	SysSt1	SYSST_DI	SYSST_WRMININ
	* EscSt_Cnt_T_u08	uint8	0	4
Return Value	None

Description

Implementation of all ESC state transitions.

‘*EscSt_Cnt_T_u08’ is the output of this function.

Local Function #13

Function Name	HwAgServo	Type	Min		Max
Arguments Passed	HwAgTrajEna_Cnt_T_logl	boolean	FALSE	TRUE
	ApaSt_Cnt_T_u08	uint8	0	4
	HwAgTraj_HwDeg_T_f32	float32	-1440	1440
	HwAgTarLimd_HwDeg_T_f32	float32	-1440	1440
	* HwAgServoCmd_HwDeg_T_f32	float32	-1440	1440
Return Value	HwAgServoEna_Cnt_T_logl	boolean	FALSE	TRUE

Description

Implementation of all ESC state transitions.

‘*HwAgServoCmd_HwDeg_T_f32’ is the output of this function.

Local Function #14

Function Name	InctIgnCntrOnce	Type	Min		Max
Arguments Passed	IgnCntrLcl_Cnt_T_u16	boolean	0	65535
Return Value	N/A

Description

Implementation of “InctIgnCntrOnce” block

Local Function #15

Function Name	HwTqFildChk	Type	Min		Max
Arguments Passed	HwTq_HwNwtMtr_T_f32	float32	-10.0	10.0
Return Value	HwTqFildWithinIntl_Cnt_T_logl	boolean	FALSE	TRUE

Description

Implementation of”HwTqFildIntlChk” block.

Local Function #16

Function Name	LKAIntv	Type	Min		Max
Arguments Passed	HwTq_HwNwtMtr_T_f32	float32	-10.0	10.0
	LkaTqCmdCdnd_HwNwtMtr_T_f32	float32	-3.0	3.0
Return Value	LKAIntv_Cnt_T_logl	boolean	FALSE	TRUE

Description

Implementation of “LKAIntv” block.

Local Function #17

Function Name	LkaPrmntFlt	Type	Min		Max
Arguments Passed	LkaFlt_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	LkaPrmntFlt_Cnt_T_logl	boolean	FALSE	TRUE

Description

Calculates LkaPrmntFlt to be used in state transitions.

Local Function #18

Function Name	HaptcStTranActvToWaitFlg	Type	Min		Max
Arguments Passed	None
Return Value	HaptcStTranActvToWaitFlg_Cnt_T_logl	boolean	FALSE	TRUE

Description

Implementation of “HaptcStTranActvToWaitFlg” block.

Local Function #19

Function Name	TranHaptcWaitToApaStActvFlg	Type	Min		Max
Arguments Passed	None
Return Value	TranHaptcWaitToApaStActvFlg_Cnt_T_logl	boolean	FALSE	TRUE

Description

Implementation of TranHaptcWaitToApaStActvFlg_Cnt_T_logl block.

Local Function #20

Function Name	EnHaptcFb	Type	Min		Max
Arguments Passed	*HwOscnEna_Cnt_T_logl	boolean	FALSE	TRUE
	*HwOscnMotAmp_MotNwtMtr_T_f32	float32	0	1.2
	*HwOscnFrq_Hz_T_f32	float32	10	50
Return Value	None

Description

Implementation of “EnHaptcFb” block.

‘*HwOscnEna_Cnt_T_logl , * HwOscnMotAmp_MotNwtMtr_T_f32, *HwOscnFrq_Hz_T_f32 are the outputs of this function.

Local Function #21

Function Name	HaptcFbPostStrtUp	Type	Min		Max
Arguments Passed	ApaSt_Cnt_T_u08	uint8	0	4
	HaptcSt_Cnt_T_u08	uint8	0	2
	HwTqFildWithinIntl_Cnt_T_logl	boolean	FALSE	TRUE
	VehSpd_Kph_T_f32	float32	0	511
	IgnCntrLcl_Cnt_T_u16	uint16	0	65535
	LoaStLimdOrSwBasdMtgtn_Cnt_T_logl	boolean	FALSE	TRUE
	*HwOscnEna_Cnt_T_logl	boolean	FALSE	TRUE
	*HwOscnMotAmp_MotNwtMtr_T_f32	float32	0	1.2
	*HwOscnFrq_Hz_T_f32	float32	10	50
Return Value	None

Description

Implementation of "En Or Di HaptcFb After Checking At Start Up" block.

‘*HwOscnEna_Cnt_T_logl , * HwOscnMotAmp_MotNwtMtr_T_f32, *HwOscnFrq_Hz_T_f32 are the outputs of this function.

Local Function #22

Function Name	ApaNrcvrlFlt	Type	Min		Max
Arguments Passed	Msg337BusChassisExpInvld_Cnt_T_logl	boolean	FALSE	TRUE
	Msg337BusChassisExpMiss_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	ApaNrcvrlFlt_Cnt_T_logl	boolean	FALSE	TRUE

Description

Determine ApaNrcvrlFlt status.

Local Function #23

Function Name	EscFlt	Type	Min		Max
Arguments Passed	Msg180BusChassisExpInvld_Cnt_T_logl	boolean	FALSE	TRUE
	Msg180BusChassisExpMiss_Cnt_T_logl	boolean	FALSE	TRUE
Return Value	EscFlt_Cnt_T_logl	boolean	FALSE	TRUE

Description

Determine EscFlt status.

Local Function #24

Function Name	LkaCheck	Type	Min		Max
Arguments Passed	*LkaFlt_Cnt_T_logl	boolean	FALSE	TRUE
	*LkaInhb_Cnt_T_logl	boolean	FALSE	TRUE
	*LkaPrmnFlt_Cnt_T_logl	boolean	FALSE	TRUE

Description

Implements LKA Check subsystem in model. The arguments to this function are all returned as output.

GLOBAL Function/Macro Definitions

None

Known Limitations with Design

DataDict.m includes a default value for GmLoaIgnCntr NVM. This is redundant because the design uses the NVM GetErrorStatus function call to determine if this NVM value should be set to its default value of 0.

UNIT TEST CONSIDERATION

None

Abbreviations and Acronyms

Abbreviation or Acronym	Description

Glossary

Note: Terms and definitions from the source “Nexteer Automotive” take precedence over all other definitions of the same term. Terms and definitions from the source “Nexteer Automotive” are formulated from multiple sources, including the following:

ISO 9000
ISO/IEC 12207
ISO/IEC 15504
Automotive SPICE® Process Reference Model (PRM)
Automotive SPICE® Process Assessment Model (PAM)
ISO/IEC 15288
ISO 26262
IEEE Standards
SWEBOK
PMBOK
Existing Nexteer Automotive documentation

Term	Definition	Source
MDD	Module Design Document
DFD	Data Flow Diagram

References

Ref. #	Title	Version
1	AUTOSAR Specification of Memory Mapping (Link:AUTOSAR_SWS_MemoryMapping.pdf)	v1.3.0 R4.0 Rev 2
2	MDD Guideline	EA4 01.00.01
3	Software Naming Conventions.doc	1.0
4	Software Design and Coding Standards.doc	2.1
5	FDD : CF009A_ GmOvrlStMgr_Design	See Synergy sub project version

3 - GmOvrlStMgr_Review

Overview

Summary Sheet
Synergy Project
Source Code
MDD
PolySpace

Sheet 1: Summary Sheet

Rev 1.2

8-Jun-15

Peer Review Summary Sheet

Synergy Project Name:

kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. CF009A_GmOvrlStMgr_Impl

Revision / Baseline:

kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. CF009A_GmOvrlStMgr_Impl_4.1.1

Change Owner:

kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Jayakrishnan T

Work CR ID:

EA4#9043

kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:

kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:

Reviewed:

Yes

MDD

Yes

Source Code

Yes

PolySpace

N/A

Integration Manual

N/A

Davinci Files

Comments:

Only reviewed changes

General Guidelines:
- The reviews shall be performed over the portions of the component that were modified as a result of the Change Request.
- New components should include FDD Owner and Integrator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Enter any rework required into the comment field and select No. When the rework is complete, review again using this same review sheet and select Yes. Add date and additional comment stating that the rework is completed.
- To review a component with multiple source code files use the "Add Source" button to create a Source code tab for each source file.
- .h file should be reviewed with the source file as part of the source file.

Sheet 2: Synergy Project

Peer Review Meeting Log (Component Synergy Project Review)

Quality Check Items:

Rationale is required for all answers of No

New baseline version name from Summary Sheet follows

Yes

Comments:

naming convention

Project contains necessary subprojects

Yes

Comments:

Project contains the correct version of subprojects

Yes

Comments:

Design subproject is correct version

Yes

Comments:

General Notes / Comments:

LN: Intended Use: Identify who were the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. KMC: Group Review Level removed in Rev 4.0 since the design review is not checked in until approved, so it would always be DR4. Review Board:

Change Owner:

Jayakrishnan T

Review Date :

02/02/17

Lead Peer Reviewer:

Shruthi R

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 3: Source Code

Rev 1.2

8-Jun-15

Peer Review Meeting Log (Source Code Review)

Source File Name:

GmOvrlStMgr.c

Source File Revision:

Header File Name:

Header File Revision:

kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this.

MDD Name:

GmOvrlStMgr_MDD.docx

Revision:

FDD/SCIR/DSR/FDR/CM Name:

CF009A_GmOvrlStMgr_Design

Revision:

4.1.0

Quality Check Items:

Rationale is required for all answers of No

Working EA4 Software Naming Convention followed:

for variable names

Yes

Comments:

for constant names

N/A

Comments:

Only reviewed changes

for function names

N/A

Comments:

for other names (component, memory

N/A

Comments:

mapping handles, typedefs, etc.)

All paths assign a value to outputs, ensuring

Yes

Comments:

all outputs are initialized prior to being written

Requirements Tracability tags in code match the requirements tracability in the FDD

N/A

Comments:

requirements tracability in the FDD

No requirement traceability

All variables are declared at the function level.

Yes

Comments:

Synergy version matches change history

kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.

Yes

Comments:

and Version Control version in file comment block

Change log contains detailed description of changes

Yes

Comments:

and Work CR number

Code accurately implements FDD (Document or Model)

Yes

Comments:

Verified no Compiler Errors or Warnings

KMC: Intended Use: To confirm no compiler errors or warnings exist for the code under review (warnings from contract header files may be ignored). Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project should be used; QAC can find compiler errors but not warnings.

Yes

Comments:

Component.h is included

N/A

Comments:

All other includes are actually needed. (System includes

N/A

Comments:

only allowed in Nexteer library components)

Software Design and Coding Standards followed:

Version: 2.1

Code comments are clear, correct, and adequate

Yes

Comments:

and have been updated for the change: [N40] and

all other rules in the same section as rule [N40],

plus [N75], [N12], [N23], [N33], [N37], [N38],

[N48], [N54], [N77], [N79], [N72]

Source file (.c and .h) comment blocks are per

Yes

Comments:

standards and contain correct information: [N41], [N42]

Function comment blocks are per standards and

N/A

Comments:

contain correct information: [N43]

Code formatting (indentation, placement of

Yes

Comments:

braces, etc.) is per standards: [N5], [N55], [N56],

[N57], [N58], [N59]

Embedded constants used per standards; no

N/A

Comments:

"magic numbers": [N12]

Memory mapping for non-RTE code

N/A

Comments:

is per standard

All execution-order-dependent code can be

Yes

Comments:

recognized by the compiler: [N80]

All loops have termination conditions that ensure

N/A

Comments:

finite loop iterations: [N63]

All divides protect against divide by zero

N/A

Comments:

if needed: [N65]

All integer division and modulus operations

N/A

Comments:

handle negative numbers correctly: [N76]

All typecasting and fixed point arithmetic,

N/A

Comments:

including all use of fixed point macros and

timer functions, is correct and has no possibility

of unintended overflow or underflow: [N66]

All float-to-unsiged conversions ensure the.

N/A

Comments:

float value is non-negative: [N67]

All conversions between signed and unsigned

N/A

Comments:

types handle msb==1 as intended: [N78]

All pointer dereferencing protects against

N/A

Comments:

null pointer if needed: [N70]

Component outputs are limited to the legal range

N/A

Comments:

defined in the FDD DataDict.m file : [N53]

All code is mapped with FDD (all FDD

Yes

Comments:

subfunctions and/or model blocks identified

with code comments; all code corresponds to

some FDD subfunction and/or model block): [N40]

Review did not identify violations of other

Yes

Comments:

coding standard rules

Anomaly or Design Work CR created

N/A

Comments: List Anomaly or CR numbers

for any FDD corrections needed

General Notes / Comments:

Anomaly fix EA4#8726 : Corrective action for this anomaly was to update the code as per model and it would fix the anomaly and the same was verified as

using a PSR.Corrective action mentioned in synergy database not followed for the same reason.

Change Owner:

Jayakrishnan T

Review Date :

02/02/17

Lead Peer Reviewer:

Shruthi R

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 4: MDD

Rev 1.2

8-Jun-15

Peer Review Meeting Log (MDD Review)

MDD Name:

GmOvrlStMgr_MDD.docx

MDD Revision:

Source File Name:

GmOvrlStMgr.c

Source File Revision:

Source File Name:

Source File Revision:

Source File Name:

Source File Revision:

Quality Check Items:

Rationale is required for all answers of No

Synergy version matches document

Yes

Comments:

Change log contains detailed description of changes

Yes

Comments:

Changes Highlighted (for Unit Tester)

Yes

Comments:

Diagrams have been included per MDD Guideline

N/A

Comments:

and reviewed

All Design Exceptions and Limitations are listed

N/A

Comments:

Design rationale given for all global

N/A

Comments:

data not communicated through RTE ports, per

Design and Coding Standards rules [N9] and [N10].

All implementation details that differ from the FDD are

N/A

Comments:

noted and explained in Design Rationale

All Unit Test Considerations have been described

N/A

Comments:

General Notes / Comments:

Change Owner:

Krishna Anne

Review Date :

02/02/17

Lead Peer Reviewer:

Shruthi R

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 5: PolySpace

Rev 1.2

8-Jun-15

Peer Review Meeting Log (QAC/PolySpace Review)

Source File Name:

GmOvrlStMgr.c

Source File Revision:

Source File Name:

Source File Revision:

Source File Name:

Source File Revision:

EA4 Static Analysis Compliance Guideline version:

Draft 01.02.00

Poly Space version:

Windows User: eg. 2013b 2013b

Polyspace sub project version:

Windows User: eg. TL108a_PolyspaceSuprt_1.0.0

QAC version:

Windows User: eg 8.1.1-R 8.1.1-R

QAC sub project version:

Windows User: eg. TL_100A_1.1.0 TL100A_QACSuprt_1.2.0

Quality Check Items:

Rationale is required for all answers of No

Contract Folder's header files are appropriate and

kzshz2: Intended Use: Identify that the contract folder contains only the information required for this component. All other variables, constants, function prototypes, etc. should be removed. Rationale: This will help avoid unit testers having to considers object not used. It will also avoid having other files required for QAC.

Yes

Comments:

2/2/2017

function prototypes match the latest component version

100% Compliance to the EA4 Static Analysis

Yes

Comments:

Compliance Guideline

Are previously added justification and deviation

Yes

Comments:

comments still appropriate

Do all MISRA deviation comments use approved

Yes

Comments:

deviation tags

Cyclomatic complexity and Static path count OK

Creager, Kathleen: use Browse Function Metrics, STCYC and STPTH

Yes

Comments:

for all functions in the component per Design

and Coding Standards rule [N47]

General Notes / Comments:

Change Owner:

Jayakrishnan T

Review Date :

02/02/17

Lead Peer Reviewer:

Shruthi R

Approved by Reviewer(s):

Yes

Other Reviewer(s):