1 - ES238A_HwAgArbn FDP Design Review Checklist

Nexteer_Template_V1.0

Overview

Peer Review Instructions
Technical Review Checklist
Template Change Log


Sheet 1: Peer Review Instructions

Instructions for Functional Design Package Peer Review




PRE-MEETING


Function OwnerConfirm that requirements are reviewed and approved PRIOR to the FDP peer review

Function OwnerStart with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews

Function OwnerProvide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review

Function OwnerNotify the assigned peer reviewer and make sure they are prepared to do their function in the meeting

Function OwnerIdentify necessary attendance and invite to meeting

Function OwnerComplete the "Author" column information for sections 1 through 3 prior to the review

Function OwnerComplete the attendance invitation list in section 5

Function OwnerFor Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews.



DURING MEETING


Function OwnerPresent document changes to the review team

Peer ReviewerCapture attendance of the review

Peer ReviewerCapture actions and issues in section 4. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN"



POST MEETING


Function OwnerFollow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided.

Function OwnerSchedule follow up review OR review open items with peer reviewer and obtain agreement to close

Peer ReviewerClose change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates

Sheet 2: Technical Review Checklist

Technical Review Checklist - Template Version 01.00.05







Product NameElectric Power SteeringElectrical Arch.4Review ScopeDefect TypeNumbers




YesClosedFR
Function NameES238A_HwAgArbnBaseline1.0.0Initial release. Includes arbitration of two channels based on correlation status and signal availabilityRequirement0




NoRejectedFDD
AuthorKushion

Interface0




NAOpenModel


EffortDesign0






FMEA


Review Effort(Hrs.)1.00Standards2






*.m File


Corr+Verf effort(Hrs.)
Documentation1






Cal Process


Total Effort (Hrs.)1.00Others0













Total3







Checklist No.Description of CheckAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







1Section 1: TECHNICAL CHECK













1.1Confirm that all signal inputs into the FDP (Functional Design Package) are contained within and exactly named as the "Available_Nexteer_Signals.m" states.Yes












1.2Confirm any removed signal inputs from the design have been removed from the "Available_Nexteer_Signals.m" file.Yes












1.3Confirm all signals and parameters (outputs, calibrations, constants, non-volatile memory) used in the *.m file and the design conform to the AutoSAR naming convention documentation.Yes












1.4Confirm *.m file has been provided to the "Available_Signal_Names" Author.Yes


Will be provided when in Synergy per new process








1.5Confirm Electrical Systems interface map is updated to reflect the FDP (signal IO)Yes


Map Updated








2Section 2: Safety CHECKAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







2.1Confirm that the functional DFMEA is up to date based on the design in the current package.NA












2.2Confirm that Safety requirements (ASIL A - D) are referenced in the design documents.Yes












3Section 3: Lessons LearnedAuthor: This column is for Self review. Author shall fill Yes/No/NA against each point in checklist. AuthorAuthor: This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist. ReviewerAuthor: Detailed Description of the finding shall be provided by the reviewer. Description of finding by reviewerAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







3.1Have functions depending upon system state been reviewed for need to be executed at the 2ms rate to avoid system lag issues?Yes


Function runs in all states, so no concern








3.2Have all diagnostics (NTCs) been confirmed to show logic to invoke a diagnostic "PASS" for control of the status byte at the customer level.NA


No NTCs








3.3Has the requirements traceability steps used the RMI steps as defined in the FDD authoring spec to generate the traceability report?Yes












3.4Has the requirements traceability report been verified to only contain ONLY requirements from the FR.Yes












3.5Confirm that all PIM that does NOT have an initialization value of zero is initialized in an INIT function.NA


No PIM initialized to non-zero value








3.6














3.7














































4Section 4: Issues / Actions IdentifiedDocumentReferenceSummary of resolutionAuthor: Defect type to be selected. Defect TypeAuthor: What action is taken to fix the comment & other remarks need to be filled by author. Remarks By AuthorAuthor: Data in this column shall be filled by reviewer after checking whether the rework is completed. Status







4.1Rename variables with counter to 'Cntr'Model
Corrected during meetingStandards
Closed







4.2Elaborate Long Names*.m File
Corrected during meetingStandards
Closed







4.3Rerun reqmt traceability after FR is baselined

Reran with Review View after baselinedDocumentation
Closed







4.4














4.5














4.6














4.7














4.8














4.9














4.10














4.11














4.12














4.13














4.14














4.15














4.16














4.17














4.18














4.19














4.20














4.21














4.22














4.23














4.24














4.25














5Section 5: APPROVALS













RoleFirst ReviewDateAttendanceApproval?










Function Owner*Kushion7/14/2015YesYes










Peer Reviewer*AmberkarYes










EPDT EngineerMcCannNo










ES EngineerPatelYes










Software LeadRijviYes










Hardware Lead<Name - if invited>











Test LeadChinchalpetYes










Safety LeadMillsapYes










RoleSecond Review (if required)DateAttendanceApproval?










Function Owner*Muragesh Asundi8/14/2015YesYes










Peer Reviewer*Spandana BalaniYes










EPDT Engineer<Name - if invited>











ES Engineer<Name - if invited>











Software Lead<Name - if invited>











Hardware Lead<Name - if invited>











Test Lead<Name - if invited>











Safety Lead<Name - if invited>











RoleThird Review (if required)DateAttendanceApproval?










Function Owner*<Owner Name>













Peer Reviewer*<Name>











EPDT Engineer<Name - if invited>











ES Engineer<Name - if invited>











Software Lead<Name - if invited>











Hardware Lead<Name - if invited>











Test Lead<Name - if invited>











Safety Lead<Name - if invited>











RoleFourth Review (if required)DateAttendanceApproval?










Function Owner*<Owner Name>













Peer Reviewer*<Name>











EPDT Engineer<Name - if invited>











ES Engineer<Name - if invited>











Software Lead<Name - if invited>











Hardware Lead<Name - if invited>











Test Lead<Name - if invited>











Safety Lead<Name - if invited>











RoleAdd more if necessaryDateAttendanceApproval?










































P.S.:Yes indicates adherence














No indicates non-adherence, reviewer shall provide suitable comments at the end of this document for each point.














NA indicates not applicable














Sheet 3: Template Change Log

RevChangeAuthor
01.00.05Added lesson learned #3.5MDK
01.00.06Added lesson learned #3.6, 3.7 - Structure and writing of NVM in mfiles and models.MDK




















































































2 - ES238A_HwAgArbn_slwebview

Simulink Web View

3 - ES238A_HwAgArbn_requirements

Requirements Traceability Report for ES238A_HwAgArbn

Requirements Traceability Report for ES238A_HwAgArbn


Chapter 1. Model Information for "ES238A_HwAgArbn"

Table 1.1. ES238A_HwAgArbn Version Information

ModelVersion1.245ConfigurationManagerNone
CreatedThu Mar 19 15:38:41 2015Creatorrzqy0r
LastModifiedDateFri Aug 14 13:53:17 2015LastModifiedByFZG88Y

Chapter 2. Traceability Summary for "ES238A_HwAgArbn"

.

Chapter 4. System - Arbitration

.

Chapter 5. System - HwAgAAvlChk

Table 5.1. ES238A_HwAgArbn/HwAgArbn/HwAgArbnPer1/HwAgAAvlChk Requirements Traceability Data

.

Chapter 6. System - HwAgAAvlChk1

Table 6.1. ES238A_HwAgArbn/HwAgArbn/HwAgArbnPer1/HwAgAAvlChk1 Requirements Traceability Data

.