This is the multi-page printable view of this section. Click here to print.
Component Design
1 - SF028A_AssiHiFrq_Peer Review Checklist Design
Overview
Peer Review InstructionsTechnical Review Checklist
Template Change Log
Sheet 1: Peer Review Instructions
| Instructions for Functional Design Package Peer Review | ||
| PRE-MEETING | ||
| Function Owner | Confirm that requirements are reviewed and approved PRIOR to the FDP peer review | |
| Function Owner | Start with latest version of the template for any "first reviews" - Continue to use existing temmplate for re-reviews | |
| Function Owner | Provide the functional design package (changed documents) to the invited attendees 1-2 working days in advance of review | |
| Function Owner | Notify the assigned peer reviewer and make sure they are prepared to do their function in the meeting | |
| Function Owner | Identify necessary attendance and invite to meeting | |
| Function Owner | Complete the "Author" column information for sections 1 through 3 prior to the review | |
| Function Owner | Complete the attendance invitation list in section 5 | |
| Function Owner | For Re-reviews only: Complete the column "remarks by author" to identify actions taken to address items found in earlier reviews. | |
| DURING MEETING | ||
| Function Owner | Present document changes to the review team | |
| Peer Reviewer | Capture attendance of the review | |
| Peer Reviewer | Capture actions and issues in section 4. Identify issue summary, Document type, Reference (Requirement ID, section number, etc), Defect Type and indicate status as "OPEN" | |
| POST MEETING | ||
| Function Owner | Follow up on all "open" items. Update "Summary of Resolution" to indicate what was done or decided. | |
| Function Owner | Schedule follow up review OR review open items with peer reviewer and obtain agreement to close | |
| Peer Reviewer | Close change request in system and confirm all associated tasks are complete. Upload peer review checklist (this document) with any FDP updates | 
Sheet 2: Technical Review Checklist
Sheet 3: Template Change Log
| Rev | Change | Author | 
2 - SF028A_AssiHiFrq_ModelAdvisorReport
| Model Advisor Report - SF028A_AssiHiFrq.slx | |
| Simulink version: 8.2 | Model version: 1.4 | 
| System: SF028A_AssiHiFrq | Current run: 02-Jun-2016 10:25:24 | 
| Model Advisor configuration: ...NxtrModelAdvisorConfig.mat | |
Run Summary
| Pass | Fail | Warning | Not Run | Total | 
|  |  |  |  | 200 | 
You should turn on the following optimization(s):
| none. | |
| none. | |
| none. | |
The following blocks are parameterized library links. Changes can be propagated to the library or discarded by right-clicking on the block in the Simulink diagram and choosing the appropriate item from the "Library Link" menu.
Identify Inport blocks in the top-level of the model with missing or inherited sample times, data types, or port dimensions
Warning
The following Inport blocks have undefined or inherited sample times, data types or port dimensions
| Inport | Link | Conditions | 
| 1 | SF028A_AssiHiFrq/VehSpd | Missing port dimension Missing signal data type Missing port sample time | 
| 2 | SF028A_AssiHiFrq/HwTq | Missing port dimension Missing signal data type Missing port sample time | 
| 3 | SF028A_AssiHiFrq/WhlImbRejctnAmp | Missing port dimension Missing signal data type Missing port sample time | 
Recommended Action
Explicitly define all missing Inport block properties identified in the results
- Missing port dimension: Model contains Inport blocks with inherited port dimension (-1). Specify port dimension for the listed Inport blocks.
- Missing signal data type: Model contains Inport blocks with inherited data type. Specify a data type for the listed Inport blocks.
- Missing port sample time: Model contains Inport blocks with inherited sample time (-1). Specify sample time information for the listed Inport blocks. Note: The sample time of root Inports with bus type must match the sample times specified at the leaf elements of the bus object.
Check Simulink blocks and Stateflow objects that do not link to a requirements document
Warning
The following blocks do not link to a requirement document:
- SF028A_AssiHiFrq/VehSpd
- SF028A_AssiHiFrq/HwTq
- SF028A_AssiHiFrq/WhlImbRejctnAmp
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq/call_AssiHiFrqInit1
- SF028A_AssiHiFrq/AssiHiFrq/call_AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqInit1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqInit1/function
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqInit1/CopyRight2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqInit1/FilHpInit
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/VehSpd
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/HwTq
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/WhlImbRejctnAmp
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Trigger
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Abslt_f32_f1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/CopyRight2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/HwTq
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/VehSpd
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/WhlImbRejctnAmp
- ..../AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY
- ..../AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY1
- ..../AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Blnd_f32
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/CopyRight2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Data Store Write
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Data Store Write1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Data Store Write2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FixdToFloat_f32_u1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FixdToFloat_f32_u16
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FixdToFloat_f32_u2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FloatToFixd_u16_f1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FloatToFixd_u16_f2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FloatToFixd_u16_f32
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From12
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From6
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From7
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Goto
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Goto1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/AssiHiFrqGain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From3
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From4
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From6
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto3
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto4
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/AssiHiFrqCmd
- SF028A_AssiHiFrq/AssiHiFrq/CopyRight2
- SF028A_AssiHiFrq/AssiHiFrq/Data Store Memory
- SF028A_AssiHiFrq/AssiHiFrq/Data Store Memory1
- SF028A_AssiHiFrq/AssiHiFrq/Data Store Memory2
- SF028A_AssiHiFrq/AssiHiFrq/Data Store Memory3
- SF028A_AssiHiFrq/CopyRight2
- SF028A_AssiHiFrq/Demux
- SF028A_AssiHiFrq/FunctionCall Generator
- SF028A_AssiHiFrq/Out1
Recommended Action
For each object in the list, in the Model Editor, right-click the block, select Requirements, and specify a requirement.
Identify levels in the model that include basic blocks and subsystems. Each level of a model must be designed with blocks of the same level (for example, only subsystems or only basic blocks).
See Also
The following level(s) in the model include basic blocks and subsystems:
∧ Less
Recommended Action
If possible, replace blocks at the identified level of the model hierarchy with basic blocks. Move nonvirtual blocks into the identified subsystem.
Identify nonstandard display attributes in Simulink diagrams.
See Also
Check format settings
Identify incorrect model-level format options.
Passed
The format options are correct.
_________________________________________________________________________________________
Check block colors
Identify blocks using nonstandard colors.
Warning
The following blocks use nonstandard colors:
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From12
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From6
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/From7
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Goto
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Goto1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/HwTq
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/VehSpd
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/WhlImbRejctnAmp
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From3
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From4
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/From6
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto2
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto3
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto4
- SF028A_AssiHiFrq/AssiHiFrq/HwTq
- SF028A_AssiHiFrq/AssiHiFrq/VehSpd
- SF028A_AssiHiFrq/AssiHiFrq/WhlImbRejctnAmp
- SF028A_AssiHiFrq/AssiHiFrq/call_AssiHiFrqInit1
- SF028A_AssiHiFrq/AssiHiFrq/call_AssiHiFrqPer1
Recommended Action
Set the block foreground color to black and the background color to white.
_________________________________________________________________________________________
Check canvas colors
Identify canvases that are not white.
Passed
All diagrams use a white canvas.
_________________________________________________________________________________________
Check diagram zoom
Identify diagrams that do not have zoom factor set to 100 %.
Passed
All canvases have a zoom factor of 100 percent.
Identify blocks that require labeled signals. A subset of source and destination blocks require labeled signals.
See Also
Check source block labels
The following source blocks require labeled signals; Inport, From, Data Store Read, Constant, Bus Selector, Demux, Selector. If the signal name is visible on the block, this rule is considered met.
Warning
The following signals have no label:
- SF028A_AssiHiFrq
- SF028A_AssiHiFrq
- SF028A_AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq
- SF028A_AssiHiFrq
Recommended Action
Add a new or propagated label to the signal line.
_________________________________________________________________________________________
Check destination block labels
The following destination blocks require labeled signals; Outport, Goto, Data Store Write, Bus Creator, Mux, Subsystem, Chart. If the signal name is visible on the source block, this rule is considered met.
Warning
The following signals have no label:
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/AssiHiFrqCmd/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqCmd/
- SF028A_AssiHiFrq/Out1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Goto/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Goto1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Goto3/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Data Store_Write/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/Data Store_Write2/
- SF028A_AssiHiFrq/AssiHiFrq/
- SF028A_AssiHiFrq/AssiHiFrq/
- SF028A_AssiHiFrq/AssiHiFrq/
- SF028A_AssiHiFrq/AssiHiFrq/
- SF028A_AssiHiFrq/AssiHiFrq/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY2/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/BilnrIntrpnWithRound_u16_u16MplXu16MplY2/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FloatToFixd_u16_f1/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FloatToFixd_u16_f2/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/Determine Gain/FloatToFixd_u16_f32/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/FilHpUpdGain/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/FilHpUpdOutp/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/FloatToFixd_u16_f32/
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/LnrIntrpn_u16_u16VariXu16VariY/
Recommended Action
Add a new or propagated label to the signal line.
Identify propagated labels on signal lines.
See Also
Check subsystem block input labels
Identify inputs to subsystem blocks to verify that the signals have labels.
Warning
The following subsystem-level Inport block signals should propagate signal labels from the parent system.
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
- SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1
Add labels to the input signals.
_________________________________________________________________________________________
Check subsystem input signals
Identify inputs to subsystem blocks to ensure that propagated signals are displayed.
Warning
The following subsystem-level Inport block signals have no propagated signal labels. Signals coming from parent system should have a label.
Display signal labels for propagated signals on the inputs signals.
_________________________________________________________________________________________
Check subsystem output label propagation
Identify outputs from subsystem blocks where propagated signals are not displayed.
Warning
The following subsystem-level Outport block signals have no propagated signal label. Signals coming from the subsystem should have a label.
Display signal labels for propagated signals on the output signals.
_________________________________________________________________________________________
Signal propagation for nonsubsystem blocks
Identify the signal propagation status for both transformative and nontransformative blocks.
Passed
All outputs from non subsystem blocks correctly use labels and display propagated signals.
Identify blocks that are not allowed in discrete controllers. Prohibited blocks include all continuous blocks and some source and sink blocks.
See Also
- MathWorks Automotive Advisory Board Guideline: jm_0001
- Check for blocks not recommended for C/C++ production code deployment
All blocks in the model are allowed in discrete controllers.
Inconsistencies:
The following selection-based links have descriptions that differ from their corresponding selections in the requirements documents. If this reflects a change in the requirements document, click Update to replace the current description in the selection-based link with the text from the requirements document (the external description). Block Current description External description REQ:SF028A_9 REQ: SF028A_9 Update REQ:SF028A_32 REQ: SF028A_32 Update REQ:SF028A_33 REQ: SF028A_33 Update REQ:SF028A_11 REQ: SF028A_11 Update REQ:SF028A_43 REQ: SF028A_43 Update REQ:SF028A_41 REQ: SF028A_41 Update REQ:SF028A_41 REQ: SF028A_41 Update SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/FixdToFloat_f32_u16
REQ:SF028A_41 REQ: SF028A_41 Update SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/FloatToFixd_u16_f32
REQ:SF028A_41 REQ: SF028A_41 Update REQ:SF028A_41 REQ: SF028A_41 Update REQ:SF028A_63 REQ: SF028A_63 Update SF028A_AssiHiFrq/AssiHiFrq/AssiHiFrqPer1/LnrIntrpn_u16_u16VariXu16VariY
REQ:SF028A_41 REQ: SF028A_41 Update REQ:SF028A_40 REQ: SF028A_40 Update