| Peer Review Checklist - Component Design |
| Template Version: | 3.0.0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Yes | Closed | FR |
 |
|
|
|
|
|
|
|
|
|
| No | Rejected | FDD |
| Process Reviewer: | Fei Y |
|
|
|
|
|
|
| NA | Open | Model |
| (optional) Reviewer #2: |
|
|
|
|
|
|
|
|
|
| FMEA |
|
| see section 4 |
|
|
|
|
|
|
|
|
| *.m File |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Cal Process |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Item No. | Cross Ref. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 |
| Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for Runnables: .Context | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for Runnables: .TimeStep | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for SrvRunnables: .Return | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for SrvRunnables: .Arguments | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .EngDT | Yes | Yes | Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .DocUnit | Yes | Yes | Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .EngInit | Yes | Yes | Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .EngMin | Yes | Yes | Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .EngMax | Yes | Yes | Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .ReadIn/WrittenIn | Yes | Yes | Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Ip/Op/IrvSignals: .ReadType/WriteType | Yes |
| Handwheel Torque Overlay Input Added |
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .DocUnit | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .PortName | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NVM: .DocUnit | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all PIM: .DocUnit | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Constants: .DocUnit | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does FDD Long Name, Short Name, and Description match requirements? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do output signal ranges match requirements? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all clients from model defined in dictionary? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do client definitions match their corresponding server runnable? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM defined in the appropriate number of blocks (separate for EOL vs saved at power-off)? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM with multiple values defined as a structure? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are NVM structure members arranged largest-to-smallest datatype? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are local Constants unique from global constants available in xx999A dictionaries? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are Constant names abbreviated properly (ALLCAPS are not checkable by tools)? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Data Dictionary Verification report error free? | NO |
| HysCmpCmdDi Name does not match required pattern.
Cannot match name to list of known Nexteer signals | HysCmpCmdDi should be added to the signal list in the next update. | Closed |
|
|
|
|
|
|
|
|
|
| Are all data types represented by released Data_Management classes? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 |
| Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is each diagnostic (NTC) capable of being set to "PASS"? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does non-zero intialization of PIM occur in the function's Init runnable? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does design properly include Set Ram Block Status when NVM RAM values change? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are NTCs set only outside an IRQ (not related to the typical periodic OS)? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are NTCs set and read only at periodic steps no less than 2 ms? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does model execute without errors/warnings after loading NxtrMBDConfig configuration set? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is filename of model in correct format? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Requirements Baseline? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Top level of the model annotated with Tool Dependencies? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is Top level of model annotated with Change Log or History? | YES |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from subsystems that are not Function-Call Subsystems? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the 2nd level of model free from arithmetic and logic operations? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the Runnable trigger signals named as "call_<Runnable>"? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number? | NA | No | The version number mismatchs the one in the 1st level. | Version Number corrected | Closed |
|
|
|
|
|
|
|
|
|
| Are all data flow layers free of Function-Call Subsystems and Memory Store blocks? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the Model have the confidentiality and copyright information inside all its Subsystems? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are all requirements links of the format <FDDNumber>_<ObjectID>? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does requirements HTML report reference only the DOORS module of this component for all links in the design? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Was Model Advisor run with the correct configuration settings? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the Model Advisor rerport free from "Fails". | YES |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the model execute? | YES |
|
|
|
|
|
|
|
|
|
|
|
|
|
| If model has ADC input, is failure boolean input and appropriate fault response been included? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do cal ranges & logic ensure no incompatible values for their datatype? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are "magic numbers" acceptable? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do IF..ELSEIF blocks also contain an ELSE condition? | YES |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do SWITCH CASE blocks also contain a DEFAULT condtion? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| 3 |
| Are ELSE and DEFAULT branching conditions reachable when dependent on internal variables? | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Does review meet 'inspection' criteria? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does Doc folder contain a zipped HTML webview model? | Yes | Yes | The previous peer review checklist should be removed. | Previous peer review checklist deleted | Closed |
|
|
|
|
|
|
|
|
|
| Was webview model created without requirements highlighted? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does Doc folder contain appropriate number of NTC Summary sheets? | Yes | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does Reports folder contain only the data dictionary verification report, Model Advisor report, and zipped requirements traceability report? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 |
| Section 4: Other Issus/Actions Identified | Document | Reference | Summary of resolution | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 4.1 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.2 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.3 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.4 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.5 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.6 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.7 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.8 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.9 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.10 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.11 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.12 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.13 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.14 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.15 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.16 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Review Checklist - Component Design |
| Template Version: | 3.0.0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Yes | Closed | FR |
 |
|
|
|
|
|
|
|
|
|
| No | Rejected | FDD |
| Safety Reviewer: | NA |
|
|
|
|
|
|
| NA | Open | Model |
| (optional) Reviewer #2: | Kevin Derry |
|
|
|
|
|
|
|
|
| FMEA |
|
|
|
|
|
|
|
|
|
|
|
| *.m File |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Cal Process |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Item No. | Cross Ref. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 |
| Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .Impact | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .TuningOwner | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .Online | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the FDD .DesignASIL property match requirements? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are lookup tables using compatible table dimensions? | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 |
| Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Are Model Advisor report ISO26262 warnings acceptable? |
| yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is model free from dynamic array size allocation? |
| yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is model free from data type conversion blocks that do not explicitly state desired data type? |
| yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does model refrain from using Display Variable values in downstream operations? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all GOTO/FROM blocks restricted in scope to their own subystem level? |
| yes |
|
|
|
|
|
|
|
|
|
|
|
|
| If model has ADC input, is failure boolean input and appropriate fault response been included? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design include output limiting blocks? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do cal ranges & logic ensure freedom from divide-by-zero? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NTC: .NtcTyp |
| yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does model include appropriate logic for dealing with missing or corrupted NVM data? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 |
| Section 3: Delivery Package | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Does review meet 'inspection' criteria? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 |
| Section 4: Other Issus/Actions Identified | Document | Reference | Summary of resolution | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 4.1 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.2 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.3 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.4 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.5 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.6 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.7 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.8 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.9 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.10 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.11 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.12 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.13 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.14 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.15 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.16 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Review Checklist - Component Design |
| Template Version: | 3.0.0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Yes | Closed | FR |
 |
|
|
|
|
|
|
|
|
|
| No | Rejected | FDD |
| Software Reviewer: | Matthew Leser |
|
|
|
|
|
|
| NA | Open | Model |
| (optional) Reviewer #2: | Kevin Derry |
|
|
|
|
|
|
|
|
| FMEA |
|
|
|
|
|
|
|
|
|
|
|
| *.m File |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Cal Process |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Item No. | Cross Ref. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 |
| Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for Runnables: .Context |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for SrvRunnables: .Return |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for SrvRunnables: .Arguments |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .PortName |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NVM: .EngInit |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NVM: .Alias |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NVM: .InitRowCol |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Display Variables: .EngMin |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Display Variables: .EngMax |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Display Variables: .InitRowCol |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all PIM: .EngMin |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all PIM: .EngMax |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all PIM: .InitRowCol |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are lookup tables using compatible table dimensions? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all clients from model defined in dictionary? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do client definitions match their corresponding server runnable? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM defined in the appropriate number of blocks (separate for EOL vs saved at power-off)? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Is NVM with multiple values defined as a structure? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are NVM structure members arranged largest-to-smallest datatype? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are local Constants unique from global constants available in xx999A dictionaries? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
| Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
| Author:
Detailed Description of the finding shall be provided by the reviewer.
| Corrective Action:
What action is taken to fix the issue?
| Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed.
|
|
|
|
|
|
|
|
|
|
| Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is each diagnostic (NTC) capable of being set to "PASS"? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does non-zero intialization of PIM occur in the function's Init runnable? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design properly include Set Ram Block Status when NVM RAM values change? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are NTCs set only outside an IRQ (not related to the typical periodic OS)? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are NTCs set and read only at periodic steps no less than 2 ms? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Is model free from dynamic array size allocation? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is model free from data type conversion blocks that do not explicitly state desired data type? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does model refrain from using Display Variable values in downstream operations? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all GOTO/FROM blocks restricted in scope to their own subystem level? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design calculate PIM values only within their defined range? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design include output limiting blocks? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do cal ranges & logic ensure freedom from divide-by-zero? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do cal ranges & logic ensure no incompatible values for their datatype? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are Model Advisor report MISRA warnings acceptable? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is design free of unreachable logic? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Do state machines provide exits of all non-latch states? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Is design free from recursive logic that could cause indefinate waits? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design maintain data size consistency? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are "magic numbers" acceptable? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is design of a managable size and easy to understand? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is Stateflow used only for state machines not easily represented in Simulink? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Is model free from over-nested IF logic or redundant IF..ELSEIF..ELSEIF.. Conditions? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Is model free from arithmetic operations on Boolean values? |
| Yes |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 |
| Section 3: Delivery Package | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 |
|
| Document | Reference | Summary of resolution | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 4.1 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.2 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.3 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.4 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.5 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.6 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.7 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.8 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.9 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.10 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.11 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.12 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.13 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.14 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.15 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.16 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Review Checklist - Component Design |
| Template Version: | 3.0.0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Yes | Closed | FR |
 |
|
|
|
|
|
|
|
|
|
| No | Rejected | FDD |
| Applications Reviewer: | NA |
|
|
|
|
|
|
| NA | Open | Model |
| (optional) Reviewer #2: | Kevin Derry |
|
|
|
|
|
|
|
|
| FMEA |
|
|
|
|
|
|
|
|
|
|
|
| *.m File |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Cal Process |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Item No. | Cross Ref. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 |
| Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for Runnables: .TimeStep |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .DocUnit |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .EngMax |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .Cardinality |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .CustomerVisible |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .Impact |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .GraphLink |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .Monotony |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NVM: .DocUnit |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Display Variables: .DocUnit |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .EngVal |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .EngMin |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .TuningOwner |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .Online |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does FDD Long Name, Short Name, and Description match requirements? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do output signal ranges match requirements? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do signal and parameter names accurately describe their purpose? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Do all .Description properties provide useful information? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are calibration tables named correctly (e.g. AssiX and AssiY)? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 |
| Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Does model execute without errors/warnings after loading NxtrMBDConfig configuration set? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does model include adequate annotation throughout? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NTC: .NtcTyp | NA | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are display variables appropriately placed? | NA | NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design provide appropriate tuning flexibility? | Yes | Yes |
|
|
|
|
|
|
|
|
|
|
|
|
| Are blocks linked to the correct requirements? (watch for problems due to copy/pasted blocks) |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is the list of unlinked blocks acceptable? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does design account for all requirements? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is design of a managable size and easy to understand? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Is design easily disabled via calibration? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does design either work with global signal units or contain necessary unit-conversion logic? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 |
| Section 3: Delivery Package | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Does NTC Summary sheet adequately describe NTC usage? | NA |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 |
| Section 4: Other Issus/Actions Identified | Document | Reference | Summary of resolution | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 4.1 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.2 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.3 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.4 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.5 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.6 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.7 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.8 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.9 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.10 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.11 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.12 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.13 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.14 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.15 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.16 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Peer Review Checklist - Component Design |
| Template Version: | 3.0.0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Yes | Closed | FR |
 |
|
|
|
|
|
|
|
|
|
| No | Rejected | FDD |
| SME Reviewer: | NA |
|
|
|
|
|
|
| NA | Open | Model |
| (optional) Reviewer #2: | Kevin Derry |
|
|
|
|
|
|
|
|
| FMEA |
|
|
|
|
|
|
|
|
|
|
|
| *.m File |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Cal Process |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Item No. | Cross Ref. | Description of Check | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 1 |
| Section 1: Data Dictionary |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Calibrations: .EngDT |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all NVM: .EngDT |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Display Variables: .EngDT |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all PIM: .EngDT |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Are the following values correct for all Constants: .EngDT |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Has Static Register evaluation has been completed and updated for any register data that is written to? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 2 |
| Section 2: Model | Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Does model include appropriate logic for dealing with missing or corrupted NVM data? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design either work with global signal units or contain necessary unit-conversion logic? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Does the design prevent Integrator drifting? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Does design make proper use of limiters to prevent integrator windup and runaway values? |
| NA |
|
|
|
|
|
|
|
|
|
|
|
|
| Are all IIR filters free of potential instability over their defined calibration ranges? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 3 |
|
| Author:
This column is for Self review. Author shall fill Yes/No/NA against each point in checklist.
Author | Author:
This column is for reviewer. Reviewer shall fill Yes/No/NA against each point in checklist.
Reviewer | Author:
Detailed Description of the finding shall be provided by the reviewer.
Description of finding by reviewer | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
|
| Has author performed basic simulations to screen for problems? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4 |
|
| Document | Reference | Summary of resolution | Corrective Action:
What action is taken to fix the issue? Corrective Action | Author:
Data in this column shall be filled by reviewer after checking whether the rework is completed. Status |
|
|
|
|
|
|
|
|
| 4.1 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.2 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.3 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.4 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.5 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.6 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.7 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.8 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.9 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.10 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.11 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.12 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.13 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.14 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.15 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.16 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.17 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.19 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.20 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.21 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.22 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.23 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.24 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 4.25 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| This is the master list of questions. |
|
|
 | ADVANCED FILTER CRITERIA |
|
|
| A macro is used to filter and populate separate spreadsheets for each engineering discipline. |
|
| Artifact | Domain1 | Domain2 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Number | Artifact | Checklist Item | Domain1 | Domain2 |
|
|
|
|
| 1 | dict | Is Filename of Data Dictionary in correct format? | Process | none |
|
|
|
|
| 2 | dict | Is the FDD.Version property correctly updated? | Process | none |
|
|
|
|
| 3 | dict | Are the following values correct for Runnables: .Context | Process | Software | Should be Architect |
|
|
|
| 4 | dict | Are the following values correct for Runnables: .TimeStep | Process | Apps | Should be Architect |
|
|
|
| 5 | dict | Are the following values correct for SrvRunnables: .Return | Process | Software | Should be Architect |
|
|
|
| 6 | dict | Are the following values correct for SrvRunnables: .Arguments | Process | Software | Should be Architect |
|
|
|
| 7 | dict | Are the following values correct for all Ip/Op/IrvSignals: .EngDT | Process | none | Should be Architect |
|
|
|
| 8 | dict | Are the following values correct for all Ip/Op/IrvSignals: .DocUnit | Process | none | Should be Architect |
|
|
|
| 9 | dict | Are the following values correct for all Ip/Op/IrvSignals: .EngInit | Process | none | Should be Architect |
|
|
|
| 10 | dict | Are the following values correct for all Ip/Op/IrvSignals: .EngMin | Process | none | Should be Architect |
|
|
|
| 11 | dict | Are the following values correct for all Ip/Op/IrvSignals: .EngMax | Process | none | Should be Architect |
|
|
|
| 12 | dict | Are the following values correct for all Ip/Op/IrvSignals: .ReadIn/WrittenIn | Process | none |
|
|
|
|
| 13 | dict | Are the following values correct for all Ip/Op/IrvSignals: .ReadType/WriteType | Process | none |
|
|
|
|
| 14 | dict | Are the following values correct for all Calibrations: .EngDT | SME | none |
|
|
|
|
| 15 | dict | Are the following values correct for all Calibrations: .DocUnit | Apps | Process |
|
|
|
|
| 16 | dict | Are the following values correct for all Calibrations: .EngMax | Apps | none |
|
|
|
|
| 17 | dict | Are the following values correct for all Calibrations: .Cardinality | Apps | none |
|
|
|
|
| 18 | dict | Are the following values correct for all Calibrations: .CustomerVisible | Apps | none |
|
|
|
|
| 19 | dict | Are the following values correct for all Calibrations: .Impact | Apps | Safety |
|
|
|
|
| 20 | dict | Are the following values correct for all Calibrations: .GraphLink | Apps | none |
|
|
|
|
| 21 | dict | Are the following values correct for all Calibrations: .Monotony | Apps | none |
|
|
|
|
| 22 | dict | Are the following values correct for all Calibrations: .PortName | Software | Process |
|
|
|
|
| 23 | dict | Are the following values correct for all NVM: .EngDT | SME | none |
|
|
|
|
| 24 | dict | Are the following values correct for all NVM: .DocUnit | Process | Apps |
|
|
|
|
| 25 | dict | Are the following values correct for all NVM: .EngInit | Software | none |
|
|
|
|
| 26 | dict | Are the following values correct for all NVM: .Alias | Software | none |
|
|
|
|
| 27 | dict | Are the following values correct for all NVM: .InitRowCol | Software | none |
|
|
|
|
| 28 | dict | Are the following values correct for all Display Variables: .EngDT | SME | none |
|
|
|
|
| 29 | dict | Are the following values correct for all Display Variables: .DocUnit | Apps | none |
|
|
|
|
| 30 | dict | Are the following values correct for all Display Variables: .EngMin | Software | none |
|
|
|
|
| 31 | dict | Are the following values correct for all Display Variables: .EngMax | Software | none |
|
|
|
|
| 32 | dict | Are the following values correct for all Display Variables: .InitRowCol | Software | none |
|
|
|
|
| 33 | dict | Are the following values correct for all PIM: .EngDT | SME | none |
|
|
|
|
| 34 | dict | Are the following values correct for all PIM: .DocUnit | Process | none |
|
|
|
|
| 35 | dict | Are the following values correct for all PIM: .EngMin | Software | none |
|
|
|
|
| 36 | dict | Are the following values correct for all PIM: .EngMax | Software | none |
|
|
|
|
| 37 | dict | Are the following values correct for all PIM: .InitRowCol | Software | none |
|
|
|
|
| 38 | dict | Are the following values correct for all Constants: .EngDT | SME | none |
|
|
|
|
| 39 | dict | Are the following values correct for all Constants: .DocUnit | Process | none |
|
|
|
|
| 40 | dict | Are the following values correct for all Calibrations: .EngVal | Apps | none |
|
|
|
|
| 41 | dict | Are the following values correct for all Calibrations: .EngMin | Apps | none |
|
|
|
|
| 43 | dict | Are the following values correct for all Calibrations: .TuningOwner | Safety | Apps |
|
|
|
|
| 47 | dict | Are the following values correct for all Calibrations: .Online | Safety | Apps |
|
|
|
|
| 44 | dict | Does the FDD .DesignASIL property match requirements? | Safety | none |
|
|
|
|
| 45 | dict | Does FDD Long Name, Short Name, and Description match requirements? | Apps | Process |
|
|
|
|
| 46 | dict | Do output signal ranges match requirements? | Apps | Process |
|
|
|
|
| 42 | dict | Are lookup tables using compatible table dimensions? | Safety | Software |
|
|
|
|
| 48 | dict | Do signal and parameter names accurately describe their purpose? | Apps | none |
|
|
|
|
| 49 | dict | Do all .Description properties provide useful information? | Apps | none |
|
|
|
|
| 50 | dict | Has Static Register evaluation has been completed and updated for any register data that is written to? | SME | none |
|
|
|
|
| 51 | dict | Are all clients from model defined in dictionary? | Process | Software |
|
|
|
|
| 52 | dict | Do client definitions match their corresponding server runnable? | Process | Software |
|
|
|
|
| 53 | dict | Is NVM defined in the appropriate number of blocks (separate for EOL vs saved at power-off)? | Process | Software |
|
|
|
|
| 54 | dict | Is NVM with multiple values defined as a structure? | Process | Software |
|
|
|
|
| 55 | dict | Are NVM structure members arranged largest-to-smallest datatype? | Process | Software |
|
|
|
|
| 56 | dict | Are local Constants unique from global constants available in xx999A dictionaries? | Process | Software |
|
|
|
|
| 57 | dict | Are calibration tables named correctly (e.g. AssiX and AssiY)? | Process | Apps |
|
|
|
|
| 58 | dict | Are Constant names abbreviated properly (ALLCAPS are not checkable by tools)? | Process | none |
|
|
|
|
| 59 | dict | Is the Data Dictionary Verification report error free? | Process | none |
|
|
|
|
| 60 | dict | Are all data types represented by released Data_Management classes? | Process | none |
|
|
|
|
| 61 | model | Are all the Memory Store blocks for PIM and Display Variables located on the 2nd level of model? | Process | Software |
|
|
|
|
| 62 | model | Is each diagnostic (NTC) capable of being set to "PASS"? | Process | Software |
|
|
|
|
| 63 | model | Does non-zero intialization of PIM occur in the function's Init runnable? | Process | Software |
|
|
|
|
| 64 | model | Does design properly include Set Ram Block Status when NVM RAM values change? | Process | Software |
|
|
|
|
| 65 | model | Are NTCs set only outside an IRQ (not related to the typical periodic OS)? | Process | Software |
|
|
|
|
| 66 | model | Are NTCs set and read only at periodic steps no less than 2 ms? | Process | Software |
|
|
|
|
| 67 | model | Does model execute without errors/warnings after loading NxtrMBDConfig configuration set? | Process | Apps |
|
|
|
|
| 68 | model | Is filename of model in correct format? | Process | none |
|
|
|
|
| 69 | model | Is Top level of model annotated with Requirements Baseline? | Process | none |
|
|
|
|
| 70 | model | Is the Top level of the model annotated with Tool Dependencies? | Process | none |
|
|
|
|
| 71 | model | Is Top level of model annotated with Change Log or History? | Process | none |
|
|
|
|
| 72 | model | Is the 2nd level of model free from subsystems that are not Function-Call Subsystems? | Process | none |
|
|
|
|
| 73 | model | Is the 2nd level of model free from arithmetic and logic operations? | Process | none |
|
|
|
|
| 74 | model | Are the Runnable trigger signals named as "call_<Runnable>"? | Process | none |
|
|
|
|
| 75 | model | Does 2nd level of model have a properly updated annotation with name, description, and intended baseline number? | Process | none |
|
|
|
|
| 76 | model | Are all data flow layers free of Function-Call Subsystems and Memory Store blocks? | Process | none |
|
|
|
|
| 77 | model | Does the Model have the confidentiality and copyright information inside all its Subsystems? | Process | none |
|
|
|
|
| 78 | model | Are all requirements links of the format <FDDNumber>_<ObjectID>? | Process | none |
|
|
|
|
| 79 | model | Does requirements HTML report reference only the DOORS module of this component for all links in the design? | Process | none |
|
|
|
|
| 80 | model | Was Model Advisor run with the correct configuration settings? | Process | none |
|
|
|
|
| 81 | model | Is the Model Advisor rerport free from "Fails". | Process | none |
|
|
|
|
| 82 | model | Does the model execute? | Process | none |
|
|
|
|
| 83 | model | Are Model Advisor report ISO26262 warnings acceptable? | Safety | none |
|
|
|
|
| 84 | model | Is model free from dynamic array size allocation? | Safety | Software |
|
|
|
|
| 85 | model | Does model include adequate annotation throughout? | Apps | none |
|
|
|
|
| 86 | model | Is model free from data type conversion blocks that do not explicitly state desired data type? | Safety | Software |
|
|
|
|
| 87 | model | Does model refrain from using Display Variable values in downstream operations? | Safety | Software |
|
|
|
|
| 88 | model | Are all GOTO/FROM blocks restricted in scope to their own subystem level? | Safety | Software |
|
|
|
|
| 89 | model | If model has ADC input, is failure boolean input and appropriate fault response been included? | Safety | Process |
|
|
|
|
| 90 | model | Does design calculate PIM values only within their defined range? | Software | none |
|
|
|
|
| 91 | model | Does design include output limiting blocks? | Software | Safety |
|
|
|
|
| 92 | model | Do cal ranges & logic ensure freedom from divide-by-zero? | Software | Safety |
|
|
|
|
| 93 | model | Do cal ranges & logic ensure no incompatible values for their datatype? | Software | Process |
|
|
|
|
| 94 | model | Are Model Advisor report MISRA warnings acceptable? | Software | none |
|
|
|
|
| 95 | model | Is design free of unreachable logic? | Software | none |
|
|
|
|
| 96 | model | Do state machines provide exits of all non-latch states? | Software | none |
|
|
|
|
| 97 | model | Is design free from recursive logic that could cause indefinate waits? | Software | none |
|
|
|
|
| 98 | model | Does design maintain data size consistency? | Software | none |
|
|
|
|
| 99 | model | Are "magic numbers" acceptable? | Process | Software |
|
|
|
|
| 100 | model | Are the following values correct for all NTC: .NtcTyp | Apps | Safety |
|
|
|
|
| 101 | model | Are display variables appropriately placed? | Apps | none |
|
|
|
|
| 102 | model | Does design provide appropriate tuning flexibility? | Apps | none |
|
|
|
|
| 103 | model | Are blocks linked to the correct requirements? (watch for problems due to copy/pasted blocks) | Apps | none |
|
|
|
|
| 104 | model | Is the list of unlinked blocks acceptable? | Apps | none |
|
|
|
|
| 105 | model | Does design account for all requirements? | Apps | none |
|
|
|
|
| 106 | model | Is design of a managable size and easy to understand? | Apps | Software |
|
|
|
|
| 107 | model | Is design easily disabled via calibration? | Apps | none |
|
|
|
|
| 108 | model | Does model include appropriate logic for dealing with missing or corrupted NVM data? | SME | Safety |
|
|
|
|
| 109 | model | Does design either work with global signal units or contain necessary unit-conversion logic? | SME | Apps |
|
|
|
|
| 110 | model | Does the design prevent Integrator drifting? | SME | none |
|
|
|
|
| 111 | model | Does design make proper use of limiters to prevent integrator windup and runaway values? | SME | none |
|
|
|
|
| 112 | model | Are all IIR filters free of potential instability over their defined calibration ranges? | SME | none |
|
|
|
|
| 113 | model | Is Stateflow used only for state machines not easily represented in Simulink? | Software | none |
|
|
|
|
| 114 | model | Do IF..ELSEIF blocks also contain an ELSE condition? | Process | none |
|
|
|
|
| 115 | model | Do SWITCH CASE blocks also contain a DEFAULT condtion? | Process | none |
|
|
|
|
| 116 | model | Are ELSE and DEFAULT branching conditions reachable when dependent on internal variables? | Process | none |
|
|
|
|
| 117 | model | Is model free from over-nested IF logic or redundant IF..ELSEIF..ELSEIF.. Conditions? | Software | none |
|
|
|
|
| 118 | model | Is model free from arithmetic operations on Boolean values? | Software | none |
|
|
|
|
| 119 | model | Is model optimized to minimize redundant calculations? | Process | none |
|
|
|
|
| 120 | package | Does NTC Summary sheet adequately describe NTC usage? | Apps | none |
|
|
|
|
| 121 | package | Does review meet 'inspection' criteria? | Safety | Process |
|
|
|
|
| 122 | package | Does Design folder contain only the model, data dictionary, and (optionally) a simulation setup script? | Process | none |
|
|
|
|
| 123 | package | Does Doc folder contain a zipped HTML webview model? | Process | none |
|
|
|
|
| 124 | package | Was webview model created without requirements highlighted? | Process | none |
|
|
|
|
| 125 | package | Does Doc folder contain appropriate number of NTC Summary sheets? | Process | none |
|
|
|
|
| 126 | package | Does Reports folder contain only the data dictionary verification report, Model Advisor report, and zipped requirements traceability report? | Process | none |
|
|
|
|
| 127 | package | Has author performed basic simulations to screen for problems? | SME | none |
|
|
|
|
