CmMtrCurr Design Review

Overview

Summary Sheet
Source Code
Data Dictionary
QAC

Sheet 1: Summary Sheet

Rev 3.0

11-Dec-13

Peer Review Summary Sheet

Component Name:

kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. CmMtrCurr

Component Revision:

kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. FDD01C_07.0_NoUTP

Change Owner:

kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Lovepreet Kaur

Change Request ID:

CR# 10909 and 11063

kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:

kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:

Reviewed:

MDD

Source Code

Data Dictionary

QAC

Integration Manual

Davinci Files

Comments:

Only Source Code and Data Dictonary have gone through initial phase of complete design review.

Changes have been made to them which need revision.MDD still needs to be looked at to finish complete design review task.

General Guidelines:
- The reviews should be performed over the portions of the component that were modified as a result of the Change Request. (Note: If this peer review form was not
completed for pervious versions of this component, the Change Owner should review the entire component and complete the checklist in its entirety prior and check
the form into Syngery. This should be done prior to reviewing the modifications for this Change Result)
- The Change Owner is responsible for completing the entire checklist (Pre and Group review items) prior holding the initial group review.
- New components should include FDD Owner and Intergator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files)
- Select "Yes" and add "N/A" to the comments for checklist items that are not applicable for this change

Sheet 2: Source Code

Rev 3.0

11-Dec-13

Peer Review Meeting Log (Source Code Review)

Source File Name:

kzshz2: Intended Use: Identify which .asm, .c, or .h file is being reviewed Rationale: Required for traceability. It will help to ensure this sheet is not attached to the wrong design review form. Sa_CmMtrCurr.c

Source File Revision:

kzshz2: Intended Use: Identify which version of the source file is being review. Rationale: Required for traceability between source code and review. Auditors will likely require this. 18

Module Design Document Name:

kzshz2: Intended Use: Identify which version of the MDD this source file was written against. Rationale: Needed for traceability between source code and MDD CmMtrCurr_MDD

MDD Revision:

kzshz2: Intended Use: Identify which version of the MDD this source file was written against. Rationale: Needed for traceability between source code and MDD 7

Data Dictionary Revision:

kzshz2: Intended Use: Identify which version of the Data Dictionary was referenced for ranges during the source file review. Rationale: Needed for traceability between source code and DD 7

Quality Check Items:

Yes

Rationale is required for all answers of No

Pre-review checklist
(change owners only)

Analysis performed for divide by zero

kzshz2: Intended Use: To confirm this defensive coding strategy has been taken into consideration Rationale: Necessary since currently there is no place this is documented

Comments:

Software Design and Coding Standard followed

Comments:

Checked through QAC

Software Naming Convention followed

Comments:

Changed variable names to address naming convention.

For example, removed 's' in the unit identifier, added 'CmMtrCurr_' in front of the Display and modular level variables.

All buffered outputs are written in every path

Comments:

Group-review Checklist (review board)

Telelogic Synergy version matches header

kzshz2: Intended Use: Indicate that the the versioning was confirmed by the peer reviewer(s). Rationale: There have been many occassions where versions were not updated in files and as a result Unit Test were referencing wrong versions. This often time leads to the need to re-run of batch tests.

Comments:

Change log contains detailed description of changes

Comments:

Code compared vs requirements (Document or Model)

kzshz2: Intended Use: Identify if previous version was compared and only the expected change(s) was present. Rationale: This is helpful in identifying unapproved (intended or mistaken) changes.

Comments:

Information sent to FDD owner for clarifications in doc

Global Outputs (RTE/Non-RTE) Initialized

Comments:

Global Outputs are limited to the legal range defined

Comments:

MtrCurrFinalQax_Amps_T_f32 output doesn't match FDD DD (D_CURRDQMAX_AMP_F32 is set to 220)

in the FDD Data dictionary

Added D_MINVCALCMD_CNT_F32 = 17500 constant to address A6080

No Compiler Errors verified

kzshz2: Intended Use: To confirm the appropriate variable name formats have been used. Rationale: This is needed to ensure there will be no errors discovered at the time of integration. A Sandox project may be required to confirm there are no errors until the QAC tool has been evaultated to determine if it can automate this check.

Comments:

Type Casting and Fix Point Macros use reviewed

Comments:

QAC check

Function prototype and passed parameters are

Comments:

consistent

General Notes / Comments:

kzshz2: Intended Use: Identify who where the reviewers and if the reviewed changes have been approved. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. Group Review Level: There are four Design Review States that a document may have as follows: DR1 – Un-reviewed document. The DR1 reviews usually require larger, cross functional review teams (i.e. Management, Hardware Engineering, etc.) It is usually advisable, but not required to include outside representation as well such as system engineers. It is up to the document owner to decide on the scope of the review, however, the peer group can decide that a re-review with additional team member is required. DR2 – The Document has previously passed through the peer review process, but requires design changes significant enough to require another group peer review. DR3 – The Document has passed group peer review but needs minor corrections that can be re-reviewed with the Lead Peer Reviewer. DR4 – The document has passed all peer reviews and is ready for release. Review Board:

Change Owner:

Lovepreet Kaur

Review Date :

01/31/14

Group Review Level:

DR4

Lead Peer Reviewer:

Selva Sengottaiyan

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 3: Data Dictionary

Rev 3.0

11-Dec-13

Peer Review Meeting Log (Data Dictionary Review)

Data Dictionary Revision:

kzshz2: Intended Use: Identify which version of the file is being reviewed Rationale: Required for traceability. 7

kzshz2: Intended Use: Indicate to the reviewers the type of variable changes. This should be filled out prior to the review by the change owner. Rationale: This will be good information to know to both reviewers and post reviewers of the change. Variables:

Newly Added

Name Changes

Range Changes

Deleted

NVM Changes

Other:

kzshz2: Intended Use: Indicate to the reviewers the type of calibration changes. This should be filled out prior to the review by the change owner. Rationale: This will be good information to know to both reviewers and post reviewers of the change. Calibrations:

Newly Added

Name Changes

Range Changes

Default Value Changes

Deleted

Other:

Quality Check Items:

Yes

Rationale is required for all answers of No

Group-review Checklist (review board)

Telelogic Synergy version matches header

Comments:

Change log contains detailed description of changes

Comments:

All Changes Identified (for Unit Tester)

Comments:

List attached

Calibration and NVM names, ranges, and default values

Comments:

compared against FDD

Global variables names, ranges, and default values

Comments:

compared against FDD Data Dictionary

General Notes / Comments:

Sheet attached sheet with comments about some of the variables that need revision and/or modification in the data dictionary.

Change Owner:

Lovepreet Kaur

Review Date :

01/31/14

Group Review Level:

DR4

Lead Peer Reviewer:

Selva Sengottaiyan

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Sheet 4: QAC

Rev 3.0

11-Dec-13

Peer Review Meeting Log (QAC Review)

Module Name:

kzshz2: Intended Use: Identify which .c file is being analyzed Rationale: Required for traceability. It will help to ensure this sheet is not attached to the wrong design review form. CmMtrCurr

Source File Revision:

Module

Compliance Document Version:

QAC_6

kzshz2: Intended Use: Identify specific changes in results (new violation present, previous violation corrected, etc.). Changes to the version of the tool or the way the results were gathered should be described here also. This should be filled out prior to the review by the change owner. Rationale: Gives reviewers an what needs to be focused on. Forces the change owner to compare with previous results to catch any differences that may otherwise go unoticed Brief Summary of Changes (In Results or Tool):

Quality Check Items:

Yes

Rationale is required for all answers of No

Pre-review
checklist for change owners

QAC version is correct and did not change (List version)

kzshz2: Intended Use: Identify which version of the QAC Subproject was used and if any of the personalities may have changed. Rationale: Will help ensure this is factored into evaluating the results

Comments:

QAC_6

Contract Folder's header files are appropriate

kzshz2: Intended Use: Identify that the contract folder contains only the information required for this component. All other variables, constants, function prototypes, etc. should be removed. Rationale: This will help avoid unit testers having to considers object not used. It will also avoid having other files required for QAC.

Comments:

G Group-review Checklist (review board)

100% Compliance to the MISRA Compliance Document

Comments:

No new warnings came

General Notes / Comments:

Change Owner:

Lovepreet Kaur

Review Date :

01/31/14

Group Review Level:

DR4

Lead Peer Reviewer:

Selva Sengottaiyan

Approved by Reviewer(s):

Yes

Other Reviewer(s):

Last modified October 12, 2025: Initial commit (0347a62)