uDiag_Design_Review

Rev 2.0

26-Aug-13

Peer Review Summary Sheet

Component Name:

kzshz2: Intended Use: Identify which component is being reviewed. This should be the Module Short Name from Synergy Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. TMS570_uDiag

Component Revision:

kzshz2: Intended Use: Identify which Synergy revision of this component is being reviewed Rationale: Required for traceability. It will help to ensure this form is not attaced to the the wrong change request. FDD32B_TMS570_uDiag_000.23

Change Owner:

kzshz2: Intended Use: Identify the developer who made the change(s) Rationale: A change request may have more than one resolver, this will help identify who made what change. Change owner identification may be required by indusrty standards. Kathleen Creager

Change Request ID:

11157, 11158. 11176

kzshz2: Intended Use: Intended to identify at a high level to the reviewers which areas of the component have been changed. Rationale: This will be good information to know when ensuring appropriate reviews have been completed. Modified File Types:

kzshz2: Intended Use: Identify who where the reviewers, what they reviewed, and if the reviewed changes have been approved to release the code for testing. Comments here should be at a highlevel, the specific comments should be present on the specific review form sheet. Rationale: Since this Form will be attached to the Change Request it will confirm the approval and provides feedback in case of audits. ADD DR Level Move reviewer and approval to individual checklist form Review Checklist Summary:

Reviewed:

MDD

X

Source Code

Data Dictionary

X

QAC

X

Integration Manual

X

Davinci Files (Generate files)

Comments:

1) Most modules in this component do not have an MDD. CR 10409 written to create MDDs.

2) Reviewed changes only.

3) Reviewed the ten changed and one new source files (out of 21 source files total) and their QAC results, plus the

changed DaVinci files, generate files, include files, and integration manuals (uDiag and FlsTst)

NOTE QAC ESM and QAC VIM tabs for future actions to be considered on next rev of component

NOTE that there are multiple Cd_uDiagxxx.c source files that use RTE functions, but only one Cd_uDiag component.

Consider writing a continuous improvement CR to restructure the component.

General Guidelines: - The reviews should be performed over the portions of the component that were modified as a result of the Change Request. (Note: If this peer review form was not completed for pervious versions of this component, the Change Owner should review the entire component and complete the checklist in its entirety prior and check the form into Syngery. This should be done prior to reviewing the modifications for this Change Result) - The Change Owner is responsible for completing the entire checklist (Pre and Group review items) prior holding the initial group review. - New components should include FDD Owner and Intergator as apart of the Group Review Board (Source Code, Integration Manual, and Davinci Files) - Select "Yes" and add "N/A" to the comments for checklist items that are not applicable for this change